| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-02-06 | |||
| 22:30:55 | efried | mnaser: did your +1 at PS3 here https://review.opendev.org/#/c/706331/ indicate that you had successfully tested this locally? | |
| 22:38:27 | mriedem | dansmith: i've got to run but will take a look at the latest later tonight | |
| 22:41:21 | dansmith | efried: I think he's going to have to apply it at the time he does his next upgrade which might not be for a while, it sounded like | |
| 22:44:33 | melwitt | dansmith: wouldn't your change unhide the instances for him today that are being incorrectly hidden? or are you saying he already fixed that via manual db update | |
| 22:44:58 | dansmith | melwitt: he already fixed up his db, as I understand it | |
| 22:45:05 | melwitt | gotcha | |
| 23:01:21 | sean-k-mooney | dansmith: i can check the code but are we not storing the resouce requests form the cybrog device profile in the request spec? | |
| 23:03:36 | sean-k-mooney | dansmith: im seeing "requested_resources": null in the request spec for the cyborg nova instance | |
| 23:04:01 | sean-k-mooney | the embeded flavor has "accel:device_profile": "FakeDeviceProfile" | |
| 23:05:12 | sean-k-mooney | however since we are not storing the groups if you change the device profil after the fact and we migration and instance or did something else that would need us to call plamcnet wwe would have to go back to cyborg which could have changed | |
| 23:18:24 | dansmith | sean-k-mooney: I think that's the idea | |
| 23:18:53 | dansmith | sean-k-mooney: you live migrate, scheduler calls placement with a new set of resources constructed from the device profile and what cyborg told you when you asked | |
| 23:19:34 | dansmith | sean-k-mooney: maybe we need to be doing something like examining the existing ARQs to generate those resource requests if the instance already exists? | |
| 23:19:56 | sean-k-mooney | new arqs sure but we dont want to hard reboot or live migate and change form an nvida gpu to an intel fpga | |
| 23:20:55 | sean-k-mooney | i think we need to be storing the groups retruned by cycborg when we instilly created the vm the same way we embed the flavor or image | |
| 23:20:57 | dansmith | not sure how that would happen on a hard reboot, but obviously agree on live-migration, but that's why I'm saying maybe we should look at the device profile on boot, and look at our existing arqs on any other move operation when asking cyborg for the resources | |
| 23:21:51 | sean-k-mooney | dansmith: i guess hardreboot it would not | |
| 23:22:03 | sean-k-mooney | we woudl just use the exising arq | |
| 23:22:10 | dansmith | maybe we need to ask sundar if the dp can change in a predictable or restricted way | |
| 23:22:45 | dansmith | I would expect the arqs can't be changed after they're allocated, and if we used those to base our new request on that would get us what we want | |
| 23:22:53 | sean-k-mooney | looking at the client i only see a create and delete | |
| 23:22:59 | sean-k-mooney | so i guess not | |
| 23:23:05 | sean-k-mooney | ill check the api | |
| 23:23:13 | dansmith | are you saying the device profile can too? | |
| 23:23:19 | dansmith | can change in place Imean | |
| 23:23:37 | sean-k-mooney | the device profile in osc can only be create or delete like a flavor | |
| 23:23:49 | sean-k-mooney | im going to check the api to see if there is an update | |
| 23:24:02 | sean-k-mooney | if they are imutable no issue | |
| 23:24:03 | dansmith | ah okay I thought you were implying it *could* change but you were just assuming? | |
| 23:24:07 | dansmith | yea | |
| 23:24:18 | dansmith | I need to run off for a bit, but we can sync with sundar tomorrow | |
| 23:24:30 | sean-k-mooney | ya no worries | |
| 23:24:46 | sean-k-mooney | i was just going to write a function to pull the resouce request form the nova db | |
| 23:24:59 | sean-k-mooney | form the request spec and compar them to the allcoations | |
| 23:25:14 | sean-k-mooney | to ensure they matched up | |
| 23:31:10 | sean-k-mooney | ok device profiels cannot be updated. https://docs.openstack.org/api-ref/accelerator/v2/index.html#device-profiles but ARQs can be whcih kind of make sense | |
| 23:31:36 | sean-k-mooney | you update ARQs with the host when binding or move operations | |
| 23:32:10 | sean-k-mooney | you cant change the device profile name however | |
| 23:37:42 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix instance.hidden migration and querying https://review.opendev.org/706331 | |
| 23:37:49 | dansmith | sean-k-mooney: cool | |
| #openstack-nova - 2020-02-07 | |||
| 00:11:16 | mriedem | dansmith: a few comments in your reno | |
| 00:36:17 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Add Cyborg device profile groups to request spec. https://review.opendev.org/631243 | |
| 00:36:18 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Define Cyborg ARQ binding notification event. https://review.opendev.org/692707 | |
| 00:36:18 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Create and bind Cyborg ARQs. https://review.opendev.org/631244 | |
| 00:36:19 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Pass accelerator requests to each virt driver from compute manager. https://review.opendev.org/698581 | |
| 00:36:19 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Compose accelerator PCI devices into domain XML in libvirt driver. https://review.opendev.org/631245 | |
| 00:36:20 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735 | |
| 00:36:20 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Enable hard/soft reboot with accelerators. https://review.opendev.org/697940 | |
| 00:36:21 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Enable start/stop of instances with accelerators. https://review.opendev.org/699553 | |
| 00:36:21 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Enable and use COMPUTE_ACCELERATORS trait. https://review.opendev.org/699554 | |
| 00:36:22 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Bump compute rpcapi version and reduce Cyborg calls. https://review.opendev.org/704227 | |
| 00:36:22 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999 | |
| 08:29:01 | gibi | efried: ack, I will try to spend some time on the cyborg series today | |
| 10:22:01 | stephenfin | gibi, lyarwood: real quick, do either of you see anything obviously wrong in https://zuul.opendev.org/t/openstack/build/5b196c5a7cf944df8857a08dc15aa79f/console ? | |
| 10:22:15 | stephenfin | It's saying "TypeError: create_port_binding() missing 2 required positional arguments: 'port_id' and 'data'" | |
| 10:22:31 | stephenfin | But line it's failing on is obviously passing those? | |
| 10:22:32 | stephenfin | "binding = client.create_port_binding(port_id, data)['binding']" | |
| 10:23:29 | stephenfin | gibi: Also, low priority but I updated a commit message on a patch you'd previously approved, if you have time to revisit https://review.opendev.org/705655 | |
| 10:24:00 | gibi | stephenfin: could you link the patch that produced such test result? | |
| 10:24:09 | stephenfin | gibi: https://review.opendev.org/#/c/706295/ | |
| 10:25:30 | gibi | interesting :) | |
| 10:25:38 | stephenfin | right? | |
| 10:25:40 | gibi | pulling it down | |
| 10:29:02 | gibi | trying to reproduce locally.. | |
| 10:34:06 | gibi | stephenfin: nova.tests.fixtures.NeutronFixture.get_port_binding has get_port_binding(self, context, client, port_id, host) signature so when the code pass two positional args it fills only client and context and not the port and host | |
| 10:34:18 | stephenfin | gdi | |
| 10:34:40 | stephenfin | gibi++ Thanks /o\ :) | |
| 10:34:44 | gibi | no problem | |
| 10:34:48 | stephenfin | I'd been staring at that for an hour | |
| 10:34:50 | gibi | the error message was deeply missleading | |
| 10:35:01 | stephenfin | Yuuup. Bad coincidence :) | |
| 10:35:27 | gibi | yepp | |
| 10:50:40 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove universal wheel configuration https://review.opendev.org/706466 | |
| 11:02:26 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles in os-instance-actions policies https://review.opendev.org/706470 | |
| 11:05:12 | lyarwood | stephenfin: sorry missed that, still need me to take a look? | |
| 11:05:25 | stephenfin | lyarwood: Nope, we sussed it | |
| 11:05:45 | lyarwood | wonderful | |
| 11:06:47 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Use neutronclient's port binding APIs https://review.opendev.org/706295 | |
| 14:19:04 | openstackgerrit | Huachang Wang proposed openstack/nova-specs master: Use PCPU and VCPU in one instance https://review.opendev.org/668656 | |
| 14:30:35 | huaqiang | stephenfin:sean-k-mooney:alex_xu spec https://review.opendev.org/668656 is updated, hope you guys have time to review it before freezing day | |
| 14:49:09 | stephenfin | gibi: Comments left on https://review.opendev.org/#/c/704759/ | |
| 14:49:23 | stephenfin | huaqiang: Ack. I'll hit that next Tuesday (spec review day) | |
| 14:55:07 | huaqiang | stephenfin: appreciate! | |
| 14:56:24 | gibi | stephenfin: thanks. I will check | |
| 15:01:58 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles in os-instance-actions policies https://review.opendev.org/706470 | |
| 15:05:53 | openstackgerrit | Martin Midolesov proposed openstack/nova master: Implementing graceful shutdown. https://review.opendev.org/666245 | |
| 15:22:18 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add SYSTEM_READER role to servers actions API https://review.opendev.org/706179 | |
| 15:26:33 | kashyap | efried: Want to have a stab at this spec? Already approved previously; and has a +2: https://review.opendev.org/#/c/693844/ | |
| 15:29:18 | Sundar | dansmith, gibi, sean-k-mooney, efried: About https://review.opendev.org/#/c/706083/, this is a refactor that affects pci requests, numa topology etc. that are not related to the Cyborg patch. I see that some of you are noncommittal and, in any case, probably needs further discussion. The Cyborg series is already long in the tooth; if we add this | |
| 15:29:19 | Sundar | general refactor, keeping that entire context in our minds will only prolong our efforts and strain. Plus, some of us are hitting time constraints. What do you think of considering the series as it is now, and feel free to add refactors on top of that later? Both of them could even go concurrently, but the discussions on the refactor need not hold | |
| 15:29:19 | Sundar | up the main series. | |
| 15:31:52 | Sundar | Just to be clear, I am not objecting to the refactoring. I am fine either way and can contribute to the reviews. | |
| 15:33:25 | sean-k-mooney | Sundar: im currently planing to redeploy with the code you pushed yesterday. | |
| 15:33:37 | Sundar | sean-k-mooney: Thanks. | |
| 15:33:45 | sean-k-mooney | i found that with the previous version i was unable to delete the cyborg vm | |
| 15:34:01 | sean-k-mooney | the conductor was not able to delete the arp binding | |
| 15:34:33 | sean-k-mooney | i was able to manually do it but could still not delete the nova vm | |
| 15:34:46 | sean-k-mooney | ill see if i hit the same issue with the new version and let you know | |
| 15:35:41 | Sundar | I see. In the worst case, for development purposes only, once could delete the ARQs using curl. | |
| 15:36:00 | sean-k-mooney | yes but you still cannot delte the nova vm | |