| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-02-06 | |||
| 16:39:34 | mnaser | dansmith: ok cool, i can try and help reviewing to my ability and id be able to provide some feedback on a cloud with 1.5 times the # of records (but only in 2 weeks :X) | |
| 16:39:48 | mriedem | i've still got core if you need to poke someone later | |
| 16:39:50 | dansmith | cool | |
| 16:41:55 | melwitt | I can help with review too if needed | |
| 16:52:40 | gibi | dansmith, efried, Sundar: I agree with the discussed direction in https://review.opendev.org/#/c/631243/55 See details in my review | |
| 16:54:33 | gibi | efried: is there other patches in the series that need my eyes? I can spend some extra time on the series tomorrow if needed | |
| 17:12:20 | openstackgerrit | Merged openstack/nova master: Don't error out on floating IPs without associated ports https://review.opendev.org/706213 | |
| 17:12:26 | openstackgerrit | Merged openstack/nova master: nova-net: Update API reference guide https://review.opendev.org/703796 | |
| 17:12:34 | openstackgerrit | Merged openstack/nova stable/queens: Add functional recreate test for bug 1852610 https://review.opendev.org/699705 | |
| 17:12:34 | openstack | bug 1852610 in OpenStack Compute (nova) queens "API allows source compute service/node deletion while instances are pending a resize confirm/revert" [Low,In progress] https://launchpad.net/bugs/1852610 - Assigned to Matt Riedemann (mriedem) | |
| 17:16:11 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove native LUKS compat code https://review.opendev.org/669121 | |
| 17:25:38 | efried | gibi: Well, I've been hoping that I would get the chance to review the series from top to bottom and be the second +2 (with dansmith) but I'm no longer sure I'm going to be able to get to it soon. So if you have time, your help would be much appreciated. But I would say you shouldn't push other stuff out of the way for it. | |
| 17:30:47 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix instance.hidden migration and querying https://review.opendev.org/706331 | |
| 17:31:16 | dansmith | mnaser: mriedem melwitt ^ haven't run all tests yet, so it might break other things, but that's what I'm thinking as a backportable change | |
| 17:31:34 | melwitt | in da club | |
| 17:34:04 | dansmith | gross. | |
| 17:34:55 | melwitt | lol wtf. never heard that before | |
| 17:35:40 | sean-k-mooney | in the club to mean pregnant ya ist an old old way of saying that in polite company when gossiping | |
| 17:36:23 | melwitt | interesting. here it means like at the dance club, in a bunch of rap songs | |
| 17:36:31 | dansmith | as someone who feels like society favors those who procreate unfairly, I definitely see it as "a club" in the negative sense | |
| 17:38:20 | sean-k-mooney | yes as i said it was used when gossiping about someone behind there back so it had a negitive over tone in many cases | |
| 17:38:52 | dansmith | that's not really what I meant :) | |
| 17:38:59 | melwitt | lol | |
| 17:39:00 | mriedem | i'm in da costco club | |
| 17:39:09 | dansmith | mnaser: how many instances in the database that failed, and how many in the one that didn't? | |
| 17:39:13 | mriedem | if you need a years supply of toilet paper i'm your guy | |
| 17:39:23 | sean-k-mooney | lol | |
| 17:39:24 | melwitt | me too, Costco Executive Club | |
| 17:47:03 | melwitt | maybe this is too out there but I wonder if this might be related to the cell timeout gate bug (affecting only grenade jobs) | |
| 17:48:04 | dansmith | the first query after upgrade works, so ... I don't think so | |
| 17:48:34 | dansmith | and also, mnaser said it worked fine for his smaller cluster, which I'm sure is waaaay larger than a grenade setup with a tempest-run worth of instances in the db | |
| 17:48:38 | melwitt | ok. I wondered if there could be something to do with the table rewriting in the background or something | |
| 17:49:15 | dansmith | surely hope not :) but it seems like it was synchronous in mnaser's case | |
| 17:49:25 | melwitt | because when I dug into that, it seemed like mysql just overloaded somehow and logging errors "reading communication packets" | |
| 17:49:39 | melwitt | ok | |
| 17:59:58 | sean-k-mooney | any table updates or data migration should be taking a full table write lock. reads should see the old data until the transaction completes | |
| 18:00:14 | sean-k-mooney | at least if you are using the innodb schema for mysql | |
| 18:14:56 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix instance.hidden migration and querying https://review.opendev.org/706331 | |
| 18:28:51 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix instance.hidden migration and querying https://review.opendev.org/706331 | |
| 18:34:09 | openstackgerrit | Dan Smith proposed openstack/nova master: Disallow specifying a default= on new Columns in schema changes https://review.opendev.org/706351 | |
| 18:34:28 | dansmith | ^ makes it impossible to use Column(default=) in migrations after 399 | |
| 18:35:08 | dansmith | efried: did you catch the earlier discussion about the relatively serious upgrade-corrupts-database bug in train? | |
| 18:35:23 | efried | no | |
| 18:35:54 | dansmith | efried: on largeish deployments, upgrading to Train can make all your instances hidden silently | |
| 18:36:24 | dansmith | we're going to want to backport my fix and release a train update with definitive action at some point here soon | |
| 18:36:54 | sean-k-mooney | dansmith: do we have that fix downstream by the way | |
| 18:37:20 | dansmith | sean-k-mooney: we don't have it upstream yet, so..no. | |
| 18:37:55 | sean-k-mooney | ok cause you know what day it is :) | |
| 18:38:11 | efried | dansmith: do I need to review things? | |
| 18:38:43 | dansmith | efried: you're welcome to.. I think we're looking for a test run, a report from mnaser and melwitt/mriedem are also going to review | |
| 18:38:50 | dansmith | efried: https://review.opendev.org/#/c/706331/ | |
| 18:38:56 | dansmith | just for YI if nothing else | |
| 18:42:06 | efried | ack | |
| 18:45:24 | mnaser | catching up on buffer... | |
| 18:45:55 | mnaser | dansmith: ~220kish it didnt fail, ~340kish it failed, mariadb 10.3.something i believe | |
| 18:46:31 | dansmith | mnaser: okay thanks. I guess if anyone asks me I'll say "somewhere around 330k" | |
| 18:46:54 | mnaser | yeah and in this case it would be nice if we purged records so | |
| 18:46:57 | dansmith | er, "300k" I mean | |
| 18:47:07 | mnaser | important note that this doesnt mean "300k active instance" but "300k db records" | |
| 18:47:11 | dansmith | yup | |
| 18:51:29 | mnaser | dansmith: i wonder if this might start a whack-a-mole of references to hidden=false or hidden=null | |
| 18:51:56 | efried | mnaser: I was just leaving a comment to that effect. | |
| 18:52:12 | dansmith | mnaser: maybe except I think these are the only two places :) | |
| 18:52:31 | efried | for now | |
| 18:52:46 | mnaser | yeah, thing is i have no better solution | |
| 18:52:48 | dansmith | not really, because everything else sits above the db layer | |
| 18:52:58 | sean-k-mooney | we porably should be normalising that when we load if form the db | |
| 18:53:00 | dansmith | this is what the db and object apis are *for* | |
| 18:53:09 | dansmith | sean-k-mooney: we are, that's what I'm doing | |
| 18:53:31 | sean-k-mooney | dansmith: in https://review.opendev.org/#/c/706331/ | |
| 18:53:31 | dansmith | the second case is specifically doing a very targeted non-ORM query | |
| 18:53:32 | dansmith | otherwise this would be a single place | |
| 19:01:22 | dansmith | mnaser: added comments to the test to mirror your self-discovery | |
| 19:01:29 | dansmith | efried: added the hidden=False case to the test | |
| 19:01:39 | dansmith | gonna wait to push it up so we can get a run on it | |
| 19:01:45 | dansmith | efried: also added that ref to the commit message | |
| 19:02:16 | efried | ack. dansmith when I re-add the default in the poison patch and run just that test, it works, but when I run the whole suite, the exception is weird | |
| 19:02:23 | efried | AttributeError: hidden | |
| 19:02:47 | dansmith | hmm, that's weird | |
| 19:02:56 | mriedem | dansmith: question in that test | |
| 19:02:56 | dansmith | I was running just one | |
| 19:05:05 | dansmith | mriedem: replied | |
| 19:05:16 | openstackgerrit | Merged openstack/nova stable/queens: Add functional recreate revert resize test for bug 1852610 https://review.opendev.org/699708 | |
| 19:05:16 | openstack | bug 1852610 in OpenStack Compute (nova) queens "API allows source compute service/node deletion while instances are pending a resize confirm/revert" [Low,In progress] https://launchpad.net/bugs/1852610 - Assigned to Matt Riedemann (mriedem) | |
| 19:05:49 | efried | dansmith: repro is: | |
| 19:05:49 | efried | activate the venv | |
| 19:05:49 | efried | fails with the expected message: stestr run -n nova.tests.unit.db.test_migrations.TestNovaMigrationsSQLite.test_walk_versions | |
| 19:05:49 | efried | fails with AttributeError: stestr run -n nova.tests.unit.db.test_migrations | |
| 19:06:11 | efried | ...venv is py36 | |
| 19:06:23 | dansmith | efried: oh I was running the whole test_migrations module myself and wasn't seeing the error, but let me try again | |
| 19:06:28 | dansmith | I'm on py37 | |
| 19:07:53 | efried | dansmith: zuul agrees with me | |
| 19:09:40 | efried | but it also fails despite the migration having been 'fixed'. | |
| 19:10:39 | dansmith | hrm | |
| 19:10:55 | dansmith | what version of sqla is in your venv? | |
| 19:11:23 | efried | I just repro'd with a fresh py37 env, so whatever's in requirements. | |
| 19:11:31 | dansmith | can you look so I can compare? | |
| 19:11:45 | efried | SQLAlchemy==1.3.13,sqlalchemy-migrate==0.13.0,sqlparse==0.3.0 | |
| 19:11:51 | sean-k-mooney | tox -e py37 -- nova.tests.unit.db.test_migrations.TestNovaMigrationsSQLite.test_walk_versions | |
| 19:11:59 | sean-k-mooney | passes form me with dans change | |