Posted	Nick	Remark
#openstack-nova - 2020-01-30
14:42:06	sean-k-mooney	anyway really food this time o/ stephenfin when you get a chance can you review https://review.opendev.org/#/c/703373/ in os-vif
14:58:16	francoisp	hello lyarwood, stephenfin, doing code rework for https://review.opendev.org/#/c/669674/ and I have a question for you:
14:58:16	francoisp	stephenfin you put in a comment at nova/conf/compute.py, line 871:
14:58:16	francoisp	"If something is failing to complete after 5 loops, surely that's an issue that bumping the value will only mask?"
14:58:17	francoisp	I understand we want do do away with the config option, and stick with a hard-coded value for max number of re-tries.
14:58:18	francoisp	are you suggesting we use a lower value (ex.: max 3 retries) ?
15:28:37	Sundar	Hello dansmith, sean-k-mooney: I am here if you have any questions.
15:31:42	dansmith	Sundar: about what? the latest rev? I haven't gone through anything yet this morning, but was hoping efried was going to take the next pass through pretty soon
15:33:29	efried	"pretty soon" yah.
15:34:05	efried	stephenfin: sending https://review.opendev.org/#/c/682655/
15:34:05	efried	bauzas: I didn't give you a chance for another swing at ^ -- please lmk if you have issues.
15:34:41	bauzas	oh cool
15:34:46	bauzas	honestly, I trust you
15:35:14	bauzas	if I have time, I'll leave a +1 for the posterity
15:35:18	efried	cool
15:35:54	efried	bauzas: did you get a chance to catch up on the discussion for the numa topo spec?
15:36:05	bauzas	efried: unfortunately no
15:36:26	bauzas	yesterday evening my time you mean ?
15:36:53	efried	Yes, but summarized in the spec comments and an etherpad linked therefrom. No need to read the whole IRC log.
15:36:56	sean-k-mooney	bauzas: efried sumerised it in the spec and linked to the conversation on irc and an ehterpad
15:37:22	efried	bauzas: no real hurry (other than spec freeze in a couple weeks), but buzz me or sean-k-mooney if you have concerns or need clarification or whatever.
15:37:33	openstackgerrit	Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522
15:39:09	stephenfin	gibi: fixed those functional tests ^
15:39:09	bauzas	sean-k-mooney: efried: no worries, i'll look at it
15:39:17	stephenfin	got burned by my own refactoring work /o\
15:39:25	stephenfin	I really need to stop changing how those things work
15:39:25	bauzas	and thanks for discussing this, even if I was parenting
15:40:16	bauzas	gibi: stephenfin: efried: we have this very old cmd that would help ops, if you like getting it a swing https://review.opendev.org/#/c/670112/
15:40:32	bauzas	mriedem would be surprised if we eventually merge it :p
15:40:37	sean-k-mooney	after backporting acrouss 4 release im not sure you can resist it
15:41:19	sean-k-mooney	the sad part is each refactoring does make them better
15:42:46	stephenfin	bauzas: Oh, that looks hairy. Can you ask me Monday once FOSDEM's behind me? :)
15:43:04	bauzas	stephenfin: well, if you're not hit by the Coronavirus, of course :D
15:43:36	sean-k-mooney	na stephen has better taste in beer then to be hit by that
15:44:14	bauzas	at least there should be good news
15:44:32	bauzas	the Delirium bar shouldn't be packed like usual times
15:44:36	bauzas	stephenfin: ^
15:46:17	openstackgerrit	Merged openstack/nova-specs master: Re-propose the flavor extra spec validation spec https://review.opendev.org/682655
15:48:51	openstackgerrit	Stephen Finucane proposed openstack/nova-specs master: Address comments on 'flavor-extra-spec-validators' spec https://review.opendev.org/705047
15:53:31	bauzas	every year I consider going to FOSDEM
15:54:12	bauzas	and every year I think it wouldn't be worth the energy I would need for being a speaker
15:54:25	bauzas	so, unless I pay...
15:54:29	Sundar	dansmith: I responded and addressed your comments in my latest update last night. Understand you want efried to review first.
15:54:42	dansmith	ack
15:55:05	Sundar	efried: I understand you have other things to take care of. I'll wait.
15:55:11	sean-k-mooney	bauzas: jay was thinking of going this year. i was hoping to see him but since i taough i would be getting the keys to the house im buying on monday i did not want to travel this weekend
15:56:11	bauzas	that also means I would miss a skiing weekend. Unfair.
15:57:39	efried	Sundar: I need to do some PM-ish paperwork (reconcile blueprints with specs, kind of thing) ahead of this afternoon's meeting, but reviewing your series is next on my list after that.
15:59:24	Sundar	efried: Thanks.
16:16:02	openstackgerrit	Merged openstack/nova-specs master: Address comments on 'flavor-extra-spec-validators' spec https://review.opendev.org/705047
16:16:18	efried	stephenfin: did you see response earlier about powervm extra specs?
16:16:58	stephenfin	efried: I did. Did you happen to leave comments on the patch, out of curiosity?
16:17:17	stephenfin	If not, could you? I probably won't get a chance to respin that until next week now
16:18:10	efried	stephenfin: The code side? No, I wasn't planning to do a pass through that until... uh, later. But assuming you've got a placeholder in there for powervm, I'll go stuff the link in there.
16:20:33	efried	stephenfin: done
16:21:12	stephenfin	ta
16:27:29	stephenfin	gibi: quick question: what move operations, if any, did we support for instances with QoS interfaces in Train?
16:37:55	efried	stephenfin: per release notes, cold migrate and resize https://docs.openstack.org/releasenotes/nova/train.html
16:39:30	efried	mm, runways could use a refresh https://etherpad.openstack.org/p/nova-runways-ussuri
16:39:56	efried	Is anyone paying attention to those anymore?
16:40:10	efried	lyarwood: I'm going to move stable device rescue into a slot, mkay?
16:43:36	lyarwood	efried: yarp, was going to ask about runways in the meeting this evening.
16:43:44	lyarwood	efried: I assume this means they are still a thing?
16:44:06	efried	I don't know. I, for one, hadn't looked at that etherpad in *months*
16:44:13	lyarwood	kk
16:44:19	efried	Easy enough to update it though, in case anyone is.
16:45:44	efried	dustinc: Reckon it wouldn't be wrong for you to put provider config in there
16:46:13	efried	what's the status btw? Are we waiting for an update based on gibi's last round of review?
16:51:27	stephenfin	efried, bauzas, dansmith, <Anyone else that cares>: We had a bug reported downstream complaining that the 'os-hypervisors' API doesn't list CPUs in the new cpu_(shared|dedicated)_set config options. That was intentional on my behalf because the API is awful and I wanted to deprecate it
16:51:42	stephenfin	I think we can get most of that information from placement now so it's also unnecessary
16:52:05	bauzas	yup, we can tell the people who pay us : 'go use osc-placement'
16:52:14	stephenfin	Anyone know of a reason to keep it, and do I need a spec to deprecate it in a microversion or is a specless BP good enough?
16:52:16	efried	stephenfin: if we can deprecate that API, let's do that.
16:52:30	efried	ahcrap, I can never remember how that works. gmann?
16:52:38	bauzas	last time we discussed, some ops disagreed AFAICR
16:52:54	bauzas	I would first raise the problem in a ML thread
16:53:04	bauzas	and ask ops what they think
16:53:07	dansmith	if you want to deprecate then a microversion yeah
16:53:15	bauzas	and yeah a microversion if so
16:53:52	efried	A microversion to deprecate? Or a microversion to remove?
16:54:05	kashyap	gibi: 3-hour long call, and then right after working? You deserve a drink
16:54:06	stephenfin	Well, to remove
16:54:09	efried	the former doesn't make a lot of sense, does it? Is there some kind of signal we give in a response?
16:54:17	stephenfin	But it'll still be there in the older microversions
16:54:28	openstackgerrit	Merged openstack/os-vif master: [OVS] VLAN tag should be set in the Port register https://review.opendev.org/703373
16:54:34	stephenfin	i.e. we won't HTTP 410 of course
16:54:37	gibi	kashyap: I wrap up my day quickly then drink :)
16:55:09	gibi	stephenfin, bauzas: I added your patches to my queue for re-review for tomorrow
16:55:22	bauzas	np, thanks
16:55:41	bauzas	gibi: and I totally understand your pain of long-running meetings
16:56:58	gibi	stephenfin: qos + move in train, based on https://review.opendev.org/#/q/topic:bp/support-move-ops-with-qos-ports it is resize and cold migrate that is supported in train
16:58:18	melwitt	yeah, if you want to deprecate os-hypervisors, I think that should (1) be run by some ops people like bauzas said and (2) make sure everything you can get in one swoop from os-hypervisors is also gettable from placement in one swoop. maybe two swoops would also be ok, or I guess could talk about placement cli batching. just some things to think about
16:58:23	gibi	efried: about the provider config, I think the ball is at dustinc
16:58:48	bauzas	agreed with melwitt, the (2) is important
16:59:01	bauzas	and IIRC, that was why we never deprecated this API
16:59:09	bauzas	because of the feature gap
16:59:36	bauzas	but maybe I'm wrong, so I would just propose to identify all the parity between the API and the osc-placement calls and document it
16:59:39	melwitt	yeah, I assumed that's why it's still around but tbh I have never dug in more
16:59:52	bauzas	it would be easier to pull the trigger and convince people after that
17:00:00	stephenfin	melwitt: So come up with a osc-placement replacement for the 'openstack hypervisor show' command?

Earlier   Later