Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-01-30
12:37:05 sean-k-mooney we are having issue related to that however
12:37:32 sean-k-mooney specificly because on train devstack install under py2 and py3 on train when you enable py3
12:37:52 gibi I see.
12:38:07 gibi my knowledge is limited here so I follow your lead
12:38:10 sean-k-mooney and that causees issues with osc and other console script still being the python 2 version in the py3 only ussuri
12:38:52 sean-k-mooney gibi: i belive its still one of the issue tosky is trying to fix in the new zuul v3 native grenade job to get plugins to work
12:39:11 gibi sean-k-mooney: OK, thanks
12:39:19 gibi stephenfin: +A-d https://review.opendev.org/#/c/695380/
12:40:00 sean-k-mooney gibi: did you have a chance to review the numa proposal following the conversation efried and i had yesterday
12:40:28 stephenfin gibi: Thanks. Looks like sean-k-mooney addressed your earlier question :)
12:40:53 sean-k-mooney stephenfin: acully ^ goes for you and bauzas
12:42:11 stephenfin I saw the etherpad, yup. LGTM
12:42:22 sean-k-mooney stephenfin: bauzas gibi https://review.opendev.org/#/c/552924/15/specs/ussuri/approved/numa-topology-with-rps.rst@126 is the main comment.
12:43:30 sean-k-mooney stephenfin: cool
12:43:35 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Re-propose the flavor extra spec validation spec https://review.opendev.org/682655
12:43:48 sean-k-mooney hehe i was just reviewing that
12:43:57 sean-k-mooney although its small so ill start again
12:45:52 gibi sean-k-mooney: I read the scrollback but did not read the etherpad and the review yet. stay tuned
12:46:08 sean-k-mooney will do
12:46:31 sean-k-mooney the etherpad has a diagram which hopefully makes the design clear
12:46:54 sean-k-mooney when it comes to placement pictures help a lot
12:47:36 gibi totally agree ^^
12:55:45 sean-k-mooney stephenfin: im happy with the latest version of the extra spec validation
12:58:52 gibi stephenfin: I have one, hopefully the last question in https://review.opendev.org/#/c/682655/5/specs/ussuri/approved/flavor-extra-spec-validators.rst@152
13:02:30 openstackgerrit Merged openstack/nova-specs master: Non-Admin user can filter their instances by more filters https://review.opendev.org/701763
13:03:02 stephenfin gibi: replied
13:06:31 sean-k-mooney stephenfin: if you are storing the validator in a dict you could use set_defautl to get the right behavior
13:06:42 sean-k-mooney depending on how you are doing the lookup
13:06:52 stephenfin set_default?
13:07:10 sean-k-mooney on a dict set default only sets the value if the key is not already present
13:07:44 stephenfin oh, I was going to hard fail if it was there
13:07:54 stephenfin rather than ignore it
13:07:54 sean-k-mooney so if you regeister all the intree ones first by namespace and then the out of tree ones the intree would win
13:08:18 sean-k-mooney ya thats an option
13:08:36 sean-k-mooney but i have found that if you try to block peole doing things they will find a way to work around it
13:08:44 sean-k-mooney like with os-vif
13:09:16 sean-k-mooney we blocked people form importing our internal module by requireing the plugins to start with os_vif to only support intree plugins
13:09:41 sean-k-mooney so a vendor that will go unnamed renamed there plugin to be able to import them
13:10:02 stephenfin \o/
13:12:24 kashyap Stable folks, am I correct in assuming that this is a "feature" and not a likely backport candidate for Train? -- https://opendev.org/openstack/nova/commit/de512f2c02
13:12:29 gibi stephenfin: thank. I'm +2 on the extra spec validation again
13:12:37 kashyap It's a small, non-invasive change, though
13:13:11 sean-k-mooney kashyap changing default ya i think that is not a backport candiate
13:13:13 stephenfin kashyap: not stable-core, but the change in behaviour of the extra spec suggests to me it's not backportable, no
13:13:19 stephenfin jinx
13:13:24 sean-k-mooney :)
13:13:36 stephenfin gimme my coke, damn it
13:13:42 lyarwood yup, I wouldn't describe it as non-invasive tbh
13:13:52 kashyap stephenfin: sean-k-mooney: Yeah, guessed as much
13:13:55 sean-k-mooney kashyap: also i missed that merging congrats its nice to have that done
13:14:08 sean-k-mooney kashyap: i also would not really like to backport that downstream
13:14:09 kashyap lyarwood: Yeah, I was a "broad" def of "non-invasive" (db changes, etc)
13:14:24 kashyap sean-k-mooney: I won't. Just wondering, in case people come knocking
13:14:37 sean-k-mooney kashyap: we could maybe add it to 16 since that is not released yet
13:14:37 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: api: Add support for extra spec validation https://review.opendev.org/704643
13:14:58 sean-k-mooney but ya i think that will have to wait to 17
13:15:18 stephenfin don't bother reviewing that ^ I've still a lot to do
13:15:54 sean-k-mooney stephenfin: by the way you dont need to my "we shoudl really move this" comments
13:16:06 stephenfin eh, it's good to note for the future
13:16:22 sean-k-mooney we shoudl totally rename/move them at somepoint but ya not related to your work
13:17:36 stephenfin efried: When you're about, if you'd care to provide docs for these (or point me to someone that could) I'd be most grateful https://review.opendev.org/#/c/704643/3/nova/api/validation/extra_specs/powervm.py
13:18:42 tosky sean-k-mooney, gibi: we don't have jobs which starts from py27 and ends with py3*; the patch which backports the "don't install python2 library packages" has been backported to train a few hours ago, so grenade jobs should be fine for a final review (and merge) now
13:18:51 gibi sean-k-mooney, efried: I like the numa modeling proposal. thanks for crafting it
13:19:09 gibi tosky: ack, thanks
13:20:29 tosky gibi: afaik (gmann can provide a better answer), we don't support at all that py2->py3 scenario; if you want to test the train->master migration, just deploy train with py3
13:20:30 sean-k-mooney tosky: awsome
13:21:00 sean-k-mooney tosky: that more because we dont have a good way of cleaning the packages
13:21:27 gmann yeah and do not have someone to do that
13:22:42 sean-k-mooney well we are also not sure if there could in be a difference in the rpc traffic somehow
13:23:11 sean-k-mooney we dont think there will be but that was one of the worries. e.g. the ovo we send over amqp could some how be incompatiable
13:23:27 sean-k-mooney i dont think that is the case but i know it was raised in the past
13:24:33 sean-k-mooney no one has reported upgrade issues at least so its untested in the gate but appears to work in reality
13:26:14 gmann yeah, other integration py2 job on train or older release along with py3 jobs can tell both py version works well and should not be issue on upgrade with py2 version too. but yes it is not tested on gate.
13:28:09 gibi stephenfin: if you can fix the funct test then I can +2 https://review.opendev.org/#/c/662522
13:55:09 openstackgerrit Sylvain Bauza proposed openstack/nova master: Add a placement audit command https://review.opendev.org/670112
13:55:09 openstackgerrit Sylvain Bauza proposed openstack/nova master: Avoid PlacementFixture silently swallowing kwargs https://review.opendev.org/695180
14:00:13 bauzas gibi: I updated the audit command for fixing the tests
14:00:32 bauzas gibi: I also saw your other change for the PlacementFixture
14:00:39 bauzas as you want
14:01:56 efried stephenfin: Hah, "docs".
14:03:34 efried I fear there were never actually docs. But let me go refresh my memory on where they're translated over to actual PowerVM-isms (which *should* have docs... somewhere).
14:04:39 efried I don't think it would be super unreasonable for you to assign the work to the #openstack-powervm team to track that down. But only if you don't want it to get done.
14:04:54 openstackgerrit Merged openstack/nova-specs master: Add action event fault details https://review.opendev.org/699669
14:07:48 gibi bauzas: ack, I will look back after my call
14:10:17 openstackgerrit Merged openstack/os-vif master: move os-vif-ovs to be a non legacy job. https://review.opendev.org/701601
14:10:18 openstackgerrit Merged openstack/os-vif master: Revert "[Follow Up] OVS DPDK port representors support" https://review.opendev.org/703672
14:10:27 sean-k-mooney efried: am i wrong in thinking that all extra spec are ment to have a spec or at least a blueprint associated with them when added
14:10:50 sean-k-mooney efried: today we would also add docs and a release note to that list
14:11:04 efried sean-k-mooney: I don't recall a rule like that, but it's not a bad one.
14:11:06 sean-k-mooney but im wondering if those would be documented in the nova spec repo
14:11:32 sean-k-mooney efried: well its technically an api change even though its an unversioned one
14:11:59 efried You'll have to slap my five-years-ago wrist.
14:12:11 sean-k-mooney normally the accompany bigger features so they get pulled into a spec or blueprint by default
14:12:20 efried There certainly aren't in-repo docs for the powervm: extra specs.
14:13:25 efried or in the oot driver repo, for that matter.
14:13:39 openstackgerrit waleed mousa proposed openstack/os-vif master: [Follow Up] OVS DPDK port representors support https://review.opendev.org/705018
14:14:31 sean-k-mooney so looks like it was intoduced in tree in ocata
14:14:33 sean-k-mooney https://github.com/openstack/nova-specs/blob/master/specs/ocata/approved/powervm-nova-compute-driver.rst
14:15:13 sean-k-mooney actully pike
14:15:25 efried took us a while

Earlier   Later