| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-01-29 | |||
| 19:25:20 | sean-k-mooney | you could have procs and memory span ya | |
| 19:25:33 | sean-k-mooney | but can_split would be need to have any one resouce span numa nodes | |
| 19:25:42 | efried | yeah, actually, the non-NUMA example can be simplified if we just use a granular group for the proc & mem.... | |
| 19:26:01 | sean-k-mooney | ya | |
| 19:26:04 | sean-k-mooney | that would work | |
| 19:26:32 | efried | simpler, I like. | |
| 19:26:36 | sean-k-mooney | oh we are missign something from all of them | |
| 19:26:44 | sean-k-mooney | we need to add group_policy=none | |
| 19:26:58 | sean-k-mooney | because we are using granular groups | |
| 19:27:58 | sean-k-mooney | we still get the correct affintiy because fo same tree in the multi numa case | |
| 19:28:09 | sean-k-mooney | even with group_policy=none | |
| 19:28:56 | efried | yeah, I was just going to check whether we in fact did remove group_policy in the latest microversions. | |
| 19:29:16 | efried | it's irrelevant in this case. We get the same result with isolate or none | |
| 19:29:21 | sean-k-mooney | looking at the api doces its still there | |
| 19:29:35 | efried | okay, boo. But as noted above, it's irrelevant, so set it to whatever. Do you agree? | |
| 19:29:56 | sean-k-mooney | it can be in this case | |
| 19:30:03 | sean-k-mooney | but isolate breaks eaisly | |
| 19:30:15 | sean-k-mooney | for example 2 port with bandwith requests | |
| 19:30:23 | sean-k-mooney | so i dont like publicising its use | |
| 19:30:43 | efried | Right, so the point is, we can leave it to the user and/or the bandwidth code to decide on group_policy. | |
| 19:30:52 | sean-k-mooney | yes | |
| 19:30:57 | efried | IIRC the bandwidth code is defaulting it rn. | |
| 19:31:07 | efried | or at least we talked about doing that. | |
| 19:31:07 | efried | We can ask gibi to confirm | |
| 19:31:16 | sean-k-mooney | rn as in none? | |
| 19:31:31 | efried | 'right now' | |
| 19:31:47 | sean-k-mooney | oh i think its defaultin to none if it is | |
| 19:31:56 | sean-k-mooney | that should be our default unless you say otherwise | |
| 19:32:25 | sean-k-mooney | ok so it required becasuee we are using groups but the value is not relevent to the spec | |
| 19:32:30 | sean-k-mooney | im fine with that | |
| 19:32:39 | sean-k-mooney | its an implemenation detail | |
| 19:33:18 | efried | yeah. That was a gripe I had during the nested magic design, that group_policy should default (can't remember which way I said) at this point because we can control everything we need using other, more granular (heh) mechanisms. | |
| 19:33:24 | efried | but we didn't actually do that. | |
| 19:33:33 | efried | And, confirmed, we're defaulting to 'none' these days. | |
| 19:33:43 | efried | I found the reno yaml, lemme find where it is in the docs. | |
| 19:34:10 | sean-k-mooney | well really we should not have it be global either | |
| 19:34:21 | sean-k-mooney | it should be per set of groups or per subtreee or something | |
| 19:34:27 | efried | https://docs.openstack.org/releasenotes/nova/train.html#other-notes | |
| 19:34:28 | sean-k-mooney | anyway out of scope | |
| 19:35:04 | efried | right, that was my gripe. We now have same_subtree to dictate which can be shared and which can be spread. Because same_subtree also devolves to same rp in relevant cases. | |
| 19:35:34 | sean-k-mooney | ya | |
| 19:36:12 | sean-k-mooney | provide we model nics with an RP per PF same_subtree or the negation should hanel that too | |
| 19:36:37 | sean-k-mooney | so we might be able to remvoe the group polices thing at some point | |
| 19:37:04 | sean-k-mooney | anyway if this does not require it to make it work it makes me happy | |
| 19:40:15 | sean-k-mooney | i have saved a copy of that etherpad locally just in case by the way. | |
| 19:41:07 | efried | cool. I've got my comment all composed, will post it when I'm done reviewing the rest. Hopefully bauzas will parlay the etherpad into the doc before the etherpad goes kablooey, as it inevitably will. | |
| 19:41:38 | sean-k-mooney | well we nerver delete them | |
| 19:41:48 | sean-k-mooney | the only go away if the db gets currpted | |
| 19:42:04 | sean-k-mooney | so you would be suprised how long they survie | |
| 19:42:20 | sean-k-mooney | that said we have been bitten enough times at ptgs that i make backups | |
| 19:42:22 | efried | I've seen enough corrupted | |
| 19:42:23 | efried | yeah. | |
| 20:15:25 | artom | dansmith, around? So, are you completely opposed to https://review.opendev.org/#/c/672595/61/nova/tests/unit/virt/libvirt/fakelibvirt.py@489 ? | |
| 20:16:06 | artom | Because I've been trying to write something better, and I'm not sure what I have is worth it. Maybe I just suck, or am overthinking it? | |
| 20:16:30 | dansmith | Why is [1] harder than 1? Aside from all the test change | |
| 20:17:08 | dansmith | or maybe you're stuck on the fact that it really should be named cpu_socket_map or something? | |
| 20:17:27 | dansmith | I do think what you have is pretty ugly and would prefer a mutually exclusive additional arg to what you have It hink | |
| 20:17:52 | artom | dansmith, well, the way I have it now is a full-on separate class | |
| 20:18:01 | artom | Well, classes, because it trickles up and down | |
| 20:18:06 | artom | Now = locally, not pushed yet | |
| 20:18:53 | dansmith | and that's really just for tests? | |
| 20:19:24 | artom | The objective being, allow tests that don't need the sockets maps complexity to use the existing class, and have a new one for the tests that need it | |
| 20:19:33 | artom | Instead of imposing sockets map on all tests | |
| 20:20:03 | artom | You mean the HostInfo and NUMATopology classes? Yeah, just for tests | |
| 20:20:08 | dansmith | Right, point is you've created a new class to wrap hostinfo just for tests | |
| 20:20:19 | dansmith | seems kinda smelly since they're not doing what the production code does | |
| 20:20:28 | dansmith | at least make that a fixture or utility thing in tests/ | |
| 20:21:45 | artom | HostInfo already exists just for tests | |
| 20:22:43 | dansmith | ohhh, sorry I maybe was thinking too fast.. doesn't it mirror something else in the main code? | |
| 20:24:04 | artom | dansmith, no worries - I've been struggling with this for way too much time, too | |
| 20:25:04 | artom | dansmith, so, the HostInfo is eventually passed down to the fake_connection here: https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/base.py#L111 | |
| 20:25:23 | artom | dansmith, it's essentially our libvirt service stub | |
| 20:25:47 | dansmith | it doesn't inherit from something real, so ignore my previous comments | |
| 20:25:47 | dansmith | a wrapper class for ease makes perfect sense I think | |
| 20:25:57 | dansmith | yup I'm caught up now | |
| 20:27:20 | artom | Ohhhh | |
| 20:27:25 | artom | I think I just got it | |
| 20:27:40 | artom | Make the "internal machinery" use sockets map | |
| 20:27:50 | artom | And leave HostInfo on top as a compatibility shim | |
| 20:28:29 | artom | And for tests that need it, they can use the "internal machinery" class directly | |
| 20:32:01 | dansmith | yeah, i thought that was what you were suggesting | |
| 20:32:47 | artom | No, I had 2 classes in parallel | |
| 21:24:19 | efried | bauzas, sean-k-mooney, stephenfin: Finished that review of the numa topo spec. | |
| 21:34:23 | sean-k-mooney | efried: cool i will try to catch up with the review tommorow | |
| #openstack-nova - 2020-01-30 | |||
| 00:11:49 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595 | |
| 00:11:51 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA LM: Add func test for bug 1845146 https://review.opendev.org/687404 | |
| 00:11:51 | openstack | bug 1845146 in OpenStack Compute (nova) train "NUMA aware live migration failed when vCPU pin set" [High,Fix committed] https://launchpad.net/bugs/1845146 - Assigned to Dan Smith (danms) | |
| 01:48:54 | openstackgerrit | Brin Zhang proposed openstack/nova master: Follow-up: Add delete_on_termination to volume-attach API https://review.opendev.org/680655 | |
| 04:14:25 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Create and bind Cyborg ARQs. https://review.opendev.org/631244 | |
| 04:14:25 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Pass accelerator requests to each virt driver from compute manager. https://review.opendev.org/698581 | |
| 04:14:26 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Compose accelerator PCI devices into domain XML in libvirt driver. https://review.opendev.org/631245 | |
| 04:14:26 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735 | |
| 04:14:27 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Enable hard/soft reboot with accelerators. https://review.opendev.org/697940 | |
| 04:14:27 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Enable start/stop of instances with accelerators. https://review.opendev.org/699553 | |
| 04:14:28 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Enable and use COMPUTE_ACCELERATORS trait. https://review.opendev.org/699554 | |
| 04:14:28 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Bump compute rpcapi version and reduce Cyborg calls. https://review.opendev.org/704227 | |
| 04:14:29 | openstackgerrit | Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999 | |
| 06:29:14 | hariii2503 | Hi Guys . I am writing a python script to get some data from nova python client . | |
| 06:29:46 | hariii2503 | I m getting authentication error , when I used below commands | |
| 06:30:01 | hariii2503 | from novaclient import client | |