| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-01-22 | |||
| 17:10:43 | sean-k-mooney | kashyap: i saw the backport and i consider it to be a regerssion | |
| 17:11:36 | bauzas | stephenfin: so, once https://review.opendev.org/#/c/703568/ do we still have gate problems with the functional tests ? | |
| 17:12:16 | sean-k-mooney | kashyap: there have been some patches to lscpu to allow it to parse the different way the flags and model are reported on aarch64. i suspect that libvirt just need to have the same change applied to its parsing | |
| 17:12:31 | sean-k-mooney | kashyap: well actully the lscpu patch merged back in 2018 | |
| 17:19:28 | kashyap | My brain is starved of food, and my chest is aching after this bizarre bike fall. So I can't parse you fully yet | |
| 17:19:47 | kashyap | melwitt: sean-k-mooney What I know we shouldn't merge that revert, IMHO | |
| 17:20:19 | melwitt | thanks kashyap | |
| 17:20:43 | kashyap | melwitt: sean-k-mooney: Until libvirt gets the parsing correct and libvirt/QEMU CPU modelling maintainers give guidance, we should stick with current Nova behaviour. | |
| 17:21:27 | sean-k-mooney | i dissagree with that but if im being over ruled fine | |
| 17:22:30 | sean-k-mooney | with the current patch its likely that after a migration if the guess is rebooted the cpu flags and model might change | |
| 17:23:27 | sean-k-mooney | its also not clear to me if there is a risk of the guest crashign if it trys to use a instuction not supported on the dest host | |
| 17:24:26 | sean-k-mooney | given the info regarding cpu model and cpu flags is availabel in /proc/cpuinfo a correct fix in my view would have been to validate those | |
| 17:25:01 | sean-k-mooney | i walso woudl have expected a workaround config optin for this but im not planing on spending time to code that up | |
| 17:27:40 | kashyap | sean-k-mooney: All this requires extensive testing, and extremely careful audit - we haven't done any of that (yet). So we go with "solid heuristics". | |
| 17:28:22 | sean-k-mooney | solid heuristics of check nothing and hope it works? | |
| 17:28:57 | kashyap | The heuristic here being, "avoid needless checks" | |
| 17:29:44 | sean-k-mooney | we would not consider it safe to not check cpu compatabily on x86. its just seam wrong to have a lower standard for other archs | |
| 17:29:56 | sean-k-mooney | anyway i better go back to backporting | |
| 17:34:27 | sean-k-mooney | stephenfin: can you review https://review.opendev.org/#/c/701601 again when you have a chance | |
| 17:42:20 | stephenfin | sean-k-mooney: done | |
| 17:42:48 | sean-k-mooney | stephenfin: thanks | |
| 17:43:30 | sean-k-mooney | stephenfin: do you know if jan is about. he is ment to be moving this week right to start his new job next week | |
| 17:43:49 | stephenfin | bauzas: We shouldn't have, no. The issues are to do with Tempest tests, iirc (something to do with pip not uninstalling pyyaml since it was installed by the package manager) | |
| 17:44:06 | sean-k-mooney | that is being fix | |
| 17:44:07 | bauzas | all good, will recheck then | |
| 17:44:18 | sean-k-mooney | or has been fixed | |
| 17:44:18 | stephenfin | not so fast, I don't think the fix has merged | |
| 17:44:40 | stephenfin | bauzas: https://review.opendev.org/#/c/703735/ | |
| 17:44:57 | sean-k-mooney | you can add a depends on and then recheck | |
| 17:45:02 | bauzas | oh ok | |
| 17:45:47 | sean-k-mooney | that was breaking os-vif as well hence why i want to get that os-vif change merged so we nolonger have legacy jobs for it to break | |
| 17:48:53 | stephenfin | ah, so that's the dependency | |
| 17:48:55 | stephenfin | gtk | |
| 18:14:02 | openstackgerrit | Merged openstack/nova stable/stein: libvirt: remove conditional on VIR_DOMAIN_EVENT_SUSPENDED_POSTCOPY https://review.opendev.org/700773 | |
| 18:14:08 | openstackgerrit | Merged openstack/nova stable/stein: libvirt: check job status for VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED event https://review.opendev.org/700774 | |
| 18:31:50 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522 | |
| 18:31:50 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Cleanup of '_test_resize' helper test https://review.opendev.org/664245 | |
| 18:35:48 | artom | stephenfin, oh, you've picked that up again? ^^ | |
| 18:36:14 | artom | IIRC you handed it off to me, and then I looked it, shrugged my shoulders in despair, and never touched it again :/ | |
| 18:36:18 | stephenfin | artom: I'm getting hassled downstream for it and figured you didn't have bandwidth, so yeah :) | |
| 18:36:23 | stephenfin | all good | |
| 18:36:57 | artom | Yeah, sorry. There was attempt, the Gerrit comments are evidence of that. | |
| 18:38:11 | sean-k-mooney | stephenfin: i can hassel you upstrem for it too if you like | |
| 18:38:43 | sean-k-mooney | i wanted that to be in 16GA | |
| 18:38:52 | sean-k-mooney | well in train | |
| 18:38:57 | sean-k-mooney | same thing | |
| 18:39:25 | stephenfin | sean-k-mooney: https://media0.giphy.com/media/R7IYpzLLMBomk/giphy.gif?cid=790b7611c0d748cc03dc8e8f5456f63a200cd89cd6b5f14f&rid=giphy.gif | |
| 18:40:22 | sean-k-mooney | i think you still being working and only at 18:40 is enough pressue to make you fix anything | |
| 18:41:01 | sean-k-mooney | /only/online/ | |
| 18:44:52 | stephenfin | heh, yeah, I'll be done shortly | |
| 18:45:38 | artom | stephenfin, oh, I remember where I blocked - if we update the request spec with the new numa_topology, but the resize fails in one of a myriad of ways, and we need to revert it | |
| 18:46:04 | artom | IIRC we talked with dansmith about not persisting the numa_topology at all, and just making sure each request to the scheduler has the correct one | |
| 18:46:23 | stephenfin | artom: Just looked into that. FWICT, we don't revert the RequestSpec.flavor, let alone the RequestSpec.numa_topolology, in the case of a failure | |
| 18:46:36 | stephenfin | So I need another follow-up to do that | |
| 18:46:50 | artom | stephenfin, ah yeah, the flavor was in the same boat | |
| 18:48:35 | sean-k-mooney | oh ye are talking about a different bug. i was refering to https://bugs.launchpad.net/nova/+bug/1831771 | |
| 18:48:35 | openstack | Launchpad bug 1831771 in OpenStack Compute (nova) "UnexpectedDeletingTaskStateError exception can leave traces of VIFs on host" [Medium,In progress] - Assigned to Matthew Booth (mbooth-9) | |
| 18:49:57 | sean-k-mooney | sorry i saw you being ping about that downstream so assume that was the one you were refering too | |
| 18:52:58 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Add emulated TPM support to Nova https://review.opendev.org/631363 | |
| 18:52:59 | openstackgerrit | Eric Fried proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934 | |
| 18:58:17 | efried | gmann: What's the accepted way to add a specialized CI job to nova these days? | |
| 18:59:41 | sean-k-mooney | efried: are you asking about thrid party or first party | |
| 18:59:49 | efried | 1p, I would think | |
| 19:00:02 | efried | Specifically, I'm going to need to work something up for vTPM. This is going to mean that the job will need to | |
| 19:00:02 | efried | - run barbican | |
| 19:00:02 | efried | - (compile and?) install special versions of libvirt and qemu | |
| 19:00:02 | efried | - (compile and?) install some custom software | |
| 19:00:02 | efried | - build servers with custom flavors | |
| 19:00:03 | efried | - run some commands via ssh | |
| 19:00:07 | sean-k-mooney | you can just defien it in tree in the .zuul.yaml | |
| 19:00:25 | sean-k-mooney | the job name should start with nova | |
| 19:00:52 | sean-k-mooney | right | |
| 19:01:34 | sean-k-mooney | am its on my long todo list but i do plan to add a tempest jobs that does the libvirt/qemu compilation for that devstack plugin | |
| 19:02:00 | sean-k-mooney | that said next cycle ubuntu 20.04 should ship the ones you need | |
| 19:02:22 | sean-k-mooney | for the swtpm sorfware | |
| 19:02:27 | efried | I don't have until next cycle ;P | |
| 19:02:52 | sean-k-mooney | i would just use an ansible per-run playbook | |
| 19:02:53 | efried | I don't know that I care to run actual tempest | |
| 19:03:23 | efried | Unless the "build servers" and "run some commands" bits need to be done in a tempestuous framework of some kind? A plugin? | |
| 19:03:36 | efried | jroll: o/ | |
| 19:03:39 | sean-k-mooney | it could | |
| 19:03:57 | sean-k-mooney | but on the custom flaovr front have you looked at my dpdk job | |
| 19:04:13 | efried | my brain goes fuzzy when I see dpdk | |
| 19:04:19 | gmann | efried: you can use zuulv3 native base jobs from devstack if you do not want to run tempest | |
| 19:04:24 | sean-k-mooney | well dpdk is not important | |
| 19:04:44 | sean-k-mooney | but you can use a pre-run playbook to create a local.sh file which will create custome flavors | |
| 19:04:51 | sean-k-mooney | e.g. request vtpm | |
| 19:04:57 | efried | gmann: is there a "making a devstack zuulv3 job for dummies" guide somewhere? | |
| 19:05:03 | sean-k-mooney | then you can run standard tempest wtih those falvor to test your feature | |
| 19:05:17 | sean-k-mooney | or a subset of tempest | |
| 19:05:47 | gmann | efried: humm, not guide as such i know but i can link you some example from other project did like Tacker etc | |
| 19:05:56 | gmann | or job description | |
| 19:06:21 | efried | k. I don't trust nova's .zuul.yaml cause I never know when there's a legacy minefield I'm walking into. | |
| 19:07:01 | gmann | 'devstasck' can be used with minimum effort on specific jobs - https://github.com/openstack/devstack/blob/2e45f2c267c9ababdbdfc4c505b329398391c5f9/.zuul.yaml#L352 | |
| 19:07:35 | gmann | this is tacker multinode job for their functional testing - https://github.com/openstack/tacker/blob/bdb2d52b3a1b69c58cb2ac6f903380ab8a7bd973/.zuul.yaml#L28 | |
| 19:08:09 | efried | oh, so it's still kosher to use run.yaml things | |
| 19:08:12 | efried | that's a relief. | |
| 19:08:16 | sean-k-mooney | yes | |
| 19:08:30 | KeithMnemonic | melwitt. did this change break the patch? it is failing on a live migration thing now https://review.opendev.org/#/c/683008/6..7/nova/tests/unit/compute/test_compute.py | |
| 19:08:34 | gmann | multinode support is in all base jobs of devstack which is based on nodeset used on job | |