| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-01-20 | |||
| 14:39:11 | gmann | stephenfin: thanks | |
| 14:39:36 | gibi | gmann: we are reviewing https://review.opendev.org/#/c/701763/ with brinzhang__ | |
| 14:39:36 | brinzhang__ | gmann, https://review.opendev.org/#/c/701763/ | |
| 14:39:54 | gmann | ok, thanks. | |
| 14:45:40 | gmann | brinzhang__: gibi i left comment in review. we should not need policy there. we already have policy to allow admin filters to access by non-admin. | |
| 14:46:01 | gmann | this case of when operator/user want AZ to be always allowed for non-admin not based on configuration. | |
| 14:46:50 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove unused code https://review.opendev.org/703408 | |
| 14:47:54 | gibi | gmann: thanks. does os_compute_api:servers:allow_all_filters' | |
| 14:48:17 | gibi | gmann: does os_compute_api:servers:allow_all_filters makes every filtering available for the user? | |
| 14:48:26 | gmann | gibi: yes, but that allow all admin filters. | |
| 14:48:54 | gibi | gmann: so that cannot be used to selectively enable AZ filtering for non-admin | |
| 14:49:06 | gmann | as per discussion with author on IRC, this policy is not they want to use for making AZ for non-admin and wanted AZ to be available by default | |
| 14:49:40 | gmann | gibi: yeah, i mean if we default any filter for non-admin then we do not need policy for that. | |
| 14:50:48 | gibi | gmann: so simply adding availiability_zone to nova.api.openstack.compute.servers.serverscontroller._get_server_search_options would make the AZ filter available to non-admin by default | |
| 14:50:53 | gmann | if we think AZ is for non-admin then we should not add config way to disallow for non-admin. | |
| 14:51:02 | gmann | gibi: yes | |
| 14:51:16 | gibi | gmann: I got it, thanks | |
| 14:52:10 | gmann | but i am little concern to bump microversion for this single fitler. i commented to do a audit for all such filter first. like we did for API clenup BP(doing such cleanup together in single microvesion) | |
| 14:52:55 | gibi | gmann: and I've just agreed with you about that | |
| 14:53:00 | gibi | :) | |
| 14:53:02 | gibi | in the review | |
| 14:53:12 | gibi | gmann: thanks for the review | |
| 14:53:19 | gmann | thanks. | |
| 14:54:27 | brinzhang__ | gmann, gibi: so this spec's context is ok, we donot car about the policy's limit :) | |
| 14:55:09 | brinzhang__ | gibi: I am ok with that ^ | |
| 14:55:22 | gmann | yeah, policy is not required for that. we should add another configurable way which is not required. | |
| 14:55:58 | gibi | brinzhang__: I still think this is a valid spec. we don't need a new policy. And we should review the other existing admin-only filters to se other need to be moved to the non-admin set | |
| 14:56:41 | gmann | s/should/should not | |
| 14:57:12 | brinzhang__ | gibi: yeah, like gmann said, *that* should done in a micoroversion, avoid more microversions to do one thing | |
| 14:57:26 | gibi | brinzhang__: exactly | |
| 14:59:41 | brinzhang__ | gibi: I think I would like to do, but it will be start after our holiday~ | |
| 15:00:55 | gibi | brinzhang__: sure. holiday recharging is important :) I also expect the author to do the first sweep of the existing filters | |
| 15:01:59 | brinzhang__ | gibi: ^^ | |
| 15:17:07 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Avoid PlacementFixture silently swallowing kwargs https://review.opendev.org/695180 | |
| 15:17:07 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add a placement audit command https://review.opendev.org/670112 | |
| 15:21:57 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Add a default VirtIO-RNG device to guests https://review.opendev.org/616603 | |
| 15:22:22 | kashyap | sean-k-mooney: ^ I reworded the commit message; and reworded the puropose more clearly. | |
| 15:22:42 | kashyap | sean-k-mooney: (And tweaked the driver.py; hop that looks OK.) | |
| 15:25:07 | sean-k-mooney | i would still delete the backgroud section to be honest. that should have beeen in the patch that chagne to use /dev/urandom by default not this chagne but i wont block on it | |
| 15:26:05 | sean-k-mooney | you could have just referencce the change id of that commit instead of providing the history again | |
| 15:30:29 | gibi | stephenfin: I have one question in https://review.opendev.org/#/c/697153/15/nova/network/neutron.py | |
| 15:37:06 | stephenfin | gibi: Replied (tl;dr: nothing has really changed, but we could probably improve it in a follow-up patch) | |
| 15:38:54 | gibi | stephenfin: ahh _setup_net_dict could raise a similar unhandled exception before. Then your change does not make it worse. thanks for the explanation | |
| 15:39:04 | stephenfin | yup, exactly | |
| 15:40:55 | gibi | stephenfin: do you have an estimate how much work still remains in the nova-net removal? | |
| 15:41:11 | stephenfin | gibi: I think the patches that are up there are it | |
| 15:41:43 | stephenfin | I'm sure I missed some stuff but that should have the bulk of the work (services, API, docs, tests) taken care of | |
| 15:41:44 | gibi | stephenfin: wow soo colse then I gather my brain and try to read through | |
| 15:41:59 | gibi | close | |
| 15:51:23 | openstackgerrit | sean mooney proposed openstack/nova stable/stein: Disable NUMATopologyFilter on rebuild https://review.opendev.org/702973 | |
| 15:51:23 | openstackgerrit | sean mooney proposed openstack/nova stable/stein: Block rebuild when NUMA topology changed https://review.opendev.org/702972 | |
| 15:51:24 | openstackgerrit | sean mooney proposed openstack/nova stable/stein: FUP for in-place numa rebuild https://review.opendev.org/702974 | |
| 16:01:59 | gibi | stephenfin: thank you for your perseverance, it was an awesome job to remove all this logically dead code | |
| 16:22:47 | KeithMnemonic | elod: thank you for the review on https://review.opendev.org/#/c/683008/ any idea who else i can ask to get the "W"? | |
| 16:27:27 | elod | KeithMnemonic: no problem. well, I was a bit hesitant to give a +2+W, but decided to wait for other stable cores (list of stable cores: https://review.opendev.org/#/admin/groups/540,members ) | |
| 16:42:44 | KeithMnemonic | melwitt: can you please join the party here https://review.opendev.org/#/c/683008/ ;-) ? | |
| 16:43:22 | melwitt | KeithMnemonic: I can go through it later today. thanks for getting more people to review it, that helps | |
| 16:44:01 | KeithMnemonic | thank you and as i mentioned the customer with the issue confirmed those fixes correct the broken behavior | |
| 16:56:57 | openstackgerrit | Elod Illes proposed openstack/nova stable/stein: Enhance service restart in functional env https://review.opendev.org/703103 | |
| 17:01:35 | kashyap | gibi: If you're looking a change of scenery, an "easy win", if I may say so myself :-) -- https://review.opendev.org/#/c/616603/ | |
| 17:02:01 | gibi | kashyap: I've saved it for tomorrow morning :) | |
| 17:02:26 | kashyap | gibi: Yep, it's EoD for us in CET anyway... | |
| 17:06:04 | gibi | yepp, I'm about to leave for today | |
| 17:31:56 | openstackgerrit | Ilya Etingof proposed openstack/nova master: Add JSON schema for network_data.json https://review.opendev.org/703133 | |
| 19:17:03 | openstackgerrit | Merged openstack/nova master: nova-net: Remove layer of indirection in 'nova.network' https://review.opendev.org/696745 | |
| 20:51:31 | openstackgerrit | Merged openstack/nova stable/stein: Remove global state from the FakeDriver https://review.opendev.org/703102 | |
| 20:51:43 | openstackgerrit | Merged openstack/nova stable/queens: Improve metadata server performance with large security groups https://review.opendev.org/697518 | |
| 21:02:47 | openstackgerrit | sean mooney proposed openstack/nova stable/rocky: Disable NUMATopologyFilter on rebuild https://review.opendev.org/703117 | |
| 21:02:47 | openstackgerrit | sean mooney proposed openstack/nova stable/rocky: Block rebuild when NUMA topology changed https://review.opendev.org/703116 | |
| 21:02:48 | openstackgerrit | sean mooney proposed openstack/nova stable/rocky: FUP for in-place numa rebuild https://review.opendev.org/703118 | |
| 21:29:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'nova.image.api' module https://review.opendev.org/702451 | |
| 21:29:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: nova-net: Remove unused nova-network objects https://review.opendev.org/697156 | |
| #openstack-nova - 2020-01-21 | |||
| 02:50:24 | alex_xu | gibi: yea, I can be the liaison for that | |
| 02:51:05 | alex_xu | melwitt: i have few question for https://review.opendev.org/602201, still on the road to familar the spec | |
| 08:49:49 | gibi | alex_xu: thanks | |
| 09:51:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Stop setting Flavor.id https://review.opendev.org/703568 | |
| 09:51:01 | stephenfin | alex_xu, gibi, bauzas: Can you folks take a look at ^ since it's causing intermittent gate failures | |
| 09:54:35 | stephenfin | I also need someone to add me to nova-drivers again so I can triage bugs :/ | |
| 09:54:36 | stephenfin | https://launchpad.net/~nova-drivers | |
| 09:57:50 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'nova.image.api' module https://review.opendev.org/702451 | |
| 09:57:51 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: nova-net: Remove unused nova-network objects https://review.opendev.org/697156 | |
| 09:59:16 | brinzhang | stephenfin: https://review.opendev.org/#/c/702790/ this I was fixed the functional test fails, and leave the failed reason, please review again, while you are free | |
| 10:00:24 | brinzhang | alex_xu: please reivew https://review.opendev.org/#/c/580271 and https://review.opendev.org/#/c/702790/ when you are free | |
| 10:00:43 | brinzhang | stephenfin, alex_xu: thanks :) | |
| 10:01:38 | stephenfin | brinzhang: Done. I want to get dansmith to hit that again when he's online | |
| 10:02:19 | brinzhang | stephenfin: yeah | |
| 10:03:35 | brinzhang | dansmith: please reivew https://review.opendev.org/#/c/580271 and https://review.opendev.org/#/c/702790/ with bug 1663456 fix code, in your free time | |
| 10:03:35 | openstack | bug 1663456 in OpenStack Compute (nova) "Field 'updated_at' always 'None' when show aggregate" [Low,In progress] https://launchpad.net/bugs/1663456 - Assigned to Brin Zhang (zhangbailin) | |
| 10:04:57 | stephenfin | brinzhang: Does my comment on https://review.opendev.org/#/c/702790/ make sense? | |
| 10:05:45 | brinzhang | stephenfin: ack | |
| 10:09:05 | brinzhang | stephenfin: yeah, that's ture, your comment is makes sense. | |
| 10:23:37 | bauzas | stephenfin: sorry had some internal network issues since yesterday evening, but will add you | |
| 10:24:21 | bauzas | stephenfin: oh, actually it's the wrong team | |
| 10:24:43 | stephenfin | well, that would explain things :-D | |
| 10:25:25 | bauzas | stephenfin: you need to be in https://launchpad.net/~nova-bugs | |
| 10:26:57 | stephenfin | perfect. thanks | |
| 10:29:02 | bauzas | and +2 | |
| 10:29:22 | bauzas | stephenfin: but I said we should wait a little bit for the CI to return first | |
| 10:30:10 | stephenfin | Coolness | |
| 10:31:55 | kashyap | To those using Bash ... here's something useful (and fun): | |