Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-01-15
12:26:47 brinzhang stephenfin: I removed the duplicate handle in compute api. In the object.aggregate was done it, updated.
14:03:57 kashyap sean-k-mooney: Hey, finally got around to this RNG thing, mind having a gander when you can - https://review.opendev.org/#/c/616603/
14:16:07 Sundar dansmith, efried: I am here if there are any questions on https://review.opendev.org/#/c/631244/ or related stuff.
14:37:10 dansmith Sundar: I just got up, so I haven't seen, but I'm assuming you pushed a new rev?
14:38:02 Sundar I published comments, will push patches after you agree.
14:40:05 Sundar dansmith: Thanks, no rush
14:40:33 Sundar brinzhang: Thanks for the release notes pointers
14:41:17 stephenfin kashyap: I hit that
14:41:47 kashyap stephenfin: Thank you
14:43:07 kashyap Okay, read your remarks, will respond there.
14:47:55 sean-k-mooney kashyap: sure ill take a look
14:48:02 kashyap Thanks
14:48:39 sean-k-mooney Sundar: when you push the new version be sure to rebase all the patches in the chain against master
14:49:26 Sundar Yes, already done internally
14:49:31 sean-k-mooney Sundar: i deployed https://review.opendev.org/#/c/699554/2 yesterday but it does not work because it is missing depencies
14:51:01 Sundar sean-k-mooney: I think you mean the root_required patch, which has been merged now?
14:51:20 sean-k-mooney yes
14:52:00 sean-k-mooney on the cyborg side i notice the device v2 api has merged on monday/tuseday
14:52:41 sean-k-mooney are the arq v2 https://review.opendev.org/#/c/696089/ and deployable v2 https://review.opendev.org/#/c/698190/ changes required for this work?
14:54:07 sean-k-mooney i deployed with cyborg master which had the device v2 changes when i was testing
14:54:27 Sundar sean-k-mooney: Yes, I am updating the patch sets with these dependencies
14:55:33 Sundar sean-k-mooney: Yes, device v2 API merged, but that should be tangential to Nova. The main thing that Nova patches needs is https://review.opendev.org/698846
14:55:42 Sundar *need
14:58:00 sean-k-mooney ok well i was trying to use the cyborg placemtn client so haveing the api to validate the existing of the fake device and compare with placment was useful
14:58:02 Sundar sean-k-mooney: You don;t need https://review.opendev.org/#/c/698190/. Looking at the other one
14:58:35 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove layer of indirection in 'nova.network' https://review.opendev.org/696745
14:58:36 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Make the security group API a module https://review.opendev.org/696746
14:58:36 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove remaining nova-network quotas https://review.opendev.org/697152
14:58:37 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'FloatingIP' object https://review.opendev.org/697153
14:58:37 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'Network' object https://review.opendev.org/697154
14:58:38 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove use of legacy 'SecurityGroup' object https://review.opendev.org/697155
14:58:38 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-net: Remove now unnecessary nova-net workaround https://review.opendev.org/702440
14:58:39 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'nova.image.api' module https://review.opendev.org/702451
14:58:39 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: nova-net: Remove unused nova-network objects https://review.opendev.org/697156
14:58:44 Sundar Sure, that has been there since Train release
15:00:01 sean-k-mooney well the device api has but the support in the client only seams to work with v2
15:00:21 sean-k-mooney Sundar: by the way this is what i found http://paste.openstack.org/show/788372/
15:00:26 Sundar sean-k-mooney: You don't need https://review.opendev.org/#/c/696089/ either
15:00:52 sean-k-mooney Sundar: cool i did not have either applied so ill only use the first one you linked
15:01:15 sean-k-mooney https://review.opendev.org/#/c/698846/
15:02:16 dansmith Sundar: replying to those comments is a lot harder 1-2 weeks after I make them, vs sooner
15:02:47 Sundar dansmith: Got it, I had to fix the Cyborg side event nptification patch and its dependencies before I got to this
15:02:56 dansmith Sundar: I'm trying to make an effort to drop whatever I'm doing to review those patches as soon as you put them up to keep things moving, so it'd be helpful if you could at least reply to them quicker, even if the code isn't coming immediately
15:03:44 dansmith I think I've replied to all the ones you're expecting to hear about, but if I missed one let me know
15:04:33 Sundar dansmith: OK, but without trying the code changes, the best I could say is 'will consider/try it out'. Presumably you want a firmer reply than that.
15:04:45 Sundar dansmith: Thanks, looking now
15:05:20 dansmith Sundar: well, some of the comments were not needing code changes. anyway, just saying, faster responses would be nice
15:05:40 Sundar sena-k-mooney: Not sure if 'openstack accelerator device profile' is ready for prime time yet. But here it seems to be fine. Do you have the cyborg API logs?
15:05:53 Sundar sean-k-mooney: ^
15:10:55 sean-k-mooney am i still have it deploy it seamed to create the profile fine as the list shows
15:11:12 sean-k-mooney its a littel weird to just dump the raw json on the command line
15:11:25 sean-k-mooney when defining the groups
15:12:08 sean-k-mooney as far as i can tell the issue was the root_required patch not being present on the branch i tested
15:14:04 sean-k-mooney Sundar: next time i try goign though the work flow of deploying a vm ill see if i can capture the api logs too
15:14:37 gibi stephenfin, efried: the qos live migration patches are ready for review, if you have some time https://review.opendev.org/#/q/status:open++topic:bp/support-move-ops-with-qos-ports-ussuri
15:16:51 Sundar sean-k-mooney: Thanks
15:18:10 Sundar dansmith: Re. https://review.opendev.org/#/c/631244/53/nova/tests/unit/compute/test_compute_mgr.py@6098 , I stepped through the code and noticed that the return value was a dict, not a list. In fact, the first dict from the list.
15:19:02 Sundar dansmith: Your concerns about clarity are probably addressed by having mock_get_arqs.assert_has_calls() and clarifying the comments, right?
15:19:45 dansmith Sundar: then I think something else is going on: https://pastebin.com/7Rr1CVfd
15:21:14 dansmith Sundar: side_effect is the one that behaves the way you're describing (as you know): https://pastebin.com/PHiKTtew
15:22:03 Sundar dansmith: let me take another look and get back
15:22:56 dansmith thanks
15:39:15 openstackgerrit Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs https://review.opendev.org/552924
15:39:25 bauzas huzzah ^
15:42:14 sean-k-mooney well it nice that you rejoin us with such a simple and non contorviral proposal :P
15:49:48 artom Controviral?
15:50:08 artom I kinda like that. Becomes viral because it's so controversial
15:50:33 sean-k-mooney hehe
15:50:47 sean-k-mooney you figured it out so its close enough
15:51:39 sean-k-mooney but yes i think the decieion we have been making related to mixed cpus makes modeing numa in plamcent more controversial
15:52:06 stephenfin gibi: Done (the QoS live migration series)
15:52:17 gibi stephenfin: thanks a lot!
15:52:53 sean-k-mooney i was less concerned when we used the hw:* syntax but if we go with the placementese syntax then i have deep concerns with granuarl request groups and the group_policy as they exist today
15:55:11 Sundar dansmith: Please see http://paste.openstack.org/show/788413/. The main change I made is http://paste.openstack.org/show/788415/. The first call to get_arqs_for_instance is mocked properly, but the second call hits a StopIteration error.
15:57:38 dansmith Sundar: no, return_value will work as many times as you want: https://pastebin.com/2Wdgb64J
15:58:20 sean-k-mooney if you want to have a limited number of retruns or different retrun i think you use sideffect with an iterable
15:58:42 Sundar Ah, my bad, I still have it as side_effect. Will fix that
15:58:53 dansmith ...
16:01:04 Sundar I think it should work with these changes. This was the only pending point, AFAICS. Are you good with updating the patch set once this is resolved?
16:01:11 Sundar dansmith: ^
16:01:45 dansmith Sundar: unless you've replied to other comments I had, I think so
16:02:56 Sundar I pretty much agreed to other changes, even if it is a matter of preference.
16:03:24 aarents lyarwood: I replied to your remark https://review.opendev.org/#/c/696084 maybe kashyap can confirm that implemeting finish_unshelved as you suggest is the way to go
16:23:03 openstackgerrit Sundar Nadathur proposed openstack/os-traits master: Add a trait that compute manager can handle accelerator requests. https://review.opendev.org/698961
16:43:53 openstackgerrit Balazs Gibizer proposed openstack/nova stable/stein: DNM: try to trace bug 1859766 https://review.opendev.org/702700
16:43:53 openstack bug 1859766 in OpenStack Compute (nova) stein "functional tests intermittently fails with "ReadOnlyFieldError: Cannot modify readonly field uuid"" [Undecided,New] https://launchpad.net/bugs/1859766 - Assigned to Balazs Gibizer (balazs-gibizer)
17:27:53 openstackgerrit Kashyap Chamarthy proposed openstack/nova-specs master: Re-propose "Secure Boot support for KVM & QEMU guests" for Ussuri https://review.opendev.org/693844
17:28:41 kashyap aarents: Sorry, I wasn't ignoring that change, just been buried.
17:46:06 stephenfin efried_afk: not sure if you're gone for the day, but https://review.opendev.org/#/c/697537/ could probably be revisited now that x-cell resize has merged
17:47:03 stephenfin and melwitt, I think I've clarified my (new) intent in https://review.opendev.org/#/c/696745/, which should assuage some of your concerns hopefully
17:47:08 stephenfin with that
17:47:32 melwitt stephenfin: ack
18:02:52 openstackgerrit Artom Lifshitz proposed openstack/nova master: NUMA LM: Add func test for bug 1845146 https://review.opendev.org/687404
18:02:52 openstack bug 1845146 in OpenStack Compute (nova) train "NUMA aware live migration failed when vCPU pin set" [High,Fix committed] https://launchpad.net/bugs/1845146 - Assigned to Dan Smith (danms)
18:03:46 artom dansmith, could I ask you to look at that 2-patch series ^^ when you get a chance? stephenfin's the other reviewer, but your +1 or +W'less +2 can still carry weight and help the evential non-RH approver (efried, I'm guessing)
18:12:05 dansmith artom: yeah, although I'm a couple layers deep on the stack and have a call in 18 minutes
18:12:27 dansmith artom: meaning, don't let me forget
18:14:15 fungi anybody remember how far back nova started providing configdrive by default without needing to manually enable it in the config?
18:14:29 fungi (i mean providing it if the client requests it at boot)
18:14:35 dansmith a long time

Earlier   Later