| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-01-13 | |||
| 15:59:53 | sean-k-mooney | well i guess maybe if we have set that internally | |
| 16:00:02 | sean-k-mooney | i still need to find that code | |
| 16:03:06 | huaqiang | sean-k-mooney: in hardware.py I'll find it for yo | |
| 16:04:56 | huaqiang | https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L1860 | |
| 16:06:07 | sean-k-mooney | thanks ok and https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L1840-L1843 is where we block the mixed case | |
| 16:06:22 | sean-k-mooney | so the transformation happens in the api | |
| 16:07:13 | sean-k-mooney | numa_get_constraints is invoked form teh api to validate teh request and it si used when constuction teh numa toplogy object that is passed to the schduler | |
| 16:07:37 | huaqiang | it will be permitted for mixed case | |
| 16:08:09 | sean-k-mooney | yes so basicaly at line 1840 you will replace that with a check that will set the polciy to mixed internally | |
| 16:08:17 | openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/nova master: Add ironic hypervisor doc https://review.opendev.org/701998 | |
| 16:08:28 | sean-k-mooney | then make the if on line 1845 an elif | |
| 16:08:44 | sean-k-mooney | so we only take it if its a non mixed case | |
| 16:13:04 | huaqiang | https://review.opendev.org/#/c/696009/1/nova/virt/hardware.py | |
| 16:13:19 | huaqiang | this is my poc code for this part | |
| 16:21:44 | huaqiang | sean-k-mooney, efried: It is too late for me, I'll go to sleep, and I caught the current idea is using an interal policy 'mixed' in code path, but without exposing it to end user for using in flavor or image properties. | |
| 16:27:24 | sean-k-mooney | huaqiang: good night o/ | |
| 16:31:11 | efried | huaqiang: to be clear, I'm saying don't *require* it from the end user. I would prefer not to expose it, but if doing so (as optional) makes something significantly easier, I won't object to it. | |
| 17:06:00 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove extra instance.save() calls related to qos SRIOV ports https://review.opendev.org/702261 | |
| 18:02:50 | artom | I can never remember this, what's the order of assertEqual(expected, actual)? | |
| 18:12:24 | dansmith | expected,actual | |
| 18:17:37 | mriedem | fyi https://github.com/testing-cabal/testtools/blob/master/testtools/testcase.py | |
| 18:19:17 | mriedem | just your friendly neighborhood lurker | |
| 18:20:29 | artom | Are we... are we like crack to you? | |
| 18:21:09 | mriedem | just eating lunch | |
| 18:21:14 | mriedem | my artom sense went off | |
| 18:21:29 | artom | Aww, you have a sense for me | |
| 19:01:02 | efried | someone should | |
| 19:01:19 | efried | <tsssss> | |
| 20:15:37 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595 | |
| 20:15:39 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA LM: Add func test for bug 1845146 https://review.opendev.org/687404 | |
| 20:15:39 | openstack | bug 1845146 in OpenStack Compute (nova) train "NUMA aware live migration failed when vCPU pin set" [High,Fix committed] https://launchpad.net/bugs/1845146 - Assigned to Dan Smith (danms) | |
| 20:15:45 | artom | *finally* | |
| 20:19:48 | sean-k-mooney | oh its stacked ... | |
| 20:35:45 | efried | dustinc: You have a couple of notes in https://review.opendev.org/#/c/676522/ about needing more UT coverage. Is that still true? | |
| 20:35:54 | efried | (I haven't dug in yet to verify) | |
| 20:41:00 | openstackgerrit | Dan Smith proposed openstack/nova master: Add NovaEphemeralObject class for non-persistent objects https://review.opendev.org/702049 | |
| 20:55:54 | openstackgerrit | Merged openstack/nova-specs master: Update provider config spec for identification conflicts https://review.opendev.org/693414 | |
| 21:10:18 | dustinc | efried: I thought it was good and I just forgot to remove the note, but I checked again just to be sure and actually found another scenario I want to write a test for.. | |
| 21:10:47 | efried | dustinc: I just finished reviewing the code side and found some things that need to be fixed anyway. | |
| 21:11:32 | dustinc | I have to step away for a few minutes, but I will check it out in a few. Thanks! | |
| 21:13:09 | efried | no hurry | |
| #openstack-nova - 2020-01-14 | |||
| 02:37:46 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree https://review.opendev.org/676522 | |
| 02:37:47 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460 | |
| 02:48:19 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree https://review.opendev.org/676522 | |
| 02:48:19 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460 | |
| 06:27:35 | openstackgerrit | Brin Zhang proposed openstack/nova master: Populate 'updated_at' when aggregate is updated https://review.opendev.org/580271 | |
| 07:47:18 | openstackgerrit | sean mooney proposed openstack/nova master: Libvirt: report storage bus traits https://review.opendev.org/666914 | |
| 08:00:25 | brinzhang | gibi: are you around? | |
| 08:20:04 | openstackgerrit | Alexandre arents proposed openstack/nova master: Avoid allocation leak when deleting instance stuck in BUILD https://review.opendev.org/702368 | |
| 08:46:43 | openstackgerrit | Lee Yarwood proposed openstack/nova master: virt: Provide block_device_info during rescue https://review.opendev.org/700811 | |
| 08:46:43 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add support for stable device rescue https://review.opendev.org/700812 | |
| 08:46:44 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP compute: Report COMPUTE_BFV_RESCUE and check during rescue https://review.opendev.org/701429 | |
| 08:46:44 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP api: Introduce microverion 2.82 allowing boot from volume rescue https://review.opendev.org/701430 | |
| 08:46:45 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Support boot from volume instance rescue https://review.opendev.org/701431 | |
| 08:47:23 | lyarwood | alex_xu: https://review.opendev.org/#/c/694063/ - I'm looking for some non-RH nova-specs core review on this if you have time today, ^ PoC code posted above. | |
| 08:47:25 | openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Add action event fault details https://review.opendev.org/699669 | |
| 09:06:13 | openstackgerrit | waleed mousa proposed openstack/os-vif master: [Follow Up] OVS DPDK port representors support https://review.opendev.org/665965 | |
| 09:44:16 | openstackgerrit | Iury Gregory Melo Ferreira proposed openstack/nova master: Add ironic hypervisor doc https://review.opendev.org/701998 | |
| 09:56:13 | gibi | lyarwood, dansmith: I'm ok with https://review.opendev.org/#/c/694063/ but there are precedence in nova (support move ops with qos ports) not to add api microversions. So I want to double check with you about it before +ait | |
| 10:04:09 | brinzhang | gibi: https://review.opendev.org/#/c/699669/ I was updated this patch, add the decription of the new policy, if you have time please review again :) | |
| 10:05:48 | gibi | brinzhang: ack, will look | |
| 10:09:09 | brinzhang | gibi: thanks~ | |
| 10:25:11 | gibi | brinzhang: I'm +2 on the instance action spec | |
| 10:25:14 | gibi | thanks for the update | |
| 10:26:03 | brinzhang | gibi: cool, thanks ^^ | |
| 11:13:19 | openstackgerrit | Arnaud Morin proposed openstack/nova master: Force refresh of instance info cache on event https://review.opendev.org/702394 | |
| 11:18:33 | stephenfin | bauzas: Can you send this on its way, please? https://review.opendev.org/#/c/695733/ | |
| 11:26:29 | alex_xu | lyarwood: got it | |
| 11:29:39 | openstackgerrit | Merged openstack/nova-specs master: Spec: Ussuri: Encrypted Emulated Virtual TPM https://review.opendev.org/686804 | |
| 11:30:46 | luyao | stephenfin: Could you look at spec 'support live migration with vpmem'? https://review.opendev.org/#/c/695863 | |
| 11:31:19 | stephenfin | luyao: I can, but not today. Could you ask me again tomorrow? | |
| 11:31:56 | luyao | stephenfin: OK, thanks at advance. :) | |
| 11:42:33 | alex_xu | lyarwood: gibi https://review.opendev.org/#/c/694063/7/specs/ussuri/approved/virt-bfv-instance-rescue.rst@76 | |
| 12:14:29 | etingof | o/ do we have a JSON schema for whatever is exposed through Nova metadata service? I am particularly interested in network_data.json | |
| 12:15:34 | openstackgerrit | Luyao Zhong proposed openstack/nova-specs master: support live migration with virtual persistent memory https://review.opendev.org/695863 | |
| 12:23:54 | sean-k-mooney | dansmith: efried i deployed https://review.opendev.org/#/c/699554/2 and installed the required version fo the sdk and cyborg client | |
| 12:24:07 | sean-k-mooney | it looks like there are still issue however http://paste.openstack.org/show/788372/ | |
| 12:25:37 | sean-k-mooney | it looks like everything on the placement side is fine but its failing to boot a vm with "AttributeError: \'RequestSpec\' object has no attribute \'root_required\'\n\n'" | |
| 12:31:24 | huaqiang | hello stephenfin. I hope you enjoyed your vacation | |
| 12:32:21 | huaqiang | I also want to invite your to review https://review.opendev.org/#/c/668656/ | |
| 12:34:26 | huaqiang | we have had some disscution especially on how to create a mixed instance, and Alex have put those dicussion links to the update of the spec | |
| 12:34:34 | huaqiang | I hope to get your comments. | |
| 12:37:00 | gibi | alex_xu: responded. If you are OK with the microversion then feel free to +A, I will +A myself if lyarwood or dansmith state that the microversion is intentional | |
| 12:39:15 | lyarwood | gibi / alex_xu ; apologies just back from a long lunch, yeah it's intentional, I'll add a comment now. | |
| 12:39:25 | gibi | lyarwood: cool thanks | |
| 12:47:13 | brinzhang | This bug fix is ready to review, if you have free time, please review https://review.opendev.org/#/c/580271/ | |
| 12:48:59 | brinzhang | it's bug 1663456 | |
| 12:48:59 | openstack | bug 1663456 in OpenStack Compute (nova) "Field 'updated_at' always 'None' when show aggregate" [Low,In progress] https://launchpad.net/bugs/1663456 - Assigned to Brin Zhang (zhangbailin) | |
| 12:54:07 | openstackgerrit | Lee Yarwood proposed openstack/nova-specs master: Boot from volume instance rescue https://review.opendev.org/694063 | |
| 12:54:19 | lyarwood | ^ addressed the commit nit btw | |
| 12:55:34 | sean-k-mooney | dansmith: efried: ok so the cyborg series just need to be rebased on https://review.opendev.org/#/c/699050/ | |
| 12:56:31 | sean-k-mooney | well that is merges so rebaseing on master would be enough | |
| 13:00:24 | gibi | lyarwood: +Ad the spec | |
| 13:00:31 | gibi | lyarwood: thanks for the confirmation | |
| 13:03:07 | lyarwood | gibi: awesome thanks :) | |
| 13:19:56 | sean-k-mooney | stephenfin: can you review this when you get a chance https://review.opendev.org/#/c/701601/ | |
| 13:34:33 | openstackgerrit | Merged openstack/nova-specs master: Boot from volume instance rescue https://review.opendev.org/694063 | |
| 13:48:08 | stephenfin | huaqiang: As with luyao, if you can ask me again tomorrow I'll try get to it. Too much to do today :( | |
| 13:57:27 | lyarwood | efried: https://review.opendev.org/#/c/694033/ - The spec for this has now merged if you're able to look again today, thanks in advance. | |
| 14:01:49 | stephenfin | sean-k-mooney: done | |