Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-12-18
16:03:59 mriedem stephenfin: it's not actually trying to get a console i don't think, just a url
16:04:44 mriedem so if there isn't any special token handling for xvpvnc it doesn't seem like it is treated any different from vnc
16:04:53 mriedem the url would be different, but the test isn't checking to see if the url can be used
16:15:17 lyarwood so is it even worth keeping the tempest test in tree for older releases in that case?
16:15:51 lyarwood stephenfin: ^ ?
16:26:20 stephenfin Sorry, meeting
16:26:34 stephenfin lyarwood, mriedem: So I think that test is junk because nova doesn't seem to check whether it can actually support the requested console type
16:27:12 stephenfin nova just requests _a_ console type from the virt driver https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6681
16:27:57 stephenfin so if you request the xvp type on the libvirt driver, it'll return a connection_info object with a URL that would never work
16:28:31 mriedem i think i said all of that above
16:28:32 lyarwood yup, do you want to push something to nuke it and I'll drop my change?
16:28:49 stephenfin lyarwood: To answer your question, given that we're deprecating the XVP console type and using it previously would require Xen, which no one's tested in who knows how long, I'd nuke it from Tempest
16:28:54 stephenfin no need for the config option
16:29:16 stephenfin mriedem: and I'm agreeing with you :)
16:29:18 lyarwood stephenfin: ack, I'll do that now then
16:29:19 mriedem i'd support nuking that from tempest
16:29:32 mriedem if someone using xen comes along and wants that later, they could write a tempest plugin
16:29:46 stephenfin If they want it on < Ussuri, that is
16:29:52 stephenfin since it'll be gone from then on, hopefully
16:29:56 mriedem sure
16:30:05 mriedem the plugin is branchless as well
16:30:19 stephenfin doubtful, given Bob Ball (?) said they're using noVNC now too
16:30:21 lyarwood goes back to PS1
16:41:10 lyarwood stephenfin: sorry side tracked, https://review.opendev.org/695853
16:42:00 mriedem so uh, we have like no end in sight for fixing http://status.openstack.org/elastic-recheck/#1844929
16:42:07 mriedem it continues to cripple the gate,
16:42:30 mriedem i think i'm going to hack a retry attempt into the scheduler code that continually hits that in the off chance it's something like eventlet that is screwing things up here and a retry will recover
16:45:02 stephenfin lyarwood: reviewed
16:45:32 stephenfin not sure about that schema change, though maybe I misunderstood what it was doing
16:52:52 lyarwood stephenfin: ack, sorted.
17:00:04 openstackgerrit Lee Yarwood proposed openstack/nova master: Remove 'nova-xvpvncproxy' https://review.opendev.org/687909
17:00:19 lyarwood stephenfin: ^ rebased so it's tested against that change
17:01:10 stephenfin ack, thanks
17:15:30 openstackgerrit Matt Riedemann proposed openstack/nova master: Retry on cell timeout failures getting nodes during scheduling https://review.opendev.org/699735
17:15:37 mriedem slaweq: ^ not sure if this will help with http://status.openstack.org/elastic-recheck/#1844929 but we can see
17:22:50 openstackgerrit Merged openstack/nova master: api-ref: avoid mushy wording around server.image description https://review.opendev.org/698976
17:28:08 openstackgerrit Matt Riedemann proposed openstack/nova master: Use COMPUTE_SAME_HOST_COLD_MIGRATE trait during migrate https://review.opendev.org/695220
17:44:17 openstackgerrit Merged openstack/nova master: Zuul v3: use devstack-plugin-nfs-tempest-full https://review.opendev.org/699516
17:44:23 openstackgerrit Merged openstack/nova master: Add troubleshooting doc about rebuilding the placement db https://review.opendev.org/698517
17:44:30 openstackgerrit Merged openstack/nova master: Remove dead code from MigrationTask._execute https://review.opendev.org/697699
18:01:36 mriedem stephenfin: reviewed https://review.opendev.org/#/c/679502/
18:03:34 stephenfin thanks
18:21:22 openstackgerrit Luigi Toscano proposed openstack/nova stable/train: Zuul v3: use devstack-plugin-nfs-tempest-full https://review.opendev.org/699753
18:28:06 openstackgerrit Merged openstack/nova master: Optimization for nova-api _checks_for_create_and_rebuild https://review.opendev.org/698125
18:36:43 KeithMnemonic1 I know the holidays are coming up, but i appreciate any more reviews to help this get merged before the year ends https://review.opendev.org/691045
19:57:59 mriedem melwitt: if you're around the bottom 4 nova-net removal patches are pretty easy, starts at https://review.opendev.org/#/c/696510/
21:17:36 gmann stephenfin: did not get your comment on this - https://review.opendev.org/#/c/657698/14
22:07:47 mriedem get yer gate bugs hyeah https://bugs.launchpad.net/nova/+bug/1856902
22:07:47 openstack Launchpad bug 1856902 in OpenStack Compute (nova) "nova.tests.functional.libvirt.test_vpmem.VPMEMTests.test_create_servers_with_vpmem fails intermittently" [Medium,Confirmed]
#openstack-nova - 2019-12-19
00:06:41 openstackgerrit Merged openstack/nova master: Revert cross-cell resize from the API https://review.opendev.org/638048
02:27:36 luyao artom, stephenfin, sean-k-mooney: spec 'support live migration with vpmem' updated. https://review.opendev.org/695863
02:28:24 artom lyarwood, ack, hopefully I can get to it before my holiday PTO on friday
02:29:07 luyao artom: thanks
04:38:07 openstackgerrit Merged openstack/nova master: Remove now invalid cells v1 comments from conductor code https://review.opendev.org/697670
06:07:30 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Add action event fault details https://review.opendev.org/699669
06:58:54 openstackgerrit Merged openstack/nova stable/rocky: Add --dry-run option to heal_allocations CLI https://review.opendev.org/698525
06:58:59 openstackgerrit Merged openstack/nova stable/rocky: Add --instance option to heal_allocations https://review.opendev.org/698529
06:59:05 openstackgerrit Merged openstack/nova stable/rocky: Add BFV wrinkle to TestNovaManagePlacementHealAllocations https://review.opendev.org/698531
07:15:59 openstackgerrit Merged openstack/nova stable/train: Zuul v3: use devstack-plugin-nfs-tempest-full https://review.opendev.org/699753
07:41:17 openstackgerrit Luigi Toscano proposed openstack/nova stable/stein: Zuul v3: use devstack-plugin-nfs-tempest-full https://review.opendev.org/699924
12:17:13 stephenfin dtantsur: Wanna give me core on x/wsme so I can go merge a load of my own stuff? :) Maintainers seem a bit thin on the ground
13:15:25 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support live migration with qos ports https://review.opendev.org/695905
13:15:26 openstackgerrit Balazs Gibizer proposed openstack/nova master: Func test for qos live migration reschedule https://review.opendev.org/699015
13:15:26 openstackgerrit Balazs Gibizer proposed openstack/nova master: Move common test method up to base class https://review.opendev.org/699064
13:15:27 openstackgerrit Balazs Gibizer proposed openstack/nova master: Func test for abort and cancel live migration https://review.opendev.org/699065
13:15:27 openstackgerrit Balazs Gibizer proposed openstack/nova master: Enable live migration with qos ports https://review.opendev.org/699066
13:15:28 openstackgerrit Balazs Gibizer proposed openstack/nova master: Fix get_request_group_mapping doc https://review.opendev.org/699979
13:20:32 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support live migration with qos ports https://review.opendev.org/695905
13:20:33 openstackgerrit Balazs Gibizer proposed openstack/nova master: Fix get_request_group_mapping doc https://review.opendev.org/699979
13:20:33 openstackgerrit Balazs Gibizer proposed openstack/nova master: Func test for qos live migration reschedule https://review.opendev.org/699015
13:20:34 openstackgerrit Balazs Gibizer proposed openstack/nova master: Move common test method up to base class https://review.opendev.org/699064
13:20:34 openstackgerrit Balazs Gibizer proposed openstack/nova master: Func test for abort and cancel live migration https://review.opendev.org/699065
13:20:35 openstackgerrit Balazs Gibizer proposed openstack/nova master: Enable live migration with qos ports https://review.opendev.org/699066
13:44:57 shilpasd zzzeek: hi
14:22:26 mriedem relatively simple docs bug if someone wants it https://bugs.launchpad.net/nova/+bug/1857013
14:22:26 openstack Launchpad bug 1857013 in OpenStack Compute (nova) "Configure live migrations in nova - timeout section for kvm doesn't mention live_migration_timeout_action" [Low,New]
14:25:44 openstackgerrit Matt Riedemann proposed openstack/nova stable/stein: Zuul v3: use devstack-plugin-nfs-tempest-full https://review.opendev.org/699924
14:27:08 tosky mriedem: oh, do you nova people require a cherry pick footer for each item in the chain?
14:27:23 mriedem tosky: preferred
14:27:29 mriedem to see that they are going in order
14:27:38 mriedem since it was a clean cherry-pick i just fixed it using the gerrit ui
14:27:45 tosky yep, noticed
14:28:01 mriedem alex_xu: this functional test race failure is spiking http://status.openstack.org/elastic-recheck/#1856902
14:28:09 mriedem i'm inclined to skip that bug until someone can post a fix
14:28:18 mriedem stephenfin: ^ any thoughts on that?
14:36:12 shilpasd mriedem:hi
14:36:34 mriedem oh is see the bug
14:37:21 shilpasd mriedem: for https://review.opendev.org/#/c/694462/3/nova/db/sqlalchemy/api.py@2010, i have made changes suggested, but its returning list of tuples
14:37:47 mriedem stephenfin: i think the issue is the delete server helper in the libvirt functional tests is no longer waiting for the server to be gone
14:37:56 mriedem probably due to the big refactoring going on
14:38:59 mriedem shilpasd: ok, i guess you'd have to debug it
14:39:26 mriedem stephenfin: or this was just always racy and we're hitting fast nodes
14:42:49 shilpasd mriedem: can you please check 'http://paste.openstack.org/show/78779' lines 40 and 41
14:43:19 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix race in test_create_servers_with_vpmem https://review.opendev.org/699997
14:43:21 mriedem stephenfin: melwitt: ^
14:43:21 shilpasd mriedem: i need to iterate again to have list of uuids
14:43:46 mriedem that paste doesn't work
14:45:54 shilpasd mriedem: means its wrong approach?
14:46:09 mriedem i mean your paste url is broken
14:47:18 shilpasd http://paste.openstack.org/show/787793/

Earlier   Later