Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-12-14
10:43:26 openstackgerrit Balazs Gibizer proposed openstack/nova master: Func test for abort and cancel live migration https://review.opendev.org/699065
11:04:18 openstackgerrit Balazs Gibizer proposed openstack/nova master: Enable live migration with qos ports https://review.opendev.org/699066
21:38:15 openstackgerrit Matt Riedemann proposed openstack/nova master: Add cross-cell resize tests for _poll_unconfirmed_resizes https://review.opendev.org/698322
21:38:15 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add negative test to delete server during cross-cell resize claim https://review.opendev.org/688832
21:38:16 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Implement reschedule logic for cross-cell resize/migrate https://review.opendev.org/696213
21:38:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix accumulated non-docs nits for cross-cell-resize series https://review.opendev.org/698935
#openstack-nova - 2019-12-15
07:41:36 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Allow specify user to reset password https://review.opendev.org/682302
11:12:23 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: Skip cpu comparison on AArch64 https://review.opendev.org/699115
11:12:55 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: Skip cpu comparison on AArch64 https://review.opendev.org/699116
11:13:30 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Skip cpu comparison on AArch64 https://review.opendev.org/699117
13:48:15 openstackgerrit Merged openstack/nova stable/train: Switch to uses_virtio to enable iommu driver for AMD SEV https://review.opendev.org/698738
13:48:19 openstackgerrit Merged openstack/nova stable/train: Also enable iommu for virtio controllers and video in libvirt https://review.opendev.org/685756
13:58:05 openstackgerrit Merged openstack/nova stable/train: Create a controller for qga when SEV is used https://review.opendev.org/698739
13:58:09 openstackgerrit Merged openstack/nova stable/train: Revert "docs: Highlight the current broken state of SEV" (partially) https://review.opendev.org/698746
14:00:18 openstackgerrit Merged openstack/nova stable/train: Mask the token used to allow access to consoles https://review.opendev.org/696685
#openstack-nova - 2019-12-16
03:04:28 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Allow specify user to reset password https://review.opendev.org/682302
03:13:55 openstackgerrit Luyao Zhong proposed openstack/nova master: address specific resources cleanup issue https://review.opendev.org/699148
03:24:33 openstackgerrit Boxiang Zhu proposed openstack/nova master: Make evacuation respects anti-affinity rule https://review.opendev.org/649963
03:31:53 openstackgerrit Boxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously https://review.opendev.org/651969
14:04:42 mriedem gibi: i dumped some ideas on https://review.opendev.org/#/c/638047/56/nova/conductor/manager.py@1883 - do you have any preferences?
14:04:59 gibi mriedem: on a meeting for 30 minutes but I will look
14:15:48 gibi mriedem: responded
14:17:26 mriedem heh and i just answered that elsewhere https://review.opendev.org/#/c/638048/56/nova/tests/functional/test_cross_cell_migrate.py@595
14:17:38 mriedem i'll work on a patch today to fix both of those things
14:37:31 mriedem I can also remove the cache from MigrationContext https://review.opendev.org/#/c/691991/15/nova/objects/migration_context.py@131 in the FUP patch
14:38:46 gibi mriedem: cool, I can re-review tomorrow at some point
14:39:01 gibi mriedem: but I'm mostly OK with the series now
14:39:28 mriedem ack, thanks
14:55:55 mriedem i put https://blueprints.launchpad.net/nova/+spec/support-move-ops-with-qos-ports-ussuri in a runway slot
14:56:01 mriedem +1 week for the holiday
14:56:15 mriedem not that people are really paying attention to runways anymore...
14:56:47 tbachman pilots
14:57:34 mriedem it's all auto-pilot now
14:57:56 tbachman that’s the way I roll when developing
14:58:23 tbachman explains all the bugs
15:06:13 gibi mriedem: thanks
15:06:14 KeithMnemonic good day mriedem: i did an update to fix that issue with osc --marker --deleted. Would you mind giving me your thought on if this is the right direction to go in. Thank you. https://review.opendev.org/691045
15:06:49 KeithMnemonic it was what we discussed a few weeks ago, just for ID only when --deleted is also used
15:08:48 gibi mriedem: will you implement the fix for https://review.opendev.org/#/c/638047/56/nova/conductor/manager.py@1883 in a separate commit top of the series? if yes then I will +A the current patch to keep the series moving
15:10:14 mriedem gibi: yes i'm working on it now
15:10:20 gibi mriedem: cool.
15:10:58 aarents lyarwood: I commented out your reply if you may have a look ? https://review.opendev.org/#/c/696084
15:12:39 mriedem KeithMnemonic: done
15:13:13 mriedem gibi: i've also removed the cache from https://review.opendev.org/#/c/691991/ in the FUP patch at the end
15:13:20 mriedem just haven't pushed it yet
15:14:05 gibi mriedem: thanks. I see your comment about having the whole instance object cached. That seems even more dangerous but dansmith seemed to have a good reason for that cache https://github.com/openstack/nova/commit/7a9942c5924d7ccfe321c54d0b5e70cfb3aede57
15:14:59 mriedem i think that's probably safer since a Migration record is created with an instance.uuid always i think
15:15:03 mriedem so it's not going to change
15:15:15 mriedem gibi: also on the assertion to add in https://review.opendev.org/#/c/638268/56 - can i do that in a FUP as well to keep things moving?
15:15:26 mriedem you said you were out after today and most of the series is approved so i'd like to FUP what i can
15:15:33 gibi mriedem: sure, that can be a simple extension to the test
15:17:09 gibi mriedem: changed my vote there
15:17:35 gibi mriedem: yeah today is my last day in the office. I will try look at some of my patches during this week still
15:18:29 gibi mriedem: I think I'm +A now on all the patches that had +2 from stephenfin
15:25:13 mriedem awesome, thanks
15:25:21 mriedem i've got your live migration qos change in the tab queue as well
15:26:11 lyarwood aarents: ack yeah sorry will try to get to it today
15:27:54 aarents lyarwood: oky, thks
15:33:36 efried o/
15:33:43 efried I'm not here
15:33:49 efried but if I were, it would be only to ask for some reviews...
15:34:16 efried gibi: you're on vacation starting... tomorrow?
15:35:01 efried mriedem: would be neat to get your feedback on (esp the ovo parts of) https://review.opendev.org/#/c/699050/ before you disappear into a quantum paradox.
15:35:05 efried or whatever that is
15:35:32 efried it's what we talked about on Friday: RequestSpec.placement_shit
15:36:47 efried And in the spirit of throwing small, self-contained, but hopefully slightly interesting stuff at you for your last few days, this one should hopefully be an easy A: https://review.opendev.org/#/c/698803/
15:37:22 mriedem they are in the tab qeuue
15:37:24 mriedem *queue
15:37:38 efried thanks mriedem
15:37:42 efried stephenfin: If you could please have another look at the vTPM spec, I would love to get that merged before the new year. https://review.opendev.org/#/c/686804/
15:39:48 openstackgerrit Eric Fried proposed openstack/nova master: FUP: Remove noqa and tone down an exception https://review.opendev.org/698054
15:40:15 efried stephenfin: that's a trivial fup you requested, probably fast-approvable ^
15:44:45 gibi efried: this is my last day in the office
15:45:34 gibi efried: I will try to still look at my qos patches during this week
15:45:54 efried gibi: okay, cool. If you have time, I think you might find https://review.opendev.org/#/c/699050/ interesting. But no big deal if you don't get to it. (Uses placement 1.35 to do root_required, and puts a request-level params object next to RequestSpec.requested_resources)
15:46:12 gibi efried: ack, added to the queue
15:52:49 KeithMnemonic mriedem: do you mean a test here? https://github.com/openstack/python-openstackclient/tree/master/openstackclient/tests/functional/compute/v2 or unit? or both? this is new to me
15:54:27 mriedem KeithMnemonic: functional would be ideal since it's easy to have false positive unit tests in osc
15:55:05 KeithMnemonic thank you
15:55:37 mriedem i.e. a functional test that does something like, (1) creates a server and then deletes it, (2) tries to list using the marker being the server name with --deleted and assert it fails with server not found, and then (3) lists servers with marker being the server.id + --deleted and show it works
16:25:18 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix accumulated non-docs nits for cross-cell-resize series https://review.opendev.org/698935
16:25:18 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add negative test to delete server during cross-cell resize claim https://review.opendev.org/688832
16:25:19 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Implement reschedule logic for cross-cell resize/migrate https://review.opendev.org/696213
16:25:19 openstackgerrit Matt Riedemann proposed openstack/nova master: Plumb graceful_exit through to EventReporter https://review.opendev.org/699237
16:25:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Use graceful_exit=True in ComputeTaskManager.revert_snapshot_based_resize https://review.opendev.org/699238
16:29:13 mriedem #success cross-cell resize/cold migrate is on its way to the gate
16:29:15 openstackstatus mriedem: Added success to Success page (https://wiki.openstack.org/wiki/Successes)
16:29:43 mriedem gibi: stephenfin: efried_pto: dansmith: et al ^ thanks for making it happen
16:34:38 gibi mriedem: wooot!
16:38:59 gibi mriedem: thanks for pushing the feauter forward
17:09:36 gibi_pto mriedem: I hope your ghost will linger around on IRC still in next year. But if not then good luck and hapy hacking!
17:09:55 gibi_pto and thanks for all the fish
17:14:09 mriedem gibi_pto: i'm sure i'll do some haunting, have a good break
17:53:26 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add negative test to delete server during cross-cell resize claim https://review.opendev.org/688832
17:53:27 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Implement reschedule logic for cross-cell resize/migrate https://review.opendev.org/696213
17:53:27 openstackgerrit Matt Riedemann proposed openstack/nova master: FUP for docs nits in cross-cell-resize series https://review.opendev.org/699259
18:48:40 openstackgerrit Merged openstack/nova master: DRY: Build ImageMetaPropsPayload from ImageMetaProps https://review.opendev.org/698803
19:36:13 KeithMnemonic mriedem ok i addressed your comments please let me know what you think https://review.opendev.org/#/c/691045/
19:36:29 KeithMnemonic melwitt: if you care to review as well that would be great
21:18:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Add recreate test for bug 1855927 https://review.opendev.org/699045

Earlier   Later