| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-12-12 | |||
| 21:01:58 | dansmith | efried: if the question is whether they need to be instances or classes, they need to be the former | |
| 21:02:21 | dansmith | the instance is what contains things like nullable=, default=, etc | |
| 21:02:34 | dansmith | and just because those don't have any of those set (currently) doesn't affect what the rest of the code is expecting | |
| 21:02:51 | efried | The question is whether they need to be discrete instances for every field of every object, or whether I could just copy in the instances from the other class. | |
| 21:03:30 | efried | like, could I theoretically do this: | |
| 21:03:30 | efried | f = IntegerField() | |
| 21:03:30 | efried | class MyObj(...): | |
| 21:03:30 | efried | fields = { | |
| 21:03:30 | efried | int1: f, | |
| 21:03:31 | efried | int2: f, | |
| 21:03:31 | efried | } | |
| 21:03:52 | dansmith | oh, well, I'll have to go look, | |
| 21:03:59 | dansmith | but the convention is obviously for each to be new | |
| 21:04:11 | dansmith | I can't remember if we stash any object-specific state in the field | |
| 21:04:19 | efried | Okay. Then prolly leave the code as it is now | |
| 21:05:12 | efried | thanks | |
| 21:06:23 | openstackgerrit | Eric Fried proposed openstack/nova master: DRY: Build ImageMetaPropsPayload from ImageMetaProps https://review.opendev.org/698803 | |
| 21:06:31 | efried | done, and changed the TODO to a NOTE | |
| 21:27:54 | sean-k-mooney | efried: oh i forgot the has. i just ran the test i added | |
| 21:27:58 | sean-k-mooney | *hash | |
| 21:28:16 | efried | sean-k-mooney: yahbut, see my fup | |
| 21:28:41 | efried | was going to say maybe you want to squash; but really they are quite different things, so let's keep them separate. | |
| 21:28:57 | efried | plus I don't want to lose the ability to +2 yours :P | |
| 21:29:22 | sean-k-mooney | yep i did i was wondering about that | |
| 21:29:34 | sean-k-mooney | if we do the follow up then we might as well nuke the object | |
| 21:29:56 | sean-k-mooney | well | |
| 21:31:23 | sean-k-mooney | we could replace the ImageMetaPayload 'properties': fields.ObjectField('ImageMetaPropsPayload') definition | |
| 21:32:02 | sean-k-mooney | with another filed that just reference the other object | |
| 21:32:24 | melwitt | jroll: thanks. I'm trying to figure out what's the correct thing to do in the nova ironic driver if ironic is not filling in a cpu_arch in a node. should we choose a default arch to report for ironic scheduling? if so, how should we choose it? a new config option? those are the kind of questions I'm trying to find answers about | |
| 21:35:06 | sean-k-mooney | efried: ok just read your comments on the patch below. ill create a fup to add the last combination and move the comments to doc strings afat i fix the Sync patch | |
| 21:35:51 | sean-k-mooney | and ya the ddt module is really nice to use. ill try to use it more often when it makes sense | |
| 21:37:13 | efried | sean-k-mooney: ++ | |
| 21:38:18 | efried | sean-k-mooney: Reasons not to nuke the object: it would make version boundaries weird; and I'm not sure what happens with SCHEMA. | |
| 21:38:32 | efried | It may be possible. But I'd leave it up to gibi | |
| 21:39:34 | sean-k-mooney | well with your follow up patch every time we add a filed to the normal nova object the notificaiton object fileds and schema will auto update chaning the hash | |
| 21:40:14 | sean-k-mooney | so if we apply that patch we need to rememebr to bump the notificion object version and document the new filed even though we are not modifying the class | |
| 21:40:33 | efried | ohhh, good point, the version. That needs a -1. | |
| 21:40:57 | sean-k-mooney | that is still less work then today however. ya i can put that in a review comment | |
| 21:41:28 | efried | Yeah, we at least need to make a note in the class with that instruction. | |
| 21:41:41 | efried | the test will fail, but you could get around it by just updating the hash without bumping the version. | |
| 21:41:52 | sean-k-mooney | yep | |
| 21:41:54 | efried | an astute reviewer ought to notice, but... | |
| 21:42:11 | jroll | melwitt: it feels like it should be a required field for an ironic node | |
| 21:42:20 | jroll | there's no way to guess at it | |
| 21:56:24 | sean-k-mooney | jroll: the cpu architecture | |
| 21:57:07 | sean-k-mooney | ya i mean some hyperisors can emulate other archs but that is kind of true for all virt drivers | |
| 22:00:32 | mriedem | ironic != hypervisor | |
| 22:00:54 | sean-k-mooney | also true | |
| 22:01:55 | sean-k-mooney | i was makeing the point that most of the virt driver only support one archtecture at a time so you amost always want to know the cpu architecture if you care about check the image for compatablity | |
| 22:03:30 | sean-k-mooney | there was that project denvor chip that nviad wanted to make but then never closed the license agreement with intel for x86 | |
| 22:04:41 | sean-k-mooney | iwas going to be an arm architecture chip with native traslation of x86 to arm opcode in hardware allowing them to run code comiled for either achtecture | |
| 22:05:21 | sean-k-mooney | im sure that would have been a pain to debug but it would have been cool if it ever worked | |
| 22:11:28 | openstackgerrit | sean mooney proposed openstack/nova master: Sync ImageMetaPropsPayload fields https://review.opendev.org/698613 | |
| 22:15:36 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use COMPUTE_SAME_HOST_COLD_MIGRATE trait during migrate https://review.opendev.org/695220 | |
| 22:23:39 | sean-k-mooney | efried: actully my brain has already switched off today so ill do the FUP tomorrow the other FUP i promised is https://review.opendev.org/#/c/698260/ but there is no really rush with reviewing that | |
| 22:24:01 | efried | ack | |
| 22:24:42 | openstackgerrit | Merged openstack/nova master: trivial: Resolve (most) flake8 3.x issues https://review.opendev.org/695732 | |
| 22:41:53 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add NodeOwnerFilter https://review.opendev.org/697331 | |
| 22:41:53 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Allow overriding self.api in _build_minimal_create_server_request https://review.opendev.org/698813 | |
| 22:51:58 | openstackgerrit | Merged openstack/nova master: Don't hardcode Python versions in test https://review.opendev.org/698732 | |
| 23:39:21 | openstackgerrit | Merged openstack/nova master: Keep pre-commit inline with hacking and fix whitespace https://review.opendev.org/674057 | |
| 23:42:35 | openstackgerrit | Merged openstack/nova stable/queens: Add functional regression test for bug 1849409 https://review.opendev.org/690724 | |
| 23:42:35 | openstack | bug 1849409 in OpenStack Compute (nova) queens "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem) | |
| #openstack-nova - 2019-12-13 | |||
| 00:25:22 | openstackgerrit | Merged openstack/nova stable/queens: Fix listing deleted servers with a marker https://review.opendev.org/690725 | |
| 00:25:28 | openstackgerrit | Merged openstack/nova master: trivial: Remove dead code https://review.opendev.org/698703 | |
| 00:25:35 | openstackgerrit | Merged openstack/nova master: support pci numa affinity policies in flavor and image https://review.opendev.org/674072 | |
| 00:26:44 | openstackgerrit | jichenjc proposed openstack/nova master: libvirt: avoid cpu check at s390x arch https://review.opendev.org/696228 | |
| 00:26:56 | brinzhang | efried: Thanks, I send this to the ML :) | |
| 01:56:34 | melwitt | jroll: thanks, I've started a ML thread to better organize my questions and get people's thoughts in one place http://lists.openstack.org/pipermail/openstack-discuss/2019-December/011558.html cc TheJulia | |
| 02:16:46 | luyao | mriedem, efried : we don't patch anything on Intel OpenStack CI, it should be zuul problem | |
| 03:53:04 | openstackgerrit | Mykola Yakovliev proposed openstack/nova master: Validate aggregate IDs before querying database https://review.opendev.org/698094 | |
| 04:13:45 | openstackgerrit | Merged openstack/nova stable/rocky: Add functional recreate test for bug 1829479 and bug 1817833 https://review.opendev.org/698106 | |
| 04:13:45 | openstack | bug 1829479 in OpenStack Compute (nova) "The allocation table has residual records when instance is evacuated and the source physical node is removed" [Medium,In progress] https://launchpad.net/bugs/1829479 - Assigned to Matt Riedemann (mriedem) | |
| 04:13:46 | openstack | bug 1817833 in OpenStack Compute (nova) "Check compute_id existence when nova-compute reports info to placement" [Medium,In progress] https://launchpad.net/bugs/1817833 - Assigned to Matt Riedemann (mriedem) | |
| 08:30:22 | openstackgerrit | jichenjc proposed openstack/nova master: libvirt: avoid cpu check at s390x arch https://review.opendev.org/696228 | |
| 08:32:08 | openstackgerrit | Merged openstack/nova master: Follow up to I5b9d41ef34385689d8da9b3962a1eac759eddf6a https://review.opendev.org/698028 | |
| 08:56:25 | openstackgerrit | Guo Jingyu proposed openstack/nova master: Define and catch InstanceAgentNotRunning for set-password failure https://review.opendev.org/661466 | |
| 09:42:11 | yoctozepto | morning | |
| 09:42:53 | yoctozepto | I assigned https://bugs.launchpad.net/nova/+bug/1856296 to nova, mostly to let you know, not sure if you can do too much about it, other than letting users know they might be impacted on upgrades | |
| 09:42:53 | openstack | Launchpad bug 1856296 in kolla-ansible "upgrade to Train might fail due to mariadb row format" [Critical,Triaged] | |
| 09:54:11 | openstackgerrit | Guo Jingyu proposed openstack/nova master: Make scheduling more debuggable https://review.opendev.org/698421 | |
| 11:25:30 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Drop tables for removed services, features https://review.opendev.org/698706 | |
| 11:25:31 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: db: Remove placement tables https://review.opendev.org/698707 | |
| 11:25:31 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Remove unused ec2 DB APIs https://review.opendev.org/698880 | |
| 11:25:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: db: Remove unused models https://review.opendev.org/698881 | |
| 11:58:01 | gibi | stephenfin: hi! what do you think about https://review.opendev.org/#/c/696574/10/nova/objects/instance.py@1239 ? shall I move this whole thing back to utils? | |
| 11:59:16 | stephenfin | gibi: I guess if there's nowhere better, you've no choice :) | |
| 11:59:27 | stephenfin | nova/compute/utils.py though, rather than nova/utils.py | |
| 12:07:27 | gibi | stephenfin: ack. moving | |
| 12:42:26 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Revert "(Temporarily) readd bare support for py27" https://review.opendev.org/698890 | |
| 12:42:45 | stephenfin | tosky: we're good to merge that now, right? ^ | |
| 12:43:18 | sean-k-mooney | that drops support again since m1 was yesterday? | |
| 12:43:36 | stephenfin | officially, yeah | |
| 12:43:45 | stephenfin | it prevents you installing nova under python 2.7 | |
| 12:43:51 | stephenfin | pip will spit the dummy out | |
| 12:43:53 | sean-k-mooney | oh i know what the patch does | |
| 12:44:07 | sean-k-mooney | i was just checking m1 was yesterday | |
| 12:44:13 | sean-k-mooney | i was 99% sure it was | |
| 12:44:47 | sean-k-mooney | also that is such an irish saying | |
| 12:49:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Revert "(Temporarily) readd bare support for py27" https://review.opendev.org/698890 | |