Posted	Nick	Remark
#openstack-nova - 2019-12-09
16:27:54	dansmith	yeah
16:28:02	efried	gmann: thoughts?
16:31:50	gmann	yeah, by RFP definition it can be all failure case "The response MAY be used in success, partial success and also in failure situations. " - https://tools.ietf.org/html/rfc4918#section-13
16:32:20	mriedem	how would you return a 400 with a json response body with the individual failure reasons?
16:32:21	gmann	considering that as success code (2xx) is not correct usage. I agree to change 404->207.
16:32:25	mriedem	that's what the 207 is for as dan noted
16:32:31	gmann	yeah
16:32:42	efried	cool
16:32:57	gmann	it need in build response body always
16:42:37	stephenfin	mdbooth: comments on https://review.opendev.org/#/c/631294/ if you're looking for something to do
16:51:57	artom	stephenfin, if you're reviewing stuff - https://review.opendev.org/#/c/672595/ is still a thing. It's become like this poisoned thing that no one want to touch :(
16:52:14	artom	Not sure how I can help get it out of that status
16:53:46	stephenfin	I'll take a look
16:54:15	artom	stephenfin, it's the NUMA func test patch, if you hadn't guessed
16:54:30	stephenfin	I'd guessed :)
16:54:49	Sundar	efried: "care to open that, since you uncovered this?" -- sure, I'll open a bug.
16:56:42	Sundar	Good to see the discussion. Is it the final conclusion that 'No host found for instance' for one instance is a 207, and rest are 404? If we hypothetically have N instances, with 'No host found' for each of them, will it still be 207?
17:02:48	efried	Sundar: the result code will always be either 200 (all ok) or 207 (some/all not ok)
17:02:56	Sundar	Never mind: the description of https://review.opendev.org/#/c/698037/ says it is always 207, and 404 is never returned.
17:03:07	Sundar	efried: Ok
17:15:47	efried	kashyap or sean-k-mooney: would one of you mind giving the SEV fix a quick sanity check please? https://review.opendev.org/#/c/693072/9
17:21:00	kashyap	efried: Hi
17:21:08	efried	o/
17:22:07	kashyap	I'm just about to head out, as I have a table-tennis "competition"; so I'm trying to switch from the sit-like-a-vegetable-in-front-of-the-screen to get-some-oxygen-going mode run :D
17:22:27	efried	The code looks fine to me, but I don't really know what a virtio-serial is, or whether I should have one.
17:23:11	sean-k-mooney	ill take a look at it
17:23:29	efried	kashyap: thanks for responding to my ping. I don't want to send this one over the net and find out later I've dropped the ball.
17:23:31	kashyap	efried: Yes, I just read the commit message, it makes sense
17:23:46	sean-k-mooney	... such a bad joke
17:23:49	sean-k-mooney	i love it :)
17:24:07	Sundar	Bug report for the HTTP 207/404 thingy in server external events: https://bugs.launchpad.net/nova/+bug/1855752
17:24:07	openstack	Launchpad bug 1855752 in OpenStack Compute (nova) "Inappropriate HTTP error status from os-server-external-events" [Undecided,New]
17:24:52	openstackgerrit	Eric Fried proposed openstack/nova master: Nix os-server-external-events 404 condition https://review.opendev.org/698037
17:24:54	kashyap	efried: BTW, 'virtio-serial' is a not-so-stellar-but-works-alright thing that exposes a character dev for simple I/O between host and guest.
17:25:01	openstackgerrit	Merged openstack/nova stable/stein: Do not update root_device_name during guest config https://review.opendev.org/696351
17:25:08	kashyap	efried: Nah, you're being your diligent self
17:25:08	efried	gmann, dansmith, mriedem, Sundar: I think that's ready now --^
17:25:16	efried	kashyap: I was making table tennis jokes
17:25:31	kashyap	efried: I'm being a dense potatoe
17:26:46	kashyap	sean-k-mooney: Ah, I already see you made the correction of generic "virtio controller" --> "virtio serial controller"
17:27:19	sean-k-mooney	yes since there are lots of virt controllers :)
17:28:06	kashyap	s/going/is going/
17:32:22	kashyap	efried: Yes, the reason for the change makse sense to me, FWIW. And I know the "IOMMU" driver being a requirement for SEV. (From its Nova spec)
17:32:59	kashyap	(I'll let sean-k-mooney to take a deeper look, as he also was looking at it before.)
17:33:57	sean-k-mooney	i have reviewd the bottm two patchs almost done with the final one
17:34:53	openstackgerrit	Merged openstack/os-traits master: Add COMPUTE_SAME_HOST_COLD_MIGRATE trait https://review.opendev.org/666604
17:37:27	stephenfin	artom: loads of comments left on that
17:38:34	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize conductor RPC method https://review.opendev.org/637075
17:38:35	openstackgerrit	Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize from the API https://review.opendev.org/637316
17:38:35	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize_at_dest compute method https://review.opendev.org/637630
17:38:36	openstackgerrit	Matt Riedemann proposed openstack/nova master: Deal with cross-cell resize in _remove_deleted_instances_allocations https://review.opendev.org/639453
17:38:36	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add finish_revert_snapshot_based_resize_at_source compute method https://review.opendev.org/637647
17:38:37	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add RevertResizeTask https://review.opendev.org/638046
17:38:37	openstackgerrit	Matt Riedemann proposed openstack/nova master: Flesh out RevertResizeTask.rollback https://review.opendev.org/695334
17:38:38	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method https://review.opendev.org/638047
17:38:38	openstackgerrit	Matt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API https://review.opendev.org/638048
17:38:39	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add functional cross-cell revert test with detached volume https://review.opendev.org/695335
17:38:39	openstackgerrit	Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server https://review.opendev.org/638268
17:38:40	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add archive_deleted_rows wrinkle to cross-cell functional test https://review.opendev.org/651650
17:38:40	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.opendev.org/614353
17:38:41	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add test_resize_cross_cell_weigher_filtered_to_target_cell_by_spec https://review.opendev.org/695336
17:38:41	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add functional test for anti-affinity cross-cell migration https://review.opendev.org/661859
17:38:42	openstackgerrit	Matt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event https://review.opendev.org/658478
17:38:42	openstackgerrit	Matt Riedemann proposed openstack/nova master: libvirt: flatten rbd image during cross-cell move spawn at dest https://review.opendev.org/691991
17:38:43	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269
17:38:49	mriedem	oh gdi that wasn't meant to be a full rebase
17:38:55	mriedem	but now that it is, i might as well do a full rebase on master
17:40:27	sean-k-mooney	efried: +1 on the qemu guest agent series
17:40:55	efried	thanks sean-k-mooney. I'll send it to the gate.
17:41:22	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add ConfirmResizeTask https://review.opendev.org/637070
17:41:23	openstackgerrit	Matt Riedemann proposed openstack/nova master: Follow up to I5b9d41ef34385689d8da9b3962a1eac759eddf6a https://review.opendev.org/698028
17:41:23	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize conductor RPC method https://review.opendev.org/637075
17:41:24	openstackgerrit	Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize from the API https://review.opendev.org/637316
17:41:24	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize_at_dest compute method https://review.opendev.org/637630
17:41:25	openstackgerrit	Matt Riedemann proposed openstack/nova master: Deal with cross-cell resize in _remove_deleted_instances_allocations https://review.opendev.org/639453
17:41:25	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add finish_revert_snapshot_based_resize_at_source compute method https://review.opendev.org/637647
17:41:26	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add RevertResizeTask https://review.opendev.org/638046
17:41:26	openstackgerrit	Matt Riedemann proposed openstack/nova master: Flesh out RevertResizeTask.rollback https://review.opendev.org/695334
17:41:27	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method https://review.opendev.org/638047
17:41:27	openstackgerrit	Matt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API https://review.opendev.org/638048
17:41:28	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add functional cross-cell revert test with detached volume https://review.opendev.org/695335
17:41:28	openstackgerrit	Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server https://review.opendev.org/638268
17:41:29	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add archive_deleted_rows wrinkle to cross-cell functional test https://review.opendev.org/651650
17:41:29	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.opendev.org/614353
17:41:30	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add test_resize_cross_cell_weigher_filtered_to_target_cell_by_spec https://review.opendev.org/695336
17:41:30	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add functional test for anti-affinity cross-cell migration https://review.opendev.org/661859
17:41:31	openstackgerrit	Matt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event https://review.opendev.org/658478
17:46:53	artom	stephenfin, thanks!
17:47:00	openstackgerrit	Vladyslav Drok proposed openstack/nova master: Minor improvements to cell commands https://review.opendev.org/698053
17:52:53	openstackgerrit	Eric Fried proposed openstack/nova master: Nix os-server-external-events 404 condition https://review.opendev.org/698037
17:53:19	efried	gmann, mriedem: done ^
18:05:19	efried	stephenfin: are you working your way up to https://review.opendev.org/#/c/696992/ eventually? (aka: "would you please, and thank you?")
18:09:17	openstackgerrit	sean mooney proposed openstack/nova master: Disable NUMATopologyFilter on rebuild https://review.opendev.org/689861
18:09:34	openstackgerrit	sean mooney proposed openstack/nova master: support pci numa affinity policies in flavor and image https://review.opendev.org/674072
18:10:37	sean-k-mooney	efried: do you have time this week to review https://review.opendev.org/#/c/687957/11 and the two patches that follow. i would like to get those merged before i go on PTO
18:10:53	efried	is that the numa affinity thing?
18:11:30	sean-k-mooney	the frist two are rebuild of numa instance and the last is the numa affinity policy thing
18:12:20	sean-k-mooney	so those 3 patch fix 2 bugs and close two blueprints/specs
18:12:47	openstackgerrit	Merged openstack/nova master: Fup for I63c1109dcdb9132cdbc41010654c5fdb31a4fe31 https://review.opendev.org/697678
18:13:20	sean-k-mooney	efried: also i think you just missed stephenfin. he was just heading home for the day

Earlier   Later