Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-11-26
19:47:33 dansmith right, but bind is the thing that takes a long time,
19:47:41 dansmith so doing that in conductor is what gets us the most gain
19:47:55 dansmith the original email states the reason for moving is because of the eventing being hard, which is is not
19:48:03 mriedem having not really any skin in this game, it doesn't really matter to me anyone re this cyborg series
19:48:13 mriedem i agree the original email is mostly excuses
19:48:25 mriedem minimal change to get a thing to sort of work as a poc
19:48:42 mriedem to which i said essentially, yeah that's why we have a lot of turdy spaghetti code we've wanted to refactor for years
19:48:51 mriedem and why artom calls nova fugly
19:49:19 dansmith yeah, understand.. the reason for moving to compute based on the spec and that original email seemed to be excuses around eventing, which are not valid,
19:49:42 dansmith so I'd prefer we revert back to the original plan which had good reasoning, which is to overlap the programming with all the other things we can do in parallel,
19:49:47 dansmith which means bind at conductor
19:50:09 sean-k-mooney they baically need to do the equvalent of double check locking in the driver. check if its bound start waiting for event, check if its bound again incase you mised it and if so cancel waiting if not wait
19:50:17 mriedem does that include building a new interface into conductor so when the api receives the external event it can route it to conductor rather than compute?
19:50:40 dansmith sean-k-mooney: did you see the explanation I linked above about how to do the check and event without the race?
19:50:47 dansmith sean-k-mooney: they do not need to check twice
19:50:56 dansmith mriedem: no it does not
19:51:16 dansmith read this: https://review.opendev.org/#/c/631244/46/nova/compute/manager.py@2627
19:51:18 sean-k-mooney no but i trust you when you say there is a way to do that
19:51:24 sean-k-mooney but neighter woudl be hard to do
19:51:36 dansmith neighter?
19:51:53 sean-k-mooney neither
19:51:58 dansmith oh
19:52:07 sean-k-mooney ya that was more off then normal
19:52:12 dansmith the double check doesn't actually help, AFAICT, it would have to be N checks i.e. polling
19:52:47 sean-k-mooney well once you have register to wait for the event if you check the status and its not complete you can just wait
19:53:04 dansmith sean-k-mooney: right, that's one check and that's what I mention in the above comment
19:53:19 dansmith it's just that you need a new thing to be able to exit the wait after you have started if you know it is not necessary which is not easy today
19:53:41 dansmith you said "equivalent of double check" so, I see what you mean now
19:53:46 sean-k-mooney ah ok i was suggesting checking that api once ot skip that incase its already done but that is not needed
19:53:51 dansmith yes
19:53:58 dansmith skip is the thing we can't do without the patch I proposed
19:54:34 sean-k-mooney gotch ya
19:56:06 mriedem so tl;dr create and bind the arq in conductor, cast to compute to build, compute grabs the event lock and checks to see if it should wait based on the cyborg api - if so, wait, if not, cancel the wait since the event taint comin
19:56:23 dansmith basically yeah
19:57:40 mriedem i suppose it's out of the question waiting for the cyborg series to be rebased and integrated with said wait-or-cancel function
19:58:05 openstackgerrit Matt Riedemann proposed openstack/nova stable/stein: Replace time.sleep(10) with service forced_down in tests https://review.opendev.org/696175
19:59:06 dansmith mriedem: I've already proposed the patch, efried has already asked you to +W, and yes, the cyborg set will need to use it to get my +2 :)
20:00:55 dansmith mriedem: or did you mean waiting to merge the new skip thing until the cyborg set is using it?
20:02:12 mriedem i was hoping to see the latter before having to dig into the new thing, to show something using it successfully outside of unit tests - but i realize that might be awhile
20:02:46 dansmith mriedem: oh that's fine, I don't care that much, but I think it's probably good to get that just landed ahead of time so the set doesn't get too much bigger..
20:03:00 dansmith I'd also propose we land the test base refactor, once it gets unfscked
20:03:18 mriedem i'm not sure why that test base refactor is even needed
20:03:32 mriedem it's just noise imo
20:03:39 dansmith me either, I haven't gotten that far yet, but someone else had a similar one up too Ithought
20:03:48 dansmith was it mdbooth you said?
20:03:53 mriedem "i like 85% of this base class but don't need the other %15 right now, so rip it all apart!"
20:03:56 mriedem yes
20:04:00 mriedem and i have the same feelings about his
20:04:03 dansmith *shrug* whatever
20:04:31 dansmith I couldn't get past the other issues with the refactor to care about reasoning I guess :P
20:07:44 mriedem there i've -1ed both of them
20:44:40 openstackgerrit Alexandre arents proposed openstack/nova master: Flatten qcow2 images when unshelving an instance https://review.opendev.org/696084
21:12:36 openstackgerrit Merged openstack/nova master: nova-net: Remove 'nova-dhcpbridge' binary https://review.opendev.org/686815
21:14:55 openstackgerrit sean mooney proposed openstack/nova master: block rebuild when numa topology changed https://review.opendev.org/687957
21:14:55 openstackgerrit sean mooney proposed openstack/nova master: Disable NUMATopologyFilter on rebuild https://review.opendev.org/689861
21:18:27 openstackgerrit sean mooney proposed openstack/nova master: block rebuild when numa topology changed https://review.opendev.org/687957
21:18:27 openstackgerrit sean mooney proposed openstack/nova master: Disable NUMATopologyFilter on rebuild https://review.opendev.org/689861
21:19:20 sean-k-mooney artom: bauzas hopefully ye are happy with ^
21:49:35 openstackgerrit sean mooney proposed openstack/nova master: support pci numa affinity policies in flavor and image https://review.opendev.org/674072
22:04:29 artom sean-k-mooney, yarp, I'll look tomorrow
22:05:32 openstackgerrit Matt Riedemann proposed openstack/nova-specs master: Amend cross-cell-resize spec https://review.opendev.org/696197
22:24:27 mriedem dansmith: efried: btw, to whom it may concern, i'm out tomorrow and back monday
22:24:40 efried ack
22:24:40 mriedem assuming i survive snowmaggaedon
22:24:43 dansmith ack, I'm headed out early tomorrow
22:24:48 efried it's 72 here
22:24:53 efried eat your heart out
22:24:57 mriedem i will not
22:25:06 dansmith yeah, I'll keep what I got but thanks
22:25:36 melwitt it's 52F here
22:25:42 mriedem laura isn't traveling with me (she's on call) but she suggested we get me an AWD vehicle today just b/c her weather travel anxiety by proxy is on high alert
22:26:22 melwitt I love AWD
22:27:33 mriedem hers is, so she can make it across town to work
22:27:44 mriedem me, i just know to not jerk and drive (tm)
22:28:05 dansmith mriedem: better 'splain that one for people about to dial 9-1-H-R
22:28:28 mriedem http://nymag.com/intelligencer/2014/12/south-dakota-yanks-dont-jerk-drive-campaign.html
22:28:41 melwitt lol
22:29:04 melwitt aren't they the same ones doing, "Meth. I'm on it"?
22:29:08 mriedem yes
22:29:30 mriedem 2 for 2 on successful ad campaigns
22:29:36 melwitt indeed
22:44:43 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480
22:58:29 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the target in os-services APIs policy https://review.opendev.org/676688
23:12:17 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing admin_actions policies https://review.opendev.org/657698
#openstack-nova - 2019-11-27
00:26:02 openstackgerrit Matt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.opendev.org/643451
00:26:03 openstackgerrit Matt Riedemann proposed openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing https://review.opendev.org/669013
00:26:03 openstackgerrit Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize_at_source compute method https://review.opendev.org/637058
00:26:04 openstackgerrit Matt Riedemann proposed openstack/nova master: Add ConfirmResizeTask https://review.opendev.org/637070
00:26:04 openstackgerrit Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize conductor RPC method https://review.opendev.org/637075
00:26:05 openstackgerrit Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize from the API https://review.opendev.org/637316
00:26:05 openstackgerrit Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize_at_dest compute method https://review.opendev.org/637630
00:26:06 openstackgerrit Matt Riedemann proposed openstack/nova master: Deal with cross-cell resize in _remove_deleted_instances_allocations https://review.opendev.org/639453
00:26:06 openstackgerrit Matt Riedemann proposed openstack/nova master: Add finish_revert_snapshot_based_resize_at_source compute method https://review.opendev.org/637647
00:26:07 openstackgerrit Matt Riedemann proposed openstack/nova master: Add RevertResizeTask https://review.opendev.org/638046
00:26:07 openstackgerrit Matt Riedemann proposed openstack/nova master: Flesh out RevertResizeTask.rollback https://review.opendev.org/695334
00:26:08 openstackgerrit Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize conductor RPC method https://review.opendev.org/638047
00:26:08 openstackgerrit Matt Riedemann proposed openstack/nova master: Revert cross-cell resize from the API https://review.opendev.org/638048
00:26:09 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional cross-cell revert test with detached volume https://review.opendev.org/695335
00:26:09 openstackgerrit Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize while deleting a server https://review.opendev.org/638268
00:26:10 openstackgerrit Matt Riedemann proposed openstack/nova master: Add archive_deleted_rows wrinkle to cross-cell functional test https://review.opendev.org/651650

Earlier   Later