| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-11-25 | |||
| 19:00:41 | gmann | johnthetubaguy: for new policy rule added due to granularity, new name should be fine right? we decided not to change name for any existing policy - https://review.opendev.org/#/c/648480/18/nova/policies/services.py@22 | |
| 19:07:38 | efried | kashyap: Forgive me if you've already had this argument^Wdiscussion with stephenfin, but why are we not squashing at least the three "remove MIN_*" patches into the bump patch? | |
| 19:08:23 | efried | to me, "do X and get rid of dead code that was made obsolete by X" counts as "one logical change". | |
| 19:10:23 | efried | "I did it separately as it cleanly highlights that we consciously picked those versions based on distro research. If we squash it in, the intention just gets buried in this noise." meh meh meh | |
| 19:17:10 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Remove stale BDMs on reserve_block_device_name failure https://review.opendev.org/682594 | |
| 19:50:22 | openstackgerrit | Merged openstack/nova stable/queens: Don't delete compute node, when deleting service other than nova-compute https://review.opendev.org/695383 | |
| 19:50:28 | openstackgerrit | Merged openstack/nova stable/rocky: Add functional regression test for bug 1849409 https://review.opendev.org/690720 | |
| 19:50:28 | openstack | bug 1849409 in OpenStack Compute (nova) rocky "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem) | |
| 20:33:03 | dansmith | artom: when I pay you to just agree with all my review comments, you're supposed to make it look non-obvious | |
| 20:37:41 | artom | dansmith, ok, 0. You don't pay nearly enough. 1. I only agreed on one thing. 2. I disagreed on the big thing. | |
| 20:38:42 | dansmith | artom: each comment was like "I agree with Dan and his bribe money, ...." :P | |
| 20:39:20 | artom | dansmith, either I misunderstood you, or you misunderstood me. | |
| 20:39:42 | artom | I thought you were saying you don't want the workaround conf option approach. I'm saying the "real" fix isn't backportable, so OK. | |
| 20:51:58 | dansmith | artom: no, I know | |
| 20:54:52 | artom | dansmith, but seriously, "subtlety" is only available in the Premium package, you need to upgrade | |
| 20:55:56 | dansmith | I'm calling my credit card company | |
| 20:56:58 | artom | *snerk* | |
| 20:57:07 | artom | "I'd like to charge back these bribes I made" | |
| 20:57:29 | artom | "Turns out corruption isn't the panacea I was hoping for." | |
| 21:00:26 | dansmith | sounds legit to me, I'm sure they've got my back | |
| 21:00:43 | dansmith | just like reporting that your dealer to the cops when he stiffed you on the dime bag | |
| 21:17:25 | artom | Hey man, get with the advanced countries, my dealer's *the government* | |
| 21:22:40 | mriedem | artom: dansmith: i've tl;dr'ed the patch, i need someone to ack on the path forward because i'm getting mixed messages on the nova changes and the os-traits change from efried | |
| 21:22:58 | mriedem | if it's more work than it's worth i'll just abandon all of it and let the bugs continue to get opened | |
| 21:24:00 | efried | what are we talking about? | |
| 21:24:48 | artom | mriedem, I obviously don't have +/-2 powers, but seems like a simple enough patch, so if it fixes some people's issues, don't see why not | |
| 21:25:04 | artom | Sure, it's not the prettiest thing I've ever seen, but... frankly, neither is most of Nova :P | |
| 21:27:12 | mriedem | efried: https://review.opendev.org/#/q/topic:bug/1748697+(status:open+OR+status:merged) | |
| 21:28:17 | mriedem | artom: as for pretty, you try having hundreds (thousands?) of random people put their dirty fingers all over you for 10 years and see how pretty you are | |
| 21:29:04 | artom | mriedem, oh, I fully understand *why* | |
| 21:29:17 | mriedem | (apparently 989 contributors according to github) | |
| 21:30:53 | mriedem | i've long advocated for py black pre-commit hooks but just no one else wants it :) | |
| 21:40:35 | artom | Oh this is weird... | |
| 21:40:48 | artom | I'm triaging a downstream bug related to external events | |
| 21:41:07 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Add functional regression test for bug 1849409 https://review.opendev.org/690724 | |
| 21:41:07 | openstack | bug 1849409 in OpenStack Compute (nova) rocky "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem) | |
| 21:41:07 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Fix listing deleted servers with a marker https://review.opendev.org/690725 | |
| 21:41:25 | artom | 17:34:14.868 No waiting events found dispatching network-vif-plugged-3dccb72d-c922-4032-8f34-d7421fe2cff6 | |
| 21:41:34 | openstackgerrit | Dan Smith proposed openstack/nova master: Add a way to exit early from a wait_for_instance_event() https://review.opendev.org/695985 | |
| 21:41:36 | dansmith | efried: ^ | |
| 21:41:40 | artom | 17:33:48.037 | |
| 21:41:42 | efried | dansmith: ack | |
| 21:41:49 | artom | 17:33:48.037 Preparing to wait for external event network-vif-plugged-3dccb72d-c922-4032-8f34-d7421fe2cff6 | |
| 21:42:10 | artom | So I guess something is consuming those events before? | |
| 21:42:15 | artom | Sorry for rubber-ducking y'all | |
| 21:43:00 | dansmith | artom: mriedem: remember the race-to-wait-for-event stuff with neutron and migration? | |
| 21:43:13 | dansmith | the patch I just pushed up would probably have helped us | |
| 21:43:13 | mriedem | how could i forget | |
| 21:43:15 | artom | dansmith, I do, but this isn't it. It's boot. | |
| 21:43:31 | dansmith | artom: yep, talking about that other thing | |
| 21:43:38 | artom | dansmith, ack, yeah | |
| 21:43:41 | artom | Looking | |
| 21:43:43 | dansmith | lots of event'n going on today | |
| 21:46:07 | dansmith | I don't remember the exact details of the neutron thing, but if we could have checked with one poll to see if a thing was done, we could have used this to safely be graceful about when the events show up and not lose our race-proof-ness | |
| 21:46:56 | dansmith | I think it was coming early for some backends, which is what this is about | |
| 21:47:00 | artom | dansmith, I haven't grokked your patch fully, but I'm not sure about that. We were getting the events *before* we even started waiting for them | |
| 21:47:08 | dansmith | right, that's what this is for | |
| 21:47:35 | dansmith | we're about to have a situation where for cyborg, an event could come before we're ready to wait for it | |
| 21:47:52 | dansmith | and we want to be able to handle that good situation (work is done before we have to stop and wait) without losing our race-proof-ness | |
| 21:51:18 | artom | Oh, that's your second para in the commit message | |
| 21:51:29 | mriedem | artom: we were getting them before we were waiting b/c the compute manager updating the port binding which trigggered the event before the driver's finish_revert_migration or whatever registered the event listener | |
| 21:51:52 | mriedem | so, we do control what was triggering the event | |
| 21:52:20 | artom | mriedem, yep | |
| 21:52:37 | dansmith | mriedem: I thought there was some component of it where we weren't use based on vif type if it came early or late? but maybe I'm remembering one of the reverted attempts? | |
| 21:52:44 | dansmith | s/use/sure/ | |
| 21:52:48 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Add functional regression test for bug 1849409 https://review.opendev.org/690734 | |
| 21:52:48 | openstack | bug 1849409 in OpenStack Compute (nova) rocky "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem) | |
| 21:52:48 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Fix listing deleted servers with a marker https://review.opendev.org/690735 | |
| 21:53:11 | mriedem | we do base it on vif type or something | |
| 21:53:35 | dansmith | ack, well, anyway, if we _can_ get in front of it, that's better obviously | |
| 21:53:46 | mriedem | https://github.com/openstack/nova/blob/ee25a82c2c1c12b0e290ed524e4d66b1a8a7a500/nova/compute/manager.py#L4459 | |
| 21:54:43 | artom | (That apparently broke Midonet, for unclear reasons: https://review.opendev.org/#/c/675021/) | |
| 21:59:58 | mriedem | can i abandon that yet? | |
| 22:00:08 | mriedem | if they don't care enough to pursue since oct 1 it must not be a big deal | |
| 22:02:10 | artom | daycare taxi time | |
| 22:03:30 | mriedem | done | |
| 22:04:10 | mriedem | you should crank up the space truckin' organ solo from made in japan for the kiddies | |
| 22:04:19 | efried | dansmith: Reviewed, thanks for putting that together. | |
| 22:42:54 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Update keypairs in saving an instance object https://review.opendev.org/683043 | |
| 22:47:12 | openstackgerrit | Merged openstack/nova master: Pick NEXT_MIN libvirt/QEMU versions for "V" release https://review.opendev.org/694821 | |
| 23:41:07 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Spec: Ussuri: Encrypted Emulated Virtual TPM https://review.opendev.org/686804 | |
| 23:42:02 | efried | dansmith: Simplified this ^ by restricting backup of vTPM data to only shelve and backup. Reasoning and effects are explained in the spec. It actually simplifies things considerably. I think with proper documentation, this is the happy middle ground. | |
| #openstack-nova - 2019-11-26 | |||
| 00:23:50 | openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: doc: Update Testing document https://review.opendev.org/695995 | |
| 00:59:42 | openstackgerrit | Guo Jingyu proposed openstack/nova-specs master: Proposal for a safer noVNC console with password authentication https://review.opendev.org/623120 | |
| 01:14:05 | openstackgerrit | Merged openstack/nova master: Do not update root_device_name during guest config https://review.opendev.org/670000 | |
| 01:27:38 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480 | |
| 01:34:49 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default rules and mapping in policy base class https://review.opendev.org/645452 | |
| 01:35:30 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Suppress policy deprecated warnings in tests https://review.opendev.org/676670 | |
| 01:36:40 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Suppress policy deprecated warnings in tests https://review.opendev.org/676670 | |
| 01:37:02 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480 | |
| 02:18:57 | openstackgerrit | Huachang Wang proposed openstack/nova master: Refactor the code path of creating instance with a NUMA topology https://review.opendev.org/688932 | |
| 02:18:58 | openstackgerrit | Huachang Wang proposed openstack/nova master: Assign instance dedicated CPU set through `cpu_pinning` field https://review.opendev.org/688933 | |
| 02:18:58 | openstackgerrit | Huachang Wang proposed openstack/nova master: Introduce a new instance CPU allocation policy: mixed https://review.opendev.org/688934 | |
| 02:18:59 | openstackgerrit | Huachang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936 | |
| 02:18:59 | openstackgerrit | Huachang Wang proposed openstack/nova master: More tests for validating CPU policy by 'resources:PCPU' and 'resources:VCPU' https://review.opendev.org/696007 | |
| 02:19:00 | openstackgerrit | Huachang Wang proposed openstack/nova master: support unbalanced dedicatd CPU distribution on instance NUMA nodes https://review.opendev.org/696008 | |
| 02:19:00 | openstackgerrit | Huachang Wang proposed openstack/nova master: Create 'mixed' instance from PCPU and VCPU resources https://review.opendev.org/696009 | |
| 02:38:48 | openstackgerrit | Eric Xie proposed openstack/nova master: Fix incorrect command examples https://review.opendev.org/695832 | |
| 04:39:56 | openstackgerrit | Merged openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591 | |
| 04:40:03 | openstackgerrit | Merged openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.opendev.org/642592 | |