| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-11-22 | |||
| 15:12:12 | mriedem | mlycka: if anything i think it would be a task_state as part of an overall snapshot "status" | |
| 15:12:31 | mriedem | so if we had a SNAPSHOTTING status in the API, the task_state would be "quiescing" | |
| 15:12:51 | mriedem | note that image-backed snapshot has 4 separate task_states | |
| 15:15:50 | mlycka | mriedem: I'm sort of coming from an angle here and I'm still finding my feet with the nova state machine, so bear with me here: I'm looking at introducing the (un)quiesce operations into nova API for use by other entities (Cinder in my case). Would that not point to a quiesce state outside of the existing snapshot process? | |
| 15:17:08 | mriedem | quiesce isn't a terminal state of a server though | |
| 15:17:27 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support service_host filtering for os-hypervisor API https://review.opendev.org/695708 | |
| 15:17:39 | mriedem | so you want to do something initiated in cinder and if the volume is attached to a server you want to call nova's rest api and tell nova to quiesce the instance, right? | |
| 15:17:40 | stephenfin | mriedem: in a meeting but I'll rebase that soon as I'm done, yup | |
| 15:17:41 | stephenfin | and thanks | |
| 15:17:55 | mlycka | mriedem: Correct. | |
| 15:18:11 | mriedem | mlycka: ok i think the api for that would be the os-server-external-events api https://docs.openstack.org/api-ref/compute/#create-external-events-os-server-external-events | |
| 15:18:29 | mriedem | which cinder already uses when extending the size of a volume attached to a server | |
| 15:19:03 | mriedem | it's still a compute api microversion change to change the schema of that api, but all of the plumbing already exists in the api layer, you just would need to implement the calls when the event is 'quiesce' or whatever | |
| 15:19:37 | mlycka | Goodness me, I didn't even realize this existed | |
| 15:19:58 | mriedem | i'm assuming you've seen the old huawei spec that was trying to expose quiesce/unquiesce out of the API for normal users? | |
| 15:20:03 | mriedem | because that didn't get traction | |
| 15:20:22 | mlycka | Yep, tried asking around earlier precisely for that reason but didn't get a respond | |
| 15:20:28 | mriedem | working it into os-server-external-events as part of a larger orchestrated operation initiated in cinder is probably the way to go | |
| 15:20:29 | mlycka | *response | |
| 15:20:49 | mriedem | so just model it on the volume-extended event | |
| 15:21:03 | mlycka | Well thank you kindly, I'll look into it | |
| 15:21:25 | mriedem | mlycka: it will require a spec https://specs.openstack.org/openstack/nova-specs/readme.html | |
| 15:21:32 | mlycka | I was just going to say | |
| 15:21:35 | mriedem | so before implementing a ton of code and then saying "here it is!" | |
| 15:21:46 | mriedem | i'd say get started on the spec to get initial feedback on the problem statement and the proposed change | |
| 15:22:16 | mlycka | Right, I just need(ed) to get a feel for the way it currently operates and why it hit a brick wall previously. | |
| 15:22:58 | mriedem | i can't remember all the details about that spec but i think they also wanted it to take a list of servers or something | |
| 15:23:06 | mriedem | anyway, what i've said above is likely much more doable | |
| 15:23:44 | mlycka | Yeah, I think that spec was more about snapshotting/quiescing multi-vm setups in a predictable order. | |
| 15:24:10 | mlycka | Yep, gotcha'. I'll poke around the code for a bit and come up with a spec. Thanks. | |
| 15:24:21 | mriedem | np | |
| 15:27:04 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support service_host filtering for os-hypervisor API https://review.opendev.org/695708 | |
| 15:27:21 | mriedem | stephenfin: what is neutron-network? https://review.opendev.org/#/c/686812/7/releasenotes/notes/remove-nova-network-c02953ba72a1795d.yaml is that something you're cooking up for nova v4? | |
| 15:28:03 | stephenfin | damn it | |
| 15:28:11 | stephenfin | I'll draft a follow-up once I'm done here | |
| 15:32:02 | ayoung | once we merge Nova Network, we should merge Authentication in to Nova and decommision Keystone | |
| 15:37:09 | mriedem | stephenfin: while you're collecting FUPs https://review.opendev.org/#/c/686810/7/api-ref/source/os-tenant-network.inc@2 | |
| 15:40:13 | mriedem | stephenfin: gibi: bauzas: dug a bit too deep here it looks like https://review.opendev.org/#/c/686810/7 | |
| 15:40:42 | bauzas | dang | |
| 15:40:49 | bauzas | we broke the world again. | |
| 15:41:04 | gibi | ack | |
| 15:41:26 | bauzas | who pushes it out of the gate ? | |
| 15:41:32 | bauzas | stephenfin: ^ | |
| 15:41:51 | stephenfin | we broke something? | |
| 15:41:54 | stephenfin | huh? | |
| 15:42:06 | bauzas | stephenfin: not yet (c) | |
| 15:42:23 | bauzas | but mriedem provided (again) a good comment | |
| 15:42:29 | bauzas | and we don't want the change to merge now | |
| 15:42:33 | bauzas | https://review.opendev.org/#/c/686810/7 | |
| 15:43:06 | mriedem | the GETs were not removed | |
| 15:43:12 | stephenfin | ah, I see now | |
| 15:43:15 | mriedem | but you removed them in docs, policy and tests | |
| 15:44:27 | stephenfin | Go me \o/ | |
| 15:47:55 | mriedem | if you're going to rebase, might as well fix that release note later in the series, | |
| 15:48:00 | mriedem | and also a question here https://review.opendev.org/#/c/686813/8/nova/cmd/manage.py@a2673 | |
| 15:49:30 | melwitt | why do we want to keep the GETs? | |
| 15:49:37 | mriedem | they are proxies for neutron and work | |
| 15:49:45 | mriedem | i mean, they'll work once nova-network is gone | |
| 15:50:06 | melwitt | oh ok. I thought we didn't want to keep proxies | |
| 15:50:25 | mriedem | the GETs are capped at 2.35 | |
| 15:50:55 | mriedem | iow, proxies have already been deprecated for a long time | |
| 15:50:59 | mriedem | newton i think | |
| 15:52:13 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove '/os-tenant-networks' REST API https://review.opendev.org/686810 | |
| 15:52:20 | mriedem | pulled from the gate ^ | |
| 15:52:37 | melwitt | oh right... but that wouldn't mean that all get/post/put stay and return http gone? I guess I never knew the detail behind how that was implemented | |
| 15:53:43 | stephenfin | okay, think I know why I removed that - there's no functional test for it | |
| 15:54:03 | stephenfin | so it didn't exist as far as I, in functional test fixup mode, was concerned | |
| 15:54:27 | mriedem | melwitt: can you rephrase? | |
| 15:54:47 | mriedem | if a thing works after nova-net is gone but was just deprecated b/c it's a proxy, no we won't remove it, because it still works | |
| 15:55:03 | mriedem | we're not removing our glance or volume proxies here either | |
| 15:55:16 | melwitt | sorry, like in the 2.35 deprecation, were all apis except GET removed? or did all apis stay and change to return http gone, in version 2.35 | |
| 15:55:29 | mriedem | they return 404 | |
| 15:55:39 | mriedem | deprecation = 404 for us, gone = 410 | |
| 15:55:51 | melwitt | and GET does not return 404? | |
| 15:55:51 | mriedem | but you can still hit the proxies at 2.1 | |
| 15:56:24 | mriedem | not below the deprecation microversion it shouldn't - not b/c of deprecation i mean; sure you could get 404 for trying to show details on a neutron network that doesn't exist | |
| 15:56:44 | melwitt | just trying to parse why removing POST is ok but not GET | |
| 15:56:52 | melwitt | should they all stay? | |
| 15:57:12 | melwitt | *shouldn't | |
| 15:57:32 | mriedem | POST is only implemented for nova-net | |
| 15:57:36 | mriedem | nova-net is going to be gone | |
| 15:57:38 | melwitt | ohhhh | |
| 15:57:38 | mriedem | so it's a 410 | |
| 15:57:49 | mriedem | if an API is only implemented for nova-net, it will be 410 | |
| 15:57:50 | melwitt | yeah, ok. I see | |
| 15:58:28 | melwitt | it all makes now | |
| 15:58:38 | melwitt | make sense now, aaarrrggghh | |
| 15:58:49 | stephenfin | mriedem: question on https://review.opendev.org/#/c/686810/7/api-ref/source/os-tenant-network.inc@2 | |
| 15:59:07 | stephenfin | does that actually make sense, since some of the APIs have been removed but others have not | |
| 15:59:07 | stephenfin | ? | |
| 16:05:54 | openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Filter hypervisors by service host https://review.opendev.org/695716 | |
| 16:07:43 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove '/os-tenant-networks' REST API https://review.opendev.org/686810 | |
| 16:07:43 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove 'USE_NEUTRON' from functional tests https://review.opendev.org/686811 | |
| 16:07:44 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove 'networks' quota https://review.opendev.org/686812 | |
| 16:07:45 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove nova-manage network, floating commands https://review.opendev.org/686813 | |
| 16:07:45 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove associate, disassociate network APIs https://review.opendev.org/686814 | |
| 16:07:46 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove 'nova-dhcpbridge' binary https://review.opendev.org/686815 | |
| 16:07:46 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove 'nova-network' binary https://review.opendev.org/686816 | |
| 16:07:47 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Blast most references to nova-network https://review.opendev.org/686817 | |
| 16:07:47 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP https://review.opendev.org/686818 | |