| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-11-21 | |||
| 18:33:19 | sean-k-mooney | https://github.com/openstack/cyborg/blob/369abe8dd06aa6648298c3256f444a63ee6268d0/cyborg/agent/manager.py#L40 | |
| 18:33:27 | sean-k-mooney | so it can be set in the config too | |
| 18:35:48 | sean-k-mooney | so yes cyborg would also have to have that set to have the same value set | |
| 18:35:50 | sean-k-mooney | https://github.com/openstack/cyborg/blob/369abe8dd06aa6648298c3256f444a63ee6268d0/cyborg/conf/default.py#L38-L45 | |
| 18:36:03 | sean-k-mooney | they default to socket.getfqdn() | |
| 18:36:55 | sean-k-mooney | nova defualt to socket.getHostname() https://github.com/openstack/nova/blob/1cd5563f2dd2b218db2422397c8aab394d484626/nova/conf/netconf.py#L55-L59 | |
| 18:37:33 | sean-k-mooney | and neutron has there own function | |
| 18:37:34 | sean-k-mooney | https://github.com/openstack/neutron/blob/f8b990736ba91af098e467608c6dfa0b801ec19c/neutron/conf/common.py#L94-L99 | |
| 18:38:31 | sean-k-mooney | which just calls socket.gethostname() | |
| 18:38:33 | sean-k-mooney | https://github.com/openstack/neutron-lib/blob/master/neutron_lib/utils/net.py#L23-L28 | |
| 18:39:01 | sean-k-mooney | so at least nova and neutron agree on the default cyborg could get a differnt value | |
| 18:40:55 | sean-k-mooney | efried: i dont think we can change anything on the nova side so i might have to file a triplo bug | |
| 18:41:41 | sean-k-mooney | although this could be related to this specific deploment | |
| 19:20:37 | mriedem | test_encrypted_cinder_volumes_luks might be failing all the time on multinode jobs too if the volume and server are on different hosts, i wonder if that's causing that to fail | |
| 19:22:32 | mriedem | nvm i guess that's not the case in the failure i'm looking at | |
| 19:45:56 | lyarwood | mriedem: link? I'm about for 15 and can take a look. | |
| 19:50:24 | mriedem | i closed it but it's a bug we've already talked about before https://bugs.launchpad.net/os-brick/+bug/1820007 | |
| 19:50:24 | openstack | Launchpad bug 1820007 in os-brick "Failed to attach encrypted volumes after detach: volume device not found at /dev/disk/by-id" [Undecided,Confirmed] | |
| 19:54:03 | lyarwood | mriedem: ah right, that weirdness | |
| 20:05:34 | lyarwood | mriedem: https://review.opendev.org/695564 - I'll follow up in the morning with this. | |
| 20:10:51 | mriedem | word | |
| 20:29:54 | melwitt | mriedem: I left comments on the --instance and --dry-run backports for the docs | |
| 20:39:15 | mriedem | melwitt: yeah good catch, i left some thoughts/options in https://review.opendev.org/#/c/693199/1/doc/source/cli/nova-manage.rst@358 | |
| 20:39:33 | dansmith | mriedem: speaking of getting off your lawn, | |
| 20:39:54 | dansmith | does it not seem hilarious that we had "% locals()" all over the code, removed it all, and then python baked it into the language? | |
| 20:40:08 | mriedem | i was reading that article ttx linked and thought that exact same thing | |
| 20:40:14 | mriedem | "oh fun this is just using locals" | |
| 20:40:18 | dansmith | right | |
| 20:40:20 | mriedem | not breakable at all! | |
| 20:40:28 | dansmith | so a new incompatible syntax for ... something you can already do but shouldn't | |
| 20:40:29 | dansmith | hah right | |
| 20:40:31 | mriedem | i also didn't know that % pre-dated format() | |
| 20:40:34 | mriedem | i prefer % | |
| 20:40:51 | dansmith | me too, because I'm old school | |
| 20:41:07 | dansmith | I've been doing python since before .format and since before you saw the non-java light, whippersnapper | |
| 20:41:44 | mriedem | hey, now we're both losers because there is go: java for python people | |
| 20:41:55 | dansmith | heh | |
| 20:41:56 | dansmith | indeed | |
| 20:41:59 | mriedem | umm, + pointers | |
| 20:44:05 | mriedem | f strings also looks like you can run functions from within strings, which .... | |
| 20:44:08 | mriedem | seems like erlang? | |
| 20:44:27 | dansmith | you can definitely hit dictionaries, which seems borderline evil | |
| 20:44:34 | dansmith | running functions and you're nearly bash | |
| 20:45:19 | dansmith | I also don't like the single-char prefix to a quoted string syntax python seems to love | |
| 20:45:29 | dansmith | u"foo", r"bar", etc | |
| 20:46:01 | dansmith | and all these new kids with their hoverboards and roller skates...*fist* | |
| 20:46:51 | melwitt | mriedem: replied. no strong opinion here | |
| 20:47:02 | melwitt | I'm cool with whatever you think is best | |
| 20:47:03 | mriedem | melwitt: but what's your take on f-strings?! | |
| 20:47:08 | melwitt | lol | |
| 20:47:14 | mriedem | f'em right?! | |
| 20:47:23 | melwitt | I didn't know what f-strings is yet so I'm way ahead of the game | |
| 20:47:36 | mriedem | i learned <1 hour ago | |
| 20:47:40 | melwitt | I read a few of the posts and had no idea what was going on | |
| 20:47:56 | melwitt | and of course, I didn't read the first one, cause BORING | |
| 20:48:04 | melwitt | jk | |
| 20:48:42 | melwitt | I mean, I really didn't read it but not because it was boring. once I saw replies piling up I read a few | |
| 20:52:41 | artom | Hates, even | |
| 20:54:42 | melwitt | I think we all do. I've been thinking about how nice it would be to refactor those things in a non-boil the ocean way. somehow. | |
| 20:54:57 | dansmith | I don't | |
| 20:54:59 | dansmith | I love it | |
| 20:55:00 | dansmith | LOVE | |
| 20:55:07 | melwitt | :) | |
| 20:56:32 | artom | Microversion 2.whatever "support for resize, cold migration, and rebuild is dropped" | |
| 20:56:39 | artom | Rewrite everything from scratch | |
| 20:56:57 | artom | Microversion 2.whatever+1 "Nova now supports resize, cold migration, and rebuild" | |
| 20:57:15 | melwitt | lol, nah just leave em out | |
| 20:57:28 | artom | Hah, yeah, just conveniently forget step 3 | |
| 20:57:35 | artom | Or step 2, even | |
| 20:58:09 | mriedem | artom: how are rebuild and resize/cold migrate intertwined? | |
| 20:58:14 | efried | Nova meeting in 2 minutes in #openstack-meeting | |
| 20:58:24 | artom | mriedem, through sheer willpower and anger | |
| 20:58:25 | efried | mriedem: they're not, rebuild and evacuate are the same thing though. | |
| 20:58:37 | mriedem | don't make me link the doc i wrote again | |
| 20:58:41 | artom | OK, resize and cold migrate then | |
| 20:58:45 | artom | Mea culpa | |
| 20:59:14 | mriedem | ok so write a resize vs cold migrate doc like this https://docs.openstack.org/nova/latest/contributor/evacuate-vs-rebuild.html | |
| 20:59:15 | mriedem | easy | |
| 20:59:24 | mriedem | 1. resize has a new flavor, cold migrate doesn't, | |
| 20:59:31 | gregwork | does nova in queens understand how to boot instances on a particular host aggregate? ive tried tagging the host aggregate "compute = 1" and then passing scheduler_hints: compute: 1 when deploying a stack with OS::Nova::Server .. however that doesnt appear to do anything and the instances ends up on whatever compute node | |
| 20:59:36 | mriedem | 2. resize can sometimes go on the same host, cold migrate does not except if you're using vcenter | |
| 21:00:05 | mriedem | artom: what other differences are there besides those 2 things? | |
| 21:00:16 | melwitt | gregwork: has to be availability zone. host agg is a admin only hidden thing | |
| 21:00:36 | artom | mriedem, I think that's about it? | |
| 21:00:47 | artom | And resize to same host is user-configurable | |
| 21:00:52 | gregwork | melwitt: oh .. so even if the admin has defined the host agg, regular users cant reference it ? | |
| 21:00:53 | mriedem | JESUS THEY ARE SO INTERTWINED!!! | |
| 21:00:54 | artom | Cold migrate is... always to a new host? | |
| 21:01:02 | mriedem | artom: you mean operator configurable... | |
| 21:01:03 | artom | mriedem, just... let me be angry | |
| 21:01:07 | artom | mriedem, sorry, yeah | |
| 21:01:19 | artom | I meant in the code, anyways | |
| 21:01:22 | mriedem | artom: remember https://review.opendev.org/#/c/676022/ | |
| 21:01:26 | melwitt | gregwork: they can but only by way of a AZ. you have to make one and map it to the aggregate(s) you want (as admin) | |
| 21:01:36 | artom | Like, you hit a method called "_cold_migrate" in the resize flow | |
| 21:01:52 | artom | mriedem, I do | |
| 21:01:52 | mriedem | yeah, so docstrings ftw | |
| 21:02:05 | mriedem | -1 people that don't write code comments | |
| 21:02:13 | gregwork | melwit: from reading up on AZ's in openstack, these seem like a very heavy abstraction compared to a simple host aggregate to configure | |
| 21:02:19 | mriedem | be the change you want to see in the world... | |