Earlier  
Posted Nick Remark
#openstack-nova - 2019-11-19
23:27:07 gmann efried: is it, this should make use_python3=True on old node
23:27:40 gmann i did in all other patches also - https://review.opendev.org/#/q/topic:drop-py27-support-devstack-default-py3+(status:open+OR+status:merged)
23:27:49 gmann and grenade-py3 job is doing that only.
23:33:56 gmann for example, watcher patch is working fine - https://review.opendev.org/#/c/695097/1
23:36:03 gmann from log it seems like DEVSTACK_GATE_USE_PYTHON3 is not set on d-g side
23:50:24 efried gmann: sorry, I didn't mean to bail on you there, I was trying to get to zuul.o.o/jobs and it crashed my machine. This has been happening for a while, I should learn.
23:50:47 efried Anyway, now I *do* need to bail. I'll try to catch up with you tomorrow about the grenade business.
23:51:14 gmann efried: sure.
#openstack-nova - 2019-11-20
00:38:12 openstackgerrit sean mooney proposed openstack/nova master: add [libvirt]/max_queues config option https://review.opendev.org/695118
01:35:18 mriedem melwitt: you're going to have to ping me earlier tomorrow about that tempest patch, it's too late for me to dig into that right now
01:35:24 mriedem but i'll star it
01:36:03 melwitt mriedem: ok, np. it's not urgent but something I thought you might have thoughts on. thanks
01:40:46 mriedem also,
01:41:00 mriedem your downstream ci people know they can just write tempest plugins for the tests they want to use right?
01:41:04 mriedem it doesn't need to be in the main repo
01:41:32 mriedem so i don't think it's a great pattern to set with like, "we'd like to test x which is 99% already covered elsewhere"
01:43:19 mriedem anyway, i've got to drop but i left that comment on there
01:43:19 melwitt I didn't know how tempest plugins work
01:43:26 mriedem cinder has one, check it out
01:43:36 mriedem like devstack plugins
01:43:41 mriedem https://github.com/openstack/cinder-tempest-plugin
01:43:59 mriedem anyway, o/
01:44:01 melwitt ok
02:22:22 mnaser sean-k-mooney: something in your domain -- i was wondering if libvirt by default makes sure that vcpus for domains live inside the same numa node
02:22:50 mnaser i'm playing with new epyc rome hardware and seeing poor memory access times with sysbench, im wondering if the reasoning behind it is that cpu time is flopping back and forth between numa nodes
02:38:56 alex_xu melwitt: hellow, are you still here
02:39:12 alex_xu s/hellow/hello/
02:55:30 HagunKim Hi, How can I see Nova version like 19.0.3, 20.0.1 on my nova-compute host?
03:58:29 openstackgerrit Merged openstack/nova master: Remove functional test specific nova code https://review.opendev.org/683609
04:58:14 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Add composable flavor properties https://review.opendev.org/663563
06:13:13 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.opendev.org/694717
07:57:51 gibi HagunKim: $ nova-compute --version
07:57:51 gibi 20.1.0
07:58:48 HagunKim gibi: Thanks!
08:28:17 bauzas good morning Nova
08:31:17 gibi bauzas: good morning
08:31:46 bauzas gibi: just doing a few stuff now, but if you're OK, I'd like to discuss on the audit command in 30 mins
08:31:49 bauzas fine with you ?
08:31:58 gibi bauzas: sure, ping me
08:32:35 bauzas tl;dr: when calling --delete, you haven't use the --verbose also, so I don't see if we tried to delete the allocation
08:32:38 bauzas gibi: ^
08:33:05 gibi bauzas: I can quickly try --verbose + --delete
08:33:20 bauzas gibi: would be nice, thanks
08:33:45 gibi bauzas: http://paste.openstack.org/show/786387/
08:34:12 gibi the output of the --verbose --delete seems like to be the same as the output of only --verbose
08:34:50 bauzas gibi: weirod
08:34:54 gibi yepp
08:35:12 gibi yesterday I had to leave but I can try to attach a debugger now
08:35:20 bauzas looks like the conditional doesn't work
08:35:38 bauzas I mean in https://review.opendev.org/#/c/670112/10/nova/cmd/manage.py@2806
08:37:55 gibi bauzas: debugger helped it is the args definition that is buggy https://review.opendev.org/#/c/670112/10/nova/cmd/manage.py@2887
08:38:33 bauzas argh
08:38:38 gibi I guess you are missing some test coverage for --delete :)
08:38:42 bauzas but I'm testing it
08:39:12 bauzas gibi: https://review.opendev.org/#/c/670112/10/nova/tests/functional/test_nova_manage.py@1417
08:39:14 gibi bauzas: you are calling audit() directly from the test so skipping the arg parser
08:39:14 bauzas OH !
08:39:19 bauzas yeah this
08:39:28 bauzas how could I test it then ?
08:41:12 gibi bauzas: good question. I just quickly checked and the heal_allocation tests do not cover args parsing either
08:41:18 bauzas yeah
08:44:07 gibi I would not worry about it then in the functional env
08:44:18 gibi it seems we don't have the facility there
08:45:48 gibi there are some nova-manage tests in https://github.com/openstack/nova/blob/master/gate/post_test_hook.sh there we can cover the args parsing too
08:46:24 openstackgerrit Sylvain Bauza proposed openstack/nova stable/train: Don't delete compute node, when deleting service other than nova-compute https://review.opendev.org/695145
08:46:45 gibi I guess this can be replaced with your audit call https://github.com/openstack/nova/blob/master/gate/post_test_hook.sh#L81
08:50:22 openstackgerrit Balazs Gibizer proposed openstack/nova stable/pike: Only nil az during shelve offload https://review.opendev.org/693839
09:17:55 stephenfin gibi, bauzas: If either of you have bandwidth available this week, I'd appreciate some reviews on the removal of nova-network series https://review.opendev.org/#/q/topic:bp/remove-nova-network-ussuri+status:open
09:19:36 gibi stephenfin: added to my list, but no hard promises
09:19:43 stephenfin ack
09:21:52 bauzas stephenfin: sure, I want to dig into reviews this week
09:46:43 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Rewrite quotas documentation https://review.opendev.org/667165
10:03:54 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Ussuri" https://review.opendev.org/695056
10:28:36 openstackgerrit Liang Fang proposed openstack/nova-specs master: Support volume local cache https://review.opendev.org/689070
10:39:59 openstackgerrit Merged openstack/nova master: Don't delete compute node, when deleting service other than nova-compute https://review.opendev.org/694756
11:41:57 openstackgerrit Sylvain Bauza proposed openstack/nova master: Add a placement audit command https://review.opendev.org/670112
11:41:58 openstackgerrit Sylvain Bauza proposed openstack/nova master: Avoid PlacementFixture silently swallowing kwargs https://review.opendev.org/695180
11:52:06 gibi stephenfin: I think your patch https://review.opendev.org/#/c/694330/ in devstack-plugin-ceph the causing nova-live-migration job to fail on stable/pike. Opened a bug here https://bugs.launchpad.net/nova/+bug/1853280
11:52:06 openstack Launchpad bug 1853280 in OpenStack Compute (nova) pike "nova-live-migration job constantly fails on stable/pike" [Undecided,New]
11:52:45 gibi lyarwood: ^^ for the yesterday stable/pike issue
12:10:53 artom stephenfin, heya, could I get you to take another look at https://review.opendev.org/#/c/672595/60?
12:11:11 artom sean-k-mooney, same question for https://review.opendev.org/#/c/691062/ :)
12:17:39 sean-k-mooney artom: sure did you fix up the other pathce below if so ill start form the bottom and work up
12:21:13 artom sean-k-mooney, yeah, the series is ready to go - Joe even merged some of the bottom ones
12:22:19 sean-k-mooney i have not written them yet so how can i be angrey :)
12:23:53 artom Ah, the anger comes later, I see
12:24:51 sean-k-mooney ohly after fighting with mocking for about an hour. although what you want me to test should be strait forward so you will likely get a pass
12:25:51 artom Yep, I know how "unit testing" some of those "functions" can be
12:26:00 artom But you made such a nice clean new one... :)
12:30:39 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: Pick NEXT_MIN libvirt/QEMU versions for "V" release https://review.opendev.org/694821
12:30:39 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Ussuri" https://review.opendev.org/695056
12:57:43 kashyap stephenfin: Heya, one reason why I also separate out the NEXT_MIN is that it lets us settle on something while we chip away at bump + resulting clean-up
13:03:07 stephenfin kashyap: The clean up is all optional though, right?
13:03:14 stephenfin I mean, it's just dead code
13:03:32 kashyap stephenfin: I mean the immediate clean-up to make the bump work; not the "full clean-up of removing dead constants"
13:03:49 stephenfin ah, I figured it would just be test removal
13:04:16 stephenfin gibi: I assume the plugin isn't versioned?
13:04:27 kashyap :-) Hehe, you've also done part of this clean-up before, maybe you forgot briefly
13:04:41 gibi stephenfin: I think it is not branched
13:04:53 stephenfin kashyap: yup, but they could all be done after the fact

Earlier   Later