| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-11-19 | |||
| 09:00:27 | brinzhang_ | bauzas: https://review.opendev.org/#/c/663563/ | |
| 09:01:06 | bauzas | brinzhang_: thanks | |
| 11:16:10 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Make '_wait_for_state_change' behave consistently https://review.opendev.org/689180 | |
| 11:16:11 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Unify '_wait_until_deleted' implementations https://review.opendev.org/689181 | |
| 11:16:11 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Make 'ServerTestBase' subclass 'InstanceHelperMixin' https://review.opendev.org/689182 | |
| 11:22:42 | gibi | sean-k-mooney, bauzas, brinzhang_, dansmith, efried_pto: I left comments in the flavor explosion spec https://review.opendev.org/#/c/663563/ . I tried to summarize Dan's and Eric's problems behind the -2s and my answers to those the problems. Let's see if this helps or not. | |
| 11:27:18 | gibi | stable-cores: it seems that nova-live-migration job is sad on stable/pike I repeatedly get error like https://zuul.opendev.org/t/openstack/build/0a199eeccc334b98a2eaf67998eef8b5/log/job-output.txt#5821 | |
| 11:29:31 | lyarwood | W: The repository 'http://mirror.dfw.rax.opendev.org/ubuntu-cloud-archive xenial-updates/ocata Release' is not signed. | |
| 11:29:47 | lyarwood | eh, why are we using that on stable/pike? | |
| 11:30:17 | gibi | lyarwood: that is a good question | |
| 11:31:40 | lyarwood | I forget where that's all defined tbh | |
| 11:35:57 | gibi | it seems that job uses the legacy-ubuntu-xenial-2-node nodeset | |
| 11:36:18 | gibi | that explains xenial-updates to me | |
| 11:37:41 | gibi | https://github.com/openstack/nova/blob/9f2d653b4050dbff859c656144c1564ea7c6fa60/.zuul.yaml#L66 | |
| 11:37:47 | gibi | https://github.com/openstack/nova/blob/9f2d653b4050dbff859c656144c1564ea7c6fa60/.zuul.yaml#L27 | |
| 13:00:35 | openstackgerrit | Lee Yarwood proposed openstack/nova-specs master: Boot from volume instance rescue https://review.opendev.org/694063 | |
| 13:32:30 | lyarwood | mdbooth: https://review.opendev.org/#/c/693537/ - apologies, thought I had added you to this a while ago, would you mind taking a look later today? Not a complete fix but it should avoid issues in some situations. | |
| 13:39:42 | corvus | efried, stephenfin: can you take a look at https://review.opendev.org/694891 asap please? | |
| 13:40:15 | efried | corvus: saw that go by. So you're saying "devstack isn't ready for you yet"? | |
| 13:41:26 | corvus | efried: yeah. if someone downloads devstack and runs stack.sh, it'll break. | |
| 13:41:27 | sean-k-mooney | there is a patch up to change the defualt value of devstack | |
| 13:41:42 | sean-k-mooney | corvus: sure so why dont we just merge the other patch | |
| 13:42:13 | corvus | sean-k-mooney: https://review.opendev.org/649097 has set it to WIP | |
| 13:42:34 | sean-k-mooney | yes because it was depending on a change that has now merged | |
| 13:42:58 | kashyap | Hey, folks. Now is the time to speak up, if you have comments on this: http://lists.openstack.org/pipermail/openstack-discuss/2019-November/010907.html ("On next minimum libvirt / QEMU versions for "V" release") | |
| 13:43:06 | stephenfin | corvus: Yeah, I was waiting on mriedem to appear and decide what to do | |
| 13:43:12 | stephenfin | as the owner of https://review.opendev.org/#/c/649097/1 | |
| 13:43:23 | stephenfin | mriedem: for context: |
|
| 13:43:26 | corvus | ftr, you don't need to set wip to avoid something with a depends-on being merged. zuul does that for you. | |
| 13:44:00 | sean-k-mooney | i know i think he might have been looking at the greneade failure too | |
| 13:44:55 | mriedem | how are changes in the nova jobs breaking everything else that's using devstack? | |
| 13:44:55 | sean-k-mooney | he set it to wip because he tought it might need to be rebased on https://review.opendev.org/#/c/688799/ | |
| 13:45:20 | corvus | either way (whether we merge the revert or the default change), we should get USE_PYTHON3 out of the .zuul.yaml in nova -- that's the red flag here. basically, if something is required for devstack to work, it should be in the devstack repo instead of nova; we should only set individual job config tweaks in nova's config. | |
| 13:45:20 | sean-k-mooney | mriedem: the chagne prevents nova being installed in python 2 | |
| 13:45:56 | corvus | yeah, the change simultaneously stopped all py2 testing on nova, and broke installing nova on py2. | |
| 13:45:59 | efried | corvus, stephenfin, sean-k-mooney: I +2ed; now just convince mriedem... | |
| 13:46:10 | sean-k-mooney | corvus: USE_PYTHON3=true is not the problem | |
| 13:46:12 | mriedem | these aren't the only jobs setting the USE_PYTHON3=True flag outside of devstack | |
| 13:46:17 | mriedem | neutron has at least one as well | |
| 13:47:00 | mriedem | sean-k-mooney: why can't it install on py2? because of dependencies that were removed? | |
| 13:47:10 | sean-k-mooney | the reson other jobs broke is python-requires = >=3.6 | |
| 13:47:23 | sean-k-mooney | in setup.cfg | |
| 13:47:24 | mriedem | i'd like to know if we (nova) can switch our jobs to use py3 meanwhile leaving in whatever is needed to install nova on py2 until other jobs move over | |
| 13:47:39 | mriedem | so let's revert that | |
| 13:47:55 | sean-k-mooney | if we just remove that it will allow nova to be installed on python 2 | |
| 13:47:56 | efried | But doesn't "stop testing py2" leave us exposed there? | |
| 13:48:00 | mriedem | with a big ass TODO about dropping that when devstack has USE_PYTHON3=True by default | |
| 13:48:36 | mriedem | either we move, or we don't, i don't really care about dropping py2 support, but that's what the TC has been hammering on for yeras | |
| 13:48:38 | mriedem | *years | |
| 13:48:42 | mriedem | so then we do and things break, and omfg | |
| 13:48:45 | slaweq | hi | |
| 13:48:47 | sean-k-mooney | https://review.opendev.org/#/c/694891/1/setup.cfg@9 | |
| 13:48:57 | mriedem | so let's just do the minimum possible to get things working which is revert the setup.cfg change yeah | |
| 13:48:57 | mriedem | ? | |
| 13:48:59 | sean-k-mooney | nova can move | |
| 13:49:05 | slaweq | I just found out that patch https://review.opendev.org/#/c/687954/ which You are now talking about broke also neutron-grenade job | |
| 13:49:17 | sean-k-mooney | if we remove that 1 line other can install it on python2 | |
| 13:49:18 | mriedem | slaweq: yeah we're just talking about what to revert | |
| 13:49:24 | slaweq | this job is py2 job and is running in many projects | |
| 13:50:13 | slaweq | mriedem: yes, I see. I just wanted to mention about this job which I just noticed that is broken | |
| 13:50:15 | sean-k-mooney | so in anycase by december 12 all project are ment to chagne to python 3 and drop python 2 testing | |
| 13:51:49 | sean-k-mooney | * all non lib projects | |
| 13:53:10 | mriedem | i've left comments on the change, | |
| 13:53:20 | mriedem | this is a clusterf*ck management-wise from my pov, | |
| 13:53:22 | mriedem | so do whatever | |
| 13:53:31 | openstackgerrit | Alexandre arents proposed openstack/nova master: Do not update root_device_name during guest config https://review.opendev.org/670000 | |
| 13:53:42 | mriedem | let the tc work on getting devstack to use py3 by default | |
| 13:54:48 | corvus | mriedem: if nova runs all devstack jobs with USE_PYTHON3 set to true, then the same thing can happen again | |
| 13:55:21 | corvus | if you don't want to revert that whole change, can you at least keep one py2 job running as long as py2 is the devstack default? | |
| 13:55:58 | mriedem | the same thing == not being able to install nova with py2, that's wrong, right? as long as we don't screw up setup.cfg, | |
| 13:56:11 | mriedem | tempest tests could break if nova lands some code that doesn't work with py2, i get that | |
| 13:56:23 | mriedem | but frankly i don't see that happening real soon, and if it does it can be fixed, | |
| 13:56:32 | mriedem | and it's also motivation to get downstream projects to move to py3 as well | |
| 13:56:38 | corvus | mriedem: right, i'm saying it's a testing hole. someone could introduce a change that doesn't work with py2. | |
| 13:56:42 | mriedem | which is what i thought everyone wanted in ussuri as a major community goal | |
| 13:56:58 | corvus | my only goal here is that "./stack.sh" always work for new users. | |
| 13:57:51 | mriedem | "always works" is pretty subjective | |
| 13:57:53 | mriedem | bugs are bugs | |
| 13:58:08 | mriedem | i agree that if nova doesn't install it's a problem | |
| 13:58:11 | tosky | mriedem: please approve the revert - all the other projects are broken because nova does not start | |
| 13:58:11 | mriedem | so revert the setup.cfg change | |
| 13:58:25 | mriedem | some other core can approve if they care | |
| 13:58:40 | mriedem | i'd like the community to shit or get off this py3 pot | |
| 13:58:43 | corvus | mriedem: yeah, but there's no testing of nova in the default devstack configuration. | |
| 13:58:49 | mriedem | christ we're talking about py3.8 gating in the tc threads these days already | |
| 13:59:28 | mriedem | do whatever stephenfin and efried want | |
| 14:00:42 | tosky | mriedem: I'm not sure why you are saying or implying that the community does not want to move - I think we want to move, just without blocking the work | |
| 14:02:10 | mriedem | i've already said i'm good with fixing setup.cfg so nova can install again, | |
| 14:02:34 | mriedem | i don't think we should be gating on py2 though and if something slips through that's a py2 bug then we fix it | |
| 14:02:53 | mriedem | otherwise just let the qa/tc/infra whoever team that cares about this manage it directly imo | |
| 14:03:09 | mriedem | since the projects obviously can't orchestrate this themselves | |
| 14:03:15 | tosky | fine, but then probably you also need to revert the requirment change | |
| 14:03:22 | tosky | not just setup.cfg | |
| 14:03:57 | mriedem | do whatever you guys want | |
| 14:04:33 | stephenfin | So someone needs to go first, and I thought it could be us since we're a service, not a library, but obviously that isn't the case | |
| 14:04:51 | stephenfin | What's the hold up with DevStack switching to Py3 first though? Can't we just merge that? | |
| 14:05:06 | tosky | I don't know | |
| 14:05:12 | mriedem | someone has to care | |
| 14:05:14 | corvus | please have at least one test on nova that runs devstack in the default configuration. otherwise, there is a very high risk that changes will merge to nova which will break it. | |
| 14:05:53 | stephenfin | okay, makes sense. So can I go switch DevStack to use Python 3 by default | |