| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-11-18 | |||
| 11:51:33 | zigo | I don't know about any bug number though, I just tested and saw it was fixed. | |
| 11:51:47 | zigo | I'm trying to lookup commits now ... | |
| 11:52:58 | lyarwood | zigo: ah retyping a volume? | |
| 11:53:31 | zigo | lyarwood: Just live-migrating a volume: | |
| 11:53:31 | zigo | openstack volume migrate --host <volume-hostname> <volume-id> | |
| 11:53:37 | lyarwood | zigo: I landed https://review.opendev.org/#/q/I1bdf3431bda2da98380e0dcaa9f952e6768ca3af to fix that | |
| 11:53:42 | zigo | In 18.1.0, the new volume is re-attached ... | |
| 11:54:17 | zigo | ... but the old one never deleted (and both new and old are still in the bad migration status) | |
| 11:54:46 | lyarwood | ack yeah that came in with 18.2.1 | |
| 11:55:07 | zigo | lyarwood: Thanks, this looks like it. | |
| 11:55:42 | zigo | lyarwood: FYI, I need to have the exact patch, so I get this fast in Buster (upgrading to 18.2.3 has a lot of chances to be unfortunately rejected by the Debian stable release team...) | |
| 11:56:03 | lyarwood | https://review.opendev.org/#/c/657577/ is the change | |
| 11:56:19 | zigo | Yeah, got it, thanks a lot. | |
| 12:00:27 | zigo | lyarwood: I need that one too, right? | |
| 12:00:29 | zigo | https://review.opendev.org/#/c/639331/ | |
| 12:00:39 | zigo | Ah no, that's for tempest ... | |
| 12:04:47 | lyarwood | zigo: yeah you don't technically need that, it will however ensure things are tested correctly if Debian stable has CI for OpenStack | |
| 12:05:17 | zigo | lyarwood: Yeah, I may also patch the tempest package... :) | |
| 12:22:15 | openstackgerrit | Pavel Gluschak (scsnow) proposed openstack/nova master: Don't delete compute node, when deleting service other that nova-compute https://review.opendev.org/694756 | |
| 12:27:49 | openstackgerrit | Pavel Gluschak (scsnow) proposed openstack/nova master: Don't delete compute node, when deleting service other than nova-compute https://review.opendev.org/694756 | |
| 12:28:54 | openstackgerrit | Pavel Gluschak (scsnow) proposed openstack/nova master: Don't delete compute node, when deleting service other than nova-compute https://review.opendev.org/694756 | |
| 12:43:46 | efried | o/ nova | |
| 12:43:46 | efried | I'm going to be out today. | |
| 12:43:46 | efried | Enjoy. | |
| 13:00:06 | gibi | efried_pto: enjoy your day too | |
| 14:23:50 | mriedem | i wonder, maybe we should drop using the neutron-grenade-multinode job which is 2 node grenade + smoke tests. we already have nova-grenade-multinode which is just live migration tests in both a block storage + lvm and shared storage + ceph setup. if we changed nova-grenade-multinode to run smoke tests + live migration for the block storage + lvm case, before changing the env to ceph, then we'd cover what the neutron-grenade-m | |
| 14:23:50 | mriedem | node job was doing | |
| 14:24:15 | mriedem | oh nova-grenade-multinode also runs a cold migrate test since train | |
| 14:27:15 | sean-k-mooney | mriedem: that sounds resonable. have you looked at https://review.opendev.org/#/c/548936/ it woudl be good to eventually get that merged to have a native grenade job | |
| 14:27:58 | mriedem | nope i haven't. it's huge and it scares me. | |
| 14:29:55 | sean-k-mooney | it is, it does appear to work at least. that said the last ci run was july so it might not anymore | |
| 14:34:43 | mriedem | grenade-core includes devstack-core and the devstack / qa team have done a lot of the initial zuulv3-ification of stuff, starting with devstack and tempest, so i'll defer to them for reviewing that massive zuulv3 chnage | |
| 14:34:47 | mriedem | *change | |
| 14:38:05 | openstackgerrit | Matt Riedemann proposed openstack/nova master: FUP to Ie1a0cbd82a617dbcc15729647218ac3e9cd0e5a9 https://review.opendev.org/694787 | |
| 14:50:24 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Drop neutron-grenade-multinode job https://review.opendev.org/694789 | |
| 14:57:36 | artom | If you do a Follow Up Patch to a Follow Up Patch, is it a Follow Up Patch Addendum? | |
| 15:07:26 | mriedem | so making nova-grenade-multinode run smoke tests adds about 14-15 minutes to the job unless we prune down the smoke tests that it runs which we might want to consider doing - to just run compute API and scenario smoke tests, though then we lose some of the coverage that neutron-grenade-multinode gave us, | |
| 15:07:44 | mriedem | though a nova change likely isn't going to break an identity/image/object/network/volume API change that doesn't use nova at all | |
| 15:19:21 | mriedem | i would need some help on the regexing though.. | |
| 15:20:15 | mriedem | artom: you like a good regex test right? | |
| 15:20:20 | mriedem | say i have a test string of: tempest.api.compute.flavors.test_flavors.FlavorsV2TestJSON.test_get_flavor[id-1f12046b-753d-40d2-abb6-d8eb8b30cb2f,smoke] | |
| 15:20:40 | mriedem | i want to match tempest.api.compute.* and tempest.scenario.* but only for those strings containing 'smoke' | |
| 15:21:12 | mriedem | i think (tempest.api.compute.*|tempest.scenario.*)([\bsmoke\b]) might work? | |
| 15:21:58 | artom | mriedem, I think aspiers was the regex master, but I'll try | |
| 15:22:36 | artom | mriedem, that should work | |
| 15:23:19 | artom | I'd have done it as 'tempest\.(api\.compute|scenario)\..*smoke' | |
| 15:25:19 | mriedem | yeah that seems to work as long as smoke comes last | |
| 15:26:02 | mriedem | well, i guess there is no $ on the regex so i guess it's ok | |
| 15:26:23 | artom | So 'tempest\.(api\.compute|scenario)\..*smoke.*' then :) | |
| 15:26:25 | mriedem | tempest.(api.compute|scenario)\..*smoke.* | |
| 15:26:29 | mriedem | yeah | |
| 15:36:34 | sean-k-mooney | bauzas: could you take a look at https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/1763766 ideally im aiming to get this merged before m1 | |
| 15:37:20 | sean-k-mooney | stephenfin: similar for https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/vm-scoped-sriov-numa-affinity if i can get that merged before m1 it would make peopel happy so if you could review it would be nice before i start asking others | |
| 15:59:02 | bauzas | sean-k-mooney: ack, will look | |
| 16:10:13 | openstackgerrit | Mark Goddard proposed openstack/nova master: [ironic] Fix node rebalance race issues https://review.opendev.org/694802 | |
| 16:14:21 | mriedem | mgoddard: hi https://review.opendev.org/#/c/684849/ | |
| 16:14:38 | kashyap | Can someone update the openSUSE stuff here? -- https://wiki.openstack.org/wiki/LibvirtDistroSupportMatrix | |
| 16:14:46 | kashyap | (I've updated for Debian, Ubuntu, RHEL and Fedora.) | |
| 16:14:58 | kashyap | Who's the contact point for Oracle Linux again? | |
| 16:15:46 | mgoddard | mriedem: thanks, I'll check it out | |
| 16:18:31 | artom | kashyap, probably Satan | |
| 16:19:09 | artom | Dammit >< | |
| 16:19:10 | kashyap | artom: Yeah, c'mon | |
| 16:22:07 | mgoddard | mriedem: it could be because I'm using Rocky, but I don't see any errors in RT following rebalance | |
| 16:24:27 | mriedem | on either node? | |
| 16:24:33 | mriedem | s/node/compute service host/ | |
| 16:25:25 | mgoddard | yeah | |
| 16:27:20 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Add TODOs for remaining nova-network functional tests https://review.opendev.org/684345 | |
| 16:27:21 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'os-security-group-default-rules' REST API https://review.opendev.org/686807 | |
| 16:27:21 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove unused '*_default_rules' security group DB APIs https://review.opendev.org/686808 | |
| 16:27:22 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove (most) '/os-networks' REST APIs https://review.opendev.org/686809 | |
| 16:27:22 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove '/os-tenant-networks' REST API https://review.opendev.org/686810 | |
| 16:27:23 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove 'USE_NEUTRON' from functional tests https://review.opendev.org/686811 | |
| 16:27:23 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove 'networks' quota https://review.opendev.org/686812 | |
| 16:27:24 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove nova-manage network, floating commands https://review.opendev.org/686813 | |
| 16:27:24 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove associate, disassociate network APIs https://review.opendev.org/686814 | |
| 16:27:25 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove 'nova-dhcpbridge' binary https://review.opendev.org/686815 | |
| 16:27:25 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove 'nova-network' binary https://review.opendev.org/686816 | |
| 16:27:26 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Blast most references to nova-network https://review.opendev.org/686817 | |
| 16:27:26 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP https://review.opendev.org/686818 | |
| 16:28:19 | mriedem | mgoddard: your commit message says you have sql errors in the logs, likely due to duplicate entry errors? | |
| 16:29:08 | mgoddard | mriedem: I never really got to the bottom of that one. http://paste.openstack.org/show/786272/ | |
| 16:29:15 | mriedem | do you have this patch? https://review.opendev.org/#/c/676514/ | |
| 16:29:26 | mriedem | what version of rocky do you have? | |
| 16:29:49 | mgoddard | yes I have that patch | |
| 16:30:07 | mgoddard | I have 18.2.0, plus a few backports (including that one) | |
| 16:33:10 | mgoddard | mriedem: I have a few things to look at here. I could try my reproducer with your patch, and try your func test with my patch | |
| 16:35:41 | mriedem | yeah it would be good to know if they aren't duplicate bugs but something else | |
| 16:40:49 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle NoSuchOptError in nova-manage gracefully https://review.opendev.org/694806 | |
| 16:53:28 | mgoddard | mriedem: my patch passes the func test, with two modifications | |
| 16:53:36 | mgoddard | 1. I didn't hit "Skipping removal of allocations for deleted instances" | |
| 16:54:18 | mgoddard | 2. Part of my change prevents the orphan deletion happening in that case, so I rolled that part back for testing | |
| 16:54:29 | mgoddard | https://review.opendev.org/#/c/694802/1/nova/db/sqlalchemy/api.py | |
| 16:54:56 | mgoddard | ^ that prevents host2 from deleting a compute node after host1 has taken ownership of it | |
| 16:55:14 | mgoddard | which should prevent us from hitting this issue | |
| 16:55:29 | mgoddard | the rest of the change is to help clean up if we have hit it previously | |
| 16:59:24 | mriedem | mgoddard: ok i guess it's up to king solomon then to figure out which patch to go with | |
| 16:59:48 | mriedem | or just -1 my change if you want | |
| 17:00:25 | mriedem | either way i think the functional test needs to stay b/c unit tests aren't really sufficient for this kind of multi-service and db interaction | |
| 17:01:06 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle NoSuchOptError in nova-manage gracefully https://review.opendev.org/694806 | |