| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-11-14 | |||
| 15:17:57 | huaqiang | and we have three PCI numa policies in total | |
| 15:17:59 | sean-k-mooney | if you mean you cant have different policies for different devices correct | |
| 15:18:35 | huaqiang | yes, that is I want to confirm | |
| 15:18:40 | sean-k-mooney | that is why its titled vm-scoped-sriov-numa-affinity | |
| 15:19:17 | sean-k-mooney | if we want to do interface scoped sriov polices we still can as a seperate qos policy on the neuton port | |
| 15:19:39 | sean-k-mooney | i would like to enable that too at some point but after this initall effort is done once we see if its required | |
| 15:20:23 | luyao | efried, mriedem: I have another question for "track error mirations and orphans in resource tracker", I think it is a bug, which have some effects on vpmem feature. Do I need put all vpmem live migration stuff based on the bug fixed. I'm not sure how to address this bug at the moment. Could you help me figure it out, I sent an emaila few days ago. | |
| 15:22:44 | sean-k-mooney | luyao: i think those are two different topics | |
| 15:22:53 | luyao | I put my solution on this etherpad. I hope it is clear for you. We can discuss on the etherpad. https://etherpad.openstack.org/p/track-err-migr-and-orphans-in-RT | |
| 15:23:01 | efried | luyao: I'll try to look, but it sounds daunting. If you think there's a bug (vpmem notwithstanding) we would welcome a patch to fix it. | |
| 15:24:32 | sean-k-mooney | efried: part of it is a design choice. which is been adressed in a bugfix already | |
| 15:25:09 | huaqiang | sean-k-mooney: Got. thanks | |
| 15:25:16 | sean-k-mooney | specificly there is a patch to reap orpahanded vms that have a nova metada in there domain xml but were deleted in the db | |
| 15:25:22 | luyao | efried, sean-k-mooney : so I can do the vpmem live migration and bug fix parallelly,right? | |
| 15:25:33 | sean-k-mooney | as an extention to the existing periodic task | |
| 15:25:42 | efried | mriedem: https://review.opendev.org/#/c/694248/ FYI (wait to recheck patches failing requirements check until ^ merges) | |
| 15:25:52 | efried | (per smcginnis) | |
| 15:26:14 | sean-k-mooney | luyao: provided you dont need to modify the same code sure even then you can factor out the common code into a shared patch | |
| 15:26:33 | sean-k-mooney | luyao: from a review persepective it will be simpler if they are seperate | |
| 15:27:23 | openstackgerrit | Matt Riedemann proposed openstack/nova master: docs: update SUSPENDED server status wrt supported drivers https://review.opendev.org/694329 | |
| 15:27:41 | mriedem | efried: i'm not sure what you're showing me | |
| 15:28:03 | mriedem | is that related to why my sqla-migrate change failed? | |
| 15:28:07 | efried | mriedem: the reqs job is broken until that merges. We've got a couple patches in the pipe that keep failing on reqs. yes. | |
| 15:28:25 | mriedem | ack, thanks | |
| 15:30:46 | luyao | sean-k-mooney: OK, get it, they should be separate if there is no surprise. :) | |
| 15:44:20 | mriedem | sean-k-mooney: did you ever write a functional test for trying to delete a compute service while a server is in VERIFY_RESIZE status for the host? i vaguely recall that coming up when i wrote test_evacuate_then_delete_compute_service | |
| 15:45:30 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Convert legacy nova-live-migration and nova-multinode-grenade to py3 https://review.opendev.org/692374 | |
| 15:45:48 | sean-k-mooney | am no i rememebr that but i think i ended up getting pulled into something else | |
| 15:46:41 | sean-k-mooney | i think we were conserned the resize confim would fail if the source was deleted right | |
| 15:47:39 | sean-k-mooney | because we would not be able to do the source host clean up | |
| 15:47:50 | mriedem | likely yes | |
| 15:47:57 | mriedem | or same if the dest is deleted and you try to revert | |
| 15:48:08 | sean-k-mooney | ya | |
| 15:48:19 | mriedem | ok i'll just write those tests today | |
| 15:49:31 | sean-k-mooney | ill freely admint while is am begining to understand the functional test better of late i still am less comfortable writing them then i woudl like to be | |
| 15:49:52 | mriedem | copy/paste/modify | |
| 15:50:25 | mriedem | that + stackforge = highly paid professional software engineer | |
| 15:50:29 | sean-k-mooney | ya so that i can do but im trying to understand some of the fixture and how they related a llitle more os if i need to write one i can | |
| 15:50:50 | mriedem | well, the best way to learn is to get started | |
| 15:51:18 | sean-k-mooney | hehe which is a good segway for me to go back to writign the ones you asked for yesterday | |
| 15:52:44 | sean-k-mooney | when i do have them working they are a nice way to test the code. bauzas has been suggestign we try to do more test driven developemnt usign functional tests | |
| 15:53:54 | sean-k-mooney | i do tend to rely on deploying things on really hardware or nested vert more then i proably should in my intally dev sometimes | |
| 15:56:03 | sean-k-mooney | bauzas: might also be motivated by a lack of hardware to test his things | |
| 15:59:17 | openstackgerrit | Lee Yarwood proposed openstack/nova-specs master: Boot from volume instance rescue https://review.opendev.org/694063 | |
| 16:00:27 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop testing Python 2 https://review.opendev.org/687954 | |
| 16:06:37 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Convert legacy nova-live-migration and nova-multinode-grenade to py3 https://review.opendev.org/692374 | |
| 16:06:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Stop testing Python 2 https://review.opendev.org/687954 | |
| 16:08:22 | openstackgerrit | Stephen Finucane proposed openstack/nova master: zuul: Make functional job inherit from openstack parents https://review.opendev.org/688425 | |
| 16:18:27 | openstackgerrit | Lee Yarwood proposed openstack/os-traits master: Add COMPUTE_RESCUE_BFV trait https://review.opendev.org/694033 | |
| 16:20:02 | mriedem | lyarwood: i've got some things for your stable rescue disk device spec https://review.opendev.org/#/c/693849/ | |
| 16:21:16 | lyarwood | mriedem: ack thanks, just in yet another meeting, will review once this ends. | |
| 16:22:26 | mriedem | i should likely open a docs bug b/c we don't have any documentatoin about rescue | |
| 16:23:30 | mriedem | i guess https://docs.openstack.org/nova/latest/user/reboot.html kind of | |
| 16:25:34 | lyarwood | mriedem: yeah we can break that out into a seperate section tbh | |
| 16:27:10 | mriedem | how about just a docs bug https://bugs.launchpad.net/nova/+bug/1852609 | |
| 16:27:10 | openstack | Launchpad bug 1852609 in OpenStack Compute (nova) "Reboot an instance in nova - split the rescue part out" [Undecided,New] | |
| 16:39:58 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional recreate test for bug 1852610 https://review.opendev.org/694351 | |
| 16:39:58 | openstack | bug 1852610 in OpenStack Compute (nova) "API allows source compute service/node deletion while instances are pending a resize confirm/revert" [Medium,Triaged] https://launchpad.net/bugs/1852610 | |
| 16:56:28 | mriedem | dansmith: how are you feeling (besides gross) about this filter duplicate migrations change https://review.opendev.org/#/c/636224/ ? is there anything you want me to do there besides burn it all down and start over? | |
| 16:56:35 | openstackgerrit | Archit Modi proposed openstack/nova stable/queens: doc: fix and clarify --block-device usage in user docs https://review.opendev.org/694357 | |
| 16:57:23 | dansmith | besides, gross.. hmm.. is "procrastinatey" a word? | |
| 16:57:46 | mriedem | it is now | |
| 16:58:15 | mriedem | if we want to genericify that i can move it to NovaBase later | |
| 16:58:34 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'os-consoles' API https://review.opendev.org/687907 | |
| 16:58:41 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'nova-console' service, 'os-consoles' API https://review.opendev.org/687908 | |
| 16:58:48 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove 'nova-xvpvncproxy' https://review.opendev.org/687909 | |
| 16:59:25 | dansmith | mriedem: honestly, I want someone else to +W that so I can happily move onto the later patches and forget about it | |
| 17:00:09 | mriedem | stephenfin: efried: ^ | |
| 17:01:00 | stephenfin | in a meeting, but I'll take a look after (if efried doesn't grab it first) | |
| 17:03:44 | bauzas | efried: around ? | |
| 17:04:21 | bauzas | efried: I was evaluating how much checking the COMPUTE_NODE trait would help the placement audit command https://review.opendev.org/#/c/670112 | |
| 17:05:09 | dansmith | mriedem: replied about the upgrade aspect on that stable rescue thing | |
| 17:05:54 | dansmith | mriedem: not sure if you saw the previous discussion on that spec about it, but once I found out those properties already exist I figured there's no point in trying to be strict about them now, and it's actually less compatible if we do, since they're silently ignored today | |
| 17:07:03 | mriedem | true they are silently ignored today, they also aren't documented so i'm not sure anyone would know to use them | |
| 17:07:57 | dansmith | mriedem: yeah, so I figure if someone did have them in an image today, found out they didn't work, left them, then started to upgrade...shit stops working for no obvious reason | |
| 17:08:02 | dansmith | (until fully upgraded) | |
| 17:09:26 | openstackgerrit | Archit Modi proposed openstack/nova stable/queens: doc: fix and clarify --block-device usage in user docs https://review.opendev.org/694357 | |
| 17:09:27 | openstackgerrit | Archit Modi proposed openstack/nova stable/queens: Revert "openstack server create" to "nova boot" in nova docs https://review.opendev.org/693239 | |
| 17:10:08 | mriedem | replied in the spec | |
| 17:10:32 | mriedem | it might just be that the documented replies to my questions/edge cases are done in a follow up i could drop the -1 | |
| 17:11:08 | mriedem | as it reads today, the spec is very much like "if you're using libvirt and everything is fully upgraded, you're golden" but i think it's worth documenting if those aren't true and what happens | |
| 17:11:35 | mriedem | plus there is no liaison and that's just like, -5 | |
| 17:13:36 | dansmith | mriedem: well, fwiw, I asked him to remove the hard fail, and also encouraged him to remove some of the upgrade impact, | |
| 17:13:56 | dansmith | well, nevermind, that's more the BFV one | |
| 17:14:03 | dansmith | anyway, whatever | |
| 17:14:35 | mriedem | ok. i'm just asking that rather than remove things and leave questions (which i obviously had b/c it wasn't documented), i'm asking that we're clear about intent | |
| 17:14:54 | mriedem | so in a year or 2 people aren't like, "why does it work this way? was x considered?" | |
| 17:15:00 | dansmith | yeah, not arguing against that, | |
| 17:15:27 | dansmith | more like hoping I didn't lead him too astray asking him to pare down some of it, specifically around the start-failing-when-we-didn't-before stuff | |
| 17:15:40 | mriedem | ack | |
| 17:15:54 | mriedem | never lead sweet lee astray | |
| 17:18:39 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional recreate revert resize test for bug 1852610 https://review.opendev.org/694364 | |
| 17:18:39 | openstack | bug 1852610 in OpenStack Compute (nova) "API allows source compute service/node deletion while instances are pending a resize confirm/revert" [Medium,Triaged] https://launchpad.net/bugs/1852610 | |
| 17:20:07 | mriedem | sean-k-mooney: ^ and the one below it are the tests we talked about | |
| 17:21:44 | efried | bauzas: Hi, here now, sorry. | |
| 17:21:54 | bauzas | efried: no worries | |
| 17:22:31 | bauzas | efried: traits from a root RP aren't automatically cascaded to their siblings, right? | |
| 17:22:43 | efried | correct | |
| 17:22:47 | bauzas | efried: because I really want to iterate over the list of RPs | |
| 17:22:48 | efried | siblings/descendants | |