Posted	Nick	Remark
#openstack-nova - 2019-11-13
22:37:14	mriedem	i want to say dansmith was in that discussion when it happened and wasn't crazy about the idea - maybe around the time of the proposal from booth to auto-revert on failed resize
22:37:25	mriedem	or maybe dan preferred just reverting from ERROR instead, i can't remember
22:38:02	melwitt	hmm ok
22:38:31	mriedem	https://review.opendev.org/#/c/462521/ was booth's patch btw
22:40:29	melwitt	ah ok
22:41:26	melwitt	tbh I think reverting from ERROR would be nice as just something
22:42:38	melwitt	it's painful knowing all the code is there to do the thing but you can't get to it because of a vm_state block and then have to do a bunch of gnarly manual stuff
22:46:29	mriedem	yeah it's definitely a kick in the ass to fix up a failed resize because of volumes, networking, allocations in placement, and some day cyborg devices,
22:46:42	mriedem	plus the quota stuff involved to even move the server back
22:47:00	mriedem	like you said, the source host was full when they tried moving it back
22:47:21	mriedem	i left a note in https://review.opendev.org/#/c/462521/12/releasenotes/notes/resize-auto-revert-6e1648828aba16b2.yaml@5 if it helps start a new discussion about changing the API
22:49:55	melwitt	yeah thanks. and thanks for talking through this, I'm gonna refresh on what was going on in that review and then I was thinking start a ML thread about the API angle based on your comment
22:51:08	mriedem	i believe the tl;dr on why that patch to auto-revert was not great was dan's comment in the reno
22:51:20	mriedem	external tooling could get screwed up
22:51:38	melwitt	given the behaviorial/api change called out on that patch, I'm not sure whether there's a decent way to roll back automatically. if there's not, the api change would be a big help imho
22:51:43	mriedem	just allowing reverting an ERROR'ed resize from the api though is pretty straight-forward and opt-into-y
22:51:52	melwitt	yeah
22:52:16	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Update keypairs in saving an instance object https://review.opendev.org/683043
23:01:34	dansmith	mriedem: yeah, not sure I remember revert-from-ERROR specifically, but definitely not in favor of auto rollback
23:09:31	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Update keypairs in saving an instance object https://review.opendev.org/683043
23:13:47	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Update keypairs in saving an instance object https://review.opendev.org/683043
23:22:31	openstackgerrit	Merged openstack/nova master: cond: rename 'recreate' var to 'evacuate' https://review.opendev.org/692900
23:27:53	openstackgerrit	Merged openstack/nova master: Remove PlacementAPIConnectFailure handling from AggregateAPI https://review.opendev.org/660852
23:30:10	openstackgerrit	Matt Riedemann proposed openstack/nova master: Do not reschedule on ExternalNetworkAttachForbidden https://review.opendev.org/694179
23:34:42	openstackgerrit	Matt Riedemann proposed openstack/nova master: Do not reschedule on ExternalNetworkAttachForbidden https://review.opendev.org/694179
23:36:38	openstackgerrit	Eric Fried proposed openstack/nova master: WIP: Add emulated TPM support to Nova https://review.opendev.org/631363
23:36:39	openstackgerrit	Eric Fried proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934
23:36:39	openstackgerrit	Eric Fried proposed openstack/nova master: WIP: vTPM request_filter https://review.opendev.org/678325
23:43:48	openstackgerrit	Merged openstack/nova master: Remove dead HostAPI.service_delete code https://review.opendev.org/693422
23:43:55	openstackgerrit	Merged openstack/nova master: Add support matrix for Delete (Abort) on-going live migration https://review.opendev.org/625781
23:44:03	openstackgerrit	Merged openstack/nova master: Implement update_provider_tree for mocked driver in test_resource_tracker https://review.opendev.org/693431
23:45:42	openstackgerrit	Matt Riedemann proposed openstack/nova master: api-ref: mark device response param as optional for list/show vol attachments https://review.opendev.org/690383
#openstack-nova - 2019-11-14
00:54:46	openstackgerrit	Merged openstack/nova master: Drop compat for non-update_provider_tree code paths https://review.opendev.org/693435
00:59:21	openstackgerrit	Merged openstack/nova master: Delete _normalize_inventory_from_cn_obj https://review.opendev.org/693436
00:59:27	openstackgerrit	Merged openstack/nova master: Remove unused CannotMigrateWithTargetHost https://review.opendev.org/693936
01:10:35	openstackgerrit	Merged openstack/nova master: Restrict RequestSpec to cell when evacuating https://review.opendev.org/650429
01:17:09	openstackgerrit	Merged openstack/nova stable/rocky: doc: fix and clarify --block-device usage in user docs https://review.opendev.org/693554
01:17:16	openstackgerrit	Merged openstack/nova stable/rocky: Revert "openstack server create" to "nova boot" in nova docs https://review.opendev.org/693240
01:46:16	openstackgerrit	Merged openstack/nova master: Fix review link. https://review.opendev.org/689612
03:08:07	openstackgerrit	Merged openstack/nova master: Use named kwargs in compute.API.resize https://review.opendev.org/693425
03:08:13	openstackgerrit	Merged openstack/nova master: "SUSPENDED" description changed in server_concepts guide and API REF https://review.opendev.org/663590
05:24:24	alex_xu	stephenfin: yea, Intel have proxy.
05:24:53	alex_xu	stephenfin: let me know if you come to Beijing, I can treat you local food :)
05:25:29	alex_xu	bauzas: nice, one more place catch you for review ;)
05:49:06	openstackgerrit	Abhishek Kekane proposed openstack/nova-specs master: Support multiple store of Glance https://review.opendev.org/641210
06:02:34	openstackgerrit	Abhishek Kekane proposed openstack/nova-specs master: Support multiple store of Glance https://review.opendev.org/641210
08:00:02	openstackgerrit	Guo Jingyu proposed openstack/nova-specs master: Proposal for a safer noVNC console with password authentication https://review.opendev.org/623120
08:29:40	openstackgerrit	Merged openstack/nova master: Require Migration object arg to migrate_instance_finish method https://review.opendev.org/690106
08:29:46	openstackgerrit	Merged openstack/nova master: Consolidate [image_cache] conf options https://review.opendev.org/690723
08:29:54	openstackgerrit	Merged openstack/nova master: Add image caching to the support matrix https://review.opendev.org/690748
08:30:00	openstackgerrit	Merged openstack/nova master: Stop converting Migration objects to dicts for migrate_instance_start https://review.opendev.org/690115
08:49:51	openstackgerrit	Merged openstack/nova master: Make API always RPC cast to conductor for resize/migrate https://review.opendev.org/693937
08:55:58	openstackgerrit	Brin Zhang proposed openstack/nova-specs master: Add flavor extra specs group https://review.opendev.org/663563
09:46:29	openstackgerrit	Stephen Finucane proposed openstack/nova master: Convert legacy nova-live-migration and nova-multinode-grenade to py3 https://review.opendev.org/692374
09:46:38	openstackgerrit	Stephen Finucane proposed openstack/nova master: Stop testing Python 2 https://review.opendev.org/687954
09:46:45	openstackgerrit	Stephen Finucane proposed openstack/nova master: zuul: Make functional job inherit from openstack parents https://review.opendev.org/688425
10:28:04	openstackgerrit	Balazs Gibizer proposed openstack/nova stable/pike: Only nil az during shelve offload https://review.opendev.org/693839
10:28:47	openstackgerrit	Merged openstack/nova master: Remove dead set_admin_password code to generate password https://review.opendev.org/691873
10:29:01	openstackgerrit	Merged openstack/nova master: doc: add troubleshooting guide for cleaning up orphaned allocations https://review.opendev.org/691427
10:31:41	openstackgerrit	Balazs Gibizer proposed openstack/nova stable/pike: Only nil az during shelve offload https://review.opendev.org/693839
11:13:55	brinzhang	gibi_off: Thanks for your review https://review.opendev.org/#/c/663563/, how about rename the bp as "resource metadata of instance"? and change the new db table's name as "resource_metadata"?
11:20:41	brinzhang	gibi_off: I think we also should establish the association for the "instance_uuid" and "resource_metadata_id". here, a) create a new table, contain the columns of "instance_uuid" and "resource_metadata_id". b) add "resource_metadata_id" to the "instance_metadata" db table, and mapping the choosed (key, value) to the instance.(I think this is compatible with current usage.)
11:36:06	openstackgerrit	Stephen Finucane proposed openstack/nova master: functional: Change order of two classes https://review.opendev.org/689178
11:36:06	openstackgerrit	Stephen Finucane proposed openstack/nova master: functional: Rework '_delete_server' https://review.opendev.org/689179
11:36:07	openstackgerrit	Stephen Finucane proposed openstack/nova master: functional: Make '_wait_for_state_change' behave consistently https://review.opendev.org/689180
11:36:07	openstackgerrit	Stephen Finucane proposed openstack/nova master: functional: Unify '_wait_until_deleted' implementations https://review.opendev.org/689181
11:36:08	openstackgerrit	Stephen Finucane proposed openstack/nova master: functional: Make 'ServerTestBase' subclass 'InstanceHelperMixin' https://review.opendev.org/689182
11:42:57	openstackgerrit	Stephen Finucane proposed openstack/nova master: DNM: Try to figure out why rbd import fails https://review.opendev.org/694260
12:22:25	openstackgerrit	Stephen Finucane proposed openstack/nova master: DNM: python3 experiments https://review.opendev.org/694281
13:26:05	openstackgerrit	Lee Yarwood proposed openstack/nova-specs master: Virtual instance rescue with stable disk devices https://review.opendev.org/693849
13:26:05	openstackgerrit	Lee Yarwood proposed openstack/nova-specs master: Boot from volume instance rescue https://review.opendev.org/694063
14:19:27	efried	o/ nova
14:19:39	efried	Is anyone around for the meeting?
14:20:00	efried	First meeting since PTG+USADST, so an hour earlier for many of us.
14:23:48	gibi_off	efried: I have to skip it today
14:24:16	efried	Okay. You and bauzas and stephenfin were going to be the stars of the show, so...
14:24:35	efried	and next week's (at 2100 utc) is going to be inconvenient for all of you.
14:24:41	bauzas	sorry, on 1:1 meeting now
14:26:16	gibi_off	efried: yeah 2100 is bad, but today (and yesterday) I have to be present on an internal conference demoing the bandwidth stuff repeatedly
14:26:37	efried	that sounds like more fun than a nova meeting anyway.
14:26:59	gibi_off	efried: and as this is done in an open demo area I don't know when somebody pops up at our booth
14:27:37	gibi_off	I can imagine there is a way to define fun that applies to me now :)
14:27:38	efried	Heh, hang an "out to lunch" placard :P
14:27:46	gibi_off	:)
14:34:39	stephenfin	efried: I got confused with the timezones. Drat /o\
14:34:46	stephenfin	DST--
14:43:45	mriedem	huh, i forgot to change my calendar as well :)
14:48:52	mriedem	efried: was there anything you wanted to go over? my thing in open discussion is in the ML and i'm just going to do a quick PoC I think
14:49:02	mriedem	there were a few stable branch releases
14:49:08	mriedem	and elod was added to the nova-stable-maint team
14:52:22	efried	mriedem: The other open (which luyao hadn't put on the agenda as of meeting start time) was whether the LM bits of vPMEM need a BP/spec or not. What are your thoughts?
14:55:20	mriedem	my gut reaction is vPMEM hasn't even baked to the point of thinking about supporting live migration
14:55:40	mriedem	i.e. i don't think we even support live migration with vgpus do we?
14:55:48	mriedem	and people might actually be using that by now
14:56:12	mriedem	vpmem and live migration is likely complicated that a short spec probably doesn't hurt
14:56:20	mriedem	*complicated enough
14:56:45	mriedem	stephenfin: i commented on https://review.opendev.org/#/c/692374/
14:57:02	mriedem	tl;dr i don't think USE_PYTHON3=True is making it to the devstack-plugin-ceph run when the post-test script runs it
14:57:36	mriedem	stephenfin: also, in trying to convert the nova-live-migration job to zuulv3 here https://review.opendev.org/#/c/693364/ oi
14:57:53	mriedem	i'm coming to the conclusion that it would be a ton simpler to just split the nova-live-migration job in two,

Earlier   Later