Earlier  
Posted Nick Remark
#openstack-nova - 2019-11-06
17:10:41 mriedem melwitt: i think we were talking about that in here the other day a bit
17:14:04 amodi mriedem++ melwitt++ thanks both!!
17:14:23 mriedem amodi: happy backporting
17:14:48 amodi lol sure :)
17:15:08 mriedem i posted to the ML about the ovh + spike cron
17:15:14 mriedem i was wondering about the dip there, but that's the weekend
17:16:13 mriedem so that query is kind of annoying because there are a lot that are just a couple of seconds, but those 50+ ones are indicative of something really bad on the node
17:16:43 mriedem mehinks it would be good to maybe have some config in oslo that sets a threshold for that and if it goes above the threshold then it's a WARNING but below it's just INFO?
17:16:52 mriedem right now everything is WARNING which is kind of just noise
17:16:59 mriedem bnemec: ^ what do you think about that?
17:17:26 mriedem like i'd like to make that a warning if something outlasts 30 seconds in devstack/gate and then we can trace it in e-r
17:18:27 dansmith mriedem: hmm, do we still need null_instance_uuid_scan? wasn't that like kilo and we have a constraint now?
17:19:25 mriedem heh yeah i think we can deprecate and remove that https://review.opendev.org/#/c/97946/
17:19:32 mriedem https://review.opendev.org/#/q/topic:bp/db2-database+(status:open+OR+status:merged) !!!
17:19:46 mriedem classic riderman
17:37:55 openstackgerrit Artom Lifshitz proposed openstack/nova master: DNM: break live migration to trigger bug 1788014 https://review.opendev.org/693045
17:37:55 openstack bug 1788014 in OpenStack Compute (nova) "when live migration fails due to a internal error rollback is not handeled correctly." [Medium,In progress] https://launchpad.net/bugs/1788014 - Assigned to Matt Riedemann (mriedem)
17:38:40 jgwentworth is there any way to discover whether force_config_drive=True in nova config from tempest? asking because of this tempest change https://review.opendev.org/693096
17:43:23 openstackgerrit Dan Smith proposed openstack/nova-specs master: Add nova-audit spec https://review.opendev.org/693226
17:43:34 artom jgwentworth, nothing's discoverable in Tempest, it's all configured
17:43:46 dansmith mriedem: jgwentworth ^ wanna skim that for obvious booboos before I blast to the ML?
17:44:31 jgwentworth artom: yeah, I was thinking whether there's some kinda api discoverability from nova that I'm not aware of
17:44:33 artom jgwentworth, in this case, the [compute-features-enabled]/config_drive option
17:44:41 jgwentworth right
17:44:52 artom jgwentworth, ah, doesn't ring a bell
17:44:59 dansmith jgwentworth: isn't that per compute node?
17:45:05 jgwentworth yeah, I'm pretty sure there's not
17:45:15 jgwentworth dansmith: oh, yeah I guess it can be
17:45:28 artom jgwentworth, I suppose you could always boot a VM, ssh to it, and check
17:45:30 artom But...
17:45:45 artom You're meant to be using the config option :)
17:45:49 jgwentworth sigh. ok. just thinking, the test could be useful if force_config_drive=False but it's not in the gate so it would be a dupe test
17:45:56 artom And skip tests that need config drive if it's not set
17:46:07 jgwentworth and is only not a dupe in envs where force_config_drive=False
17:48:09 jgwentworth so at least in the gate, it should be disabled by default. maybe it should actually check the opposite, only run if [compute-features-enabled]/config_drive=False
17:48:39 jgwentworth because tempest seems to be using that to mean whether config drive is being forced
17:49:19 artom What does passing config_drive=True on server creation even do?
17:49:44 artom "Indicates whether a config drive enables metadata injection."
17:49:53 artom That's... no the same as "a config drive will be present"
17:49:55 artom Is it?
17:50:03 larsks artom: attaches a config drive to your instance that will be used for getting instance metadata instead of the network metadata service.
17:50:19 artom larsks, see, I had no idea that was user-controllable in that way
17:50:32 larsks Used e.g. by cloud-init for retrieving ssh keys, network confguration, etc.
17:50:46 artom larsks, right, I know what a config drive *is* :)
17:51:15 artom I just didn't think the user had that level of control over its presence
17:52:31 artom enabled by default, otherwise users can still enable config drives via the REST
17:52:31 artom option."
17:52:31 artom "When this option is set to true config drive functionality will be forced
17:52:31 artom API or image metadata properties. Launched instances are not affected by this
17:52:32 artom Oh OK.
17:53:01 jgwentworth ok, I commented accordingly on the review about inverting the logic of the skip
17:53:03 mriedem because not everyone wants to run the metadata api service
17:53:36 artom mriedem, so I heard
17:53:39 mriedem and the metadata api is only as good as the stuff we persist, which isn't everything that you can use, like personality files
17:54:00 mriedem i.e. you might get your goodies on boot but they are gone after resizing
17:55:28 dansmith config drive is a big benefit for edge peeps
17:55:55 dansmith because hitting the metadata api is a trip over the wan, either via http if it's central, or by it to the db which likely is
17:55:58 dansmith configdrive keeps working even if you're isolated
18:00:10 openstackgerrit Dan Smith proposed openstack/nova-specs master: Add nova-audit spec https://review.opendev.org/693226
18:02:58 sean-k-mooney you can use metadta service if you have isolated neutron networks too
18:03:14 sean-k-mooney but you need to configure neturon to proxy the metadta api via the dhcp agent
18:03:19 sean-k-mooney instead fo the router
18:03:47 dansmith sean-k-mooney: to be clear, I meant partitioned as in...the wan is down
18:03:48 sean-k-mooney but ya config drive woks regardless of the network topology
18:03:58 sean-k-mooney ah right
18:04:35 sean-k-mooney the only draw back with the config drive is that it will not be updated if you attach interface ectra at least while the vm is running
18:04:50 sean-k-mooney in general i works well for what it does
18:05:21 artom jgwentworth, I think gmann and the other tempest folks need to weigh in on https://review.opendev.org/#/c/693096/ - I'm not even sure it's necessary at all
18:06:50 jgwentworth yes, I assumed tempest ppl will review it :)
18:07:13 artom There's... latency, sometimes :)
18:09:47 jgwentworth yeah, I just meant it's a tempest patch so it's gonna be up to them
18:13:20 mriedem dansmith: per usual you updated while i was leaving comments :/
18:16:42 dansmith mriedem_lunch: sorry man, just fixing pep8
18:18:45 jgwentworth dansmith: spec looks sane to me and ok for ML input
18:22:36 dansmith jgwentworth: thanks, I'll make some of the changes mriedem_lunch suggested and then blast
18:38:44 openstackgerrit Dan Smith proposed openstack/nova-specs master: Add nova-audit spec https://review.opendev.org/693226
18:46:24 openstackgerrit Dan Smith proposed openstack/nova-specs master: Add nova-audit spec https://review.opendev.org/693226
18:56:27 dansmith omg the gate, the gate
18:56:35 dansmith 5 minute turnaround time.... <3
19:01:34 melwitt we're living in gate luxury
19:02:52 sean-k-mooney if only there was ptg every month
19:03:04 sean-k-mooney and we did not have to travel
19:04:16 artom PTG in my basement, hell yeah
19:31:28 openstackgerrit Archit Modi proposed openstack/nova stable/pike: Revert "openstack server create" to "nova boot" in nova docs https://review.opendev.org/693236
19:32:01 artom Do we have a middleware-knowing person?
19:32:18 artom I'm trying to figure out a 413 error for a downstream, and it's bugging me
19:32:48 artom Even with debug enabled, the only log line I see is "POST /v2.1/servers" status: 413"
19:32:54 artom Nothing else that's interesting for that request ID
19:33:12 artom So... could it be oslo_middleware's sizelimit doing that? How would we make sure?
19:37:51 openstackgerrit Archit Modi proposed openstack/nova stable/queens: Revert "openstack server create" to "nova boot" in nova docs https://review.opendev.org/693239
19:38:09 sean-k-mooney artom: byond a print statemtent in the function im not really sure
19:38:39 artom sean-k-mooney, or I guess removing it from the paste config
19:38:58 artom But paste scares me
19:39:07 sean-k-mooney ya although that might fail somewhere else then
19:39:43 mriedem artom: efried_rollin has dorked around in a lot of that code lately
19:39:46 openstackgerrit Archit Modi proposed openstack/nova stable/rocky: Revert "openstack server create" to "nova boot" in nova docs https://review.opendev.org/693240
19:39:46 sean-k-mooney im sure there is a way to congirue custom midelware to log extra stuff in the 413 case but ya i didnt really want to have to learn that
19:40:07 sean-k-mooney cdent know that code pretty well too i think
19:40:08 mriedem amodi: i see you're doing backports backwards,
19:40:21 mriedem amodi: note that you should be doing train -> stein -> rocky -> queens -> pike

Earlier   Later