| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-11-05 | |||
| 17:26:08 | dansmith | you know | |
| 17:26:22 | dansmith | it has been said that on several providers we're our own noisy neighbor | |
| 17:26:32 | dansmith | if we see a massive drop in the IO-based failures this week, | |
| 17:26:45 | dansmith | that would probably just go to confirm that as a likely problem | |
| 17:26:51 | dansmith | less volume for samples for sure, but.. | |
| 17:29:01 | melwitt | yeah, I was wondering that too. summit/ptg and if suddenly less gate failures | |
| 17:30:56 | mriedem | gate has been smooth has rich creamery butter this week | |
| 17:32:00 | mriedem | https://www.youtube.com/watch?v=3ds0vWfoTwU | |
| 17:33:51 | melwitt | lol | |
| 17:35:10 | mriedem | i didn't actually think of the simpsons when i said that, but now i realize it's just baked into my brain from years of watching those recorded episodes on vhs as a kid | |
| 17:35:35 | mriedem | "we didn't have streaming in my day..." | |
| 17:35:46 | melwitt | that's impressive | |
| 17:36:30 | sean-k-mooney | even with out streaming like friends the simsons is one of those shows that is on a loop on cable/satialite tv constantly | |
| 17:36:52 | mriedem | we didn't have cable until i was 17 | |
| 17:36:54 | mriedem | hence the vhs | |
| 17:37:18 | mriedem | and then it was all WWE and Love Line years after my friends were sick of those shows | |
| 17:37:33 | sean-k-mooney | some what similar i was maybe 12/14 but that just becasue ireland and it not being a thing until the 90s | |
| 17:38:15 | dansmith | "This channel is for Nova development and mriedem's childhood nostalgia" | |
| 17:38:40 | sean-k-mooney | dansmith: and music references form the 80s | |
| 17:38:51 | dansmith | sean-k-mooney: same category | |
| 17:39:52 | mriedem | let it be so | |
| 17:40:01 | sean-k-mooney | well now that im donw backporting a patch we backported 6 months ago i think im going to get food then do something useful... | |
| 17:50:44 | openstackgerrit | melanie witt proposed openstack/nova stable/stein: Add regression test for bug 1824435 https://review.opendev.org/692906 | |
| 17:50:44 | openstack | bug 1824435 in OpenStack Compute (nova) stein "fill_virtual_interface_list migration fails on second attempt" [Medium,In progress] https://launchpad.net/bugs/1824435 - Assigned to melanie witt (melwitt) | |
| 17:50:44 | openstackgerrit | melanie witt proposed openstack/nova stable/stein: Remove redundant call to get/create default security group https://review.opendev.org/692907 | |
| 18:06:37 | watersj | is openstack resource provider a command available to stein? or am I supposed to replace "resource provider" with something else ? | |
| 18:07:37 | melwitt | watersj: you need to install osc-placement in order to get the placement cli commands | |
| 18:10:08 | watersj | melwitt, ty | |
| 18:17:08 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668 | |
| 18:17:09 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Refresh instance in MigrationTask.execute Exception handler https://review.opendev.org/669012 | |
| 18:17:09 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684 | |
| 18:17:10 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224 | |
| 18:17:10 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Start functional testing for cross-cell resize https://review.opendev.org/636253 | |
| 18:17:11 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle target host cross-cell cold migration in conductor https://review.opendev.org/642591 | |
| 18:17:11 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Validate image/create during cross-cell resize functional testing https://review.opendev.org/642592 | |
| 18:17:12 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add zones wrinkle to TestMultiCellMigrate https://review.opendev.org/643450 | |
| 18:17:12 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add negative test for cross-cell finish_resize failing https://review.opendev.org/643451 | |
| 18:17:13 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add negative test for prep_snapshot_based_resize_at_source failing https://review.opendev.org/669013 | |
| 18:17:13 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize_at_source compute method https://review.opendev.org/637058 | |
| 18:17:14 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add ConfirmResizeTask https://review.opendev.org/637070 | |
| 18:17:14 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add confirm_snapshot_based_resize conductor RPC method https://review.opendev.org/637075 | |
| 18:17:15 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Confirm cross-cell resize from the API https://review.opendev.org/637316 | |
| 18:17:15 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add revert_snapshot_based_resize_at_dest compute method https://review.opendev.org/637630 | |
| 18:17:16 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Deal with cross-cell resize in _remove_deleted_instances_allocations https://review.opendev.org/639453 | |
| 18:17:16 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add finish_revert_snapshot_based_resize_at_source compute method https://review.opendev.org/637647 | |
| 18:17:17 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add RevertResizeTask https://review.opendev.org/638046 | |
| 18:25:21 | dansmith | mriedem: I'm missing something | |
| 18:27:48 | dansmith | okay I think I see, but I feel like now the flow is more confusing than it was before | |
| 18:28:12 | dansmith | all the nested conditions make it hard for me to tell what states you can end up in after your fall out of all of it | |
| 18:28:35 | dansmith | and having the two "restricting" cases is not helping | |
| 18:29:08 | dansmith | I feel like that is a lot more complicated just because we're trying to log a message there about something that will happen later based on a flag we're not even concerned with | |
| 18:30:15 | dansmith | maybe it's more complicated because of the later change you commented about but... it's pretty confusing | |
| 18:30:42 | dansmith | ....which adds another level of nested conditional | |
| 18:30:50 | dansmith | and more logs | |
| 18:31:27 | dansmith | maybe it's just me, and sorry if so, but I think that end state tripley-nested conditional thing is just a total nightmare | |
| 18:39:10 | openstackgerrit | Archit Modi proposed openstack/nova master: Fix block-device-mapping parameter naming https://review.opendev.org/693065 | |
| 18:40:33 | dansmith | mriedem: totally untested, but I think this rearrangement of the final code works the same and is easier to follow? https://pastebin.com/Hq61MM2V | |
| 18:57:41 | mriedem | that paste could work, it's fine with me. it's after the targeted host thing so https://review.opendev.org/#/c/635668/ would be different | |
| 18:58:55 | mriedem | unless you're suggesting munging those changes together | |
| 19:00:26 | dansmith | mriedem: no, I'm not suggesting muging, I just chose the final state to demonstrate what I think it needs to look like | |
| 19:03:53 | mriedem | i'm tinkering | |
| 19:04:09 | melwitt | mriedem: I added you to what's turning out to be a hairy review for a bfv docs fix https://review.opendev.org/693065 | |
| 19:05:06 | melwitt | I think it probably just needs to be updated to use --boot-from-volume (new in 4.0.0 added by you) because it's a confusing mix of wrong osc commands and correct nova boot commands | |
| 19:05:27 | melwitt | but you know best | |
| 19:05:41 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341 | |
| 19:05:41 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029 | |
| 19:05:42 | openstackgerrit | Dustin Cowles proposed openstack/nova master: WIP: Provider Config File: Merge provider configs to provider tree https://review.opendev.org/676522 | |
| 19:06:27 | mriedem | melwitt: ok so this was likely a case of a doc being straight up changed from nova boot to just openstack server create with no thought to the implications of the actual option names or what was supported at the time | |
| 19:06:28 | mriedem | fun | |
| 19:06:36 | melwitt | exactly | |
| 19:12:06 | mriedem | melwitt: left some thoughts on how to maybe break that down into more manageable chunks | |
| 19:12:15 | mriedem | b/c i really hate fixing lots of random shit like this in the docs in the same patch | |
| 19:12:19 | mriedem | easy to get something wrong | |
| 19:12:40 | artom | alias 'openstack server create' 'nova boot' amirite | |
| 19:12:41 | melwitt | cool thanks | |
| 19:13:45 | mriedem | dansmith: ok so this would be pass 1 http://paste.openstack.org/show/785820/ | |
| 19:13:53 | mriedem | for https://review.opendev.org/#/c/635668/ | |
| 19:14:50 | mriedem | which i'd build on with the targeted host stuff in https://review.opendev.org/#/c/642591/ later | |
| 19:14:55 | mriedem | to be more like your final paste | |
| 19:18:32 | melwitt | mriedem: so first step is just replace 'openstack server create' with 'nova boot' to make everything work correctly, backport that. then next step is just convert everything to osc commands properly. I don't think I understand the middle step you described | |
| 19:18:47 | melwitt | or rather I'm seeing 2 steps instead of 3 | |
| 19:20:34 | mriedem | no there is still a nova boot example in there https://review.opendev.org/#/c/693065/1/doc/source/user/launch-instance-from-volume.rst@224 | |
| 19:20:37 | mriedem | so i was saying: | |
| 19:20:44 | mriedem | 1. revert to using nova boot everywhere | |
| 19:20:48 | mriedem | which is backportable | |
| 19:21:03 | dansmith | mriedem: did I miss that requested_destination can be set and None? | |
| 19:21:08 | mriedem | 2. fix the non nova boot (so not https://review.opendev.org/#/c/693065/1/doc/source/user/launch-instance-from-volume.rst@224) openstack server create usage | |
| 19:21:28 | mriedem | 3. replace the remaining nova boot example with openstack server create and mention --boot-from-volume since osc 4.0.0 | |
| 19:21:46 | mriedem | dansmith: that was the existing logic and is what we do elsewhere for setting the cell when moving the server | |
| 19:22:19 | dansmith | aight | |
| 19:22:31 | mriedem | melwitt: that's just how i'd tackle that to try and keep it small and sane for each thing getting fixed | |
| 19:22:50 | mriedem | rather than do it all in a single change stephen style :P and wait for 8 months for someone to review the doc fix | |
| 19:23:19 | melwitt | mriedem: yeah, sorry. I'm just thinking after we revert to nova boot everywhere, there won't be any non nova boot for step 2 | |
| 19:23:22 | mriedem | dansmith: this is my end product http://paste.openstack.org/show/785821/ | |
| 19:23:31 | mriedem | no test changes | |
| 19:23:47 | mriedem | melwitt: oh yeah you're right | |
| 19:23:47 | dansmith | mriedem: hundy times better, IMHO | |
| 19:23:54 | mriedem | dansmith: ok pushing | |
| 19:25:15 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668 | |
| 19:25:15 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Refresh instance in MigrationTask.execute Exception handler https://review.opendev.org/669012 | |