Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-10-30
23:14:24 sean-k-mooney artom: i think that would also fix the issue more generally
23:14:39 sean-k-mooney but i have not tested it
23:15:25 sean-k-mooney anyway night all o/
23:17:01 artom sean-k-mooney, nice idea
23:17:13 artom I'd kinda be afraid of any side effects
23:17:30 artom It'd a wide-reaching change
23:43:44 openstackgerrit Merged openstack/nova master: fixtures: Add support for security groups https://review.opendev.org/686802
23:47:56 openstackgerrit Merged openstack/nova master: nova-net: Migrate 'test_floating_ips' functional tests https://review.opendev.org/684344
#openstack-nova - 2019-10-31
01:25:57 openstackgerrit Merged openstack/nova master: nova-net: Use deepcopy on value returned by NeutronFixture https://review.opendev.org/688139
02:04:58 openstackgerrit melanie witt proposed openstack/nova master: Replace time.sleep(10) with service forced_down in tests https://review.opendev.org/692252
02:07:43 openstackgerrit melanie witt proposed openstack/nova master: Replace time.sleep(10) with service forced_down in tests https://review.opendev.org/692252
03:05:23 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Support re-configure deleted_on_termination in server https://review.opendev.org/580336
05:08:06 openstackgerrit Merged openstack/nova master: Update help for image_cache_manager_interval option https://review.opendev.org/678954
05:08:12 openstackgerrit Merged openstack/nova master: Only allow one scheduler service in tests https://review.opendev.org/682486
08:47:21 openstackgerrit Balazs Gibizer proposed openstack/nova master: Use API calls to force down compute in func test https://review.opendev.org/692291
09:33:19 openstackgerrit Adit Sarfaty proposed openstack/nova master: Avoid fetching metadata when no subnets found https://review.opendev.org/679247
09:53:52 openstackgerrit Adit Sarfaty proposed openstack/nova master: Avoid fetching metadata when no subnets found https://review.opendev.org/679247
10:19:12 openstackgerrit Adit Sarfaty proposed openstack/nova master: Avoid fetching metadata when no subnets found https://review.opendev.org/679247
10:29:04 openstackgerrit Adit Sarfaty proposed openstack/nova master: Avoid fetching metadata when no subnets found https://review.opendev.org/679247
11:09:13 openstackgerrit Merged openstack/nova master: Add missing parameter https://review.opendev.org/682886
11:20:58 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Proposal for a safer noVNC console with password authentication https://review.opendev.org/623120
11:22:55 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Proposal for a safer noVNC console with password authentication https://review.opendev.org/623120
13:09:03 openstackgerrit Merged openstack/nova stable/train: Switch to opensuse-15 nodeset https://review.opendev.org/692032
13:13:52 mriedem boo
13:24:27 mdbooth sean-k-mooney: I was about to start reviewing https://review.opendev.org/#/c/687957/ . Any advice?
13:25:09 sean-k-mooney am i was going to avoid depending on your refactor to make backporting simpeler
13:25:41 sean-k-mooney i do think you functest refactor is good but im not sure it will be backported
13:26:16 sean-k-mooney as such i am wondering if i should avoid intoducing the new test class and use the old way in that patch
13:26:50 mdbooth sean-k-mooney: Sure. It's not strictly required either as I think I mentioned, as you can just inherit from the class I ripped everything out of.
13:27:03 mdbooth The additional cruft isn't actually harmful if you're not using it.
13:27:40 sean-k-mooney ya
13:28:54 sean-k-mooney anyway if you have input on how i should adress this let me know and i can adress it
13:30:31 openstackgerrit Fan Zhang proposed openstack/nova master: Rollback persistent domain xml after DeviceDetachFailed. https://review.opendev.org/692370
13:39:19 efried mriedem: https://zuul.opendev.org/t/openstack/build/aeac2cbd2fc94751a4a5eb7e86b70981/log/logs/subnode-2/screen-n-cpu.txt.gz?severity=4 I don't see anything rbd in any of our requirements files. Does it have another name?
13:45:49 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional test for two-cell scheduler behaviors https://review.opendev.org/452006
13:46:39 mriedem efried: librados
13:46:39 mriedem ?
13:47:05 mriedem it's not on pypi,
13:47:12 efried that neiter
13:47:13 mriedem it's a python lib built from the rbd binary
13:47:14 efried neither
13:47:14 mriedem i think
13:47:44 efried that error is only showing up on the "stop testing with py2" patch and the one above it, per logstash. But I don't see how that patch could have affected that job.
13:48:07 mriedem efried: we should do https://review.opendev.org/#/c/691765/ first then
13:48:10 mriedem in case it's related
13:48:38 mriedem though,
13:48:44 mriedem that's not the job that's failing in the drop py2 change right?
13:49:15 mriedem the nova-live-migration and nova-grenade-multinode jobs have a post-test hook script that sets up ceph
13:49:22 efried correct, but I'll approve that change anyway.
13:49:25 mriedem and those likely aren't setting USE_PYTHON3
13:50:18 mriedem i can wip something up quick to try to move those to py3
13:50:20 efried the other one is failing with a weird PyYAML dep
13:50:34 efried mriedem: stuff it in the pile underneath 'remove py2'?
13:50:38 mriedem yes
13:50:54 mriedem does this call for a "back to the pile" south park reference?!
13:51:14 efried It wasn't intentional. My South Park knowledge is slim
13:51:25 mriedem it's nsfw anyway
13:51:36 efried when have you ever cared about that?
13:51:48 mriedem ...
13:51:59 mriedem i've gotten better after being burned a few times over the years
13:52:10 mriedem despite artom still leaving traps for me
13:52:16 efried The PyYAML thing would be happening earlier than the rbd fail, so it's possible it would have hit the same thing later anyway.
13:52:57 artom mriedem, hey man, I've always had plausible deniability for everything, those traps are in your head
13:53:00 efried but again, I don't see how the 'stop testing py2' patch would have changed anything that would make the hook setup change.
13:53:18 efried the straight man in the comedy duo
13:53:59 openstackgerrit Matt Riedemann proposed openstack/nova master: Convert legacy nova-live-migration and nova-multinode-grenade to py3 https://review.opendev.org/692374
13:54:38 openstackgerrit Matt Riedemann proposed openstack/nova master: Convert legacy nova-live-migration and nova-multinode-grenade to py3 https://review.opendev.org/692374
13:54:52 openstackgerrit Matt Riedemann proposed openstack/nova master: Stop testing Python 2 https://review.opendev.org/687954
13:55:00 mriedem let's see how that works
13:55:11 mriedem mels, then mine, then stephens
13:55:20 efried zuul kicked it
13:55:27 efried nm
13:55:32 efried nova meeting in five minutes
13:57:31 sean-k-mooney efried: that reminds me i need to recheck your os-vif job change.
13:57:40 sean-k-mooney i think the devstack patch should now be merged
13:58:51 sean-k-mooney actully no it faild to merge and is being rechecked so ill wait
14:00:17 efried thanks for keeping track of that sean-k-mooney
14:02:22 sean-k-mooney we should wait until after m1 to merge the os-vif change in anycase but ill keep an eye on it till then
14:09:06 openstackgerrit Matt Riedemann proposed openstack/nova master: Default AZ for instance if cross_az_attach=False and checking from API https://review.opendev.org/469675
14:09:07 mriedem dansmith: updated ^ with a test and fix for a thing alex_xu found (thanks alex)
14:09:19 dansmith I saw
14:10:21 mriedem sean-k-mooney: i want to say this is a duplicate of an existing bug but haven't dug for it, maybe you know? https://bugs.launchpad.net/nova/+bug/1850736
14:10:21 openstack Launchpad bug 1850736 in OpenStack Compute (nova) " MemoryPageSizeInvalid: Invalid memory page size" [Undecided,New]
14:11:35 sean-k-mooney mriedem: i have not looked at that but ill do it now and update it
14:11:58 sean-k-mooney also til packstack is still used...
14:29:42 dansmith oh jeez, today is halloween
14:29:48 dansmith totes forgot
14:43:18 mdbooth sean-k-mooney: My concern with the 'Don't clean anything up because we want to backport it' philosophy is that it means nothing ever gets cleaned up, which means we just end up accumulating duplicated crap. You could move the generic parts of NUMAServersTestNew to a reusable location and it would
14:43:18 mdbooth not impact the backportability of this patch at all.
14:43:55 mriedem dansmith: i don't want to alarm you, but you should probably get to your panic room in the basement soon
14:43:59 mriedem the kids start earlier and earlier
14:44:01 mdbooth At some point you have to clean stuff up. That impacts backports. The alternative is never clean anything up.
14:44:25 mriedem mdbooth: it's not that black and white,
14:44:51 mriedem if you've got 3 refactors leading up to a bug fix that is going to be backported, try to minimize change to make the fix backportable, and stack the refactors on top
14:44:53 dansmith mriedem: remember, my house automatically shuts off all front-facing illumination on 10/31
14:44:58 dansmith it remembered, I didn't
14:45:17 mdbooth dansmith: Nice :)
14:45:56 mriedem the cirros image we're using in the gate (0.4.0) is ~2 years old...
14:46:01 mriedem but there isn't anything newer
14:46:27 efried mriedem: here's that rbd thing http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22RuntimeError%3A%20rbd%20python%20libraries%20not%20found%5C%22

Earlier   Later