Earlier  
Posted Nick Remark
#openstack-nova - 2019-10-30
15:45:38 artom And on fire.
15:46:31 melwitt haha
15:46:33 mriedem you can always bug tonyb https://review.opendev.org/#/admin/groups/540,members
15:47:49 openstackgerrit Eric Fried proposed openstack/nova master: Only allow one scheduler service in tests https://review.opendev.org/682486
15:48:04 melwitt I have learned to greatly appreciate when I have internet access
15:48:39 mriedem my grandpappy always said internet is a privilege not a right
15:49:29 mriedem you know this has to be done: https://southpark.cc.com/clips/x2wsii/is-there-internet-here
15:51:33 melwitt lol
15:51:53 dansmith that's pretty much how I picture california in my head
15:54:17 melwitt that was me driving to different coffee shops and libraries looking for wifi. first three places I tried didn't have internet
15:55:22 melwitt "is there internet here??"
15:55:25 artom melwitt, actually, you might still be on the hook for https://review.opendev.org/#/c/649419/ and the patch above it, looks like dansmith didn't +W
15:55:39 artom Two RH +2s for a non-RH backport is cool, right?
15:55:47 melwitt yeah
15:55:55 dansmith artom: yeah I figured if she was around she'd be hitting it after I'm done
15:56:10 artom I misled her by explicitly told her you'd preempted her
15:56:12 artom Mea culpa
15:56:43 melwitt :)
16:02:12 dansmith mriedem: aren't you respinning the az one to remove the bulk comment? that's why I didn't +2
16:08:18 mriedem dansmith: yeah i will, was busy abandoning old patches from my dashboard
16:15:07 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Reset vm_state to original value if rebuild claim fails https://review.opendev.org/692185
16:19:03 melwitt mriedem: do you remember how is REQUIRES_LOCKING related to NeutronFixture? I couldn't find a note about it in nova/test.py https://review.opendev.org/649419
16:21:08 mriedem melwitt: i think it's related to https://review.opendev.org/#/c/649385/ and how if you're using nova-net you have to require locking b/c of the network manager
16:21:13 mriedem but it's been a long time since i did that backport
16:21:27 melwitt ok, was just curious
16:22:32 openstackgerrit Matt Riedemann proposed openstack/nova master: Default AZ for instance if cross_az_attach=False and checking from API https://review.opendev.org/469675
16:22:33 mriedem dansmith: ^
16:46:12 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691
16:46:18 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213
16:57:21 AJaeger nova stable cores, please review https://review.opendev.org/692032 to update train opensuse job so that Infra can retire openSUSE 15.0
17:09:21 mriedem done
17:17:05 openstackgerrit Matt Riedemann proposed openstack/nova master: Reset vm_state to original value if rebuild claim fails https://review.opendev.org/692185
17:18:13 artom melwitt, dansmith thanks you folks for the backport reviews!
18:09:26 mriedem dansmith: i think i found a justification for https://review.opendev.org/#/c/669545/ now - https://bugs.launchpad.net/nova/+bug/1850682
18:09:26 openstack Launchpad bug 1850682 in OpenStack Compute (nova) "functional tests in rocky randomly fail with "Build of instance was re-scheduled: Cannot modify readonly field uuid"" [Undecided,New]
18:10:10 dansmith aight
18:10:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Nova compute: add in log exception to help debug failures https://review.opendev.org/669545
18:18:03 openstackgerrit Eric Fried proposed openstack/nova master: Use annotated ddt for test_cpu_policy_constraint https://review.opendev.org/692205
18:19:03 artom Some sort of timeout
18:19:14 artom And their stupid interface means hitting the back button loses all you bug text
18:19:38 artom It's still saved by firefox as part of the POST request though, so if I just keep hitting refresh and re-sending...
18:22:17 openstackgerrit Artom Lifshitz proposed openstack/nova master: Avoid error 500 on shelve task_state race https://review.opendev.org/692206
18:24:13 artom There we go
18:24:18 artom mdbooth, sean-k-mooney ^^ keep me honest
18:24:27 artom There was a definite lack of hairy tentacles
18:24:31 artom Did I miss something?
18:30:02 mriedem artom: yeah just refresh on lp until it goes through
18:31:22 AJaeger thanks, mriedem
18:34:40 mriedem artom: question on your patch
18:41:44 artom mriedem, cheers, replied
18:43:13 artom (To one of the things, at any rate)
18:44:30 mriedem yeah, this is just whack a mole
18:44:35 mriedem which i'm not really against but
18:45:00 mriedem we could also just have a generic decorator in the api methods that handles this exception and returns HTTPConflict so we don't have to do the dance in the wsgi controller route handler code
18:45:32 artom Yep
18:45:48 artom I wasn't aware of the widespreaded-ness of this
18:45:59 artom Such a decorator would also remain backportable
18:46:52 mriedem yeah and no maybe,
18:46:59 mriedem not all route handlers have 409 in their @wsgi.expected_errors((404, 409)) decorator
18:47:13 mriedem i don't know how much that matters honestly - i wouldn't be surprised if we leak things through in some cases
18:47:44 artom We could always do the wait and see thing
18:47:55 artom Wack this mole, and if another mole pops up, think about a more generic appraoch
18:48:23 mriedem that's what i'd probably do
18:48:28 mriedem no point overengineering this now
18:48:35 artom Ack
19:00:13 umbSublime Is there any reference documentation to help fill up a new blueprint (to avoid wasting peoples time)
19:03:03 mriedem umbSublime: https://docs.openstack.org/nova/latest/contributor/blueprints.html
19:14:17 efried mriedem: added comment as requested to https://review.opendev.org/#/c/682486/ and gibi is +2, wanna send it?
19:15:16 mriedem hmmm, maybe
19:15:37 dansmith cah-ripes
19:15:57 dansmith change failed in the gate and rechecked 4.5h ago, still hasn't started a single job.
19:16:07 mriedem the gate is not happy
19:16:15 mriedem buttloads of ssh fails in guests for different reasons,
19:16:23 mriedem the timed out talking to cell db thing,
19:16:28 mriedem https read timeout errors
19:16:46 artom b'Expected: save(expected_tast_state=[None])'
19:16:46 artom b'Actual: save(expected_task_state=[None])'
19:16:48 artom *sigh*
19:16:56 artom Oh!
19:19:43 openstackgerrit Artom Lifshitz proposed openstack/nova master: Avoid error 500 on shelve task_state race https://review.opendev.org/692206
19:28:26 openstackgerrit Merged openstack/nova master: api-ref: remove mention about os-migrations no longer being extended https://review.opendev.org/682102
19:32:46 efried mriedem: are there other projects that are running tempest-slow that could stop doing that, similar to https://review.opendev.org/683988 ?
19:36:59 mriedem efried: don't know
19:43:30 mriedem efried: i'd like to remove that part of the comment that gibi pointed out and then approve, is that ok with you?
19:43:47 efried sure
19:44:19 openstackgerrit Matt Riedemann proposed openstack/nova master: Only allow one scheduler service in tests https://review.opendev.org/682486
19:54:59 openstackgerrit Merged openstack/nova master: Refactor volume connection cleanup out of _post_live_migration https://review.opendev.org/682741
19:55:05 openstackgerrit Merged openstack/nova master: Move pre-3.44 Cinder post live migration test to test_compute_mgr https://review.opendev.org/683597
19:57:30 openstackgerrit Matt Riedemann proposed openstack/nova master: Avoid error 500 on shelve task_state race https://review.opendev.org/692206
20:52:21 dansmith efried: asking because I think I've seen some notes from you around this code in the past,
20:52:41 dansmith but do you have strong opinions on what we should do if we have, say, three glance endpoints and we get an error from one trying to do something?
20:52:57 efried dansmith: we should not have three glance endpoints
20:52:57 dansmith looks like we round-robin the available endpoints, but don't move onto the next one after a failure
20:53:09 efried unless you mean three interfaces
20:53:20 dansmith efried: three urls
20:53:23 efried f, did we not get rid of that api_servers thing yet?
20:53:25 efried stand by
20:53:35 dansmith no, the round-robin-ing you mean? that's still there
20:54:10 dansmith I honestly thought that we had pushed responsibility for that down into the glance client, but ... the round-robin stuff is there
20:54:12 efried omg we haven't even deprecated it yet!

Earlier   Later