| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-10-28 | |||
| 14:50:47 | dansmith | haha | |
| 14:50:57 | dansmith | gibi: thanks | |
| 14:51:25 | gibi | dansmith: I'm +2 now | |
| 14:51:34 | dansmith | thanks! | |
| 14:51:39 | gibi | dansmith: thank you for not waiting for me to write these patches :) | |
| 14:53:19 | dansmith | heh, well, this was definitely a learning moment for me.. I (like many) have just depended on you to do all of this in the past, | |
| 14:53:26 | dansmith | so "glad" to have the opportunity | |
| 14:53:51 | gibi | I'm glad that I'm not alone in this boat any more :) | |
| 14:54:20 | mriedem | gmann: i noticed that the tempest-integrated-compute job is running volume API tests - https://openstack.fortnebula.com:13808/v1/AUTH_e8fd161dc34c421a979a9e6421f823e9/zuul_opendev_logs_3dc/691129/2/gate/tempest-integrated-compute/3dcc0e0/testr_results.html.gz - is there a reason for that? those are cinder-only so i'm not sure why they are part of that job | |
| 14:55:19 | mriedem | it's also running glance and neutron api tests | |
| 15:01:43 | gibi | mriedem: I cannot reproduce your functional test api db leak locally | |
| 15:02:58 | gibi | mriedem: both test case order passes to me | |
| 15:03:23 | mriedem | gibi: yeah same on master, train and stein but 100% reproducible on rocky with https://review.opendev.org/#/c/690720/ | |
| 15:03:28 | mriedem | i'm not sure what changed in stein | |
| 15:03:39 | gibi | mriedem: ohh, then I will check on rocky | |
| 15:05:12 | mriedem | it looks like the leaked instances are coming from cell0 | |
| 15:05:13 | mriedem | which is odd | |
| 15:36:50 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Add functional regression test for bug 1849409 https://review.opendev.org/690720 | |
| 15:36:50 | openstack | bug 1849409 in OpenStack Compute (nova) rocky "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem) | |
| 15:36:50 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Fix listing deleted servers with a marker https://review.opendev.org/690721 | |
| 15:37:20 | mriedem | i just worked around it, can't figure it out, tried a bunch of different thigns | |
| 15:37:22 | mriedem | *things | |
| 15:38:35 | openstackgerrit | Merged openstack/nova master: Added openssh-client into bindep https://review.opendev.org/690482 | |
| 15:40:09 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add new policy rule for viewing host status UNKNOWN https://review.opendev.org/679181 | |
| 15:40:09 | smcginnis | mriedem: Did you have a list of which of the outstanding patches were needed before switching nova stable/queens to EM? | |
| 15:41:38 | mriedem | i think i'm just trying to get https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/queens+topic:bug/183358 , https://review.opendev.org/#/c/687058/, https://review.opendev.org/#/c/688090/ , | |
| 15:41:51 | mriedem | https://review.opendev.org/#/c/691283/ would be nice but has to be updated and land in stein first | |
| 15:42:01 | smcginnis | Dang, that's a lot. | |
| 15:42:27 | mriedem | gibi: how much do you care that https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/queens+topic:bug/183358 gets released in the final queens release? | |
| 15:42:39 | mriedem | you're really targeting pike right? so maybe you don't care that those get into the final queens release | |
| 15:42:45 | gibi | mriedem, smcginnis: from my perspective https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/queens+topic:bug/183358 is not super important in the last release as I need it in pike as well where there is no more releases | |
| 15:42:58 | mriedem | ok yeah so let's ignore those for queens final release | |
| 15:43:02 | smcginnis | Can still get merged, but just not able to be in an official release after the cutover. | |
| 15:43:04 | gibi | mriedem: agree | |
| 15:43:12 | smcginnis | Thanks gibi. | |
| 15:43:16 | gibi | smcginnis: sure | |
| 15:43:36 | mriedem | so https://review.opendev.org/#/c/688090/ just needs a +W | |
| 15:43:54 | smcginnis | Just reviewed it. | |
| 15:43:55 | mriedem | as does https://review.opendev.org/#/c/691282/ (stein) and then i can re-cherry-pick that to queens and approve it | |
| 15:43:57 | dansmith | mriedem: you need me to hit somequeens things? | |
| 15:44:06 | mriedem | sorting it out | |
| 15:46:04 | mriedem | lyarwood: do you want to take a pass at this queens one again? https://review.opendev.org/#/c/676285/ - i addressed the comment | |
| 15:47:01 | mriedem | beyond that i say we just punt on everything else for the final queens release | |
| 15:49:02 | mriedem | smcginnis: so i guess just these three and then we're ready https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/queens+label:Code-Review=2 | |
| 15:49:43 | smcginnis | Awesome, thanks! | |
| 16:09:53 | gmann | mriedem: reason to run them was, current API tests are mixed with single API operation and multiple service API operation like - https://github.com/openstack/tempest/blob/master/tempest/api/volume/test_volumes_actions.py#L39 | |
| 16:10:21 | gmann | mriedem: so i thought of running them to avoid any coverage miss. glance API tests we can remove I think. | |
| 16:10:53 | mriedem | i would assume volume attach is covered in an existing compute api test | |
| 16:14:20 | gmann | this is example, either we have to go with case by case and take care that new tests etc are added in scenario only but that is difficult. | |
| 16:14:31 | mriedem | yeah i understand | |
| 16:14:58 | gmann | i can try to run with related tests where 'compute' service is added for non-compute folder tests (hoping we tag them correctly ) | |
| 16:15:42 | gmann | that way we can run only compute related test only | |
| 16:38:14 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Add functional regression test for bug 1849409 https://review.opendev.org/690720 | |
| 16:38:14 | openstack | bug 1849409 in OpenStack Compute (nova) rocky "openstack server list --deleted --limit -1 hangs" [High,In progress] https://launchpad.net/bugs/1849409 - Assigned to Matt Riedemann (mriedem) | |
| 16:38:14 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Fix listing deleted servers with a marker https://review.opendev.org/690721 | |
| 18:16:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: add troubleshooting guide for cleaning up orphaned allocations https://review.opendev.org/691427 | |
| 18:20:59 | openstackgerrit | Merged openstack/nova stable/queens: Fix exception translation when creating volume https://review.opendev.org/688090 | |
| 18:23:51 | mriedem | dansmith: looking for another stable core on this queens backport https://review.opendev.org/#/c/676285/ | |
| 18:33:33 | melwitt | it's another nomadic wifi week. both starbucks nearest me have no internet either. had to go farther out | |
| 18:36:23 | artom | By virtue of being I assume the fires aren't affecting you too much. Must stil suck tho. | |
| 18:39:15 | melwitt | artom: yeah, I'm in the santa cruz mountains. the current fire in norcal is up in sonoma, pretty far from here, few hours drive | |
| 18:40:57 | melwitt | pg&e has been proactively shutting off power to lots of areas, mine is always included in that. our comcast doesn't have generators so no internet in the area even though we have a generator | |
| 18:41:09 | artom | I remember we had forest fires up north, and the winds blew the smoke down here. Weirdly eery... Weak orange sun, everything out of focus | |
| 18:42:03 | artom | That sucks :( That means no hot water and heating too? | |
| 18:42:38 | melwitt | yeah, there was a lot of that last year. didn't get as far south as santa cruz area but the main bay area looked like apocalypse sky | |
| 18:43:21 | melwitt | we have hot water thankfully, that's on propane | |
| 18:43:50 | artom | That's a relief | |
| 18:44:00 | melwitt | yeah, that's kind of my main thing I need is hot water heh | |
| 18:44:13 | artom | Dammit I have a dead pixel right below by blinking IRC cursor | |
| 18:44:47 | melwitt | :( | |
| 18:45:09 | artom | Yeah, being able to take shower is a massive plus | |
| 19:09:57 | efried | gmann: Can you please make the file path match the bp name for policy-defaults-refresh ? | |
| 19:10:14 | efried | If you want to pull https://review.opendev.org/#/c/686058/ out of the gate I'll fast approve it. Or you can put another on top. | |
| 19:10:39 | efried | looks like it was mismatched for train as well :( | |
| 19:10:48 | efried | I thought we had some kind of build check for that. | |
| 19:12:17 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: Re-propose policy-defaults-refresh spec for Ussuri https://review.opendev.org/686058 | |
| 19:12:33 | melwitt | I put a check for that into the count_blueprints script, but other than that, I don't know of anything that checks it | |
| 19:12:50 | efried | okay. | |
| 19:13:05 | efried | I made the change, to save having to add a redirect as well --^ | |
| 19:13:13 | melwitt | cool | |
| 19:15:36 | gmann | efried: ah, thanks for update. | |
| 19:15:43 | efried | yahyoubetcha. | |
| 19:34:54 | openstackgerrit | Merged openstack/nova-specs master: Re-propose policy-defaults-refresh spec for Ussuri https://review.opendev.org/686058 | |
| 19:38:40 | mriedem | move_implemented_specs checks for mismatching filenames to blueprint names, | |
| 19:38:44 | mriedem | but there is no pep8 check for it | |
| 19:51:28 | mriedem | dansmith: i'm open to discussion on some of the things in https://review.opendev.org/#/c/688173/ | |
| 19:51:36 | mriedem | but we should at least have *some* test for some of that i think | |
| 19:55:38 | dansmith | mriedem: s'all good. as I said, I care more about the next patch in line and just built that one on top of this because it was structured properly, but never really got around to doing anything here | |
| 19:56:01 | dansmith | then this morning gibi had +2d everything and I fixed his nits in the top patch not really thinking about it | |
| 19:56:19 | dansmith | so I'll add some more tests to the middle one, probably in the morning | |
| 19:56:30 | dansmith | if you could review the next patch so I have all of that feedback together, that'd be cool | |
| 20:00:45 | mriedem | conditions.....ugh.... | |
| 20:00:54 | mriedem | but i wanted to move onto my next todo which was staring at this wall | |
| 20:07:38 | openstackgerrit | Merged openstack/nova master: Add notification sample test for aggregate.cache_images.start|end https://review.opendev.org/691129 | |
| 20:16:10 | mriedem | dansmith: ok reviewed the top as well | |
| 20:34:52 | openstackgerrit | Merged openstack/nova stable/queens: rt: only map compute node if we created it https://review.opendev.org/676285 | |
| 20:45:25 | dansmith | mriedem: thanks | |
| 22:26:29 | openstackgerrit | melanie witt proposed openstack/nova master: Switch to devstack-plugin-ceph-tempest-py3 for ceph https://review.opendev.org/691765 | |
| 22:29:06 | openstackgerrit | melanie witt proposed openstack/nova master: Switch to devstack-plugin-ceph-tempest-py3 for ceph https://review.opendev.org/691765 | |
| 22:33:26 | openstackgerrit | melanie witt proposed openstack/nova master: Switch to devstack-plugin-ceph-tempest-py3 for ceph https://review.opendev.org/691765 | |