| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-10-25 | |||
| 16:19:32 | mriedem | *those* people | |
| 16:19:35 | openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Integrating with unified limits https://review.opendev.org/615180 | |
| 16:19:51 | cdent | them | |
| 16:24:10 | mriedem | blarg, yeah we have doc/requirements.txt but https://review.opendev.org/#/c/689152/ threw requirements.txt back into the install for the docs job | |
| 16:24:11 | mriedem | fixing | |
| 16:26:36 | openstackgerrit | Dan Smith proposed openstack/nova master: Log some stats for image pre-cache https://review.opendev.org/688173 | |
| 16:26:37 | openstackgerrit | Dan Smith proposed openstack/nova master: Add Aggregate image caching progress notifications https://review.opendev.org/691390 | |
| 16:29:03 | mriedem | https://bugs.launchpad.net/nova/+bug/1849870 | |
| 16:29:03 | openstack | Launchpad bug 1849870 in OpenStack Compute (nova) "docs build failing on psycopg2 dependency" [Undecided,New] | |
| 16:39:42 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Stop building docs with (test-)requirements.txt https://review.opendev.org/691391 | |
| 16:39:43 | mriedem | ^ will hopefully unblock the gate for nova ^ | |
| 16:41:48 | dansmith | mriedem: should we slam that in? | |
| 16:42:11 | mriedem | let's see if it passes the docs job first, it works for me locally | |
| 16:42:17 | mriedem | guess it could take awhile to get a node... | |
| 16:42:22 | dansmith | okay | |
| 16:42:35 | mriedem | oh it got a node http://zuul.openstack.org/stream/63d6bbd171134e00877ae6ce61856a84?logfile=console.log | |
| 16:42:42 | mriedem | build baby build! | |
| 16:47:39 | mriedem | dansmith: looks like it passed so you can commence to slamming | |
| 16:48:04 | dansmith | mriedem: you going to fix the typo? | |
| 16:48:21 | mriedem | sure, sec | |
| 16:48:22 | dansmith | or just clarifying for review? | |
| 16:48:25 | dansmith | ack | |
| 16:49:03 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Stop building docs with (test-)requirements.txt https://review.opendev.org/691391 | |
| 16:50:32 | openstackgerrit | Dan Smith proposed openstack/nova master: Add Aggregate image caching progress notifications https://review.opendev.org/691390 | |
| 17:00:44 | mriedem | melwitt: were you going to backport https://review.opendev.org/#/c/688206/ and the one below it? | |
| 17:00:55 | mriedem | i'm planning a train release next week so probably good to get that in it | |
| 17:01:14 | melwitt | mriedem: yes. I wasn't sure if I should wait for the top patch to merge first before proposing | |
| 17:01:28 | mriedem | i don't think you need to wait | |
| 17:01:33 | melwitt | ok | |
| 17:09:25 | dansmith | mriedem: what's the trick for generating the notification samples? | |
| 17:32:48 | mriedem | you have to create them manually | |
| 17:33:02 | mriedem | the json file i mean | |
| 17:33:18 | dansmith | WAT | |
| 17:33:50 | mriedem | all sales are final | |
| 17:35:00 | dansmith | if I add this is there something that will check my work? | |
| 17:35:26 | mriedem | the functional test should be comparing against the sample | |
| 17:35:39 | dansmith | oh if I write that test okay | |
| 17:36:04 | dansmith | I should rebase mine on yours I guess | |
| 17:36:05 | mriedem | yeah so instead of this https://review.opendev.org/#/c/691390/2/nova/tests/functional/compute/test_cache_image.py | |
| 17:36:08 | mriedem | right | |
| 17:36:17 | dansmith | not instead, in addition right? | |
| 17:36:26 | mriedem | i don't see why we'd need both | |
| 17:37:01 | dansmith | because it already has the error case and other-agg case | |
| 17:37:04 | mriedem | this is where the test in mine validates the sample against the actual notification generated by the test https://review.opendev.org/#/c/691129/1/nova/tests/functional/notification_sample_tests/test_aggregate.py@199 | |
| 17:37:28 | mriedem | oh yeah ok that makes sense | |
| 17:39:22 | openstackgerrit | Merged openstack/nova stable/train: libvirt: Ignore volume exceptions during post_live_migration https://review.opendev.org/691281 | |
| 17:40:25 | openstackgerrit | melanie witt proposed openstack/nova stable/train: Add regression test for bug 1824435 https://review.opendev.org/691402 | |
| 17:40:25 | openstack | bug 1824435 in OpenStack Compute (nova) "fill_virtual_interface_list migration fails on second attempt" [Medium,In progress] https://launchpad.net/bugs/1824435 - Assigned to melanie witt (melwitt) | |
| 17:40:25 | openstackgerrit | melanie witt proposed openstack/nova stable/train: Remove redundant call to get/create default security group https://review.opendev.org/691403 | |
| 17:43:35 | openstackgerrit | Merged openstack/nova stable/queens: Fix unit of hw_rng:rate_period https://review.opendev.org/689155 | |
| 17:50:56 | dansmith | mriedem: I don't really understand why we specify the payload in a file, but also some fields of the payload to verify in the doc schema file or whatever | |
| 17:51:25 | dansmith | mriedem: this stuff: https://review.opendev.org/#/c/691129/1/doc/notification_samples/aggregate-cache_images-end.json@5 | |
| 18:04:56 | openstackgerrit | Dan Smith proposed openstack/nova master: Add notification sample test for aggregate.cache_images.start|end https://review.opendev.org/691129 | |
| 18:04:56 | openstackgerrit | Dan Smith proposed openstack/nova master: Log some stats for image pre-cache https://review.opendev.org/688173 | |
| 18:04:57 | openstackgerrit | Dan Smith proposed openstack/nova master: Add Aggregate image caching progress notifications https://review.opendev.org/691390 | |
| 18:21:45 | openstackgerrit | Merged openstack/nova master: Stop building docs with (test-)requirements.txt https://review.opendev.org/691391 | |
| 18:21:55 | mriedem | dansmith: that's an override for what's in the common file | |
| 18:22:06 | mriedem | otherwise you just get what's in "$ref": "common_payloads/AggregatePayload.json#", | |
| 18:22:30 | dansmith | so I can just put my stuff in the common file? I mean, that seemed to work fine, but didn't know if it wasn't "right" | |
| 18:23:11 | dansmith | if so, the rev I just pushed may be acceptable then | |
| 18:24:45 | mriedem | it's a little weird to have that much stuff in the common file but not necessarily wrong, the only field you override is the host one | |
| 18:25:03 | mriedem | i'd probably just leave it until we have more samples that re-use the common payload and it no longer makes sense, | |
| 18:25:13 | mriedem | er yeah, that's it | |
| 18:25:24 | dansmith | yeah, I mean, doesn't seem like much point unless you need to sub things | |
| 18:33:42 | openstackgerrit | Eric Fried proposed openstack/python-novaclient master: Stop supporting and testing python2 https://review.opendev.org/691365 | |
| 18:56:31 | openstackgerrit | Eric Fried proposed openstack/os-vif master: Drop python2 support and testing https://review.opendev.org/691364 | |
| 19:00:06 | openstackgerrit | Eric Fried proposed openstack/os-vif master: Drop python2 support and testing https://review.opendev.org/691364 | |
| 19:00:44 | openstackgerrit | Eric Fried proposed openstack/os-vif master: Drop python2 support and testing https://review.opendev.org/691364 | |
| 19:10:56 | melwitt | I dunno if anyone is looking at the docs job failure yet, looks like psycopg missing libpq-dev package? https://zuul.opendev.org/t/openstack/build/57fdb73f89084fa9b845561ec724e11d/log/job-output.txt#664 | |
| 19:11:37 | dansmith | pretty sure mriedem already had a fix up for that | |
| 19:11:55 | efried | yeah, it merged | |
| 19:12:03 | efried | https://review.opendev.org/#/c/691391/2 | |
| 19:12:17 | efried | you fast approved it dansmith :P "pretty sure" indeed. | |
| 19:12:36 | dansmith | efried: I didn't look at her link before answering, hence my pretty sure | |
| 19:27:42 | melwitt | oh ok, I missed the discussion and didn't see an ML thread | |
| 19:28:32 | melwitt | glad it's fixed | |
| 19:42:03 | mriedem | we SEV1 IPL'ed that APAR | |
| 19:43:10 | mriedem | efried: those py2 removal patches are going to be the end of one of us | |
| 19:43:48 | efried | mriedem: I figured there would be some churn. I'm a zuul dunce to begin with. | |
| 19:44:11 | efried | but I feel like we're ahead of the game anyway, we've got months to get it sorted. | |
| 19:44:42 | mriedem | way to jinx yourself | |
| 19:47:40 | openstackgerrit | Eric Fried proposed openstack/os-vif master: Drop python2 support and testing https://review.opendev.org/691364 | |
| 19:51:02 | melwitt | IPL and APAR, had to google those | |
| 19:57:58 | efried | mriedem: join us in -release if you please? | |
| 19:58:42 | looking4somethin | yes | |
| 19:59:01 | looking4somethin | mriedem are you talking to me? | |
| 20:01:00 | efried | looking4somethin: sorry, you arrived in the middle of a conversation | |
| 20:01:26 | looking4somethin | awesome! | |
| 20:02:04 | efried | looking4somethin: Have you tried randomizing your placement allocation candidates? | |
| 20:02:23 | efried | landing on one compute isn't really a bug | |
| 20:02:40 | efried | I can't remember if we pack or spread by default -- dansmith? | |
| 20:02:47 | looking4somethin | not really | |
| 20:02:51 | looking4somethin | how can I do it. | |
| 20:03:11 | melwitt | efried: pack is default | |
| 20:03:28 | efried | looking4somethin: there you go ^ so by default you'll go to one compute until it's "full". | |
| 20:03:43 | efried | If you prefer to spread, you can do things with weighers. | |
| 20:04:01 | melwitt | you need to adjust some config options if you would prefer VMs to spread first onto compute hosts | |
| 20:04:32 | looking4somethin | that's it then. however I have observed some spreading previously but right now one compute is getting everything. | |
| 20:05:52 | melwitt | you can use https://docs.openstack.org/nova/rocky/configuration/config.html#placement.randomize_allocation_candidates to have placement randomize the computes it returns to nova | |
| 20:06:17 | melwitt | you can use https://docs.openstack.org/nova/rocky/configuration/config.html#filter_scheduler.host_subset_size to make nova choose randomly from a larger subset of hosts | |