Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-10-10
15:27:06 mriedem i bet efried would know off the top of his head since he was just ripping that out
15:27:25 dansmith I was going to ping him until I saw the code was really old
15:27:43 dansmith but yeah
15:27:45 mriedem is that using the admin_api or api?
15:27:56 dansmith admin, but just like the test I subclassed, which runs fine
15:27:59 mriedem i wouldn't expect a keyerror though, i'd expect a 403
15:28:11 mriedem is that code up or still local?
15:29:00 efried dansmith: unless you have https://review.opendev.org/#/c/687416/ or above in your sandbox...
15:29:06 dansmith I wonder if it's because I'm doing the microversion wrong, hang on.. just realized the parent doesn't have a dot in the version
15:29:20 mriedem yeah so if the api fixture was created with version v2,
15:29:24 mriedem and you're passing a microversion header,
15:29:29 mriedem i'd think something is going to blow up there
15:29:32 dansmith yeah, that's it.. so in here: https://review.opendev.org/#/c/687140/5/nova/tests/functional/test_aggregates.py
15:29:39 mriedem yar
15:29:49 dansmith I misread it as api_version and effectively changed v2 to v2.80 and it explodes that obscure way
15:30:38 dansmith am I supposed to be able to set api_major_version='v2.80' ?
15:31:14 mriedem no
15:31:20 mriedem it's the thing that goes into the fixture init
15:31:24 mriedem either v2 or v2.1
15:31:52 mriedem https://review.opendev.org/#/c/687140/6/nova/tests/functional/integrated_helpers.py@437
15:31:55 dansmith cool, well I have confirmed that it's failing as expected (I guess ;D)
15:32:34 dansmith okay, microversion= works, got it
15:32:46 dansmith a teensy bit obscure in the failure mode
15:33:12 mriedem obviously the fixture or TestOpenStackClient or whatever could detect that you're trying to send a microversion header to a v2(.0) route and blow up in a more obvious way
15:33:17 efried what I can contribute to the conversation is, if you see x-server-management-url in a traceback, it's breaking in test code, nothing to do with real life.
15:33:48 efried the microversion and api_major_version class members are for template substitutions afaiu
15:33:58 mriedem hells nah
15:34:01 efried the latter also used to construct the auth url
15:34:04 mriedem they are for the api fixture and resulting client
15:34:22 dansmith efried: yeah I know it's just test stuff
15:34:31 efried if you want to send a request at a specific microversion, I think you still need to use a kwarg to your API method.
15:34:49 mriedem well,
15:34:54 mriedem the api fixture client stuff handles that
15:35:16 mriedem self.api = self.useFixture(nova_fixtures.OSAPIFixture('v2.1')).api
15:35:24 mriedem self.api.microversion = '2.80'
15:35:26 mriedem something like that
15:35:27 efried oh, I guess the fixture also uses the microversion as the default if you don't specify a kwarg.
15:35:32 mriedem correct
15:36:22 efried the aforementioned series rips some of that magic out of the test-only paths so it happens more like it would in real life. But I don't think what you're doing would be affected (other than to fail differently if you f it up)
15:48:50 openstackgerrit Dan Smith proposed openstack/nova master: Add cache_images() to conductor https://review.opendev.org/687139
15:48:51 openstackgerrit Dan Smith proposed openstack/nova master: Add image caching API for aggregates https://review.opendev.org/687140
15:48:51 openstackgerrit Dan Smith proposed openstack/nova master: WIP: Add image precaching docs for aggregates https://review.opendev.org/687348
15:49:14 dansmith mriedem: okay, conductor/api now lets non-nova exceptions up to the top
15:50:20 dansmith I didn't even really try on the release note, because I bet you're going to want all kinds of fancy links to docs and stuff, which don't exist until the next patch
15:50:30 dansmith so I figure I'll take my -1 on that :P
15:51:59 mriedem i think i said something to the effect of we can add a release note for the new route and microversoin and config option and in the docs patch update the release note to link to the docs for more details, i.e. keep the reno short and sweet
15:52:16 dansmith cool, well, then it may work after all :)
15:54:53 mriedem ok i left a comment in there, but haven't gone over everything again yet
15:55:17 dansmith s'fine, let me begrudgingly add your requested comments before you hit it up again anyway
15:59:46 openstackgerrit Dan Smith proposed openstack/nova master: Add cache_image() driver method and libvirt implementation https://review.opendev.org/687137
15:59:46 openstackgerrit Dan Smith proposed openstack/nova master: Add cache_image() support to the compute/{rpcapi,api,manager} https://review.opendev.org/687138
15:59:47 openstackgerrit Dan Smith proposed openstack/nova master: Add cache_images() to conductor https://review.opendev.org/687139
15:59:47 openstackgerrit Dan Smith proposed openstack/nova master: Add image caching API for aggregates https://review.opendev.org/687140
15:59:48 openstackgerrit Dan Smith proposed openstack/nova master: WIP: Add image precaching docs for aggregates https://review.opendev.org/687348
15:59:52 dansmith word salad baby
16:02:25 mriedem ok +2 on the bottom 2 changes, i'll get to conductor and the api after lunch
16:03:00 dansmith sha-wing
16:10:00 mloza Hi. I have this issue with nova conductor where instances are stuck creating. This happened after I did a re-ip of the machines. Other nova services except conductor. This is the log https://clbin.com/pErEA
16:11:05 dansmith mloza: if the ip of your rabbit changed you probably need to update your cell mappings
16:11:10 mriedem lyarwood: i've left a few thoughts on https://review.opendev.org/#/c/682594/
16:11:14 dansmith mloza: nova-manage cell_v2 update_cell
16:11:14 mriedem lyarwood: two things:
16:11:17 dansmith mloza: also, please see topic
16:11:29 mriedem 1. seems we could workaround the instance uuid lock causing MessagingTimeout by using the long_rpc_timeout on that rpc call,
16:11:46 mriedem 2. your cleanup in the api is best effort - might not catch all cases but it's worth a try, yeah?
16:12:02 lyarwood mriedem: yup sorry just working my way towards this
16:12:21 lyarwood mriedem: 1. nice idea, yeah that would be useful, 2. yes it's just best effort
16:12:29 mriedem 3. long-term we should create the bdm in the api, pass it down to compute, and then delete in api if we hit a failure
16:12:45 mriedem i.e. implement vishy's todo from like 2012
16:12:54 lyarwood mriedem: yeah just read that comment, yup that would be much much cleaner
16:12:58 mriedem but 3 is not backportable
16:13:02 lyarwood mriedem: both something to do on top of this
16:13:09 mriedem and with that i'm away!
16:13:10 lyarwood mriedem: as I'd like to backport this best effort approach
16:13:16 lyarwood enjoy
16:13:19 mriedem_lunch <3
16:16:49 mloza dansmith: I forgot about that. I updated the cell mappings. Thanks
16:39:18 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: Stop testing Python 2 https://review.opendev.org/687954
17:06:26 openstackgerrit sean mooney proposed openstack/nova master: [WIP] block rebuild when numa toplogy changed https://review.opendev.org/687957
17:54:32 openstackgerrit Lee Yarwood proposed openstack/nova master: Helper to start computes with different HostInfos https://review.opendev.org/686832
17:54:34 openstackgerrit Lee Yarwood proposed openstack/nova master: Add regression test for bug #1843639 https://review.opendev.org/682621
17:54:34 openstack bug 1843639 in OpenStack Compute (nova) "libvirt: post_live_migration failures to disconnect volumes result in the rollback of live migrations" [Medium,In progress] https://launchpad.net/bugs/1843639 - Assigned to Lee Yarwood (lyarwood)
17:54:34 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Ignore volume exceptions during post_live_migration https://review.opendev.org/682622
17:56:10 lyarwood artom: ^ my bad, I didn't mean to rebase your change there, sorry.
18:00:19 efried mriedem, dansmith, et al. I need to take the rest of the day off, and probably tomorrow too. Can someone run the meeting this afternoon?
18:00:23 mriedem efried: a question in https://review.opendev.org/#/c/687416/5
18:00:37 mriedem efried: i have to leave early during the meeting (parent/teacher conferences)
18:00:44 mriedem maybe melwitt can run it?
18:01:04 efried The p.m. ones have been really sparse lately anyway, maybe just cancel and pick up next week.
18:01:21 dansmith efried: I'mma be gone today by the time of the meeting
18:01:26 mriedem there is quite a few things in open discussion,
18:01:35 mriedem but if we don't have a quorum then i'm not sure it's worth having...
18:01:40 efried right, exactly
18:01:45 efried I wanted to be present to discuss those things.
18:01:47 dansmith efried: fwiw, the early meeting is pretty much not doable for people in PDT
18:01:53 efried mm
18:02:07 mriedem ML or bust i guess
18:02:21 efried yeah, I'll cancel via ML.
18:06:42 mriedem dansmith: https://review.opendev.org/#/c/687139/ is failing a unit test
18:06:45 mriedem https://storage.gra1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_543/687139/7/check/openstack-tox-py36/5432a3a/testr_results.html.gz

Earlier   Later