Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-10-08
21:31:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove dead reserve_volume compat code in _validate_bdm https://review.opendev.org/687427
21:42:08 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove Stein compute compat checks for volume type support https://review.opendev.org/687428
21:48:45 mriedem this is a good easy fix https://review.opendev.org/#/c/678991/
21:54:11 ceryx mriedem: I'm the colleague eandersson mentioned. https://elixir.bootlin.com/linux/v3.10/source/drivers/net/tun.c#L115 has the cap set to 8, but that same file from the centos source RPM for that kernel version is https://pastebin.com/2415QjTW. Unsure what version they changed that in though.
21:55:25 ceryx but they set '#define MAX_TAP_QUEUES 256
21:55:26 ceryx ' rather than DEFAULT_MAX_NUM_RSS_QUEUES (which is still set to 8 in the rhel/centos version)
21:56:37 mriedem ok, i guess that's the question
21:57:09 mriedem and if it's a centos only patch then it's pretty hard to have a condition in nova for that
22:01:29 kosa777777 I am also the colleague of eandersson and ceryx, how about having option to set it to certain number on compute itself if operator chooses to not rely on default?
22:03:02 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Pre-validate volumes for cross_az_attach=False during create https://review.opendev.org/687430
22:03:54 mriedem kosa777777: i'd prefer not having options like that but not sure what others think - maybe start by reporting a bug and taking it from there
22:05:29 ceryx I checked through the centos kernel versions up through 7.7 and they all have that driver hard-coded to #define MAX_TAP_QUEUES 256 :/
22:05:57 mriedem can you do a git blame and find out the change that patched it?
22:11:22 kosa777777 also "platform.linux_distribution()" would determine if it is CentOS, if that is needed to distinguish Ubuntu from Centos
22:14:55 mriedem let's start with a reported bug with options and discuss there - there could be a [workarounds] group option if people are ok with that
22:17:56 eandersson Yea sounds good
22:26:43 kosa777777 great
22:29:35 eandersson mriedem, do you happen to have an estimate on when we could get an initial version of the backport for making restating computes safe :P
22:29:57 eandersson I could probably take a stab at it, but last time the number of differences between the master and rocky code base was pretty overwhelming
22:30:57 mriedem it starts in train which GAs on oct 17 https://wiki.openstack.org/wiki/Nova/Train_Release_Schedule - after that we can release in train 20.0.1 and move to stein + release and then rocky + release
22:31:12 mriedem so my guess would be early november at the earliest
22:31:48 mriedem meaning, it's not a regression in train so we're not putting it into the train GA right now, it will be in the first patch release after the train GA
22:32:02 mriedem then stein and rocky as normal
22:36:26 eandersson Yea - I mean for me it's more about the patch being pushed, but not necessarily merged.
22:36:54 mriedem you can propose the stein and rocky backports, there are at least 2 patches for that fix b/c there is a functional recreate test patch and then the fix patch
22:37:07 mriedem or you can bribe gibi to move on that
22:37:16 eandersson How do I bribe gibi? beer? :D
22:37:20 mriedem goulash
22:43:35 openstackgerrit Eric Fried proposed openstack/nova master: Deprecate [api]auth_strategy and noauth2 https://review.opendev.org/687373
22:43:35 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Murder NoAuthMiddleware https://review.opendev.org/687416
23:28:42 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Pre-validate volumes for cross_az_attach=False during create https://review.opendev.org/687430
23:29:27 mriedem dansmith: for your morrow, ^ is an alternative and much less fugly solution for the cross_az_attach=False server create issue that i was trying to fix in https://review.opendev.org/#/c/469675/
23:29:41 mriedem basically all contained in the api so less passing of garbage down and up through the layers
#openstack-nova - 2019-10-09
00:03:54 openstackgerrit Merged openstack/nova master: api-ref: Fix security groups parameters https://review.opendev.org/686517
02:32:58 openstackgerrit Jing Zhang proposed openstack/nova master: [WIP] Default mem_page_size to small for pinned instances https://review.opendev.org/686079
03:58:31 openstackgerrit Dongcan Ye proposed openstack/nova master: libvirt: Check the guest support UEFI https://review.opendev.org/685678
07:16:07 SonPham hi . how to boot to instance with this conf
07:16:11 SonPham <disk type="network" device="disk">
07:16:45 SonPham i changed xml file type="raw" to type="qcow2"
07:17:02 SonPham Nova error: Error: Failed to perform requested operation on instance "4444", the instance has an error status: Please try again later [Error: CantStartEngineError].
07:20:06 openstackgerrit Brin Zhang proposed openstack/nova master: Follow-up: Add delete_on_termination to volume-attach API https://review.opendev.org/680655
07:36:57 gibi eandersson: hi! I read about bribery above but not 100% sure which bugfix you are talking about. is it https://bugs.launchpad.net/nova/+bug/1833581 ?
07:36:57 openstack Launchpad bug 1833581 in OpenStack Compute (nova) train "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] - Assigned to Balazs Gibizer (balazs-gibizer)
07:39:32 SonPham hi . how to boot to instance with this conf
08:40:05 kashyap melwitt: stephenfin: Added my review notes here: https://review.opendev.org/#/c/589769/ (skip CPU comparison on AAr ch64)
09:55:20 openstackgerrit Merged openstack/nova master: Skip functional test jobs for doc redirect changes https://review.opendev.org/687357
09:55:25 openstackgerrit Merged openstack/nova master: docs: Add redirects for '/user/aggregates' https://review.opendev.org/687353
09:55:31 openstackgerrit Merged openstack/nova master: doc: link to user/availability-zones from user home page https://review.opendev.org/687165
09:55:37 openstackgerrit Merged openstack/nova master: doc: link to user/index from main home page https://review.opendev.org/687292
10:08:39 efried gibi: Yes, eandersson was talking about https://bugs.launchpad.net/nova/+bug/1833581
10:08:39 openstack Launchpad bug 1833581 in OpenStack Compute (nova) train "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] - Assigned to Balazs Gibizer (balazs-gibizer)
10:11:15 efried gibi: Was there not a func repro patch for that?
10:13:28 gibi efried: thanks. I can propose stable patches to stable branches even before the stein backport merges.
10:13:38 gibi efried: stable/stein has the func reproduce as it merged earlier
10:13:44 efried ahh
10:14:03 efried and yes, I think eandersson can make progress with just the proposed patches, even if they're not merged.
10:14:18 efried I think it's rocky he cares about.
10:14:27 gibi efried: ack. I will go and propose the backport today
10:14:32 efried thanks gibi
10:14:52 gibi efried: I also need to backport that to pike for my downstream world
10:15:08 efried everybody wins
10:15:43 gibi yepp
10:38:35 SonPham hi . how to boot to instance with this conf
10:52:16 openstackgerrit sean mooney proposed openstack/nova master: [DNM] cpu pinning testing https://review.opendev.org/681807
10:55:17 openstackgerrit Balazs Gibizer proposed openstack/nova stable/stein: Add functional test for resize crash compute restart revert https://review.opendev.org/687532
10:56:41 openstackgerrit Balazs Gibizer proposed openstack/nova stable/stein: Functional reproduce for bug 1833581 https://review.opendev.org/687534
10:56:41 openstack bug 1833581 in OpenStack Compute (nova) train "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] https://launchpad.net/bugs/1833581 - Assigned to Balazs Gibizer (balazs-gibizer)
10:56:41 openstackgerrit Balazs Gibizer proposed openstack/nova stable/stein: Error out interrupted builds https://review.opendev.org/687535
10:57:02 gibi eandersson: stable/stein ^^ rocky coming up next
11:41:15 efried mriedem: mock.patch.stopall() has unanticipated knock-on effects. For example, fixtures.MockPatch uses... mock.patch. So any fixtures.MockPatch'd mock, anywhere in the test setup, goes away as well.
11:42:33 sean-k-mooney efried: well that is kind of expect in one way but i guest the other uses may not have been considered
11:43:07 sean-k-mooney e.g. we do expect it to stop _all_ patches using that pattern
11:43:26 efried according to the docs, it only stops patches started with mock.patch.start()
11:43:29 sean-k-mooney efried: is it causeing other code to run that should not
11:43:40 sean-k-mooney sure
11:43:50 efried it was in my local change
11:43:58 sean-k-mooney so decorators should not be affected
11:44:00 efried where I'm adding a fixtures.MockPatch waaaay down in the test setup
11:44:03 sean-k-mooney or with context manager
11:44:39 efried I got around it by changing to MonkeyPatch, which doesn't use mock.patch.start(), but my point is, that's a terrible side effect.
11:45:55 sean-k-mooney efried: you could also jsut save the patche object as self.whatever and then do self.whatever.stop()
11:46:07 sean-k-mooney rather then stopall right
11:49:48 efried sean-k-mooney: theoretically, but I think in this case the patches are buried and difficult to get at.
11:50:08 efried see test_bug_1781286
11:57:04 sean-k-mooney the test_bug_1781286 on your local branch or https://review.opendev.org/#/c/686017/4/nova/tests/functional/regressions/test_bug_1781286.py
11:58:49 sean-k-mooney in anycase i better go prepare a few thing before going to the bank. in an hour
13:15:36 openstackgerrit Balazs Gibizer proposed openstack/nova stable/rocky: cleanup evacuated instances not on hypervisor https://review.opendev.org/687550
13:48:23 openstackgerrit Balazs Gibizer proposed openstack/nova stable/rocky: Add functional test for resize crash compute restart revert https://review.opendev.org/687563
13:49:42 openstackgerrit Balazs Gibizer proposed openstack/nova stable/rocky: Functional reproduce for bug 1833581 https://review.opendev.org/687564
13:49:42 openstack bug 1833581 in OpenStack Compute (nova) train "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] https://launchpad.net/bugs/1833581 - Assigned to Balazs Gibizer (balazs-gibizer)
13:49:42 openstackgerrit Balazs Gibizer proposed openstack/nova stable/rocky: Error out interrupted builds https://review.opendev.org/687565
13:58:43 dansmith mriedem: yeah that seems more efficient than waiting until we get to the compute to find out we're effed anyway right?
14:02:05 mriedem dansmith: we weren't waiting until the compute
14:02:18 mriedem that cinder.check_availability_zone method is called from the api's _validate_bdm method,
14:02:27 mriedem for the pre-existing volume bfv case,
14:02:32 dansmith your other solution wasn't?
14:02:33 mriedem it's also called from compute when we create a volume
14:02:36 mriedem correct
14:02:49 mriedem it's confusing b/c the method is used in both the api and compute but for different source bdms
14:02:54 dansmith oh, it was deep in the cinder code

Earlier   Later