| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-23 | |||
| 10:05:21 | aspiers | cdent: sorry, can't even remember what that was about - been on holiday :-/ | |
| 10:05:23 | kashyap | aspiers: Not really; I'm just parsing existing domain_caps data | |
| 10:05:48 | cdent | aspiers: :) me too. It was about openstack/opensource. Something in the tc election related threads | |
| 10:05:56 | aspiers | kashyap: AttributeError: 'LibvirtConfigDomainCaps' object has no attribute '_os' | |
| 10:06:19 | aspiers | cdent: rings a vague bell :-o | |
| 10:06:58 | kashyap | aspiers: Bad me, you were right, get this one, please: https://review.opendev.org/#/c/673790/ | |
| 10:10:28 | kashyap | aspiers: Okay ... I see it, was blind, it's due to the damn 'for' loop, for _each_ of the enums (readonly, type, secure), it is printing the value of 'secure' | |
| 10:11:21 | aspiers | yeah | |
| 10:12:45 | kashyap | Hehe; top it with a drink | |
| 10:14:02 | aspiers | kashyap: you may eventually want to use https://review.opendev.org/#/c/680777/6/tempest/scenario/test_server_sev.py as a basis for a SB tempest test | |
| 10:14:52 | kashyap | aspiers: Ah, thank you | |
| 10:17:01 | kashyap | aspiers: In your "copious free time", can you also please review these "sketch" methods (no tests yet, the first method is broken) for detecting SB: https://review.opendev.org/#/c/682627/1/nova/virt/libvirt/host.py | |
| 10:17:24 | kashyap | aspiers: You'll see that they're "stolen" from how SEV detected (although, it requires check in the kernel support & host) | |
| 10:17:44 | kashyap | (Note to self: maybe move these methods out from host.py --> to the grab-bag-of-all utils.py) | |
| 10:18:55 | kashyap | aspiers: The commit message explains the design, with an example, even (of firmware auto-selection in action) | |
| 11:02:08 | openstackgerrit | Merged openstack/os-traits master: Add support for ppc64le platforms https://review.opendev.org/680580 | |
| 11:31:33 | openstackgerrit | Matthew Booth proposed openstack/nova stable/stein: libvirt: Fix service-wide pauses caused by un-proxied libvirt calls https://review.opendev.org/683922 | |
| 11:44:37 | openstackgerrit | Matthew Booth proposed openstack/nova stable/rocky: libvirt: Fix service-wide pauses caused by un-proxied libvirt calls https://review.opendev.org/683927 | |
| 11:50:55 | openstackgerrit | Matthew Booth proposed openstack/nova stable/queens: libvirt: Fix service-wide pauses caused by un-proxied libvirt calls https://review.opendev.org/683930 | |
| 12:26:00 | openstackgerrit | Merged openstack/nova master: Rename 'nova.common.config' module to 'nova.middleware' https://review.opendev.org/676898 | |
| 12:45:04 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Functional reproduction for bug 1844993 https://review.opendev.org/683947 | |
| 12:45:05 | openstack | bug 1844993 in OpenStack Compute (nova) "migrate a server with qos port with compute RPC pinned to 5.1 fails and leaves the qos port in an inconsistent state" [Undecided,New] https://launchpad.net/bugs/1844993 - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 12:46:18 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reject migration with QoS port from conductor if RPC pinned https://review.opendev.org/683948 | |
| 13:06:54 | efried | o/ nova | |
| 13:09:13 | gibi | o/ efried | |
| 13:17:57 | sean-k-mooney | efried: o/ have a good weekend | |
| 13:18:21 | efried | yeah, not bad, did much laziness. | |
| 13:19:07 | sean-k-mooney | good. stephenfin's cpu patches finally merged on saturday too | |
| 13:19:13 | sean-k-mooney | so thats a thing | |
| 13:19:44 | efried | yeah, I was watching all of that, need to go update blueprints if that hasn't already been done... | |
| 13:20:37 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522 | |
| 13:20:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Cleanup of '_test_resize' helper test https://review.opendev.org/664245 | |
| 13:20:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add '_setup_compute_services' helper https://review.opendev.org/663102 | |
| 13:20:43 | efried | done | |
| 13:21:02 | sean-k-mooney | same, but it ment on sunday i coudl actully relax and not worry about them | |
| 13:21:20 | bauzas | mriedem: I guess we can close https://bugs.launchpad.net/nova/+bug/1427772, right? | |
| 13:21:21 | openstack | Launchpad bug 1427772 in OpenStack Compute (nova) "Instance that uses force-host still needs to run some filters" [Low,Confirmed] | |
| 13:21:40 | bauzas | mriedem: because 1/ we no longer accept to force live-migrations | |
| 13:21:49 | bauzas | 2/ we removed the CachingScheduler etc. | |
| 13:22:30 | sean-k-mooney | bauzas: we still accept force for evaucation and maybe resize/cold migrate | |
| 13:23:06 | bauzas | well, good point | |
| 13:23:08 | sean-k-mooney | im not sure if that affect the bug or not | |
| 13:23:17 | stephenfin | bauzas: It can be closed because it's possible to request a specific host without bypassing the scheduler filters | |
| 13:24:20 | sean-k-mooney | well at least the numa related stuff is going to be adress seperatly | |
| 13:24:41 | stephenfin | bauzas: Specifically, blueprint add-host-and-hypervisor-hostname-flag-to-create-server | |
| 13:25:22 | sean-k-mooney | stephenfin: that wont prevent people form using the old way with --force | |
| 13:25:29 | sean-k-mooney | using the az | |
| 13:25:41 | stephenfin | sean-k-mooney: then the answer is "you're holding it wrong" | |
| 13:26:18 | mriedem | osc by default forces live migrations to the specified host | |
| 13:26:19 | sean-k-mooney | i guess we could close it because we have a new feature to replace it | |
| 13:26:31 | sean-k-mooney | yes | |
| 13:26:33 | sean-k-mooney | well | |
| 13:26:39 | sean-k-mooney | you have to spcify a host | |
| 13:26:42 | mriedem | given the age of that bug i'd say screw it, close it | |
| 13:26:43 | sean-k-mooney | i dont know if it forces it | |
| 13:26:44 | stephenfin | we can't remove the old way and the new way was specifically added to avoid this issue, so the answer is surely use the new feature | |
| 13:26:51 | mriedem | sean-k-mooney: yes it does | |
| 13:27:05 | mriedem | osc by default (1) requires you specify a host and (2) defaults to 2.1 | |
| 13:27:08 | mriedem | which by default forces the host | |
| 13:27:19 | sean-k-mooney | :( | |
| 13:27:31 | sean-k-mooney | ok i know 1 but not 2 | |
| 13:27:36 | mriedem | that is deprecated in osc 4.0 with something i added in train | |
| 13:27:55 | mriedem | https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/server.html#server-migrate | |
| 13:28:01 | mriedem | --live <hostname> is deprecated | |
| 13:28:15 | mriedem | but for rhosp customers using queens that's going to be an open issue for a long time | |
| 13:28:30 | sean-k-mooney | unless we backport it | |
| 13:28:45 | bauzas | anyway, nevermind | |
| 13:28:45 | sean-k-mooney | that said i dont know if we can do that | |
| 13:28:48 | stephenfin | we'll backport it, I imagine | |
| 13:29:03 | mriedem | we == red hat | |
| 13:29:10 | sean-k-mooney | well we cant backprot the api change downstream | |
| 13:29:19 | mriedem | the api change is in queens, that's not your problem | |
| 13:29:23 | mriedem | it's the client side tooling | |
| 13:29:28 | stephenfin | well you were talking about rhosp, so yes, clearly Red Hat | |
| 13:29:33 | sean-k-mooney | oh ok | |
| 13:30:20 | sean-k-mooney | i guess we should add it to our backlog to consider. the question is can we do it without breaking people | |
| 13:30:28 | sean-k-mooney | if we cant we cant backport | |
| 13:31:07 | sean-k-mooney | that said just adding --live-migration shoudl be fine | |
| 13:31:25 | stephenfin | efried, gibi, (dansmith): Interesting issue here https://review.opendev.org/#/c/663102/11/nova/tests/functional/libvirt/test_numa_servers.py@1060 | |
| 13:32:44 | stephenfin | efried, gibi, (dansmith): As the comment suggests, that test is working by creating two hosts, one of which doesn't have the second node to which a given physnet is associated https://review.opendev.org/#/c/663102/11/nova/tests/functional/libvirt/test_numa_servers.py@855 | |
| 13:33:20 | stephenfin | and we're doing that because it's not possible to have different configuration for different compute "services" in functional tests | |
| 13:33:52 | stephenfin | however, there's a check that prevents us doing just this (configured a physnet for a NUMA node that doesn't exist) that the test simply wasn't triggering | |
| 13:34:57 | stephenfin | because it's only hit as part of the calculation of the host NUMA topology object, which happens in the 'update_available_resource' periodic task, which our test wouldn't normally have time to trigger | |
| 13:35:31 | efried | not having looked yet, just reacting to ^, we have a way to trigger that periodic | |
| 13:35:39 | efried | but it's also triggered as part of instance creation fwiw | |
| 13:36:10 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Error out interrupted builds https://review.opendev.org/666857 | |
| 13:36:16 | stephenfin | it seems to be triggered when we query against the placement fixture https://review.opendev.org/#/c/663102/11/nova/tests/functional/libvirt/test_numa_servers.py@82 | |
| 13:36:50 | stephenfin | and that's the issue - by adding that query, we end up in a situation when the compute service for that falls over | |
| 13:37:15 | stephenfin | aaactually, maybe it was falling over already and we just never thought to check for that | |
| 13:37:20 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Pull up compute node queries to init_host https://review.opendev.org/682680 | |
| 13:37:48 | stephenfin | which is the real reason we're getting NoValidHost - not because the compute service can't support the request but because it never actually started | |
| 13:38:51 | sean-k-mooney | stephenfin: you could check that by looking at the comptue service logs | |
| 13:39:21 | stephenfin | that's what I'm doing as we speak | |
| 13:39:22 | stephenfin | :) | |
| 13:40:24 | stephenfin | yup, it never even started \o/ | |
| 13:40:40 | sean-k-mooney | i dont know the specific incantation to do that in the functional test but i have seen mriedem and gibi asserting log messages are emmited in the functional test form different agent in the past | |
| 13:41:01 | mriedem | self.assertIn('whatever', self.stdlog.logger.output) | |
| 13:41:15 | gibi | sean-k-mooney: you can access the logs in from the logger fixture | |
| 13:41:34 | gibi | sean-k-mooney: self.stdlog.logger.output | |
| 13:41:40 | gibi | sean-k-mooney: but it is not per service | |