Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-09-17
19:31:42 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Add functional recreate test for regression bug 1825537 https://review.opendev.org/682725
19:31:43 openstack bug 1825537 in OpenStack Compute (nova) queens "finish_resize failures incorrectly revert allocations" [Medium,In progress] https://launchpad.net/bugs/1825537 - Assigned to Matt Riedemann (mriedem)
19:46:49 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Changing scheduler sync event from INFO to DEBUG https://review.opendev.org/669127
19:49:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Refactor pre-live-migration work out of _do_live_migration https://review.opendev.org/641453
20:20:31 openstackgerrit Matt Riedemann proposed openstack/nova master: Refactor volume connection cleanup out of _post_live_migration https://review.opendev.org/682741
20:36:36 gyee if the given vm is using pci passthrough, is resizing to the same host allowed or disallowed?
20:52:56 artom mriedem, left a question in https://review.opendev.org/#/c/682741/1
20:53:15 artom Figured it's more polite to ask on IRC than -1 the thing (even if that's what I initially did)
21:02:11 openstackgerrit Akihiro Motoki proposed openstack/nova master: doc: Improve PDF document structure https://review.opendev.org/682746
21:06:53 mriedem replied
21:07:46 artom Cheers
21:13:44 mriedem gyee: resize on the same host with pci passthrough should work but there is no integration testing for it, if there are limitations sean-k-mooney might be aware of them
21:14:32 mriedem i could see the code not being so smart and realizing that if pci devices in the flavor have not changed and we're resizing on the same host that we don't need to re-claim them
21:15:24 gyee mriedem, if the host has one PCI card, I am guessing we can't resize and it has already claimed
21:15:54 gyee but I am not too sure, have had time to dive into the code yet, was hoping for a quick yes or no answer :-)
21:16:18 mriedem i don't have that code memorized so i can't say off the top of my head
21:17:08 mordred mriedem: I'm very disappointed that you don't have it memorized
21:17:17 mriedem i'm not
21:17:18 gyee I see this in the logs "nova-scheduler.log:2019-09-17 19:41:34.269 31312 DEBUG nova.scheduler.filters.pci_passthrough_filter [req-9165ec70-88b2-4ce1-804b-ee28d7c1992c c6d51320a59041588a26477c64ec0973 d35583e194d845b79aaa2a6de2bef94b - default default] (d14-58-d0-52-4c-28, d14-58-d0-52-4c-28.i1.cloud.suse.de) ram: 114519MB disk: 1468416MB io_ops: 0 instances: 2 doesn't have the required PCI devices (InstancePCIRequests(i
21:17:18 gyee nstance_uuid=<?>,requests=[InstancePCIRequest])) host_passes /usr/lib/python2.7/site-packages/nova/scheduler/filters/pci_passthrough_filter.py:54"
21:17:25 mriedem gyee: the claims code in the resource tracker would be here for resize https://github.com/openstack/nova/blob/0984ebb9f1c3cc3c8ff352dd2a615a58da79833c/nova/compute/resource_tracker.py#L280
21:17:52 gyee so I am guessing the device has already be claimed and therefore we can't share the same device, even on resizing
21:19:06 mriedem gyee: the PciPassthroughFilter might not be smart enough for resize to the same host yeah
21:19:20 mriedem in general the scheduler and its filters don't know about move operations
21:19:44 mriedem mordred: also, what a weird time for you to show up and heckle me :)
21:21:27 mriedem gyee: i wouldn't be surprised if you look at the starlingx nova repo that they have something for pci passthrough same host resize
21:22:00 mriedem cfriesen: ^
21:23:02 mordred mriedem: it's 11:22pm where I am right now - that seems like perfect heckling time
21:23:04 gyee mriedem, thanks for the info. Time to read code I guess. :-)
21:24:23 mriedem mordred: so you're bored and lonely eh
21:24:52 mordred mriedem: well, there's no aurora borealis tonight
21:26:28 cfriesen mriedem: gyee: I think we're now aligned with upstream nova now, and that doesn't ring any bells for me. Checking with someone.
21:28:12 mriedem i would think being able to resize a pci passthrough instance on a single node edge site would be important for starlingx
21:28:37 gyee cfriesen, thanks. Our instance is running stable/rocky right now, if that makes any difference.
21:41:50 cfriesen gyee: mriedem: just checked and can't find anything like that. Since Stein at least Starlingx has been aligned with upstream nova. Sounds like a useful change though.
21:45:23 gyee cfriesen, thanks for the info! Yeah, I agree, resizing to the same host is a useful feature
22:27:07 cfriesen gyee: I did some more digging, turns out that we did do some special-casing for sriov and resize/cold migration for Pike, because cold migration with PCI passthrough was broken. For Stein, I think the only customization is numa-aware live migration.
22:45:12 openstackgerrit Merged openstack/nova stable/stein: Fix 'has_calls' method calls in unit tests https://review.opendev.org/677329
23:22:00 stephenfin alex_xu: This failing PMEM patch is killing me. If I rebase the PCPU series and push it up, can you fast re-approve them. I see only one merge conflict with master
23:22:14 alex_xu stephenfin: yes, I can
23:22:57 stephenfin Thanks. Incoming
23:23:16 alex_xu \o/
23:23:24 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement https://review.opendev.org/671793
23:23:25 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: '_get_(v|p)cpu_total' to '_get_(v|p)cpu_available' https://review.opendev.org/672693
23:23:25 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Add 'InstanceNUMATopology.cpu_pinning' property https://review.opendev.org/680106
23:23:26 openstackgerrit Stephen Finucane proposed openstack/nova master: Validate CPU config options against running instances https://review.opendev.org/680107
23:23:26 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Add 'NUMACell.pcpuset' field https://review.opendev.org/680108
23:23:27 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800
23:23:28 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait https://review.opendev.org/675571
23:23:28 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Additional functional tests for pinned instances https://review.opendev.org/681750
23:23:28 openstackgerrit Stephen Finucane proposed openstack/nova master: Include both VCPU and PCPU in core quota count https://review.opendev.org/681374
23:23:29 openstackgerrit Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801
23:23:30 openstackgerrit Stephen Finucane proposed openstack/nova master: fakelibvirt: Make 'Connection.getHostname' unique https://review.opendev.org/681060
23:23:30 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Mock 'libvirt_utils.file_open' properly https://review.opendev.org/681061
23:23:30 openstackgerrit Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895
23:23:31 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Use sane indent https://review.opendev.org/680229
23:23:43 stephenfin alex_xu: FYI the merge conflict was on 'libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait' and due to commit 36ee9c1913a
23:23:52 alex_xu stephenfin: ok, thanks
23:56:54 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Track user_id/project_id for migrations https://review.opendev.org/682511
#openstack-nova - 2019-09-18
00:08:01 openstackgerrit Alex Xu proposed openstack/nova master: [DNM] Print some logs https://review.opendev.org/682766
01:43:11 openstackgerrit Arthur Dayne proposed openstack/nova master: Fix block disk attchment failure https://review.opendev.org/682772
01:59:37 openstackgerrit Arthur Dayne proposed openstack/nova master: Fix block disk attachment failure https://review.opendev.org/682772
02:10:17 openstackgerrit Arthur Dayne proposed openstack/nova master: Fix block disk attachment failure https://review.opendev.org/682772
06:08:42 openstackgerrit Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces https://review.opendev.org/679640
06:08:43 openstackgerrit Luyao Zhong proposed openstack/nova master: doc: attaching virtual persistent memory to guests https://review.opendev.org/680300
06:08:43 openstackgerrit Luyao Zhong proposed openstack/nova master: objects: use all_things_equal from objects.base https://review.opendev.org/681397
06:17:38 openstackgerrit garyk proposed openstack/nova master: Deconstruct the mother of all locks https://review.opendev.org/682242
06:18:13 openstackgerrit Luyao Zhong proposed openstack/nova master: objects: use all_things_equal from objects.base https://review.opendev.org/681397
08:01:50 openstackgerrit Yongli He proposed openstack/nova master: clean up orphan instances https://review.opendev.org/627765
08:15:35 bauzas good morning Nova
08:19:38 gibi bauzas: good morning!
08:21:09 openstackgerrit Arthur Dayne proposed openstack/nova master: Fix block disk attachment failure https://review.opendev.org/682772
08:24:46 openstackgerrit Balazs Gibizer proposed openstack/nova stable/pike: Stabilize unshelve notification sample tests https://review.opendev.org/676677
08:51:38 cshen Good morning. I have a short question. This config "rpc_conn_pool_size = 30" in nova.conf on compute nodes , is this pool shared with all workers, or each worker has a rpc connection pool (size=30)?
08:57:22 bauzas cshen: good question
08:57:38 bauzas cshen: the rpc parameter you mention comes from oslo.rpc
08:57:52 bauzas cshen: while the notion of workers comes from oslo.service
08:58:46 bauzas cshen: since workers are fully seen as Linux processes, I'd guess the pool size is per worker
08:59:03 bauzas but I could be wrong
09:08:59 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Rewrite host aggregate, availability zone docs https://review.opendev.org/667133
09:09:21 stephenfin bauzas: You think you could take a look at that (unfortunately large) doc patch today/this week? ^
09:09:31 stephenfin I mostly need a sanity check to make sure I'm not telling any lies
09:09:49 bauzas stephenfin: I surely can try to take a look on it :)
09:10:09 stephenfin aaaaand _another_ random job has failed for the cpu-resources series. FFS.
09:10:32 stephenfin This time nova-live-migration with something from devstack-gate, which I thought we weren't using anymore
09:10:43 bauzas oh, facepalm, dude
09:11:00 bauzas stephenfin: I haven't paid attention to the series tbh
09:11:10 bauzas I mean, once they were approved
09:12:20 stephenfin I count 13 rechecks on the base patch since approval :(
09:12:35 stephenfin and all of them for different reasons
09:12:48 stephenfin talk about a moving target
09:13:47 brinzhang stephenfin: these patch are not merged until now :(
09:14:51 brinzhang as you said, the failed reason are not same every time
09:15:46 brinzhang Is it because zuul's execution pressure is too great?
09:26:24 stephenfin I think it's just a lot of things combined
09:27:18 stephenfin TripleO hammering the gate, issues with a package, pressure of the gate, large series with many patches that means increased chances of hitting a bug, etc.
09:31:02 cshen bauzas: thanks for the answer. How many nova workers can I see on the compute node?
09:32:11 cshen bauzas: I can see only 1 nova process is running my compute node now.
09:59:45 openstackgerrit Merged openstack/nova stable/stein: Fix non-existent method of Mock https://review.opendev.org/676838
09:59:55 openstackgerrit Merged openstack/nova stable/stein: Fix wrong assertions in unit tests https://review.opendev.org/677388

Earlier   Later