| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-13 | |||
| 18:15:34 | artom | Ah, right, only if self._caps isn't set | |
| 18:15:40 | sean-k-mooney | yes | |
| 18:15:54 | mriedem | LibvirtConnTestCase is the bad one and that uses the fixture so i think we'll be ok | |
| 18:21:31 | openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: stub logging of host capabilities https://review.opendev.org/682133 | |
| 18:21:33 | mriedem | tremble before this ^ | |
| 18:22:55 | sean-k-mooney | isnt it awsome how it conflits with everything | |
| 18:23:18 | mriedem | ha | |
| 18:23:23 | sean-k-mooney | im running the tests localy | |
| 18:23:25 | artom | Don't we have a thing about not changing code to work around CI? | |
| 18:23:37 | sean-k-mooney | this is not a ci bug | |
| 18:23:45 | sean-k-mooney | its a subunit parser bug | |
| 18:23:49 | artom | Tru | |
| 18:23:50 | artom | e | |
| 18:24:31 | sean-k-mooney | so the alteritive is disbable test. which is worse or 1 day after FF replace our test framework with somethin that does not use stestr | |
| 18:24:32 | mriedem | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22subunit.parser%5C%22%20AND%20message%3A%5C%22FAILED%5C%22%20AND%20tags%3A%5C%22console%5C%22%20AND%20voting%3A1%20AND%20project%3A%5C%22openstack%2Fnova%5C%22&from=7d | |
| 18:24:38 | mriedem | for the recent nova hits on that bug | |
| 18:24:48 | mriedem | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22subunit.parser%5C%22%20AND%20message%3A%5C%22FAILED%5C%22%20AND%20tags%3A%5C%22console%5C%22%20AND%20voting%3A1%20AND%20project%3A%5C%22openstack%2Fnova%5C%22&from=10d i guess is better | |
| 18:27:35 | sean-k-mooney | so far it seams to be working locallly. do you want to rebases https://review.opendev.org/#/c/682025/ on top of combine them? | |
| 18:27:52 | mriedem | i do'nt want to combine them | |
| 18:28:00 | mriedem | and i don't know if we have cores around to approve the libvirt one | |
| 18:28:40 | mriedem | looking at the other tracebacks in a passing functional test job, i see a lot of _allocate_network_async which makes me think (and i think these are negative scenario tests) that we're triggering a failure to satisfy the test, | |
| 18:28:47 | mriedem | but then dropping something in the code, | |
| 18:29:03 | mriedem | which gets logged and i'm thinking we might want to have a fixture that makes _allocate_network_async serial | |
| 18:29:12 | mriedem | like the fixtures we have for spawn_n | |
| 18:29:51 | mriedem | i mean we're hitting NetworkInfoAsyncWrapper which calls utils.spawn(_allocate_network_async) | |
| 18:29:53 | sean-k-mooney | we use a fixture like that for the cells scater gather code too right | |
| 18:30:05 | mriedem | so we might just not be using the spawn fixture in several places | |
| 18:33:16 | sean-k-mooney | there are quite a few SADeprecationWarning too | |
| 18:33:58 | sean-k-mooney | The Engine.contextual_connect() method is deprecated. | |
| 18:34:07 | mriedem | and lots of "Detected removed column" | |
| 18:34:29 | mriedem | we should probably squash alembic logging in tests | |
| 18:35:25 | sean-k-mooney | well im not sure we would notice it was deprected if we did but maybe | |
| 18:35:41 | mriedem | i'm talking about a different issue | |
| 18:35:47 | mriedem | these | |
| 18:35:47 | mriedem | 2019-09-13 17:33:40.316170 | ubuntu-bionic | 2019-09-13 17:33:40.248 4439 INFO alembic.autogenerate.compare [req-d6f4db5b-4ad9-4096-9832-08d8692555d7 fake fake - - -] Detected removed column 'build_requests.vm_state'[00m | |
| 18:36:10 | sean-k-mooney | oh ok | |
| 18:36:30 | mriedem | there are columns from the build_requests table that were removed from the model but not the schema | |
| 18:37:04 | sean-k-mooney | like the vpmem coloum in the instance_extra table | |
| 18:38:07 | sean-k-mooney | dont we normally whitelist to be ingored. i would have expected that to not be logged | |
| 18:38:10 | sean-k-mooney | but i guess not | |
| 18:38:26 | mriedem | idk | |
| 18:38:35 | mriedem | idk where the message is coming from | |
| 18:38:42 | mriedem | probably the walk migrations stuff | |
| 18:39:26 | mriedem | yeah there is a whitelist in filter_metadata_diff | |
| 18:39:56 | sean-k-mooney | the deprecation warnings at lesast are not coming form nova they are form sqlaclamate migrate | |
| 18:40:06 | sean-k-mooney | eventrulally we will need to move off that | |
| 18:40:08 | mriedem | yeah that's an old one | |
| 18:40:16 | mriedem | i disagree | |
| 18:40:55 | mriedem | just fix this https://bugs.launchpad.net/sqlalchemy-migrate/+bug/1814288 | |
| 18:40:56 | openstack | Launchpad bug 1814288 in sqlalchemy-migrate "DeprecationWarning: inspect.getargspec() is deprecated, use inspect.signature() instead" [Medium,Confirmed] | |
| 18:41:25 | mriedem | sqlalchemy.migrate is opened by openstack, i'm a core, it's in maintenance mode, and changing nova to go from migrate to alembic is not worth the trouble | |
| 18:41:26 | sean-k-mooney | mriedem: didnt the maintainer say the did not want to maintain sqlalcamey migrate anymore | |
| 18:41:28 | mriedem | at least not while i'm around | |
| 18:41:36 | sean-k-mooney | oh ok | |
| 18:41:37 | mriedem | openstack has maintained it for like 5 years now | |
| 18:42:00 | mriedem | so patches welcome to fix https://bugs.launchpad.net/sqlalchemy-migrate/+bug/1814288 | |
| 18:42:01 | openstack | Launchpad bug 1814288 in sqlalchemy-migrate "DeprecationWarning: inspect.getargspec() is deprecated, use inspect.signature() instead" [Medium,Confirmed] | |
| 18:42:15 | mriedem | migrate is probably due for a release in ussuri | |
| 18:42:57 | sean-k-mooney | well if i can squash some of those message simple then sure | |
| 18:43:45 | sean-k-mooney | thats the allcoate error right http://paste.openstack.org/show/775783/ | |
| 18:44:31 | sean-k-mooney | also http://paste.openstack.org/show/775785/ | |
| 18:45:56 | sean-k-mooney | the functional test seamed to pass but i know that the subunit thing is somewhat non determinisitc | |
| 18:51:05 | sean-k-mooney | huh when i open it in pycharm it sticts through getaragspec and tell you how to fix it | |
| 18:51:08 | openstackgerrit | melanie witt proposed openstack/nova-specs master: Amend "Configure max number of volumes to attach" spec https://review.opendev.org/682136 | |
| 18:51:42 | mriedem | i'm working on http://paste.openstack.org/show/775783/ | |
| 18:52:10 | sean-k-mooney | ok i was going to fix the migrate issue since it seam simpler | |
| 18:52:37 | mriedem | i can't quite figure out what's wrong with test_boot_reschedule_fill_provider_mapping_raises | |
| 18:52:38 | sean-k-mooney | also you sounded like you had an idea how to fix it | |
| 18:52:40 | mriedem | probably need gibi | |
| 18:52:59 | mriedem | using the SpawnIsSynchronous fixture in test_boot_reschedule_fill_provider_mapping_raises definitely makes it fail on that IndexError | |
| 18:53:02 | mriedem | i'm just not sure why yet | |
| 18:53:11 | mriedem | but i think it's because it's stubbing out fill_provider_mapping | |
| 18:53:51 | sean-k-mooney | ill open it and take a look but i dont know if ill be able to help i gues i can run it in a debugger and step in | |
| 18:56:15 | sean-k-mooney | or not... its one of those test where the debuger does not work | |
| 18:57:05 | artom | pysnoop | |
| 18:57:22 | sean-k-mooney | its the placmenet fixture | |
| 18:57:38 | sean-k-mooney | but i could use that i dont think it will help however | |
| 18:57:53 | mriedem | got it | |
| 19:08:54 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use SpawnIsSynchronousFixture in reschedule functional tests https://review.opendev.org/682140 | |
| 19:08:55 | mriedem | sean-k-mooney: ^ | |
| 19:10:45 | sean-k-mooney | it seams to get rid fo the error | |
| 19:12:49 | sean-k-mooney | how is mock_fill in scope? | |
| 19:13:50 | sean-k-mooney | it refers to the mock you are creating in the with statemnet but you are using it in the stub fill provider mapping funciton | |
| 19:14:00 | mriedem | python magic | |
| 19:14:14 | mriedem | it's used in the function which isn't used until after the mock is setup | |
| 19:14:38 | mriedem | anyway, as for https://review.opendev.org/#/c/682133/ i'm going to do a full py26,func-py36,pep8 locally and if that's good clark is going to promote to the gate | |
| 19:14:47 | sean-k-mooney | right so its parsing the function signiture but not the body untill its used | |
| 19:14:53 | mriedem | yar | |
| 19:14:59 | mriedem | that's something that always trips me up with python | |
| 19:14:59 | sean-k-mooney | and by the time its use its inscope | |
| 19:15:17 | sean-k-mooney | that is slightly terrifying but ok | |
| 19:15:42 | artom | Wait, what? | |
| 19:16:07 | artom | The function can refer to its own mock? | |
| 19:16:11 | sean-k-mooney | dont look too closely https://review.opendev.org/#/c/682140/1/nova/tests/functional/test_servers.py@6808 | |
| 19:16:21 | sean-k-mooney | you might go insane | |
| 19:16:23 | artom | Too late, I clicked | |
| 19:16:42 | sean-k-mooney | but ya i get how it could work | |
| 19:16:43 | artom | There's gotta be a less funky clever way of doing that | |
| 19:17:11 | sean-k-mooney | i think there is a mock.wraps that does something similar | |
| 19:17:20 | artom | Yeah | |