| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-13 | |||
| 15:04:23 | sean-k-mooney | as aopposed to just sriov port say sriov neutron ports | |
| 15:04:30 | sean-k-mooney | vpp | |
| 15:04:35 | mriedem | it had another name | |
| 15:04:35 | sean-k-mooney | ? | |
| 15:04:47 | sean-k-mooney | oh yes am | |
| 15:04:49 | mriedem | that yaml based port definition thing that was a drop in for neutron | |
| 15:04:57 | mriedem | quark? | |
| 15:05:05 | sean-k-mooney | no but it was like that | |
| 15:05:13 | sean-k-mooney | prothon or some partical thing | |
| 15:05:33 | mriedem | porthole | |
| 15:05:46 | mriedem | anyway, saying "neutron ports" in openstack is redundant | |
| 15:06:02 | sean-k-mooney | ya as i said it looks fine to me | |
| 15:06:13 | sean-k-mooney | stephenfin: any opipion ^ | |
| 15:06:54 | stephenfin | nope :) | |
| 15:15:28 | mriedem | stephenfin: wasn't this supposed to fail https://review.opendev.org/#/c/681938/ ? | |
| 15:15:52 | stephenfin | Yes. Yes it was. | |
| 15:16:00 | stephenfin | So my diagnosis is wrong | |
| 15:16:35 | stephenfin | That code is definitely wrong, on account of it leaving Nones in there, but what did I do to trigger it... | |
| 15:16:36 | mriedem | unless my patch is wrong | |
| 15:16:58 | stephenfin | it looks okay | |
| 15:18:10 | mriedem | i see that the flavor is configured properly from the n-cpu logs | |
| 15:18:11 | mriedem | https://zuul.opendev.org/t/openstack/build/a7ae03ac0af24dc6b474a54de9d5cf86/log/controller/logs/screen-n-cpu.txt.gz#1924 | |
| 15:18:16 | mriedem | Sep 13 04:50:30.647385 ubuntu-bionic-rax-ord-0011241791 nova-compute[18284]: DEBUG nova.virt.hardware [None req-f2beffe4-882b-4f73-ab07-ba3c859361ab tempest-AggregatesAdminTestJSON-598247452 tempest-AggregatesAdminTestJSON-598247452] Getting desirable topologies for flavor Flavor(created_at=2019-09-13T04:48:13Z,deleted=False,deleted_at=None,description=None,disabled=False,ephemeral_gb=0,extra_specs={trait:COMPUTE_NET_ATTACH_I | |
| 15:18:16 | mriedem | FACE='required'},flavorid='42',id=11,is_public=True,memory_mb=64,name='m1.nano',projects=<?>,root_gb=1,rxtx_factor=1.0,swap=0,updated_at=None,vcpu_weight=0,vcpus=1) and image_meta ImageMeta(checksum='443b7623e27ecf03dc9e01ee93f67afe',container_format='bare',created_at=2019-09-13T04:45:17Z,direct_url=<?>,disk_format='qcow2',id=e085b93e-a43c-42f1-9496-2b46f103dd3d,min_disk=0,min_ram=0,name='cirros-0.4.0-x86_64-disk',owner='4323 | |
| 15:18:16 | mriedem | f86c41da98dc6230d777d7c4',properties=ImageMetaProps,protected=<?>,size=12716032,status='active',tags=<?>,updated_at=2019-09-13T04:45:17Z,virtual_size=<?>,visibility=<?>), allow threads: True {{(pid=18284) _get_desirable_cpu_topologies /opt/stack/nova/nova/virt/hardware.py:572}} | |
| 15:19:33 | stephenfin | mriedem: I know - you don't have cpu_model set on the host | |
| 15:19:42 | stephenfin | or cpu_flags | |
| 15:19:47 | stephenfin | both in the 'libvirt' group | |
| 15:19:54 | mriedem | and the scheduling request in placement | |
| 15:19:54 | mriedem | https://zuul.opendev.org/t/openstack/build/a7ae03ac0af24dc6b474a54de9d5cf86/log/controller/logs/screen-placement-api.txt.gz#337 | |
| 15:19:57 | stephenfin | I missed that /o\ | |
| 15:20:09 | mriedem | oh | |
| 15:20:17 | mriedem | so this is only if you use the cpu flag traits stuff | |
| 15:20:24 | stephenfin | Not quite | |
| 15:20:33 | openstackgerrit | Merged openstack/nova master: Find instance in another cell during floating IP re-association https://review.opendev.org/656594 | |
| 15:21:08 | stephenfin | It's only if you have '[libvirt] cpu_model' and '[libvirt] cpu_flags' (or maybe just the first - I'll check) set on the host | |
| 15:21:31 | stephenfin | which I _think_ most people will have because (a) live migration and (b) spectre/meltdown | |
| 15:21:55 | mriedem | you mean cpu_models and cpu_model_extra_flags yeah? | |
| 15:22:08 | stephenfin | that's the one | |
| 15:22:09 | mriedem | and yeah those are both [] in this run | |
| 15:23:05 | stephenfin | Because we're not actually using the libvirt driver in the functional tests, it should be possible set both of those in a functional tests | |
| 15:23:07 | stephenfin | I'll check | |
| 15:23:47 | mriedem | so cpu_model was renamed to cpu_models in train, right? | |
| 15:24:05 | stephenfin | it was. It's now a list | |
| 15:24:08 | mriedem | because i see https://docs.openstack.org/nova/stein/configuration/config.html#libvirt.cpu_model in stein but not in train and https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.cpu_models in train but not stein | |
| 15:24:16 | mriedem | so, | |
| 15:24:45 | mriedem | if cpu_model isn't deprecated with a rename how is the upgrade handled? just checking for cpu_models first and if not found use cpu_model and log a warning to use the new option? | |
| 15:25:00 | stephenfin | deprecated_name | |
| 15:25:07 | mriedem | bnemec: is there any kind of flag in oslo.config that says "kill the service on startup if using config options that aren't actually defined"? | |
| 15:25:27 | stephenfin | ListOpt works just like StrOpt if you only list one item | |
| 15:25:28 | mriedem | oh there it is | |
| 15:25:32 | mriedem | bnemec: ignore | |
| 15:29:38 | mriedem | so is there a model i could use in this devstack job that we could expect to be in a gate run, like IvyBridge? and i could probably just set cpu_model_extra_flags to pcid? | |
| 15:30:34 | mriedem | or vmx or something? | |
| 15:31:21 | sean-k-mooney | vmx would need nested virt but ya pcid would proably work | |
| 15:31:22 | stephenfin | I'm using this https://gist.github.com/stephenfin/31a44d9cc40d9ce7abffadb5a6830cb1#file-local-conf-master-L25-L28 | |
| 15:31:36 | stephenfin | and that's on 6+ year old hardware so it should do the trick | |
| 15:31:56 | mriedem | ok i'll update my devstack patch | |
| 15:33:30 | sean-k-mooney | pcid was added in the first gen xeon i think back like 11 years ago | |
| 15:33:35 | sean-k-mooney | so ya that is safe | |
| 15:33:46 | sean-k-mooney | well | |
| 15:33:53 | sean-k-mooney | as long as the geate is useing it | |
| 15:34:01 | sean-k-mooney | it will proably work however | |
| 15:34:09 | mriedem | we'll see https://review.opendev.org/#/c/681938/ | |
| 15:36:05 | mriedem | updated release cycle highlights https://review.opendev.org/681943 | |
| 15:45:20 | aspiers | I've just drafted a blog post on SEV. Feedback welcome: https://blog.adamspiers.org/?p=1871&preview=1&_ppp=1bfc4e4f7e | |
| 16:18:56 | openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: remove mention about os-migrations no longer being extended https://review.opendev.org/682102 | |
| 16:19:35 | openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: remove mention about os-migrations no longer being extended https://review.opendev.org/682102 | |
| 16:24:36 | stephenfin | aspiers: Can you check something for me? | |
| 16:30:34 | aspiers | stephenfin: I'll try | |
| 16:31:19 | stephenfin | sorry, got distracted | |
| 16:31:20 | stephenfin | aspiers: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L697 | |
| 16:31:35 | stephenfin | Isn't that line wrong? Should it read: | |
| 16:31:49 | stephenfin | self._host.get_capabilities().host.cpu.model (not .arch) ? | |
| 16:31:54 | stephenfin | *shouldn't it | |
| 16:32:36 | stephenfin | (Actually, "shouldn't it" is colloquial. Oops :)) | |
| 16:39:11 | sean-k-mooney | https://review.opendev.org/#/c/634827/ failed withthe 6 not greathan 7 notificaiton thing again | |
| 16:40:10 | stephenfin | sean-k-mooney: https://review.opendev.org/682025 | |
| 16:40:13 | sean-k-mooney | so the numa serise will block until https://review.opendev.org/#/c/682025/ is mergd | |
| 16:40:17 | sean-k-mooney | ya | |
| 16:40:34 | sean-k-mooney | just pointing out there is no point recheck untill that has merged | |
| 16:41:03 | sean-k-mooney | wow that was the fix... | |
| 16:44:18 | stephenfin | yup | |
| 16:44:32 | stephenfin | tbf, I've made that same mistake myself many times | |
| 16:44:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: DNM: Reproducer for bug #1843836 https://review.opendev.org/682111 | |
| 16:44:41 | openstack | bug 1843836 in OpenStack Compute (nova) "Failure to schedule if flavor contains non-CPU flag traits" [Undecided,In progress] https://launchpad.net/bugs/1843836 - Assigned to Stephen Finucane (stephenfinucane) | |
| 16:44:43 | stephenfin | mriedem_afk: ^ | |
| 16:44:58 | sean-k-mooney | i think it was enqued directly to gate so it should merge soon i hope | |
| 16:45:43 | stephenfin | mriedem_afk: there's a WIP functional reproducer for the bug. I'll clean it up Monday once I'm done investigating the other issue that reproducer highlighted | |
| 16:45:50 | stephenfin | *potential issue | |
| 16:45:55 | stephenfin | sean-k-mooney: It sure was, yup | |
| 16:47:49 | aspiers | stephenfin: that github link is basically a DoS attack on my browser X-D | |
| 16:48:03 | stephenfin | aspiers: Hahahaha | |
| 16:48:17 | stephenfin | yeah...don't try to load it on a phone | |
| 16:48:49 | aspiers | no that was on my laptop | |
| 16:49:08 | stephenfin | if there was ever a sign that a file had grown too large... | |
| 16:49:15 | aspiers | right? | |
| 16:49:30 | stephenfin | funnily enough, libvirt source files tend to be huuuuge as well | |
| 16:49:57 | sean-k-mooney | thats not uncommon in c | |
| 17:00:15 | aspiers | stephenfin: anyway yes it looks wrong to me | |