Earlier  
Posted Nick Remark
#openstack-nova - 2019-09-12
22:30:38 stephenfin at least if I do 'git review -m 671793,24-25' I see all the vpmem stuff introduced
22:30:43 stephenfin maybe I've an old version of git-review
22:31:10 sean-k-mooney melwitt: it will do it if you dont rebase between 4 and 10
22:31:26 melwitt I mean I did a diff after a rebase between
22:31:55 stephenfin sean-k-mooney: yeah, 'git format-patch HEAD~N > (old|new); diff -r old/ new/' would do the trick
22:32:20 stephenfin melwitt: I imagine the difference could be that that rebase didn't introduce changes to the files you were touching
22:32:32 stephenfin but that's a complete guess
22:32:54 melwitt it did, otherwise it wouldn't be useful right? I went to do it in git-review after seeing the diff in gerrit a mess with rebase stuff
22:33:52 efried stephenfin: looks like manual rebases on four of those? You're +A all the way.
22:33:53 sean-k-mooney well i just get an error when i run stephens example
22:34:06 stephenfin efried: That's what I was seeing too
22:34:50 stephenfin Sweet. Anything else I need to do or is it home time?
22:34:52 efried I do what stephenfin does - open two tabs and toggle.
22:35:07 melwitt but anyway, I'm getting the same result as you with your example :\ I don't get why this acts inconsistent depending on the change
22:35:12 efried and yes, rumor has it the newer gerrit has a 4-way. aspiers is always wishing misty-eyed for it.
22:35:53 sean-k-mooney it is very pretty
22:35:54 efried maybe fungi is getting that set up for us once he gets his shoes back on
22:36:59 fungi no shoes needed with new gerrit
22:37:23 fungi it's like the plushest 1970s era orange shag carpet
22:39:30 sean-k-mooney fungi: its a diff that only show you what changed between two patche set ignoring anything that came form a rebase
22:39:35 melwitt there's a heineken light? eesh. as if normal heineken wasn't bad enough
22:39:50 fungi yeah, i'm probably a beer snob but i wouldn't touch heineken anything with a 3m pole
22:40:22 sean-k-mooney fungi: normally i only dirink stouts or poters if im drinking beer
22:40:38 fungi (currently enjoying o'connor brewing's "el guapo" agave ipa)
22:40:39 sean-k-mooney but this was all i had in the fridge
22:40:40 melwitt I'm obsessed with hazy ipas lately
22:41:34 melwitt in colder weather I go for stouts and porters
22:41:34 fungi those can indeed be tasty
22:42:03 melwitt with the exception of north coast's old no 38, I will drink that anytime
22:42:32 fungi i do prefer drier varieties like pale ales, but especially when doing yardwork in the summer
22:43:24 sean-k-mooney hot summer days are cider weather
22:45:11 stephenfin sean-k-mooney: Spoken like a true Tipp wan
22:46:06 sean-k-mooney of course i was born in the town where bulmer/magnars cider is from
22:46:42 sean-k-mooney although i prefer dry cider in general
22:49:43 openstackgerrit Matt Riedemann proposed openstack/nova master: Cleanup reno live-migration-with-PCI-device https://review.opendev.org/681942
22:50:59 mriedem hmm, i was going to avoid mentioning things in the cycle highlights about deprecating the xenapi driver, consoleauth and cells v1, but wondering if i should mention that the placement-in-nova code was removed
22:51:36 mriedem i've avoided mentioning things like that as "highlights"
22:52:02 sean-k-mooney if you mentioned it as remvoed you should mention cells v1 as removed
22:52:10 sean-k-mooney deprecation of xen is more a lowlight
22:52:13 mriedem cells v1 was optional and not many used it,
22:52:17 mriedem placement-in-nova was not optional
22:52:29 mriedem nor was consoleauth really
22:52:37 mriedem anyway, from a marketing perspective those aren't highlights
22:52:50 efried mriedem: if you'd rather put a positive spin, focus on "extracted placement is required"
22:53:05 sean-k-mooney was the removeal of placmenet done with a release note
22:53:10 mriedem that's not really marketing
22:53:19 stephenfin does the prelude form part of the marketing?
22:53:20 mriedem sean-k-mooney: yes, i'm scanning the release notes for highlights
22:53:25 mriedem stephenfin: no,
22:53:33 mriedem that's why i think ^ is all good prelude stuff b/c it's big,
22:53:38 mriedem but it's not marketing shit that sales people would undersatnd
22:53:46 melwitt yeah, I was gonna say, I agree none of those are highlights but they are prelude material
22:53:47 stephenfin I agreed
22:53:49 stephenfin *agree
22:53:51 mriedem if i'm selling train, why do i care if nova uses placement in nova or external
22:53:53 sean-k-mooney mriedem: i expect the placement release note will mark it graduation to a sperate service as a highlight
22:53:54 efried sales schmales, this is open source beyotch
22:54:06 stephenfin efried: Not according to cdent :-D
22:54:29 efried mriedem: because it's way faster?
22:54:34 cdent aw man, don't invoke me for that
22:54:45 stephenfin sorry, cdent
22:54:53 melwitt sean-k-mooney: well, I think we already used "you can run with extracted placement" as a highlight last cycle
22:55:03 cdent for cycle highlights we justsaid that
22:55:03 melwitt re: graduation to separate service
22:55:06 cdent whoops
22:55:20 cdent we said "extracted placement must be used"
22:55:39 efried okay, I gotta go teach people how to beat each other up. No rest for the wicked and all that. Thanks all for the long hours and general ass-kicking today.
22:55:39 cdent and then talked about nfv
22:55:46 cdent because it's, like, the rage
22:56:35 sean-k-mooney cdent: ye had some pretty big feature this release
22:56:57 cdent sean-k-mooney: I'm only being half serious, see: https://review.opendev.org/681197
22:57:19 sean-k-mooney cdent: nfv does corralate with rage however
23:05:12 mriedem efried: et al nova cycle highlights https://review.opendev.org/#/c/681943/1
23:05:25 mriedem if people think that should say something about sev please propose words
23:06:06 mriedem sean-k-mooney: sriov live migration was not driver specific right?
23:06:41 sean-k-mooney it only works for libvirt
23:06:45 mriedem f
23:06:47 mriedem of course
23:07:22 sean-k-mooney you said that in the highlight
23:07:31 mriedem i didn't say it was specific to libvirt,
23:07:31 sean-k-mooney oh that was numa
23:07:33 mriedem like the numa one
23:08:05 mriedem ok i'll leave it wip until tomorrow and update it
23:08:15 mriedem i need to family now
23:08:23 sean-k-mooney o/
23:09:21 sean-k-mooney does anywone know what grenade_devstack_localrc does https://review.opendev.org/#/c/548936/102/.zuul.yaml
23:10:31 sean-k-mooney is there a way in greade to set differnt local.conf options in different releases?
23:11:01 sean-k-mooney ah there is
23:13:11 sean-k-mooney maybe not...
23:13:22 stephenfin efried: Would you mind if we pulled this out of the queue so I can do some surgery on it tomorrow? https://review.opendev.org/#/c/678470/
23:13:53 stephenfin It's test only so we can merge after FF, if artom's comments on https://review.opendev.org/#/c/640021/ are to be believed
23:23:12 sean-k-mooney dansmith: i think i have hit a blocker on the greade job
23:23:14 sean-k-mooney https://review.opendev.org/#/c/548936/102/.zuul.yaml@69
23:23:32 sean-k-mooney i have it mostly done but i dont know how to change the config on upgrade
23:24:05 sean-k-mooney i think i might need a greade plugin to do that or and extention to the grenade job
23:51:12 artom stephenfin, that was my understanding, yeah
23:51:27 artom I mean, even dansmith was telling me he'd look at it next week
23:51:43 artom To me that's an implicit "test-only patches can wait until after FF"
23:53:22 sean-k-mooney speaking of test only patches my uber test of doom https://review.opendev.org/#/c/681771/2 is pendingin the experimenal queue. that will test PMEM PCPUS and numa migration
23:53:31 sean-k-mooney its curently getting ready to stack

Earlier   Later