| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-11 | |||
| 19:50:15 | mriedem | he added handling for BuildAbortException, | |
| 19:50:19 | sean-k-mooney | the finally block will be run by the way when we catch the BuildAbortException | |
| 19:50:27 | sean-k-mooney | i was just comming that in gerrit | |
| 19:50:29 | mriedem | but was missing some things we do when we don't reschedule from a prep_resize failure, like recording a fault and sending an error notification | |
| 19:56:17 | gibi | mriedem: I'm not sleeping yet but I'm already short on brainpower | |
| 19:56:40 | mriedem | gibi: ok if you can look at https://review.opendev.org/#/c/676980/20 before going to bed i can try to update it | |
| 19:56:49 | mriedem | but it's looking non-trivial | |
| 19:57:04 | mriedem | otherwise i'll just move up the series since those changes look simple | |
| 19:59:25 | gibi | now I read your comments. it seems non trivial indeed. Would it be too bad letting the re-schedule happen as a first solution. And optimizing out the unnecessary rechedule later? | |
| 20:01:13 | gibi | mriedem: I cannot implement the functional test and the proper cleanup today. I can do that tomorrow morning. Or If you able to implement it then I can try to review it | |
| 20:02:36 | sean-k-mooney | donnyd: the new lable job passed https://review.opendev.org/#/c/680738/ so im going to call it a day | |
| 20:03:57 | gibi | I will be back in 15 minutes | |
| 20:05:12 | mriedem | gibi: i could let the BuildAbortException handling slide to a follow up but the fact that i can comment out the new code and none of the functional tests fail is kind of a blocker for me | |
| 20:05:39 | gibi | mriedem: ack, that was a surprise for me too. | |
| 20:06:22 | gibi | mriedem: I suggest you move forward with the reviews and I will respin this in the morning with a proper functional test | |
| 20:07:05 | gibi | mriedem: as I run out of time today and I don't want to ask you to troubleshoot those functional tests | |
| 20:07:40 | openstackgerrit | Luyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory https://review.opendev.org/678470 | |
| 20:08:29 | mriedem | gibi: yup sounds like a plan | |
| 20:11:44 | openstackgerrit | Merged openstack/nova master: Nova object changes for forbidden aggregates request filter https://review.opendev.org/671072 | |
| 20:21:37 | gibi | shover thoughts: the computes in those tests are symmetrical. they have the same PF setup. PFs are named the same on host1 and on host2 and we are "updating" the PF name in the PCI request. | |
| 20:21:55 | gibi | when we migrate from host1 to host2 | |
| 20:22:12 | gibi | so I can imagine that without the update the PF names remains the same | |
| 20:22:30 | gibi | and everything works | |
| 20:22:30 | donnyd | sean-k-mooney: woot woot | |
| 20:43:04 | openstackgerrit | Merged openstack/nova master: Improve SEV documentation and other minor tweaks https://review.opendev.org/681254 | |
| 20:43:14 | openstackgerrit | Merged openstack/nova master: Introduce live_migration_claim() https://review.opendev.org/635669 | |
| 20:48:16 | gibi | I was able to disprove my shover thoughts. | |
| 20:48:36 | gibi | I'm going to sleep now. Talk to you tomorrow | |
| 20:49:54 | gibi | and I disproved my disproval | |
| 20:51:08 | openstackgerrit | Merged openstack/python-novaclient master: doc: Add support microversions for options https://review.opendev.org/681174 | |
| 20:53:21 | openstackgerrit | Merged openstack/os-traits master: Build pdf docs https://review.opendev.org/681465 | |
| 20:53:25 | openstackgerrit | Merged openstack/os-traits master: Update README to be a bit more clear https://review.opendev.org/681237 | |
| 20:56:38 | eandersson | thanks for the help sean-k-mooney mriedem | |
| 20:56:44 | eandersson | sorry had to walk away earlier for a meeting | |
| 20:59:22 | aspiers | #success AMD SEV support finally landed in nova after a year https://docs.openstack.org/nova/latest/admin/configuration/hypervisor-kvm.html#amd-sev-secure-encrypted-virtualization | |
| 20:59:24 | openstackstatus | aspiers: Added success to Success page (https://wiki.openstack.org/wiki/Successes) | |
| 20:59:55 | mriedem | eandersson: yw, though i'm not sure how helpful it was | |
| 21:00:05 | mriedem | at least you know what the problem is | |
| 21:01:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Counting both of VCPU and PCPU as core quota https://review.opendev.org/681374 | |
| 21:01:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | |
| 21:02:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: fakelibvirt: Make 'Connection.getHostname' unique https://review.opendev.org/681060 | |
| 21:02:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Mock 'libvirt_utils.file_open' properly https://review.opendev.org/681061 | |
| 21:02:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | |
| 21:03:38 | aspiers | #thanks efried, sean-k-mooney, stephenfin, kashyap, bbobrov, and many others for helping land AMD SEV support in Nova! | |
| 21:03:39 | openstackstatus | aspiers: Added your thanks to Thanks page (https://wiki.openstack.org/wiki/Thanks) | |
| 21:15:02 | mriedem | i'm all the way up through the bw migration series and barring some catastrophe i think it'll probably all be +2ed from me tomorrow | |
| 21:15:27 | mriedem | ooo the thanks page | |
| 21:17:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Include both VCPU and PCPU in core quota count https://review.opendev.org/681374 | |
| 21:17:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | |
| 21:17:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: fakelibvirt: Make 'Connection.getHostname' unique https://review.opendev.org/681060 | |
| 21:17:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Mock 'libvirt_utils.file_open' properly https://review.opendev.org/681061 | |
| 21:17:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | |
| 21:17:35 | mriedem | #thanks sean-k-mooney and donnyd for getting numa-aware live migration CI testing going on FortNebula nodes | |
| 21:17:36 | openstackstatus | mriedem: Added your thanks to Thanks page (https://wiki.openstack.org/wiki/Thanks) | |
| 21:17:55 | donnyd | np mriedem | |
| 21:19:02 | donnyd | mriedem: anything else that can be done on the provider end you can think of... lmk and i will do my best | |
| 21:26:48 | mriedem | dansmith: remember this multi-cell floating IP re-associate bug fix https://review.opendev.org/#/c/656594/ ? can we get that re-approved? | |
| 21:27:06 | mriedem | i think the only thing since it was last approved was fixing some words in the test and removing the handling for CantStartEngineError | |
| 21:43:49 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use multiple attachments in test_list_volume_attachments https://review.opendev.org/681618 | |
| 21:44:12 | donnyd | can someone help me understand how the api-paste.ini works? | |
| 21:44:39 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use multiple attachments in test_list_volume_attachments https://review.opendev.org/681618 | |
| 21:44:43 | donnyd | for reasons out of my control i need to run an api to include an additional url | |
| 21:44:57 | dansmith | mriedem: jes | |
| 21:45:12 | donnyd | this isn't really for nova... but i am hoping the api-paste works pretty much the same across projects | |
| 21:46:34 | mriedem | donnyd: the rest all likely copied from nova originally so it should probably work similarly | |
| 21:47:41 | donnyd | so i need to add /image in at the front of the request for glance | |
| 21:48:06 | donnyd | and with the other service i just use apache and that works like a boss | |
| 21:48:14 | mriedem | would that be api-paste.ini or the endpoint url in the service catalog? | |
| 21:48:23 | donnyd | well both | |
| 21:48:24 | mriedem | probably best to ask in #openstack-glance | |
| 21:48:40 | mriedem | oh right glance is yet to support wsgi | |
| 21:48:46 | mriedem | it's all mtreinish's fault | |
| 21:48:53 | donnyd | i did | |
| 21:49:06 | mriedem | maybe #openstack-operators? | |
| 21:49:13 | mriedem | glance room is pretty dead usually | |
| 21:49:20 | donnyd | oh i will give that a swing | |
| 21:49:29 | mriedem | or hunt down rosmaita | |
| 21:49:34 | mriedem | he's in -cinder | |
| 21:49:38 | mriedem | hiding as the cinder ptl | |
| 21:50:16 | donnyd | adding /image in the api-paste works right now | |
| 21:50:32 | donnyd | but the ref links don't come back with the url in them | |
| 21:51:11 | mriedem | ref links from glance or from nova? | |
| 21:51:42 | mriedem | b/c https://docs.openstack.org/nova/latest/configuration/config.html#api.glance_link_prefix :( | |
| 21:52:01 | mriedem | i think ^ might only matter if you're using the compute api as a proxy to glance, | |
| 21:52:07 | mriedem | which tools shouldn't be doing anymore | |
| 22:12:52 | stephenfin | melwitt: If you're still around, I've addressed your comments on https://review.opendev.org/#/c/681374/ | |
| 22:13:44 | stephenfin | You can find the functional tests in the following patch that turns everything on https://review.opendev.org/#/c/671801/45/nova/tests/functional/libvirt/test_numa_servers.py@241 and https://review.opendev.org/#/c/671801/45/nova/tests/functional/libvirt/test_numa_servers.py@329 | |
| 22:14:29 | melwitt | stephenfin: ack, thanks | |
| 22:16:13 | stephenfin | and for dansmith, I've got the snazzy "try and try again" scheduler thing here itching for some red pen https://review.opendev.org/#/c/671801 | |
| 22:25:44 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add TODO note for mox removal https://review.opendev.org/576758 | |
| 22:47:49 | stephenfin | I haven't seen anything stream by from Gerrit in quite some time :-\ | |
| 22:48:06 | stephenfin | Guess that's as good a sign as any to call it | |
| 22:48:38 | sean-k-mooney | this is several hours past when you normally do | |
| 22:54:54 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Re-add some useful checks https://review.opendev.org/681626 | |
| 22:59:44 | openstackgerrit | Merged openstack/nova master: vCPU model selection https://review.opendev.org/670298 | |
| 23:15:24 | openstackgerrit | Merged openstack/nova master: Add compatibility checks for CPU mode and CPU models and extra flags https://review.opendev.org/670299 | |
| 23:16:42 | openstackgerrit | Merged openstack/nova master: Support reporting multi CPU model traits https://review.opendev.org/670300 | |
| 23:31:56 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement https://review.opendev.org/671793 | |
| 23:31:57 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: '_get_(v|p)cpu_total' to '_get_(v|p)cpu_available' https://review.opendev.org/672693 | |
| 23:31:57 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add 'InstanceNUMATopology.cpu_pinning' property https://review.opendev.org/680106 | |