| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-11 | |||
| 16:22:44 | efried | you can't call it a slug | |
| 16:22:53 | efried | because Jay will kick your ass | |
| 16:23:17 | efried | IMO it's definitely not worth respinning for this. | |
| 16:23:41 | efried | even if this object winds up single use | |
| 16:23:59 | stephenfin | Fair point. I was on the fence as it was | |
| 16:24:18 | sean-k-mooney | we can alwas do it later | |
| 16:24:33 | sean-k-mooney | if we have a common felid type this can jsut be an alias or inherit | |
| 16:24:41 | stephenfin | very true | |
| 16:24:47 | stephenfin | I switched to +2 anyway | |
| 16:24:51 | mriedem | https://bugs.launchpad.net/nova/+bug/1843615 | |
| 16:24:52 | openstack | Launchpad bug 1843615 in OpenStack Compute (nova) "TestInstanceNotificationSampleWithMultipleCompute.test_multiple_compute_actions intermittently failing since Sept 10, 2019" [Undecided,New] | |
| 16:25:09 | stephenfin | on account of it not being a slug and therefore probably not as reusable as I thought it would be | |
| 16:25:24 | sean-k-mooney | stephenfin: once question does the qutotat code need to be move down in the series | |
| 16:25:41 | stephenfin | sean-k-mooney: Yup, see my comment on same. I'll move it when I squash that fixup patch back | |
| 16:25:54 | stephenfin | except for the functional test. That has to wait til the end, of course | |
| 16:25:55 | sean-k-mooney | ah cool | |
| 16:26:12 | stephenfin | the squash back which will be happening any minute now | |
| 16:29:43 | openstackgerrit | Alex Xu proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup https://review.opendev.org/678455 | |
| 16:29:43 | openstackgerrit | Alex Xu proposed openstack/nova master: Parse vpmem related flavor extra spec https://review.opendev.org/678456 | |
| 16:29:44 | openstackgerrit | Alex Xu proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces https://review.opendev.org/679640 | |
| 16:29:44 | openstackgerrit | Alex Xu proposed openstack/nova master: Add functional tests for virtual persistent memory https://review.opendev.org/678470 | |
| 16:29:45 | openstackgerrit | Alex Xu proposed openstack/nova master: objects: use all_things_equal from objects.base https://review.opendev.org/681397 | |
| 16:30:39 | alex_xu | stephenfin: sean-k-mooney ^ done \o/ | |
| 16:31:09 | alex_xu | really small change actually | |
| 16:31:14 | alex_xu | and tested | |
| 16:31:33 | efried | sean-k-mooney: Can I abandon https://review.opendev.org/#/c/681474/ ? | |
| 16:31:48 | sean-k-mooney | oh yes | |
| 16:33:18 | alex_xu | stephenfin: sean-k-mooney removed the workaround code at https://review.opendev.org/678455, then a super simple check at https://review.opendev.org/678456 | |
| 16:34:30 | sean-k-mooney | alex_xu: i expect the code is simpler overall | |
| 16:34:52 | alex_xu | sean-k-mooney: yea | |
| 16:35:14 | alex_xu | oops, I forget to remove that useless need_pin parameters | |
| 16:36:23 | sean-k-mooney | im not sure get_guest_numa is correct it proablyt should be get_guest_singel_numa | |
| 16:37:42 | efried | these sound like fupables | |
| 16:37:52 | alex_xu | sean-k-mooney: emm? | |
| 16:38:21 | sean-k-mooney | https://review.opendev.org/#/c/678455/30/nova/virt/hardware.py | |
| 16:38:36 | sean-k-mooney | it ignores the flavor and always returns a single numa node | |
| 16:38:51 | sean-k-mooney | so get_guest_numa is missleading | |
| 16:39:03 | alex_xu | sean-k-mooney: sorry, that one should be removed, noone use that method anymore | |
| 16:39:13 | sean-k-mooney | ah ok | |
| 16:39:19 | sean-k-mooney | i was looking for where it was used | |
| 16:39:28 | sean-k-mooney | that explain why i could not find it | |
| 16:40:10 | bauzas | see you folks tomorrow morning | |
| 16:41:11 | openstackgerrit | Alex Xu proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup https://review.opendev.org/678455 | |
| 16:41:12 | openstackgerrit | Alex Xu proposed openstack/nova master: Parse vpmem related flavor extra spec https://review.opendev.org/678456 | |
| 16:41:12 | openstackgerrit | Alex Xu proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces https://review.opendev.org/679640 | |
| 16:41:13 | openstackgerrit | Alex Xu proposed openstack/nova master: Add functional tests for virtual persistent memory https://review.opendev.org/678470 | |
| 16:41:13 | openstackgerrit | Alex Xu proposed openstack/nova master: objects: use all_things_equal from objects.base https://review.opendev.org/681397 | |
| 16:42:01 | alex_xu | sean-k-mooney: actually, it is all about this little bit https://review.opendev.org/#/c/678456/32/nova/virt/hardware.py@1688 | |
| 16:43:35 | sean-k-mooney | alex_xu: ya that shoudl cause nodes to be 1 | |
| 16:44:17 | sean-k-mooney | and i think we will take this brance when creating the numa toplgoy right https://review.opendev.org/#/c/678456/32/nova/virt/hardware.py@1742 | |
| 16:45:34 | sean-k-mooney | well we will also call numa_topology = _get_numa_topology_auto(...) | |
| 16:47:15 | sean-k-mooney | ya | |
| 16:47:19 | alex_xu | sean-k-mooney: yes, it is go to the _get_nuam_toplogy_auto | |
| 16:47:23 | sean-k-mooney | the singel numa toplogy is created by https://review.opendev.org/#/c/678456/32/nova/virt/hardware.py@1514 | |
| 16:47:42 | sean-k-mooney | which is exactly what we want | |
| 16:47:53 | alex_xu | yea | |
| 16:53:15 | stephenfin | efried: What do you think about https://review.opendev.org/#/c/678455/25/nova/virt/libvirt/driver.py@1299 ? | |
| 16:54:12 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606 | |
| 16:54:12 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021 | |
| 16:54:13 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595 | |
| 16:54:18 | artom | dansmith, mriedem ^^ | |
| 16:54:19 | efried | stephenfin: It is critical that a dirty pmem not be allowed to be assigned to another guest | |
| 16:55:16 | efried | sorry, you're asking whether we should continue cleaning up wait until the end to fail out? | |
| 16:55:32 | stephenfin | yup | |
| 16:55:40 | efried | this is by no means the only way we can fail out of a destroy() early | |
| 16:55:43 | efried | is it? | |
| 16:55:50 | stephenfin | That's what I'm trying to figure out | |
| 16:56:05 | stephenfin | _unplug_vifs is called with ignore_errors=True | |
| 16:56:19 | efried | looking at L1207-30 | |
| 16:56:34 | efried | anything that's not LibvirtException will cause immediate failure. | |
| 16:56:47 | efried | and even some LibvirtErrorZ | |
| 16:56:57 | efried | so this is far from unprecedented it would seem. | |
| 16:57:11 | stephenfin | good point. If it's broken, it was already broken | |
| 16:57:30 | efried | stephenfin: likewise below when cleaning up bdms | |
| 16:57:31 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix race in _test_live_migration_force_complete https://review.opendev.org/681540 | |
| 16:57:33 | mriedem | efried: dansmith: ^ this fixes a gate bug | |
| 16:57:37 | mriedem | which reset us earlier | |
| 16:57:51 | sean-k-mooney | stephenfin: its called where | |
| 16:58:21 | sean-k-mooney | oh in distroy | |
| 16:58:26 | stephenfin | https://review.opendev.org/#/c/678455/25/nova/virt/libvirt/driver.py@1196 | |
| 16:58:28 | stephenfin | sean-k-mooney: ^ | |
| 16:58:44 | stephenfin | heh | |
| 16:59:55 | gibi_bus | stephenfin: yepp, try to get to Athlone | |
| 17:00:13 | sean-k-mooney | so there is a diffreenc between pmens and vifs | |
| 17:00:22 | efried | mriedem: qualified +2 | |
| 17:00:42 | sean-k-mooney | pmem namespace contain user data which we want to be very careful with ensuring it is earased | |
| 17:01:03 | sean-k-mooney | we shoudl clean up vifs but if noting is plug into it it has little effect | |
| 17:01:12 | sean-k-mooney | ideal neighter would fail | |
| 17:01:28 | sean-k-mooney | but we shoudl make sure we dont skip the rest of the cleanup if they do | |
| 17:01:30 | dansmith | artom: -1 | |
| 17:01:45 | artom | For the sheep joke or the code? | |
| 17:02:18 | dansmith | artom: for the plethora of typos | |
| 17:02:33 | sean-k-mooney | stephenfin: efried so i think we shoudl catch the VPMEMCleanupFailed excetion or put the rest of the cleanup into a finally block | |
| 17:02:37 | dansmith | I assumed you were spending lots of time wordsmithing and checking all that stuff | |
| 17:02:49 | sean-k-mooney | stephenfin: efried or do the pmem cleanup last | |
| 17:03:00 | sean-k-mooney | actullly no we want to always try it | |
| 17:03:05 | stephenfin | sean-k-mooney: You see what efried said about us already failing hard on other things though? | |
| 17:03:28 | sean-k-mooney | yes and that has bit us over and over again | |
| 17:03:49 | sean-k-mooney | this is one of the places we leak resouces on failed migrations | |
| 17:04:22 | efried | seems like yet another thing we shouldn't start fixing as part of this series, but should do later when we can be more complete | |