| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-10 | |||
| 13:53:44 | sean-k-mooney | mriedem: artom is in dad taxi mode currently but he should be back soon ish | |
| 13:55:20 | sean-k-mooney | although looking at that funciton im not clear why that helps | |
| 13:55:20 | Sundar | Thanks, sean-k-mooney | |
| 13:56:21 | efried | https://bugs.launchpad.net/nova/+bug/1843439 | |
| 13:56:23 | openstack | Launchpad bug 1843439 in OpenStack Compute (nova) "doc: Rebuild vs. Evacuate (and other move-ish ops)" [Low,Confirmed] - Assigned to Matt Riedemann (mriedem) | |
| 13:56:53 | efried | mriedem: there's a 'doc' tag and a 'docs' tag. Which one is real? | |
| 13:56:57 | efried | (I used both) | |
| 13:59:30 | bauzas | efried: IIRC, it was 'docs' 3 years ago | |
| 14:00:00 | bauzas | oops, I meant 'doc' | |
| 14:00:03 | bauzas | holy shit | |
| 14:00:26 | sean-k-mooney | its doc | |
| 14:00:30 | sean-k-mooney | https://wiki.openstack.org/wiki/Nova/BugTriage#Tag_Owner_List | |
| 14:00:31 | bauzas | efried: yeah, I'm correct : https://bugs.launchpad.net/nova/+bugs?field.tag=doc vs. https://bugs.launchpad.net/nova/+bugs?field.tag=docs | |
| 14:01:29 | efried | bauzas: are tags autovivified or do they need to be explicitly created somewhere? | |
| 14:01:39 | bauzas | efried: nope, you can add anyone | |
| 14:01:40 | efried | Like, could we go through the latter four bugs and remove 'docs' and that tag would disappear? | |
| 14:01:40 | mriedem | there is an official list | |
| 14:01:49 | bauzas | efried: I'm just updating the 4 'docs' | |
| 14:01:49 | mriedem | anyone can add any tag, | |
| 14:01:50 | sean-k-mooney | efried: if you go to the wiki i likned | |
| 14:01:55 | bauzas | s/docs/doc | |
| 14:01:57 | mriedem | but the list of official tags that auto-complete is curated | |
| 14:01:58 | sean-k-mooney | there is a link to manage the offical tags | |
| 14:01:59 | efried | cool | |
| 14:02:12 | efried | mriedem: oh, in that case both 'docs' and 'doc' must be in there | |
| 14:02:14 | sean-k-mooney | https://bugs.launchpad.net/nova/+manage-official-tags | |
| 14:02:17 | efried | because both autocompleted for me | |
| 14:02:24 | mriedem | https://bugs.launchpad.net/nova/+manage-official-tags | |
| 14:02:24 | sean-k-mooney | no idea how to use that however | |
| 14:02:42 | mriedem | you move things in or out of the 'official tags' column | |
| 14:02:49 | bauzas | efried: mriedem: I removed usage for 'docs' https://bugs.launchpad.net/nova/+bugs?field.tag=docs | |
| 14:03:02 | efried | okay, I'm removing 'docs' from official... | |
| 14:03:11 | bauzas | and yeah, I just removed 'docs' from the official list | |
| 14:03:15 | bauzas | heh, jinxed | |
| 14:03:39 | efried | sorted | |
| 14:03:41 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove custom comparison methods https://review.opendev.org/472285 | |
| 14:03:41 | mriedem | i just added "documentation" | |
| 14:03:47 | efried | you're a bastard | |
| 14:03:47 | mriedem | and "docify" | |
| 14:04:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove custom comparison methods https://review.opendev.org/472285 | |
| 14:04:13 | efried | gibi: Did I see something about a grenade failure - should I wait to recheck stuff? | |
| 14:04:28 | bauzas | efried: mriedem: either way, it's been a long time since I triaged a single bug in Launchpad, floor is yours, folks | |
| 14:04:30 | gibi | efried: don't have to wait | |
| 14:04:36 | efried | thanks | |
| 14:04:38 | gibi | efried: it was a failure in an open review | |
| 14:04:44 | efried | o good :) | |
| 14:04:51 | gibi | efried: which I respinned with a fix | |
| 14:05:19 | efried | I'm going to need to bring in a ringer for this vpmem patch https://review.opendev.org/#/c/678455/ | |
| 14:05:29 | efried | I can handle the rest, but that one is beyond me. | |
| 14:05:53 | efried | stephenfin is already lined up for it. alex_xu is a co-author. | |
| 14:06:34 | efried | sean-k-mooney, kashyap, aspiers, artom: I would proxy a +2 from one of you if you're able --^ | |
| 14:06:53 | alex_xu | also the vpmem CI is pretty close https://review.opendev.org/#/c/679640/14 \o/ | |
| 14:06:54 | kashyap | efried: vPMEM? | |
| 14:07:22 | efried | kashyap: Yeah, that patch is just "do shit efried doesn't understand to the libvirt xml" | |
| 14:07:32 | efried | so I don't think you need to understand vpmem | |
| 14:07:45 | sean-k-mooney | efried: the pmem seriese. i can take a look if kashyap cant | |
| 14:07:48 | kashyap | efried: It's been forever on my to-read list, but I was pulled into urgent downstream stuff last/this week | |
| 14:07:59 | bauzas | efried: once I'm done with gibi's series and stephenfin's cpu-resources, I could give some look at https://review.opendev.org/#/q/topic:bp/virtual-persistent-memory | |
| 14:08:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fixing broken links https://review.opendev.org/681206 | |
| 14:09:09 | efried | Thanks folks. bauzas kashyap sean-k-mooney in the interest of focusing resources, if it's possible to start with https://review.opendev.org/#/c/678455/ rather than going through the whole series, that's the one where we have a known reviewer gap. | |
| 14:09:33 | alex_xu | bauzas: kashyap sean-k-mooney thanks also | |
| 14:09:53 | bauzas | efried: honestly, reviewing the series needs me looking from the start, but I can surely just look at the patches without really commenting them | |
| 14:10:05 | sean-k-mooney | yes if that is the one that need to be reviewed i can start there in about 5 mins | |
| 14:10:08 | kashyap | efried: Nod; that's what I clicked on | |
| 14:10:55 | gibi | stephenfin: a question about the cpu series. The vcpu_pins_set can be and empty string and the nova will use every host cpu for the vcpus. Does this behaviour preserved for the cpu_shared_set and cpu_dedicated_set ? | |
| 14:11:52 | efried | gibi: iiuc no, you'll get an error if you try that. | |
| 14:12:04 | bauzas | gibi: good question, we haven't agreed on that in the spec | |
| 14:13:20 | gibi | efried: so I can assume that when the vcpu_pin_set is removed then there will be no way to implicitly offer every host cpu as vcpu? But I have to explicitly list them in one of the new configs | |
| 14:13:50 | stephenfin | gibi: It's preserved, yes | |
| 14:14:10 | bauzas | stephenfin: only if you don't use the new options, right? | |
| 14:14:29 | bauzas | stephenfin: because if you start messing with your options, then something will come up :) | |
| 14:14:39 | stephenfin | any(vcpu_pin_set, compute.cpu_shared_set, compute.cpu_dedicated_set) == False --> allocate all host CPUs for PCPU inventory | |
| 14:14:43 | stephenfin | bauzas: correct | |
| 14:14:56 | sean-k-mooney | whats the status on the SEV series by the way. stephen did you get a chance to look at the bottom patch? i think that was all that was left to be +w and the rest were ready to go? | |
| 14:15:00 | efried | Right, I guess we don't have to make the decision about what gibi is asking until a future release. | |
| 14:15:06 | efried | sean-k-mooney: it's gateward | |
| 14:15:08 | stephenfin | sean-k-mooney: It's gone through | |
| 14:15:19 | stephenfin | going, rather | |
| 14:15:21 | sean-k-mooney | ok so i can unload the SEV context form my brain | |
| 14:15:32 | sean-k-mooney | at least for a while thats good | |
| 14:15:35 | stephenfin | burn it. burn it all | |
| 14:15:51 | stephenfin | at least until people start using it in two years or so | |
| 14:15:52 | gibi | efried: sure, the part of what happens when we remove the vcpu_pin_set is for the future not for Train | |
| 14:16:00 | gibi | stephenfin: thanks | |
| 14:16:23 | stephenfin | gibi, efried: fwiw, when we remove 'vcpu_pin_set' I'd like to preserve the same behavior | |
| 14:16:30 | stephenfin | though sean-k-mooney disagrees | |
| 14:16:45 | stephenfin | in U or V or whatever, the above simply becomes | |
| 14:16:53 | stephenfin | any(compute.cpu_shared_set, compute.cpu_dedicated_set) == False --> allocate all host CPUs for PCPU inventory | |
| 14:17:00 | gibi | stephenfin: I have conflicting requirements internally what empty vcpu_pin_set "should" mean | |
| 14:17:05 | stephenfin | damn, sorry, VCPU | |
| 14:17:07 | stephenfin | in both cases | |
| 14:17:20 | gibi | stephenfin: yeah, VCPU. even beter | |
| 14:17:36 | efried | alex_xu: even if not yet +2able, do you see https://review.opendev.org/#/c/671800/ being generally sane, enough to unblock the bottom and start merging cpu-resources patches? | |
| 14:17:39 | stephenfin | yeah, my mistake | |
| 14:18:18 | alex_xu | efried: yes, I think it is good. the case I tested passed | |
| 14:18:32 | efried | stephenfin: any reservations about that ^ ? | |
| 14:19:30 | stephenfin | efried: Nope. I need to fix a thing with quotas and discuss whether we need the scheduler option with dansmith ([1]) but neither of those should affect anything [1] https://review.opendev.org/#/c/671801 | |
| 14:19:42 | stephenfin | *anything lower in the series | |
| 14:20:16 | stephenfin | sean-k-mooney: Want to skim through https://review.opendev.org/#/c/671793/ again now that the fixes for your issues are merged directly in? | |
| 14:20:49 | sean-k-mooney | am ill add it to the queue after the vpmem patch but sure | |