| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-09 | |||
| 06:12:19 | brinzhang | takashin:https://review.opendev.org/#/c/674243/23/nova/api/openstack/compute/schemas/migrations.py@55 | |
| 06:12:40 | brinzhang | takashin: I am using the same as query_params_v21 used here [1], they do the same thing, need to be defined again? . | |
| 06:12:40 | brinzhang | [1]https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/servers.py#L570-L571 | |
| 06:13:13 | brinzhang | takashin: should I replaced this with single_sample({'type': 'string'}) | |
| 06:19:56 | takashin | brinzhang: If multiple same query params (e.g. ?user_id=usera&user_id=userb) are not allowed, single_param should be used. | |
| 06:21:08 | brinzhang | takashin: Yeah, got it, will be replace it with single_param, thanks. | |
| 06:40:26 | openstackgerrit | Akira KAMIO proposed openstack/nova master: VMware: disk_io_limits settings are not reflected when resize https://review.opendev.org/680296 | |
| 06:52:32 | openstackgerrit | Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243 | |
| 07:36:15 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Nova object changes for forbidden aggregates request filter https://review.opendev.org/671072 | |
| 07:36:15 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: DB API changes to get non-matching aggregates from metadata https://review.opendev.org/671074 | |
| 07:36:16 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Add a new request filter to isolate aggregates https://review.opendev.org/671075 | |
| 07:36:17 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Docs for isolated aggregates request filter https://review.opendev.org/667952 | |
| 08:12:33 | openstackgerrit | Luyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory https://review.opendev.org/678470 | |
| 08:34:33 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Note about Destination.forbidden_aggregates https://review.opendev.org/680945 | |
| 08:40:30 | gibi | shilpasd: ^^ | |
| 08:54:01 | openstackgerrit | Luyao Zhong proposed openstack/nova master: doc: attaching virtual persistent memory to guests https://review.opendev.org/680300 | |
| 09:24:28 | openstackgerrit | Boxiang Zhu proposed openstack/nova master: Fix live migration break group policy simultaneously https://review.opendev.org/651969 | |
| 09:28:07 | yaawang | stephenfin: Hi, I have updated the patches of vCPU model selection, could you take a review if you have time :) https://review.opendev.org/#/c/670298 https://review.opendev.org/#/c/670299 | |
| 09:36:09 | bauzas | gibi: stephenfin: had no time this morning for both your series but this is planned today | |
| 09:47:14 | openstackgerrit | Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243 | |
| 10:32:54 | alex_xu | stephenfin: good morning, I think luyao get her vpmem pathces ready https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/virtual-persistent-memory, appreciate if you can take a look at them again | |
| 10:33:22 | stephenfin | alex_xu: Will do. I'm just working through your comments on the cpu-resource spec first then I'll move onto that (y) | |
| 10:36:33 | alex_xu | stephenfin: thanks, I will do another around test on your patch after you updated. Then I think we are pretty ready to go | |
| 10:39:15 | aspiers | alex_xu, stephenfin: let me know if I can help in any way with reviews on the last 2 SEV patches | |
| 10:40:34 | alex_xu | aspiers: I will give a try tomorrow if the last few patches doesn't merge yet | |
| 10:40:47 | artom | sean-k-mooney or stephenfin, heya, there's a request from mriedem to review a new bit of XML generation for NUMA LM in https://review.opendev.org/#/c/635229/58..61/nova/virt/libvirt/driver.py and https://review.opendev.org/#/c/635229/58..61/nova/virt/libvirt/migration.py | |
| 10:41:03 | artom | It's the vcpu_pin_set stuff we talked about on... Friday? | |
| 10:41:08 | aspiers | alex_xu: There are only 2 left waiting for review | |
| 10:41:56 | aspiers | alex_xu: but the runway ends on Thursday and then it's the feature freeze, so I am getting a bit worried :-/ | |
| 10:43:38 | alex_xu | aspiers: I'm pretty sure everybody worries this week :) | |
| 10:43:43 | aspiers | alex_xu: ;) | |
| 11:05:09 | openstackgerrit | Brin Zhang proposed openstack/nova master: Follow-up: Add delete_on_termination to volume-attach API https://review.opendev.org/680655 | |
| 11:08:10 | gibi | bauzas: ack, thanks | |
| 11:11:46 | sean-k-mooney | artom: ill take a look at it today | |
| 11:13:14 | sean-k-mooney | im going to finish reviewing stephenfin pcpu seriese and then ill start revering the numa series | |
| 11:13:32 | artom | sean-k-mooney, ack, rhanks | |
| 11:21:22 | sean-k-mooney | artom looking at those links i dont see the question. you seam to have already ansered all the questions that were asked. but as i said ill go through the series fully today | |
| 11:23:30 | artom | sean-k-mooney, it's about making sure the way I generate LibvirtLiveMigrateNUMAInfo on the dest and use it to update the XML on the source is sane, specifically around updating the <vcpu> element from cpu_set | |
| 11:24:14 | artom | sean-k-mooney, mriedem's review on PS60 of https://review.opendev.org/#/c/635229/ | |
| 11:24:24 | artom | "Looks OK compared to PS58 but with the changes for allocation pin set I'm going to need to have Sean and Stephen look at this first." | |
| 11:48:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Validate CPU config options against running instances https://review.opendev.org/680107 | |
| 11:48:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Use sane indent https://review.opendev.org/680229 | |
| 11:48:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add 'NUMACell.pcpuset' field https://review.opendev.org/680108 | |
| 11:48:20 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800 | |
| 11:48:20 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait https://review.opendev.org/675571 | |
| 11:48:20 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | |
| 11:48:21 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | |
| 11:48:22 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Interim follow ups for cpu-resources series https://review.opendev.org/680983 | |
| 11:57:24 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make _revert_allocation nested allocation aware https://review.opendev.org/676138 | |
| 11:59:55 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support reverting migration / resize with bandwidth https://review.opendev.org/676140 | |
| 12:02:15 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Func test for migrate re-schedule with bandwidth https://review.opendev.org/676972 | |
| 12:05:02 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980 | |
| 12:07:21 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497 | |
| 12:09:47 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Do not query allocations twice in finish_revert_resize https://review.opendev.org/678827 | |
| 12:12:11 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow resizing server with port resource request https://review.opendev.org/679019 | |
| 12:34:04 | efried | alex_xu: cpu-resources, can you assert that https://review.opendev.org/#/c/671800/ is at least the right design, just needs a few tweaks? If so, I can take the hold off the bottom and we can start merging these. | |
| 12:34:38 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Extract pf$N literals as constants from func test https://review.opendev.org/680991 | |
| 13:02:21 | mriedem | bauzas: the bottom 5 changes of the bw provider migration series is +2ed starting at https://review.opendev.org/#/c/680394/ if you have time today to look through those | |
| 13:02:37 | bauzas | mriedem: yup, I told gibi I was planning to do it today | |
| 13:02:45 | bauzas | for the moment, cpu-resources | |
| 13:02:48 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Improve dest service level func tests https://review.opendev.org/680998 | |
| 13:03:24 | gibi | mriedem: I've fixed up the 6th patch in the series https://review.opendev.org/#/c/676138 (was -W before) | |
| 13:03:34 | gibi | mriedem: and proposed the followups | |
| 13:03:42 | gibi | mriedem: from the earlier patches | |
| 13:03:52 | mriedem | gibi: yup i saw, i will review those today | |
| 13:03:59 | gibi | mriedem: thanks! | |
| 13:04:33 | gibi | I'm +2 on the forbidden agregates series, but I guess we need dansmith for that | |
| 13:06:03 | mriedem | artom: on the numa live migration series you said that https://review.opendev.org/#/c/680739/ should be good for the test job we're looking at (with the old label) but we haven't had a run of that on the latest patch series you posted on saturday, right? | |
| 13:06:47 | mriedem | i just kicked it off so we'll hopefully have results today | |
| 13:09:17 | Luzi | efried, i wanted to restore the image encryption spec, but i don't have the restore button as it seems. Could you restore it for me? Thank you :) | |
| 13:09:31 | mriedem | Luzi: you have to re-propose it for ussuri anyway | |
| 13:09:38 | mriedem | and address feedback from the train spec | |
| 13:09:52 | mriedem | oh but i guess you want the same change id, | |
| 13:09:53 | mriedem | yeah sec | |
| 13:10:02 | mriedem | Luzi: got a link? | |
| 13:10:15 | mriedem | https://review.opendev.org/#/c/608696/ | |
| 13:10:17 | artom | mriedem, I thought we did - sean-k-mooney told me to use recheck, not check experimental | |
| 13:10:42 | mriedem | artom: if it's in the experimental queue you have to do "check experimental" since it's on-demand | |
| 13:10:44 | artom | mriedem, right, https://zuul.opendev.org/t/openstack/build/435aded2c1934212a87c6efcc3df0f44 | |
| 13:10:44 | mriedem | Luzi: done | |
| 13:10:53 | Luzi | mriedem, thank you :) | |
| 13:10:57 | artom | mriedem, I'm not sure how he set it up, but it ran and passed | |
| 13:11:12 | mriedem | artom: yeah but i don't think on the latest changes | |
| 13:11:26 | mriedem | Zuul experimentalSep 7 2:36 AM was the last run | |
| 13:11:45 | artom | mriedem, Sep 7 10:54 AM Hrmm maybe not | |
| 13:11:55 | mriedem | Artom Lifshitz Uploaded patch set 60. Sep 7 8:26 AM | |
| 13:11:58 | artom | mriedem, in any case, 'recheck' is definitely the thing to do on the DNM patches | |
| 13:12:19 | artom | Zuul | |
| 13:12:19 | artom | Sep 7 10:54 AM | |
| 13:12:20 | artom | Patch Set 1: Verified+1 | |
| 13:12:20 | artom | Build succeeded (check pipeline). | |
| 13:12:20 | artom | nova-nfv-multi-numa-multinode SUCCESS in 56m 56s | |
| 13:12:53 | mriedem | oh i guess it is in check https://review.opendev.org/#/c/680739/1/.zuul.yaml@573 | |
| 13:13:29 | artom | mriedem, and in case you missed it, I set up https://review.opendev.org/#/c/680806/ to run in the gate with the vcpu_pin_set configured, to give the new allocation_cpu_tuning stuff a smoke check | |
| 13:13:35 | mriedem | it also showed up in experimental which is why i was confused | |
| 13:13:54 | artom | It won't change allocation_cpu_pins because vcpu_pin_set is identical on both hosts, but it'll run through the code | |
| 13:25:02 | openstackgerrit | Ivaylo Mitev proposed openstack/nova master: VMware: Update flavor-related metadata upon instance resize https://review.opendev.org/681004 | |
| 13:25:35 | brinzhang | mriedem: https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/add-user-id-field-to-the-migrations-table | |
| 13:25:47 | brinzhang | mriedem: this patch can be merged in Train? | |
| 13:26:28 | mriedem | brinzhang: maybe, i have higher priority things to review first today | |