Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-09-05
15:15:24 artom dansmith, ack
15:16:39 efried dustinc: I'd like to defer provider-config-file to ussuri given it has only had one reviewer (me) looking at it so far. Please let me know if you have reason to believe it can land in the next week.
15:20:30 openstackgerrit Balazs Gibizer proposed openstack/nova master: Func test for migrate server with ports having resource request https://review.opendev.org/655113
15:20:30 openstackgerrit Balazs Gibizer proposed openstack/nova master: Make _rever_allocation nested allocation aware https://review.opendev.org/676138
15:20:55 kashyap efried: Don't defer it yet, please. But I'll keep you posted.
15:21:04 efried kashyap: ack
15:21:32 kashyap efried: I'll also be using that exception from Adam's InvalidMachineType patch; so there's a small dep there
15:21:56 efried kashyap: unclear whether SEV will make it too fyi
15:22:20 kashyap efried: Hmm, understandable; review bandwidth, topic complexity, etc...
15:23:10 kashyap But to state the obvious, I don't want to rush anything, though.
15:23:46 efried stephenfin: how are you feeling about cpu-resources?
15:24:42 stephenfin efried: I'm happy with it, but I need someone to take the hit on https://review.opendev.org/#/c/671800/ I've simplified it as much as I can at this point, I think
15:24:52 stephenfin I've been bugging bauzas for that :)
15:25:02 efried stephenfin: what I mean is: do you reasonably expect it can land by next Thursday?
15:25:14 stephenfin Yeah, I think so
15:25:20 efried okay
15:25:27 bauzas efried: I feel it's a reasonable target if someone else but me does reviews as well
15:25:33 bauzas hint : could be you
15:25:45 efried bauzas: I've been doing what I can, but much of it is beyond my ken.
15:25:50 bauzas cool
15:26:27 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support reverting migration / resize with bandwidth https://review.opendev.org/676140
15:27:02 stephenfin efried: tbh, it's probably beyond most people that aren't called me and sean-k-mooney (and maybe cfriesen)
15:27:22 stephenfin so I think we're going to have to rely on the fact that there are lot of functional tests there, and ask me all the questions if necessary
15:27:35 stephenfin (and I mean, a _lot_ of functional tests)
15:28:04 efried Okay, sean-k-mooney if you've got room, it would be helpful if you could ack that stuff.
15:28:34 efried I think between bauzas, alex_xu, sean-k-mooney, and me, we should be able to scrape together the expertise. It's more a question of bandwidth.
15:29:24 openstackgerrit Balazs Gibizer proposed openstack/nova master: Func test for migrate re-schedule with bandwidth https://review.opendev.org/676972
15:32:26 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980
15:32:26 openstackgerrit Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497
15:35:15 sean-k-mooney efried: sorry was on a call
15:35:18 sean-k-mooney what was the context
15:35:53 efried sean-k-mooney: The cpu-resources series
15:36:05 bauzas sean-k-mooney: the point was whether we have reasonable amount of eyes for cpu-resources
15:36:07 efried sean-k-mooney: it would increase confidence if it had your ack
15:36:26 efried dansmith: regarding isolated vs forbidden, this is a Nova UX vs Placement API thing.
15:36:32 sean-k-mooney i can dedicate the next few days to testing it like i was toing with artoms stuff
15:36:40 dansmith efried: yeah I called that out
15:36:59 efried From the Nova perspective, we're isolating aggregates. Internally we're using placement's forbidden aggregates feature.
15:37:02 sean-k-mooney i think the numa migration is more or less in a good place so i can review the cpu serieis and start testing
15:37:28 dansmith efried: did you see my comment on the later patch?
15:38:00 sean-k-mooney efried: while i hate to do this to my own seires we could punt https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/image-metadata-prefiltering if required to help to U. its ready to go but the sev and cpu series conflict with it
15:38:20 sean-k-mooney so untill they are landed its going to keep gong into merge conflict
15:38:29 openstackgerrit Balazs Gibizer proposed openstack/nova master: Do not query allocations twice in finish_revert_resize https://review.opendev.org/678827
15:39:22 efried sean-k-mooney: thanks, that's helpful
15:40:28 sean-k-mooney efried: stephen created https://etherpad.openstack.org/p/nova-cpu-resources as a set of test he wanted me to try.
15:40:54 sean-k-mooney i can start on them today/tomorrow but if anything else woudl help i could try that.
15:41:17 sean-k-mooney i can if need also try and create a temp ci job
15:41:24 efried dansmith: seeing it now. Sorry, I'm spread in a number of directions at the moment.
15:41:42 openstackgerrit Balazs Gibizer proposed openstack/nova master: Allow resizing server with port resource request https://review.opendev.org/679019
15:41:46 dansmith efried: let me circle back and explain more about why I think the seam needs to move up a step
15:41:55 efried dansmith: From my perspective, everything on the nova side should be called isolated, and we should only call placement-isms forbidden
15:42:17 dansmith efried: cool, I shall tailor my response to indicate why that's a problem
15:42:56 efried dansmith: It's a little bit like where we (should) draw the line between 'member_of' and 'aggregate'.
15:43:02 dansmith efried: yep
15:43:18 efried 'member_of' should really only start appearing in the thing we're using to construct the placement querystring.
15:43:30 efried RequestGroup, I think it's called.
15:45:32 dustinc efried: I’d really like to get it landed in train and am working towards that. I hope to get it reviewable again by eod today.
15:46:14 efried dustinc: I would like that too, but unfortunately I don't feel like it's close enough given how much other stuff we're trying to cram in in the next week.
15:48:05 efried dustinc: not because you did anything wrong, just because there has been more to review than reviewers have been able to keep up with, and this is one that slid off the bottom.
15:48:07 dansmith efried: https://review.opendev.org/#/c/671072/11/nova/scheduler/utils.py
15:49:21 efried dansmith: ack. You da boss. shilpasd ^
15:49:42 dansmith efried: you just saw a wall of text and gave in without reading didn't you?
15:50:12 efried no, I read it. I don't agree, but it's more important to you than to me and I want to see it move forward. So let's do that.
15:50:36 dansmith well, that's constructive
15:50:39 efried dansmith: tbc, what you want to see is the field in Destination named forbidden_aggregates rather than isolated_aggregates. Everything else is okay?
15:52:19 dustinc efried: I understand. I will keep working on it anyway but if the review bandwidth isn’t there then go ahead and punt it to U. Thanks for your time spent reviewing it so far.
15:52:59 dansmith efried: I think the set is kinda upside down, which I assume you also saw from the later ones, but what I'm gathering is that by asking me to review, you wanted me to either just approve or only look shallow for things that physically won't work instead of things that might bite us in the future
15:53:14 dansmith efried: so maybe I should just drop my -1 and you find someone looking to do _that_ kind of review?
15:55:03 efried dansmith: Again, multitasking heavily right now, so I haven't read all of whatever reviews have been done today. I don't want you to rage quit. If there are other nontrivial issues you've called out, then those should be addressed.
16:24:45 mriedem gibi: so close https://review.opendev.org/#/c/680394/2 but there are missing tests for the new _reschedule condition
16:52:26 mriedem gibi: a few easy things to address on the 2 after that as well
16:56:04 openstackgerrit raphael.glon proposed openstack/nova master: Ironic driver: fix when entering rebuild while already in error https://review.opendev.org/680468
17:04:40 openstackgerrit Dustin Cowles proposed openstack/nova-specs master: Spec: Provider config YAML file https://review.opendev.org/680471
17:06:59 mriedem Ironic driver: fix when entering rebuild while already in error https://review.opendev.org/680468 is another duplicate of https://review.opendev.org/#/c/523559/ which is pretty old so maybe we should get that in?
17:07:08 mriedem melwitt: ^?
17:08:35 melwitt mriedem: thanks for the reminder, I was thinking about that the other day. I do want to review that. been dreading re-loading of context on that one
17:10:16 mriedem i think given the amount of time, the review it's had, the duplicates, and the fact it was proposed by an operator of an ironic deployment and this fixes their issue, and it's so narrow in focus, it's pretty low risk to just pull the trigger
17:10:33 mriedem like a mfing renegad
17:10:36 mriedem *renegade
17:11:13 mriedem artom: dansmith: just got done going through that bw provider migration series again, now lunch and then i swear on my sweet lucy cat's whiskers that i'll review that numa live migration series
17:12:37 artom mriedem, appreciated :)
17:16:03 efried I think I've deferred all the obvious deferrals at this point. https://blueprints.launchpad.net/nova/train
17:16:03 efried A couple on there still that don't seem likely, but aren't obvious so I'm letting them slide off and will punt them next week.
17:21:59 dansmith mriedem: thanks
17:22:12 dansmith mriedem: I'm sure you'll find some stuff, so just want to make sure there's time to address it
17:33:03 donnyd melwitt: dansmith for the record today I have only thrown 4 errors from image related tasks... usually it is about 5x that
17:33:20 donnyd thanks for sticking with me on it
17:33:37 melwitt mriedem: noted
17:34:00 dansmith donnyd: cool
17:34:10 melwitt donnyd: \o/
17:41:15 melwitt mriedem: +2
17:51:20 mriedem artom: you could have probably asked in irc or commented without a vote on https://review.opendev.org/#/c/656594/
17:51:22 mriedem but i've replied
17:51:37 mriedem i see you've gone hunting for my changes...
17:57:23 dansmith ah yes, "I plan to backport this" is always a good reason :D
17:57:27 mriedem don't get me wrong, i appreciate the reviews
17:57:53 mriedem and lord knows artom is heavily in debt in this regard :P
17:58:01 dansmith artom: protip: tell him you'll +1 if he queues up a patch behind to do the right thing that needn't be backported :P
17:58:23 mriedem i still won't do what he's suggesting, but he can do that
17:58:28 dansmith haha

Earlier   Later