| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-03 | |||
| 14:38:05 | aspiers | does that make sense? | |
| 14:38:11 | kashyap | aspiers: I was also thinking something like that, sitting on _guest_machine_type_for_secure_boot() :D | |
| 14:38:12 | aspiers | all the rest of the machine type calculation is already in utils | |
| 14:38:15 | sean-k-mooney | donnyd: if we had that support we would jsut set some flave extra specls liek we did for numa sutff | |
| 14:38:37 | aspiers | kashyap: hell, we could even have machine_types.py | |
| 14:38:40 | kashyap | aspiers: Yeah, I think it does make sense -- keeps all the machine type-related context in the same place. | |
| 14:38:59 | aspiers | utils.py is a random mix of crap anyway | |
| 14:39:07 | sean-k-mooney | donnyd: pmem emultaion in qemu is really reall new however so even if openstack could do it most deploymes likely would not have a knew enough version | |
| 14:39:19 | kashyap | aspiers: Haha, "utils" is so generic, it's beyond description | |
| 14:40:24 | kashyap | aspiers: More seriously, bearing future work in mind, I _guess_ there will be more special-casing based on machine types. So a machine_types.py doesn't sound far-fetched to me | |
| 14:40:49 | kashyap | (Thoug, I _was_ serious on "utils" being generic :D) | |
| 14:40:50 | aspiers | kashyap: maybe I could do that after this SEV change | |
| 14:41:02 | kashyap | aspiers: Yeah, don't let that bog you down, though. | |
| 14:42:18 | kashyap | (It's a nice-to-have for now; and I'd rather let the "Apply SEV-specific guest config when SEV is required | |
| 14:42:24 | kashyap | " through the finish line.) | |
| 14:43:50 | aspiers | kashyap: yeah I'm working on that patch now | |
| 14:51:55 | sean-k-mooney | artom: http://paste.openstack.org/show/770137/ | |
| 14:52:38 | sean-k-mooney | almost everything is working at this point | |
| 14:53:19 | sean-k-mooney | what does not work is the case where the source and dest nodes dont have the same numa nodes available | |
| 15:03:08 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: unit test: do not fill rp mapping for failed re-schedule https://review.opendev.org/679653 | |
| 15:05:39 | sean-k-mooney | artom: so ya if i use code with the same vcpu pin set on both host so both numa nodes are valid i can live migrate an instance with (pinning, hugepages, sriov, realtime, shared emulator threads) enable all at the same time | |
| 15:06:17 | sean-k-mooney | ill repoduce the failing case in the ci for you now | |
| 15:08:45 | brtknr | i need someone who uses fedora-coreos on openstack to tell me why the --keypair argument doesnt get respected | |
| 15:15:29 | openstackgerrit | sean mooney proposed openstack/nova master: [DNM] test non overlaping vcpu pin sets. https://review.opendev.org/679805 | |
| 15:17:05 | artom | sean-k-mooney, are you using the code I pushed earlier this morning? | |
| 15:17:18 | sean-k-mooney | yes | |
| 15:17:28 | sean-k-mooney | that fix everything except this last edgecase | |
| 15:17:43 | artom | You mean "hugepages: node 1 not found" is till happening? | |
| 15:17:49 | sean-k-mooney | yes | |
| 15:19:18 | openstackgerrit | sean mooney proposed openstack/nova master: [DNM] test non overlaping vcpu pin sets. https://review.opendev.org/679805 | |
| 15:19:29 | sean-k-mooney | i for got to disable the other jobs in ^ so now its fixed | |
| 15:21:05 | openstackgerrit | Merged openstack/nova master: Add |
|
| 15:21:58 | artom | I'm trying to understand what that error means | |
| 15:22:48 | openstackgerrit | sean mooney proposed openstack/nova master: [DNM] test migration with pinning https://review.opendev.org/679754 | |
| 15:23:37 | sean-k-mooney | artom: by the way the non WIP/DNM patches have the job in the perodic and experimental pipline so you need to use check experimenttal or somthing like that not recheck | |
| 15:24:29 | sean-k-mooney | artom: ill repoduce it locally again and dump the migration xml | |
| 15:26:44 | artom | sean-k-mooney, I *think* I'm getting it | |
| 15:26:57 | artom | I'll poke danpb downstream to make sure | |
| 15:27:11 | sean-k-mooney | ok | |
| 15:46:24 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: Use Claims to update numa-related XML on the source https://review.opendev.org/635229 | |
| 15:46:24 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606 | |
| 15:46:25 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021 | |
| 15:46:25 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595 | |
| 15:49:34 | efried | dustinc: Three sdk patches merging; problems on 4 & 5. | |
| 16:01:51 | openstackgerrit | Merged openstack/nova master: libvirt: Simplify 'fakelibvirt.HostInfo' object https://review.opendev.org/678861 | |
| 16:02:01 | openstackgerrit | Merged openstack/nova master: libvirt: Start checking compute usage in functional tests https://review.opendev.org/678902 | |
| 16:24:03 | donnyd | sean-k-mooney: Ok FN should have the right stuff to run the NUMA jobs now | |
| 16:24:20 | donnyd | https://review.opendev.org/#/c/679789/ | |
| 16:26:07 | sean-k-mooney | donnyd: cool | |
| 16:26:31 | sean-k-mooney | ill try and swap the jobs over to use those during the week | |
| 16:28:25 | mriedem | gibi: i left comments on https://review.opendev.org/#/c/655113/23 but will withold voting for now | |
| 16:28:37 | mriedem | *withhold | |
| 16:30:18 | mriedem | https://review.opendev.org/#/c/679651/ and https://review.opendev.org/#/c/679653/ are pretty simple if another core can hit those - i'm going to have to rebase the cross-cell-resize series and i'd like to wait until after those are merged since they are going to merge conflict me as well | |
| 16:32:13 | sean-k-mooney | donnyd: are you ok with leaveing the current lable as it is till the end of the week and ill swap over to the new lable at the weekend | |
| 16:32:30 | donnyd | Makes no nevermind to me | |
| 16:32:54 | donnyd | I can leave it intact until asked to refactor the current jobs | |
| 16:56:14 | openstackgerrit | Merged openstack/nova master: objects: Rename 'fields' import to 'obj_fields' https://review.opendev.org/674103 | |
| 16:56:22 | openstackgerrit | Merged openstack/nova master: Nice to have test coverage for If1f465112b8e9b0304b8b5b864b985f72168d839 https://review.opendev.org/679629 | |
| 16:56:31 | openstackgerrit | Merged openstack/nova master: Remove dead code https://review.opendev.org/679668 | |
| 17:11:58 | sean-k-mooney | artom: https://46b5dc7879590352c3ef-b484a2b89d5d2c358f068133dfb2fa14.ssl.cf5.rackcdn.com/679805/2/experimental/nova-nfv-multi-numa-multinode/b040d28/testr_results.html.gz :) that is for https://review.opendev.org/#/c/679805/2 | |
| 17:12:28 | sean-k-mooney | artom: the other two are going to fail due to capasity issue with concurrent tests | |
| 17:12:35 | artom | sean-k-mooney, yeah, I just posted on https://review.opendev.org/#/c/679656/7 summarized the CI success | |
| 17:12:50 | sean-k-mooney | but they did pass some of the tests | |
| 17:13:10 | sean-k-mooney | artom: ok cool | |
| 17:13:14 | artom | dansmith, mriedem, if you guys want to take a look ^^ I'd say https://review.opendev.org/#/c/672595/ is ready | |
| 17:13:27 | artom | Err, https://review.opendev.org/#/c/635669/49 | |
| 17:13:30 | artom | The first patch | |
| 17:15:57 | artom | So there's a failure in https://storage.gra1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/logs_54/679754/2/experimental/nova-nfv-multi-numa-multinode/7956dad/testr_results.html.gz, but it's because it failed to even create the server | |
| 17:16:01 | artom | The other live migration tests passed | |
| 17:16:31 | sean-k-mooney | artom: yep that is due to tempest_concurrency 2 | |
| 17:22:29 | mriedem | artom: the functional test patch is in merge conflict | |
| 17:23:36 | artom | mriedem, I know, working on it, it's https://review.opendev.org/678861 | |
| 17:47:21 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.opendev.org/635669 | |
| 17:47:22 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827 | |
| 17:47:22 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: Use Claims to update numa-related XML on the source https://review.opendev.org/635229 | |
| 17:47:23 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606 | |
| 17:47:23 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021 | |
| 17:47:24 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595 | |
| 17:47:56 | artom | mriedem, ^^ | |
| 17:48:22 | efried | dansmith: Would you please have a look at the bottom two patches of https://review.opendev.org/#/c/678447/ when you get a chance? There's still a bit of work to be done up the series, but stephenfin and I are reviewing that. Want to be able to un-hold and send it once it's baked without having to bug you in emergency mode. | |
| 17:50:32 | openstackgerrit | Merged openstack/nova master: Use SDK for node.list https://review.opendev.org/656027 | |
| 17:50:56 | dansmith | artom: okay so it's passing everything or still failing legit on something? | |
| 17:51:15 | mriedem | landing that vpmems series in ~9 days makes me personally uncomfortable | |
| 17:51:20 | artom | dansmith, passing everything as far as I can tell | |
| 17:51:28 | dansmith | efried: yeah, just got off a call, so let me bio break and then I will | |
| 17:51:33 | dansmith | artom: oh okay, sweet | |
| 17:51:36 | efried | thank you dansmith | |
| 18:17:47 | openstackgerrit | Merged openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028 | |
| 18:30:20 | openstackgerrit | Merged openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690 | |
| 18:37:37 | dansmith | is FF this thursday? | |
| 18:37:55 | mriedem | next | |
| 18:39:05 | dansmith | oh okay cool | |
| 18:41:27 | dansmith | artom: since you rebased it's a little hard to tell...can you summarize what you're now doing to indicate that both ends are new enough to do the numa LM? | |
| 18:42:46 | artom | dansmith, https://review.opendev.org/#/c/634606/70/nova/compute/manager.py@6486 | |
| 18:43:22 | artom | If the destination got a migration flag from the conductor, it sets the numa_live_migration sentinel to True | |
| 18:43:42 | artom | It then passes that sentinel (either True or False) to check_can_live_migrate_source | |
| 18:45:04 | dansmith | is that all? | |
| 18:45:24 | artom | The source compute manager calls the driver's check_can_live_migrate_source - if that driver sets src_supports_numa_live_migration but the numa_live_migration sentinel was False or None, src_supports_numa_live_migration gets removed from migrate_data: https://review.opendev.org/#/c/634606/70/nova/compute/manager.py@6561 | |
| 18:46:13 | artom | Which would then cause the check at https://review.opendev.org/#/c/634606/70/nova/compute/manager.py@6519 back on the destination to be False | |
| 18:46:41 | dansmith | okay, so we've passed a new thing in conductor->destination, proving the conductor's rpc allows it, | |