Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-09-02
10:06:17 openstackgerrit sean mooney proposed openstack/nova master: libvirt: use domain capabilities to get supported device models https://review.opendev.org/666915
10:06:17 openstackgerrit sean mooney proposed openstack/nova master: Add transform_image_metadata request filter https://review.opendev.org/665775
10:20:04 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Support set port vnic type to create server https://review.opendev.org/672400
10:25:04 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Support set port vnic type to create server https://review.opendev.org/672400
10:51:19 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Rewrap definitions of 'NUMACell' https://review.opendev.org/674395
10:51:20 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Simplify 'fakelibvirt.HostInfo' object https://review.opendev.org/678861
10:51:20 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Start checking compute usage in functional tests https://review.opendev.org/678902
10:51:21 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Rename 'fields' import to 'obj_fields' https://review.opendev.org/674103
10:51:21 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Fold in argument to '_update_provider_tree_for_vgpu' https://review.opendev.org/676729
10:51:22 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement https://review.opendev.org/671793
10:51:22 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: '_get_(v|p)cpu_total' to '_get_(v|p)cpu_available' https://review.opendev.org/672693
10:51:23 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800
10:51:23 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait https://review.opendev.org/675571
10:51:24 openstackgerrit Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801
10:51:24 openstackgerrit Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895
10:54:26 openstackgerrit Chris Dent proposed openstack/nova master: Use microversion in put allocations in test_report_client https://review.opendev.org/679622
11:10:52 stephenfin alex_xu, bauzas: Still working on changing the scheduler config option and adding resize functional tests for cpu-resources, but I've moved all the trivial patches up to the front of the series, if you fancy taking a look (starts here https://review.opendev.org/#/c/678861/)
11:11:09 stephenfin gibi: Yeah, that's on my list for today (t)
11:11:11 stephenfin *(y)
11:11:37 gibi stephenfin: thanks
11:49:33 openstackgerrit Chris Dent proposed openstack/nova master: Tune up db.instance_get_all_uuids_by_hosts https://review.opendev.org/679627
11:59:24 openstackgerrit Balazs Gibizer proposed openstack/nova master: Nice to have test coverage for If1f465112b8e9b0304b8b5b864b985f72168d839 https://review.opendev.org/679629
12:07:35 aspiers stephenfin: thanks for the reviews. BTW https://review.opendev.org/#/c/636334/ is missing W+1
12:08:14 aspiers stephenfin: I'm working on adding the checks you requested, for live migration / suspend etc.
12:21:03 kashyap aspiers: Nice, seems like the SEV work is almost merged.
12:21:14 aspiers kashyap: Yes, pretty close now :)
12:21:56 aspiers It's almost a year since I uploaded the Stein spec :-o
12:22:13 aspiers So this has been a year-long project or more already
12:23:19 kashyap It required a lot of 'supporting infra' work, which is also useful for other features (machine types rework; domCapabilities, etc)
12:23:28 aspiers Right
12:23:42 aspiers I'm glad it turned out to have other uses. Didn't anticipate that originally.
12:24:17 kashyap aspiers: Unrelated - SEV _requires_ 'q35', isn't it?
12:25:28 aspiers kashyap: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-07-30.log.html#t2019-07-30T09:21:35
12:25:30 aspiers ;-)
12:26:03 kashyap aspiers: Haha, my memory is like the bumblebee's -- can't recall anything more than past 7 seconds
12:26:07 aspiers XD
12:26:20 aspiers Similar thing happened to me this morning
12:27:20 kashyap aspiers: I asked because, the next question I was looking for was: is there a check in the code where: "if SEV && !q35 --> throw an error"
12:27:52 sean-k-mooney kashyap: you could only do that check on the compute node currenlty
12:28:27 kashyap sean-k-mooney: Right, it matters only on compute nodes anyway.
12:28:27 sean-k-mooney i guess you could push it to placemetn by not reporting the sev resouces if the machine type is set to pc
12:28:45 sean-k-mooney kashyap: my point is it woudl cause a late reschdule
12:28:46 kashyap sean-k-mooney: What I was wondering is, _if_ such a thing exists already
12:28:58 aspiers Guys, no need to speculate ;-)
12:29:06 aspiers https://review.opendev.org/#/c/644565/49/nova/virt/libvirt/driver.py@5104
12:29:42 sean-k-mooney im not sure overriding the machine type is a good idea
12:30:07 aspiers We could bail there instead
12:30:37 kashyap Oh, at _what_ point does the override happens?
12:30:52 aspiers kashyap: At *that* point ^^^
12:31:03 sean-k-mooney its in the driver when its generating the xml
12:31:07 kashyap Right. Override can cause a potential surprise for the operator, doesn't it?
12:31:25 sean-k-mooney kashyap: yes and maybe live migration issues
12:31:32 aspiers Live migration is unsupported
12:31:48 aspiers See above message I wrote to stephenfin ^^^
12:32:06 kashyap aspiers: Ah, nod, noticed.
12:32:08 aspiers But it will probably be supported eventually
12:32:14 sean-k-mooney also you can request teh machine type in the image https://github.com/openstack/glance/blob/master/etc/metadefs/compute-libvirt-image.json#L34-L38
12:32:43 aspiers sean-k-mooney: Yes, that's why image_meta is a parameter to get_machine_type_no_default() in the code I just linked
12:33:08 kashyap aspiers: Thinking out loud: do we need an additional function for handling SEV-specific quirks for machine types, instead of squeezing it into the generic guest_machine_type()?
12:33:10 aspiers https://review.opendev.org/#/c/644565/49/nova/virt/libvirt/utils.py@539
12:33:25 sean-k-mooney yes but overrideing an explcit machine_type in the image is not correct
12:33:43 aspiers sean-k-mooney: like I said, we could bail there instead
12:33:49 aspiers that would probably be fine
12:33:58 sean-k-mooney i would bail on conflict with the image
12:34:07 aspiers Yes that's what I'm saying
12:34:24 sean-k-mooney that leave the question of what to do if its set to pc in nova.conf
12:34:39 sean-k-mooney your could bail then also or override
12:35:01 kashyap aspiers: One more: It seems like if machine type is _not_ set, then we're defaulting to 'q35' -- https://review.opendev.org/#/c/644565/49/nova/virt/libvirt/driver.py@5099
12:35:07 sean-k-mooney i think raising an exception in both case is less surpising
12:35:23 sean-k-mooney but i am ment ot be getting food so i should go do that
12:35:26 sean-k-mooney brb
12:35:32 aspiers kashyap: Yes of course, otherwise SEV won't work without explicit hw_machine_type every time
12:36:06 kashyap aspiers: Okay, the function name confused me, then
12:36:21 aspiers Which name?
12:36:41 kashyap The _guest_machine_type() --> should this be named more SEV-specific
12:37:03 kashyap Something like ... _guest_machine_type_for_sev()?
12:37:13 aspiers Yes sure I could extract the big chunk out into _guest_machine_type_for_sev()
12:37:27 aspiers then _guest_machine_type() would call that
12:37:45 aspiers another non-inlined function to annoy stephenfin ;-)
12:38:14 kashyap aspiers: Yeah, thank you. So in _guest_machine_type() -- we can call the _for_sev() based on some SEV-specific conditional
12:38:27 aspiers It would use the exact same conditional which is already there
12:38:35 aspiers on line 5090
12:38:41 kashyap Right, sev_enabled
12:38:49 aspiers and X86_64
12:38:57 aspiers We're not supporting SEV on other architectures ;-)
12:38:57 kashyap Yep, agreed
12:39:01 kashyap Hehe
12:39:16 aspiers OK I'm going for a run to preserve sanity
12:39:21 aspiers biab
12:40:11 kashyap +1
12:40:22 kashyap (On a run)
12:46:56 openstackgerrit Matthew Booth proposed openstack/nova master: libvirt: Fix service-wide pauses caused by un-proxied libvirt calls https://review.opendev.org/677736
12:47:16 openstackgerrit Merged openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420
12:47:27 openstackgerrit Merged openstack/nova master: trivial: Rewrap definitions of 'NUMACell' https://review.opendev.org/674395
12:52:00 openstackgerrit Merged openstack/os-vif master: Fix code bug in document https://review.opendev.org/679382
12:58:45 kashyap aspiers: When you're back, on a similar vein, I also to introduce such a method for Secure Boot: _guest_machine_type_for_secure_boot()
13:00:25 openstackgerrit Luyao Zhong proposed openstack/nova master: db: Add resources column in instance_extra table https://review.opendev.org/678447
13:00:26 openstackgerrit Luyao Zhong proposed openstack/nova master: object: Introduce Resource and ResouceList objs https://review.opendev.org/678448
13:00:26 openstackgerrit Luyao Zhong proposed openstack/nova master: Add resources dict into _Provider https://review.opendev.org/678449
13:00:27 openstackgerrit Luyao Zhong proposed openstack/nova master: Retrieve the allocations early https://review.opendev.org/678450

Earlier   Later