Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-08-30
16:26:14 artom When the destination gets the migrate_data back from the source, pop the src_supports_numa_live_migration sentinel if the destination did not receive a migration from the conductor
16:28:28 dansmith the migration from conductor doesn't tell the whole story, so I don't think it's legit to use that as your sentinel
16:28:42 dansmith conductor's rpc version may be pinned differently
16:29:11 artom Differently.... from the computes?
16:29:24 artom I thought it was a deployment-wide thing
16:29:58 dansmith differently from anything, sure
16:30:07 dansmith config is per-node
16:30:36 dansmith in general you'd kinda assume they're the same, but especially when doing the slide-puzzle migration approch,
16:30:52 dansmith you might need to pin some computes differently to be able to communicate while things are old
16:31:13 artom Hrmm, so in addition to this whole thing, I need to check that the migration from the conductor is not None
16:31:34 dansmith regardless of the pinning of the computes you mean?
16:31:46 artom Yeah
16:31:49 dansmith if there's something you're doing that assumes conductor passed an argument from compute 5.2, then for sure,
16:32:03 dansmith because if it's pinned at 5.1 or "auto" and there are older computes present, then..yeah
16:32:08 dansmith also,
16:32:30 dansmith if everyone is set to "auto", then the version they think is legit right now depends on when they started, or were restarted during the upgrade
16:32:53 dansmith like, as soon as the last compute restarts, its auto pin is set to current, but everyone else hasn't gotten their service restart kick yet, etc
16:33:07 dansmith so assuming they're all atomically set identically is not legit, IMHO
16:33:56 artom So I think migration=None ends up creating a migration object in _move_claim, which is not what we want
16:34:07 artom OK, I think I got a better handle on this, thanks!
16:34:36 dansmith ack, maybe comment that on the patch in the proper place for tracking
16:36:38 openstackgerrit Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616
16:38:02 aspiers efried: need your input on this (sorry) https://review.opendev.org/#/c/666616/38/nova/conf/libvirt.py@845
16:38:38 efried aspiers: more than earlier?
16:39:01 aspiers efried: uhh, different topic I think
16:39:07 efried okay, hit me
16:39:20 aspiers URL above ^^^
16:39:52 efried oh, sorry, stand by
16:40:05 aspiers alex_xu and stephenfin want the default for num_memory_encrypted_guests changed from None to 0
16:40:36 aspiers I'm not convinced it's the best idea, but I guess I'd be OK with it. However I wouldn't be OK with ditching None altogether.
16:43:16 openstackgerrit Adam Spiers proposed openstack/nova master: Indent fake libvirt host capabilities fixtures more nicely https://review.opendev.org/679339
16:43:36 sean-k-mooney aspiers: you could replace non with -1 to signify unlimited
16:43:48 aspiers sean-k-mooney: that's already mentioned in my comment
16:44:01 sean-k-mooney i didnt click
16:44:03 aspiers efried, stephenfin: dedent removed ^^^
16:44:23 sean-k-mooney i just assumed that that would be reason for not using none
16:44:39 aspiers No, None currently means "try to auto-detect, but if you can't, unlimited"
16:44:53 sean-k-mooney ah right yes
16:45:14 aspiers Another reasonable default would be "try to auto-detect, but if you can't, 0"
16:45:28 aspiers So that operators have to explicitly request unlimited
16:45:30 sean-k-mooney ya
16:45:51 aspiers I'd be OK with that too, although it's getting a bit complicated
16:46:05 sean-k-mooney well that would be cloaset to that you want
16:46:14 aspiers Not necessarily
16:46:18 aspiers Read the comment ;-)
16:47:11 sean-k-mooney im more or less done for the day. just waiting for food to be delivers so im trying to avoid starting any more reviews or work.
16:47:38 sean-k-mooney anyway i was fine with what you had orginally proposed
16:47:45 aspiers thanks
16:48:33 openstackgerrit Adam Spiers proposed openstack/nova master: Indent fake libvirt host capabilities fixtures more nicely https://review.opendev.org/679339
16:49:07 aspiers Don't you just love it when the final tempest-slow-py3 in the gate fails with some unrelated issue and means you have to re-run your whole damn CI twice
16:49:32 aspiers *sigh*
16:49:34 sean-k-mooney twice your lucky its not more :)
16:49:43 aspiers haha maybe it will be
16:49:59 aspiers tempest.lib.exceptions.SSHTimeout: Connection to the 172.24.5.222 via SSH timed out.
16:50:04 aspiers Ah that good old favourite
16:51:37 aspiers stephenfin: you still around?
16:52:03 aspiers If I address two nits in https://review.opendev.org/#/c/638680/ I guess I lose the +2 W+1, right?
16:52:37 sean-k-mooney you will and i think he is gong for the weekend
16:52:46 sean-k-mooney add a followup patch
16:52:55 efried aspiers: responded
17:38:23 aspiers efried: thanks
17:38:26 aspiers sean-k-mooney: ok
18:14:34 artom dansmith, so actually, I could at least test pinning to 5.1 in the func tests
18:14:56 artom Just self.flags(compute='5.1', group='upgrade_levels')
18:16:16 dansmith artom: yeah, you should be able to test old conductor (call), new compute(s), mixed computes, etc I think
18:16:31 artom Not sure about mixed because CONF is global
18:17:17 dansmith in unit tests for sure,
18:17:37 dansmith but the compute manager should grab its rpcapi object on start, IIRC, which means you can set it, start one, set it again, start another, etc
18:17:44 dansmith I think it doesn't work for auto, but for manual pins I think you can
18:19:21 artom Oh, fun.
18:19:28 artom After lunch though, I put it off long enough
18:20:00 artom I'll push what I have I guess
18:20:18 openstackgerrit Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.opendev.org/635669
18:20:18 openstackgerrit Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827
18:20:19 openstackgerrit Artom Lifshitz proposed openstack/nova master: LM: Use Claims to update numa-related XML on the source https://review.opendev.org/635229
18:20:19 openstackgerrit Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606
18:20:20 openstackgerrit Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021
18:20:20 openstackgerrit Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595
18:38:14 mriedem_afk sean-k-mooney: you have a pep8 failure here https://review.opendev.org/#/c/669738/
19:24:33 mriedem efried: i think these are ready for gibi's series https://review.opendev.org/#/q/topic:nova-grenade-multinode+(status:open+OR+status:merged)
19:33:34 openstackgerrit Nathan Kinder proposed openstack/nova master: Allow TLS ciphers to be configurable for console proxies https://review.opendev.org/679502
19:42:22 openstackgerrit Merged openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899
19:42:36 openstackgerrit Merged openstack/nova master: libvirt/host.py: remove unnecessary temporary variable https://review.opendev.org/679340
19:42:58 openstackgerrit Merged openstack/nova master: fix lxml compatibility issues https://review.opendev.org/678964
19:44:09 mriedem need someone to backport https://review.opendev.org/#/c/678964/ to stein.
21:19:41 openstackgerrit Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334
21:21:21 openstackgerrit Adam Spiers proposed openstack/nova master: Add and to config.py https://review.opendev.org/636318
21:26:32 openstackgerrit Adam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565
21:30:01 openstackgerrit Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616
21:49:43 openstackgerrit Matt Riedemann proposed openstack/nova master: Rename the nova-grenade-live-migration job to nova-grenade-multinode https://review.opendev.org/678841
21:49:43 openstackgerrit Matt Riedemann proposed openstack/nova master: Add cold migrate and resize to nova-grenade-multinode https://review.opendev.org/679210
21:49:44 openstackgerrit Matt Riedemann proposed openstack/nova master: allow getting resource request of every bound ports of an instance https://review.opendev.org/655110
21:49:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Pass network API to the conducor's MigrationTask https://review.opendev.org/655111
21:49:45 openstackgerrit Matt Riedemann proposed openstack/nova master: Add request_spec to server move RPC calls https://review.opendev.org/655721
21:49:45 openstackgerrit Matt Riedemann proposed openstack/nova master: re-calculate provider mapping during migration https://review.opendev.org/655112
21:49:46 openstackgerrit Matt Riedemann proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422
21:49:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Extend NeutronFixture to handle migrations https://review.opendev.org/655114
21:49:47 openstackgerrit Matt Riedemann proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109
21:49:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Func test for migrate server with ports having resource request https://review.opendev.org/655113
21:49:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Make _rever_allocation nested allocation aware https://review.opendev.org/676138

Earlier   Later