| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-29 | |||
| 14:37:03 | openstackgerrit | Edward Hope-Morley proposed openstack/nova stable/queens: Force refresh instance info_cache during heal https://review.opendev.org/679274 | |
| 14:37:58 | ivve | kashyap: got it, so a least common denominator just as with cpu_models then? | |
| 14:38:07 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: DNM: Run LM integration tests with NUMA flavor https://review.opendev.org/678887 | |
| 14:38:14 | kashyap | ivve: Yep | |
| 14:38:55 | ivve | kashyap: im guessing using virsh capabilities to find out what hosts have available to them is the way to go? | |
| 14:39:13 | kashyap | ivve: To find out machine type? | |
| 14:39:21 | ivve | ye available types | |
| 14:39:48 | ivve | i.e. highest available, lower would obviously be available i guess | |
| 14:40:12 | ivve | as with cpu models / flags | |
| 14:40:38 | kashyap | ivve: Yeah. (Or `qemu-system-x86_64 -machine help | head`) | |
| 14:40:51 | ivve | ah cool, great. thanks a bunch! | |
| 14:41:51 | kashyap | stephenfin: Follow-up: I've addressed Adam's feedback, and got his ACK, FWIW. Might want to queue this - https://review.opendev.org/#/c/673790/ | |
| 14:42:25 | stephenfin | kashyap: I sure can, but could you ask me in the morning? /o\ I've a lotttt of tabs open rn | |
| 14:42:53 | kashyap | stephenfin: Certainly. Ignore it for now | |
| 14:59:12 | mriedem | stephenfin: i'm assuming we can defer this to U at this point? https://blueprints.launchpad.net/nova/+spec/flavor-extra-spec-image-property-validation-extended | |
| 14:59:37 | stephenfin | Yup, and anything != cpu-resources assigned to me | |
| 14:59:53 | stephenfin | I'll re-propose the spec after M3 | |
| 15:00:57 | mriedem | kashyap: i'm assuming we can defer this to U https://blueprints.launchpad.net/nova/+spec/cpu-selection-with-hypervisor-consideration | |
| 15:01:51 | kashyap | mriedem: Yes, definitely. My hands are beyond full. I just want to focus on the other spec. | |
| 15:02:40 | kashyap | Although, I won't stop anyone who is raring to pick it up :-) | |
| 15:06:09 | mriedem | stephenfin: https://blueprints.launchpad.net/nova/+spec/remove-consoleauth is essentially done yeah? | |
| 15:06:26 | stephenfin | Yeah. I think it's totally done, actually | |
| 15:12:49 | openstackgerrit | Eric Fried proposed openstack/nova master: DRY get_sdk_adapter tests https://review.opendev.org/679288 | |
| 15:13:25 | efried_afk | stephenfin: for you ^ :* | |
| 15:13:34 | stephenfin | efried: already done | |
| 15:14:03 | efried | stephenfin: awesome. Can we +W https://review.opendev.org/#/c/676926/ now? | |
| 15:14:17 | stephenfin | Oh, I meant to do that earlier | |
| 15:14:43 | efried | be nice if johnthetubaguy were the +A on the next one https://review.opendev.org/#/c/642899/ ... else mriedem? | |
| 15:15:00 | efried | (after that one I'll be able to +2 up the series) | |
| 15:15:10 | stephenfin | efried: not so fast https://review.opendev.org/#/c/656028/30 | |
| 15:15:35 | efried | stephenfin: oh, I of course meant "when they're ready" | |
| 15:15:40 | stephenfin | oh, cool :) | |
| 15:15:45 | efried | sorry, yeat | |
| 15:15:47 | efried | yeah | |
| 15:16:09 | efried | dustinc is hopefully polishing those up later today. | |
| 15:22:43 | mriedem | efried: yeah i can get back on that one | |
| 15:22:50 | efried | thanks mriedem | |
| 15:30:40 | mriedem | efried: i'm going to push a novaclient release request so that we can get https://review.opendev.org/#/c/665336/ in for train | |
| 15:30:47 | mriedem | we'll likely have another novaclient release at FF | |
| 15:31:06 | efried | mriedem: ack | |
| 15:32:09 | dustinc | efried, stephenfin: my plan is to work on the series more today, I gave it a shot late last night but it didn’t seem to work as expected and I was too tired to keep at it. | |
| 15:32:28 | efried | dustinc: I've got a -1 on the node.list one coming, in case you haven't started yet | |
| 15:33:14 | stephenfin | bauzas: btw https://review.opendev.org/#/c/679273/ | |
| 15:34:27 | efried | dustinc: done, lmk if that doesn't make sense. | |
| 15:46:07 | dustinc | Thanks efried I’ll check it out in a bit. Out at an appt now. | |
| 15:55:19 | artom | stephenfin, sean-k-mooney, sanity check a thing for me. Context is fitting hugepages: https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L632-L658 | |
| 15:55:43 | artom | If the host only has 1 size of pages available (ex: only 2048), that avail_pagesize[:-1] will end up with an empty list | |
| 15:55:45 | artom | And the fail | |
| 15:55:49 | artom | *And then | |
| 15:55:57 | artom | Is that a realistic scenario in the real world? | |
| 15:56:02 | sean-k-mooney | that wont happen. | |
| 15:56:07 | artom | I'm hitting this in func tests, wondering if I'm doing something wrong | |
| 15:56:37 | sean-k-mooney | if you have 1 item in the list [0] == [-1] | |
| 15:57:01 | artom | >>> [1][:-1] | |
| 15:57:01 | artom | [] | |
| 15:57:05 | sean-k-mooney | and [:-1] will b the empty list | |
| 15:57:22 | artom | Yeah, which makes https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L647 a problem | |
| 15:57:46 | sean-k-mooney | lets talk about this later | |
| 15:57:58 | artom | OK? | |
| 15:58:01 | stephenfin | artom: but [1][-1:] | |
| 15:58:07 | stephenfin | [1] | |
| 15:58:23 | stephenfin | [1][:-1] is only used for large pages | |
| 15:58:24 | sean-k-mooney | trying to listen to matt | |
| 15:58:28 | stephenfin | a host won't have only large pages | |
| 15:58:35 | sean-k-mooney | correct | |
| 15:58:40 | artom | stephenfin, that'll only get hit if inst_cell.pagesize == MEMPAGES_SMALL | |
| 15:58:53 | sean-k-mooney | the kernel cannoth run with only hugepages | |
| 15:58:59 | artom | stephenfin, aha, so in the real world, you can't have only 2048 size pages | |
| 15:59:08 | stephenfin | correct | |
| 15:59:19 | stephenfin | there have to be 4k pages | |
| 15:59:21 | artom | stephenfin, gotcha, thanks | |
| 15:59:25 | stephenfin | on x86(_64) anyway | |
| 15:59:33 | sean-k-mooney | if you did they would be the native page size on the system | |
| 15:59:34 | artom | Right, in retrospect, when you put it that way, it seems kinda obvious | |
| 15:59:36 | stephenfin | I don't know what pagesizes are on other platforms | |
| 15:59:37 | sean-k-mooney | not a hugepage | |
| 15:59:49 | sean-k-mooney | ntataive page size can be bigger then 4k | |
| 16:00:03 | artom | So I need to setup my fake hostinfo accordingly | |
| 16:00:27 | sean-k-mooney | mem_size small menas that you get teh smallest pageszie on the host | |
| 16:00:36 | sean-k-mooney | so if the only one is 2048 then that what you get | |
| 16:06:02 | bauzas | calling it a day | |
| 16:06:15 | bauzas | stephenfin: I'm a mean guy https://review.opendev.org/#/c/679273/1 | |
| 16:06:59 | bauzas | no, seriously, I'm torn but I feel from an operators perspective that 'upgrades' is better. That said, that would in theory leave us having some kind of nova-manage stuff to do | |
| 16:07:11 | bauzas | nova-status, my bad | |
| 16:07:19 | stephenfin | I was also on the fence | |
| 16:07:28 | stephenfin | I can do upgrades | |
| 16:07:54 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Follow-up for I491eb7abe1405b27c552cdef142c688a46e914f2 https://review.opendev.org/679273 | |
| 16:07:58 | stephenfin | bauzas: ^ | |
| 16:08:49 | openstackgerrit | Merged openstack/nova master: trivial: Rename 'nova.tests.unit.test_nova_manage' https://review.opendev.org/679095 | |
| 16:10:04 | bauzas | stephenfin: https://docs.openstack.org/nova/latest/contributor/releasenotes.html#when-a-release-note-is-needed makes me torn | |
| 16:10:13 | bauzas | (and that's actually me who wrote this) | |
| 16:10:58 | stephenfin | I'm not planning to backport this fix though | |
| 16:11:07 | stephenfin | so upgrade impact does make sense | |
| 16:19:45 | artom | Hrmm, is the conductor/scheduler code for live migration host selection even set up to handle the case of no host being found? | |
| 16:20:00 | mriedem | yes | |
| 16:20:58 | mriedem | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L439 | |
| 16:21:00 | artom | OK, then I'm doing something wrong | |
| 16:21:48 | artom | Oh, wait, are func tests using cast as call? | |
| 16:21:53 | artom | So it gets bubbled up to the API? | |
| 16:25:11 | aspiers | stephenfin: can I raise exception.FlavorImageConflict from within ResourceRequest? | |