| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-27 | |||
| 14:57:58 | mriedem | that's the question - my changes would be docs/test really | |
| 14:58:06 | mriedem | but alex is the only other core that's really gone through it much | |
| 14:58:10 | mriedem | so yeah i'd still want to be able to +2 | |
| 14:58:22 | efried | If your changes are docs/test, then I'm good with it. | |
| 15:13:08 | artom | dansmith, true. I don't mind doing something like that as a follow-up, as I think func tests that test more scenarios are more important to get done first | |
| 15:13:33 | dansmith | artom: they're important for sure, they just don't give me all that much confidence | |
| 15:13:43 | artom | dansmith, honest question, why? | |
| 15:14:03 | artom | We have no way to be sure real libvirt would accept the XML we generate? | |
| 15:15:07 | dansmith | artom: because every other thing we've landed like this has been fine in the contrived tests, but not actually work in the real world | |
| 15:15:14 | artom | dansmith, heh, fair | |
| 15:15:22 | dansmith | like because we generate bad libvirt xml, or were digesting not-real-world host xml, etc | |
| 15:15:41 | dansmith | numa itself was DoA, IIRC, and pci wasn't actually usable for a long time, etc | |
| 15:16:07 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make _rever_allocation nested allocation aware https://review.opendev.org/676138 | |
| 15:16:07 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support reverting migration / resize with bandwidth https://review.opendev.org/676140 | |
| 15:17:33 | artom | dansmith, would the current combination of manual tests + func tests be enough initially? | |
| 15:18:04 | artom | ... I guess it doens't address your point, because all previous things you mention were exactly in that situation | |
| 15:18:08 | dansmith | artom: you mean, similar to the manual + func tests we had for things we landed borken in the past? | |
| 15:18:27 | dansmith | artom: it just seems like this should be relatively simple to try, by altering the flavor on a LM job, while you're waiting for review or something | |
| 15:18:56 | dansmith | mriedem: how hard is it to float a new job or changed job which does one of our multinode LM tests, but with a different flavor that specifies a simple numa topo? | |
| 15:20:02 | mriedem | dansmith: the hard part there is likely just hacking the flavor, | |
| 15:20:22 | mriedem | but we could probably do that within the script that runs the live migration tests themselves after configuring tempest.conf to use the new flavor | |
| 15:20:50 | dansmith | yeah, I was thinking that would be doable | |
| 15:20:52 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Func test for migrate re-schedule with bandwidth https://review.opendev.org/676972 | |
| 15:20:58 | mriedem | https://github.com/openstack/nova/blob/master/nova/tests/live_migration/hooks/run_tests.sh | |
| 15:21:01 | mriedem | dansmith: in there ^ | |
| 15:21:02 | dansmith | not necessarily landable, but just hacked into place so we can see it run | |
| 15:21:07 | dansmith | artom: ^ | |
| 15:21:31 | mriedem | we should be able to create a new flavor and then re-configure tempest (on the controller host) to use that for the flavor before running the tests | |
| 15:21:40 | artom | dansmith, yeah, I was looking at that as well | |
| 15:22:11 | mriedem | you can see we already configure tempest from the script using ansible | |
| 15:22:11 | mriedem | $ANSIBLE primary --become -f 5 -i "$WORKSPACE/inventory" -m ini_file -a "dest=$BASE/new/tempest/etc/tempest.conf | |
| 15:22:43 | mriedem | so yeah, just create a new flavor and re-configure tempest with the id | |
| 15:23:03 | mriedem | this one https://github.com/openstack/tempest/blob/master/tempest/config.py#L285 | |
| 15:23:18 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980 | |
| 15:25:41 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497 | |
| 15:25:42 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Do not query allocations twice in finish_revert_resize https://review.opendev.org/678827 | |
| 15:26:04 | artom | mriedem, ack, appreciated :) | |
| 15:27:05 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add online migration for legacy NUMA objects https://review.opendev.org/537414 | |
| 15:27:10 | dansmith | artom: sean-k-mooney wrote these functional tests didn't he? | |
| 15:27:30 | artom | dansmith, no... You're implying there's loads of typos? | |
| 15:27:58 | dansmith | hehe, yes | |
| 15:28:03 | dansmith | you must be hanging around him too much then | |
| 15:28:43 | sean-k-mooney | :) | |
| 15:29:06 | artom | I suck up to the best :D | |
| 15:29:07 | sean-k-mooney | eventrully my influnce will spread to all in nova | |
| 15:29:37 | dansmith | over my dead body | |
| 15:29:48 | artom | That can be arranged | |
| 15:31:15 | dansmith | believe me, I know | |
| 15:31:20 | artom | o_O | |
| 15:31:30 | artom | Did you upset the mafia or something | |
| 15:31:42 | sean-k-mooney | bauzas: stephenfin im just running the test locally but i have droped the flatten_iterable function and replaced it with itertools.chain(*model.values()) as stephen suggested it does more or less the same thing so it will do form my usecase | |
| 15:31:53 | dansmith | artom: I assume you have russian mob connections | |
| 15:32:03 | artom | dansmith, I like to pretend I do :) | |
| 15:32:25 | bauzas | sean-k-mooney: honestly, I don't want to overthink this :p | |
| 15:32:49 | bauzas | itertools.chain() is cool with me | |
| 15:32:56 | sean-k-mooney | neither do i but i want something that will merge without me haveing to keep rewriting it | |
| 15:33:14 | bauzas | sean-k-mooney: because of the unpredictability of the dict ordering ? | |
| 15:33:14 | sean-k-mooney | ok | |
| 15:33:23 | stephenfin | bauzas: RE: https://review.opendev.org/#/c/674894/11/, will I just generate a stub 'RequestSpec' for the 'resources_from_flavor' caller? | |
| 15:33:38 | stephenfin | as in to address https://review.opendev.org/#/c/674894/11/nova/scheduler/utils.py@393 | |
| 15:33:40 | bauzas | sean-k-mooney: there are ways to predict a dict ordering but whatever | |
| 15:33:41 | sean-k-mooney | no this is the 4 way i have done this | |
| 15:33:50 | sean-k-mooney | in in those pathces | |
| 15:33:55 | bauzas | stephenfin: yeah, I think it would be fine | |
| 15:34:03 | stephenfin | (y) | |
| 15:34:17 | sean-k-mooney | bauzas: it is noting to do with dict ordering | |
| 15:34:29 | sean-k-mooney | that was just a side effect of how i wrote the tests | |
| 15:34:29 | bauzas | stephenfin: I was cool with (flavor, image) as parameters | |
| 15:34:42 | bauzas | stephenfin: but is_bfv really did hurt my guts :p | |
| 15:34:56 | bauzas | sean-k-mooney: ok | |
| 15:35:50 | stephenfin | understandable :) | |
| 15:37:41 | openstackgerrit | Merged openstack/nova stable/stein: lxc: make use of filter python3 compatible https://review.opendev.org/676496 | |
| 15:37:49 | openstackgerrit | Merged openstack/nova stable/stein: Add an issue releasenote for placement eventlet stall https://review.opendev.org/676973 | |
| 15:45:51 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: DNM: Run LM integration tests with NUMA flavor https://review.opendev.org/678887 | |
| 15:46:06 | artom | I'm pretty sure ^^ is entirely broken, but it's a first step | |
| 15:48:20 | dansmith | artom: seems plausible | |
| 15:50:00 | sean-k-mooney | artom: that will fail because we dont have nested verit or a new enough qemu to enable the mttcg backend | |
| 15:50:20 | artom | sean-k-mooney, I thought vexxhost enabled that? | |
| 15:50:44 | sean-k-mooney | they do | |
| 15:50:53 | sean-k-mooney | did you change the nodeset to the vexxhost one | |
| 15:51:06 | artom | ... no :( | |
| 15:51:15 | sean-k-mooney | it could land on vexhost still | |
| 15:51:17 | sean-k-mooney | and pass | |
| 15:51:26 | sean-k-mooney | actuly it will still fail | |
| 15:51:34 | sean-k-mooney | we disable kvm in the gate too | |
| 15:51:48 | sean-k-mooney | you would have to change the node set and then set the virt type to kvm | |
| 15:51:53 | sean-k-mooney | then it should work | |
| 15:53:39 | dansmith | sean-k-mooney: why will it fail without kvm? is it because the host will have no numa info so we'll fail to schedule anything? | |
| 15:54:37 | sean-k-mooney | no it fails becasue when we set hw:numa_node=1 we pin the guest cpus to float over just 1 host numa node | |
| 15:54:59 | sean-k-mooney | we do that using the vcpupin element instad of the cpuset attibute on the vcpu element | |
| 15:55:22 | sean-k-mooney | the vcpupin element which does per core pinning is only supported with kvm or the mttcg backend | |
| 15:55:51 | dansmith | ah okay | |
| 15:56:17 | sean-k-mooney | the normal tsg backend that qemu ueses only support pinning via the <vcpu cpuset=""> method | |
| 15:56:45 | sean-k-mooney | so in pricaipal there is no reason it cant work just the way we generate the xml breaks it | |
| 15:57:13 | sean-k-mooney | or use a newer qemu/libvirt | |
| 15:57:33 | sean-k-mooney | i belive the one in fedroa 31 will be new enough by defualt | |
| 15:57:50 | sean-k-mooney | f29 and i think f30 still need the virt preview repo enabeld | |
| 15:58:17 | dansmith | sean-k-mooney: maybe you could fix up that patch for artom to do whatever it is that needs doing? | |
| 15:59:19 | sean-k-mooney | i can try yes | |
| 15:59:25 | sean-k-mooney | i also need to fix https://review.opendev.org/#/c/652197/ | |