| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-23 | |||
| 18:27:15 | sean-k-mooney | so for numa the if(migration.type!=live) shoudl be enough | |
| 18:28:12 | artom | We have functional tests for SRIOV LM? | |
| 18:28:20 | artom | I wonder if we could try both in a func test | |
| 18:28:41 | sean-k-mooney | we dont | |
| 18:29:06 | artom | Func tests for neutron SRIOV at all? | |
| 18:29:27 | sean-k-mooney | nope | |
| 18:29:38 | sean-k-mooney | we have for flavor based pci passthough | |
| 18:29:43 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_pci_sriov_servers.py | |
| 18:29:52 | sean-k-mooney | but no fucntional test for neutorn sriov | |
| 18:30:03 | artom | So manual testing it is | |
| 18:30:07 | sean-k-mooney | so we would have to extend the neutron mock | |
| 18:30:12 | artom | Yeah | |
| 18:30:15 | sean-k-mooney | but we could add them if we did | |
| 18:30:57 | sean-k-mooney | i dont think we have any livemigration functional tests that use the libvirt fake driver | |
| 18:31:09 | artom | We didn't | |
| 18:31:16 | artom | NUMA LM's going to be the first | |
| 18:31:37 | artom | You meant fakelibvirt, right? | |
| 18:31:42 | sean-k-mooney | so your going to implement the multiple port bidnign workflow in the neutron fixtures | |
| 18:31:46 | sean-k-mooney | yes | |
| 18:31:47 | artom | Because we have a couple that use fake virt | |
| 18:31:49 | sean-k-mooney | fakelibvirt | |
| 18:32:03 | artom | sean-k-mooney, Ha. Ha. Ha. | |
| 18:32:26 | sean-k-mooney | artom: you will need that form live migration testing i think | |
| 18:32:37 | sean-k-mooney | you would for sriov lm | |
| 18:32:50 | artom | sean-k-mooney, heh, one thing at a time :) | |
| 18:32:55 | sean-k-mooney | for numa you could fall back to the old codepath | |
| 18:33:06 | artom | If we decide neutron sriov func test is something we want, I don't mind doing it | |
| 18:33:19 | artom | But for NUMA LM it's irrelevant | |
| 18:36:14 | sean-k-mooney | it would be nice to have functional test for this at some point but i think we shoudl wait till U to do that | |
| 18:36:28 | sean-k-mooney | at least that we we can do some firstpart testing beyond unit tests | |
| 18:37:24 | mriedem | sean-k-mooney: https://review.opendev.org/#/c/678098/2 needs to mention the reason for the difference in the backport (in the commit message) | |
| 18:37:27 | mriedem | otherwise it looks OK | |
| 18:37:47 | sean-k-mooney | ok ill respin it now | |
| 18:38:51 | sean-k-mooney | it was this https://github.com/openstack/os-vif/commit/ee124d2e98c2660ced7d71c1bd10525bf095a939 | |
| 18:38:58 | mriedem | yeah i just ofund that | |
| 18:38:58 | mriedem | Id8b71172fb06b435cf169a7e55c11233f22fa65b | |
| 18:44:02 | openstackgerrit | sean mooney proposed openstack/os-vif stable/stein: only disable mac ageing for ovs hybrid plug https://review.opendev.org/678098 | |
| 18:44:10 | sean-k-mooney | something like ^ | |
| 18:44:27 | sean-k-mooney | the other option we have would be to backport Id8b71172fb06b435cf169a7e55c11233f22fa65b | |
| 18:49:01 | mriedem | no we don't want to backport that big refactor | |
| 18:49:02 | mriedem | +2 on the other | |
| 18:49:20 | mriedem | melwitt: maybe you want to hit https://review.opendev.org/#/c/678098/ since lee is probably done | |
| 18:58:54 | mriedem | melwitt: any changes of getting https://review.opendev.org/#/c/507486/ and/or https://review.opendev.org/#/c/640898/ updated soonish before i lose context on those? | |
| 18:58:58 | mriedem | *chance | |
| 19:04:45 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.opendev.org/635669 | |
| 19:04:46 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827 | |
| 19:04:46 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for augmenting migrate_data with info from claims https://review.opendev.org/634828 | |
| 19:04:47 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.opendev.org/635229 | |
| 19:04:47 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606 | |
| 19:04:48 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021 | |
| 19:04:48 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Functional test for NUMA live migration https://review.opendev.org/672595 | |
| 19:16:39 | sean-k-mooney | artom: the last patch ^ is the one i should deploy yes? | |
| 19:16:51 | artom | sean-k-mooney, hol'up, things are in motion | |
| 19:16:57 | sean-k-mooney | have you added the sriov if? | |
| 19:16:58 | sean-k-mooney | ok | |
| 19:17:02 | artom | But in general, yeah | |
| 19:17:10 | artom | I did add the if | |
| 19:17:26 | sean-k-mooney | im not quite ready yet to run it but its close | |
| 19:17:50 | sean-k-mooney | i normlly run a vanila devstack install first then switch to the ting i want to test | |
| 19:18:01 | openstackgerrit | Eric Fried proposed openstack/nova master: Allow strict_proxies for sdk Connection https://review.opendev.org/676926 | |
| 19:19:00 | efried | I think I oughtta rebase the ironic series on that ^ and switch it on. | |
| 19:24:05 | openstackgerrit | Eric Fried proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899 | |
| 19:24:06 | openstackgerrit | Eric Fried proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027 | |
| 19:24:06 | openstackgerrit | Eric Fried proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028 | |
| 19:24:07 | openstackgerrit | Eric Fried proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690 | |
| 19:24:07 | openstackgerrit | Eric Fried proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691 | |
| 19:24:08 | openstackgerrit | Eric Fried proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213 | |
| 19:24:10 | efried | so there's that | |
| 19:38:26 | NobodyCam | Happy Friday Nova folks | |
| 19:38:47 | dansmith | don't fall for it, it's a trap | |
| 19:39:30 | NobodyCam | off the wall question; is it possible to the kvm vgamem option per flavor or image? | |
| 19:39:35 | NobodyCam | lol | |
| 19:39:38 | dansmith | see ^ | |
| 19:39:46 | sean-k-mooney | NobodyCam: yes | |
| 19:39:54 | sean-k-mooney | you can change it via the image | |
| 19:40:15 | NobodyCam | Nice! :) | |
| 19:40:21 | NobodyCam | Thank you | |
| 19:40:24 | sean-k-mooney | https://github.com/openstack/glance/blob/master/etc/metadefs/compute-libvirt-image.json#L57-L62 | |
| 19:40:41 | sean-k-mooney | also we dont test that so it might be broken | |
| 19:40:48 | sean-k-mooney | but it should work | |
| 19:40:53 | sean-k-mooney | let us know | |
| 19:41:31 | sean-k-mooney | oh and apparently you can set a limit in the flavor | |
| 19:44:16 | NobodyCam | I'll play with that | |
| 19:44:25 | NobodyCam | <model type='qxl' ram='65536' vram='65536' vgamem='16384' heads='1' primary='yes'/> | |
| 19:44:41 | NobodyCam | is what I'm getting by default | |
| 19:45:43 | sean-k-mooney | ya this is the code that uses it in the livbrt dirver | |
| 19:45:44 | sean-k-mooney | https://opendev.org/openstack/nova/src/branch/master/nova/virt/libvirt/driver.py#L4809-L4846 | |
| 19:45:52 | sean-k-mooney | apparently its supported by vmware too | |
| 19:46:30 | sean-k-mooney | i think that default is coming form libvirt | |
| 19:48:49 | NobodyCam | yea looking at the code I'm not sure that will get me what I'm looking for | |
| 19:49:07 | sean-k-mooney | what are you trying to do | |
| 19:49:42 | sean-k-mooney | oh you want to change vgamem | |
| 19:49:45 | sean-k-mooney | not vram | |
| 19:50:48 | sean-k-mooney | https://libvirt.org/formatdomain.html#elementsVideo looking at the docs | |
| 19:51:10 | sean-k-mooney | vgamem is used for the size of the fallback framebuffer for the qxl type only | |
| 19:52:26 | NobodyCam | oh, yea reading that now | |
| 19:52:57 | sean-k-mooney | vram is basicaly the amount of ram reported to as on the grapics card to the guest | |
| 19:53:19 | sean-k-mooney | so its normally the only one you care about changing | |
| 19:54:02 | NobodyCam | yea, Let me test that, Thank you sean-k-mooney :) | |
| 19:54:58 | sean-k-mooney | no worries. i added suport for requestion virtio a few weeks ago so it relitivly fresh in my mind since i wen though all the option at that time | |