Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-08-23
16:37:47 dansmith but does the scheduler actually use some of this information anymore?
16:37:51 dansmith right, okay, the legacy things
16:38:27 artom So because we'll be tracking all live migrations, we need to do claims for all live migrations, not just NUMA ones
16:38:35 artom (which is what's currently in the patch series)
16:38:39 dansmith so right now we don't report this for live migrations, nor do we claim, so the numa filter will send us things we don't have room for, and we also won't do claims to check that it was wrong, right?
16:38:55 artom Yep
16:39:14 dansmith okay, but non-numa-affected live migrations are already protected and don't need anything else right?
16:39:21 dansmith because we're depending on placement for the non-numa resources
16:39:32 artom Yeah, that should be fine
16:39:40 artom I was more worried about things like PCI
16:40:05 artom Though I guess we don't support live migrations for those at all, so it the claim fails, it'll just be a plus
16:40:11 dansmith no live migration with pci devices yeah?
16:40:12 dansmith right
16:40:16 dansmith so to continue my thought above,
16:40:21 artom Though that's completely untested
16:40:30 dansmith I think you can save that change until the very end,
16:40:56 dansmith because once we're claiming, we're doing better than we are today, and then we can start reporting them, which is another incremental improvement to make the scheduler make better decisions
16:41:24 artom The very end == the massive squashed patch, right?
16:41:35 dansmith well, wherever
16:41:38 dansmith just saing,
16:41:53 dansmith it doesn't need to be synchronous with the change to claim I think
16:42:29 artom Oh, right, that's a given. I've addressed all that feedback, now working on squashing
16:42:43 dansmith okay
16:42:59 dansmith seems like it might be a good candidate for being its own patch though.. right?
16:44:23 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove 'hw:cpu_policy', 'hw:mem_page_size' extra specs from API samples https://review.opendev.org/675338
16:44:24 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement https://review.opendev.org/671792
16:44:24 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: '_get_(v|p)cpu_total' to '_get_(v|p)cpu_available' https://review.opendev.org/672693
16:44:25 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Rewrap definitions of 'NUMACell' https://review.opendev.org/674395
16:44:25 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800
16:44:26 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Rename 'fields' import to 'obj_fields' https://review.opendev.org/674103
16:44:26 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait https://review.opendev.org/675571
16:44:27 openstackgerrit Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801
16:44:27 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Fold in argument to '_update_provider_tree_for_vgpu' https://review.opendev.org/676729
16:44:28 openstackgerrit Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895
16:44:57 artom dansmith, don't think so - it depends on the RPC changes, and once we start claiming, we need all the other things as well - rollback/application of the migration context, etc
16:45:19 dansmith um
16:45:27 dansmith artom: the reporting stands alone, no?
16:45:55 artom dansmith, it uses the resource tracker, which is affected by claims
16:46:03 artom You're making me doubt myself now
16:46:11 dansmith artom: if we don't report (as we don't today) then the scheduler will keep making the same decisions it is today, but we can stop an operation if the claim tells us there isn't space
16:46:20 dansmith we don't alter the claims as part of that routine do we?
16:47:21 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement https://review.opendev.org/671793
16:47:21 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: '_get_(v|p)cpu_total' to '_get_(v|p)cpu_available' https://review.opendev.org/672693
16:47:22 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Rewrap definitions of 'NUMACell' https://review.opendev.org/674395
16:47:22 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800
16:47:23 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Rename 'fields' import to 'obj_fields' https://review.opendev.org/674103
16:47:23 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait https://review.opendev.org/675571
16:47:24 openstackgerrit Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801
16:47:24 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Fold in argument to '_update_provider_tree_for_vgpu' https://review.opendev.org/676729
16:47:25 openstackgerrit Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895
16:47:38 artom dansmith, I might be misunderstanding you entirely, but reporting and claims go hand in hand - when we start claiming, we'll automatically get correct reporting
16:48:03 artom Well
16:48:16 artom Unless we keep ignoreing live migration in the resource tracker
16:48:50 stephenfin mriedem: How does one kick off tempest tests when they wouldn't normally run? https://review.opendev.org/#/c/677475/
16:49:10 stephenfin (because irrelevant-files, I'm assuming)
16:49:42 artom dansmith, is that what you meant? Move the "stop ignoreing live migrations in the resource tracker" to its own small patch on top?
16:50:14 dansmith artom: yes, but, I need to re-read this claims stuff
16:50:24 dansmith maybe I'm making CLAIMS that are incorrect
16:50:30 artom dansmith, ack. Sounds like a good place for me to get lunch
16:50:58 artom dansmith, HI-OH
16:51:01 openstackgerrit Stephen Finucane proposed openstack/nova master: setup.cfg: Cleanup https://review.opendev.org/677969
16:51:16 artom dansmith, want me to push the bottom fixes?
16:51:23 dansmith I think it's because all the regular claim code has been removed
16:51:24 dansmith artom: yes
16:52:45 dansmith I thought the only bits left of the claiming stuff don't actually really interact that much with the resource tracker,
16:53:01 dansmith and rather just see if the things being asked for exist on the compute.. meaning the pci device and the numa arrangement
16:53:17 dansmith so I'm not sure why the reporting stuff is really related directly
16:54:40 openstackgerrit Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.opendev.org/635669
16:54:40 openstackgerrit Artom Lifshitz proposed openstack/nova master: New objects for NUMA live migration https://review.opendev.org/634827
16:54:41 openstackgerrit Artom Lifshitz proposed openstack/nova master: LM: add support for augmenting migrate_data with info from claims https://review.opendev.org/634828
16:54:41 openstackgerrit Artom Lifshitz proposed openstack/nova master: LM: add support for updating NUMA-related XML on the source https://review.opendev.org/635229
16:54:42 openstackgerrit Artom Lifshitz proposed openstack/nova master: NUMA live migration support https://review.opendev.org/634606
16:54:42 openstackgerrit Artom Lifshitz proposed openstack/nova master: Deprecate CONF.workarounds.enable_numa_live_migration https://review.opendev.org/640021
16:54:43 openstackgerrit Artom Lifshitz proposed openstack/nova master: Functional test for NUMA live migration https://review.opendev.org/672595
16:54:47 efried dansmith: I should only have to restart n-cpu to pick up a change in oslo.service, yah?
16:54:53 efried at least, the change we care about
16:55:08 dansmith efried: if you're just testing that service then obviously :)
16:55:35 efried I didn't know if other services and their e.g. RPC objects would care.
16:56:05 efried dansmith: Then I've confirmed the oslo.service fix doesn't fix the problem.
16:56:31 efried (which doesn't mean it's wrong, just not complete)
16:57:17 dansmith artom: okay, I see now, I forgot how this works, but I see that if we don't remove that skip we won't do the actual checking of anything, so ignore me
16:57:20 dansmith efried: sweet
16:58:35 artom dansmith, yeah, it's coupling great?
16:58:40 artom *isn't
16:59:06 artom Right, pushed, bottom 4 should be good, now lunch
17:01:51 ozzzo It looks like nova is keeping mysql connections open until they time out. Is there a way to stop these error messages?
17:02:00 ozzzo Aborted connection 10726 to db: 'nova' user: 'nova' host: 'asdf' (Got timeout reading communication packets)
17:16:08 mnaser efried: if you have a few seconds, i wanted to know if you had thoughts about https://review.opendev.org/#/c/676540/ -- should i mark it no longer as deprecated as it's clearly being used?
17:17:46 efried mnaser: or propose whatever alternative we would prefer. mriedem ^
17:18:39 mnaser i mean if it's clearly being consumed, then i don't mind making the change to stop marking is an deprecated..
17:25:43 openstackgerrit Merged openstack/nova stable/rocky: Remove experimental job on openSUSE 42.3 https://review.opendev.org/677176
17:25:50 openstackgerrit Merged openstack/nova stable/queens: Remove experimental job on openSUSE 42.3 https://review.opendev.org/677177
17:25:57 openstackgerrit Merged openstack/nova stable/pike: Remove experimental job on openSUSE 42.3 https://review.opendev.org/677178
17:28:37 efried mriedem, dansmith: Posted details on the SIGHUP patch https://review.opendev.org/#/c/641907/
17:29:01 efried We are indeed breaking the privsep pipe (/me says as if I know what I'm talking about)
17:29:15 efried unclear where that would need to be fixed.
17:29:42 mriedem stephenfin: yeah irrelevant-files
17:36:47 sean-k-mooney stephenfin: add a followup [DNM] patch that add whitespace to a file that would trigger tempest or temporally remove one fo the fiels from irrelevent-files. i generall prefer to have a DNM testing patch as i can just run the job i care about.
17:37:39 mriedem efried: mnaser: i think we likely should undeprecate the direct file download stuff since clearly there are users and those users have made attempts to upstream an alternative solution which hasn't been approved, but not wholesale rejected either from what i understand, so it's probably not good to just rip it out from them when we're not providing an alternative
17:38:16 efried wfm

Earlier   Later