| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-22 | |||
| 12:19:31 | gibi | shilpasd: it is how I understand the spec https://review.opendev.org/#/c/609960/8/specs/train/approved/placement-req-filter-forbidden-aggregates.rst@20 | |
| 12:19:58 | shilpasd | gibi: yes | |
| 12:19:59 | gibi | so if the keys are empty then we have to forbid every aggregates that has some kind of metadata set | |
| 12:20:28 | shilpasd | so we shouldn't raise ValueError in DB for ignored_keys empty | |
| 12:21:37 | shilpasd | https://review.opendev.org/#/c/671074/8/nova/objects/aggregate.py@472 | |
| 12:22:43 | gibi | shilpasd: you are correct. so if there is no ignored_keys then we have to return every aggregate that has metadata.value set to "required" | |
| 12:23:04 | gibi | shilpasd: so my comment is wrong in https://review.opendev.org/#/c/671074/8/nova/objects/aggregate.py@472 | |
| 12:23:37 | shilpasd | gibi: ok, will skip this | |
| 12:25:29 | gibi | shilpasd: I guess i mixed up ignored_keys and key_prefix. See https://review.opendev.org/#/c/671074/8/nova/objects/aggregate.py@473 | |
| 12:26:19 | shilpasd | gibi: no prob, tnx for discussion | |
| 12:26:33 | gibi | shilpasd: thanks for double checking my comment | |
| 12:26:46 | shilpasd | will have ValueError at beginning only for key_prefix | |
| 12:27:16 | gibi | shilpasd: ack | |
| 12:27:23 | shilpasd | thank you | |
| 12:54:09 | openstackgerrit | Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680 | |
| 12:58:29 | aspiers | stephenfin: thanks for your recheck on https://review.opendev.org/#/c/673151/16 - but any idea why it's rerunning the check jobs not the gate jobs? | |
| 12:59:07 | stephenfin | aspiers: no idea. That's just the way it's always done it. It's a zuul thing, I imagine | |
| 12:59:31 | aspiers | Oh, I thought that once it hit the gate, recheck would only redo the gate jobs | |
| 12:59:40 | aspiers | Thought I'd seen that behaviour before | |
| 12:59:57 | aspiers | Seems kinda pointless to rerun the check jobs when nothing has changed there | |
| 13:00:09 | aspiers | Oh well, check is almost finished, gate soon | |
| 13:10:44 | openstackgerrit | Merged openstack/nova master: Make memtune parameters consistent with libvirt docs and code https://review.opendev.org/636301 | |
| 13:10:52 | openstackgerrit | Merged openstack/nova master: fakelibvirt: Stop distinguishing between NUMA, non-NUMA https://review.opendev.org/675570 | |
| 13:11:56 | belmoreira | melwitt I'm upgrading nova to stein and i'm having issues with novnc | |
| 13:13:27 | belmoreira | as part of the consoleauth deprecation where are the tokens stored? | |
| 13:13:30 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Nova object changes for forbidden aggregates request filter https://review.opendev.org/671072 | |
| 13:22:17 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: DB API changes to get non-matching aggregates from metadata https://review.opendev.org/671074 | |
| 13:24:15 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Add a new request filter to isolate aggregates https://review.opendev.org/671075 | |
| 13:27:33 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Enable request filter isolate_aggregates https://review.opendev.org/667952 | |
| 13:32:11 | belmoreira | I would really appreciate some help with vnc | |
| 13:32:46 | belmoreira | when using workarounds/enable_consoleauth=true we don't keep the previous behaviour? | |
| 13:33:08 | belmoreira | tokens are now stored in the cell db. | |
| 13:33:36 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Update docstring of 'revert_resize' function https://review.opendev.org/665976 | |
| 13:33:37 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522 | |
| 13:33:37 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Cleanup of '_test_resize' helper test https://review.opendev.org/664245 | |
| 13:33:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add '_setup_compute_services' helper https://review.opendev.org/663102 | |
| 13:33:57 | belmoreira | the was I'm running novnc is global, so is not connecting to the db to check the token | |
| 13:34:14 | belmoreira | s/was/way | |
| 13:34:27 | adrianc | stephenfin, sean-k-mooney : do we have a verdict on: https://review.opendev.org/#/c/675776/ ? | |
| 13:35:20 | sean-k-mooney | we could revert it and not that this is need due to a bug in the sriov nic agent | |
| 13:36:38 | stephenfin | belmoreira: melwitt will hopefully correct me if I say anything wrong, but '[workarounds] enable_consoleauth' enables a fallback path to help with migration to the new DB-based system | |
| 13:36:43 | sean-k-mooney | there is nolonger a need to set the mac for libvirt but it valid to still set it untill the sriov nic agent is updated. it is a bug that the agent depens on the mack however | |
| 13:37:19 | stephenfin | Emphasis on fallback. We'll use the DB tokens first and foremost and only fallback if no tokens are found | |
| 13:37:34 | adrianc | "a historic design decision" :) | |
| 13:37:37 | belmoreira | stephenfin I'm trying to use that without success. | |
| 13:38:31 | sean-k-mooney | adrianc: the historic design descis being the only thing that was allowed to be depeded on is the pci address :) | |
| 13:38:41 | sean-k-mooney | at somepoint i guess neutron forgot that | |
| 13:39:31 | sean-k-mooney | the sriov nic agent is in principal ment to be able to work with non libvirt virt drivers too | |
| 13:39:33 | belmoreira | stephenfin token validation fails | |
| 13:40:08 | sean-k-mooney | like xen or powervm although i dont know if it is used with either | |
| 13:40:26 | yonglihe | sean-k-mooney: thanks given your valuable +1 for https://review.opendev.org/#/c/621476/ | |
| 13:40:50 | stephenfin | belmoreira: Odd. I'm looking at commit 969239029d4a13956747e6e0b850d6c6ab4035f0 rn to see what could possibly be going wrong | |
| 13:41:36 | stephenfin | belmoreira: Dumb question, but you have this option set on the conf files used by the 'nova-novncproxy' service, right? | |
| 13:41:51 | belmoreira | stephenfin yes | |
| 13:41:58 | stephenfin | Cool. Just checking :) | |
| 13:42:01 | sean-k-mooney | stephenfin: feel like sending https://review.opendev.org/#/c/621476/ on its way and closing out that blueprint | |
| 13:42:48 | stephenfin | I'd been holding off on that because I still wasn't sure how I feel about that whole thing, heh | |
| 13:43:02 | stephenfin | But yeah. Let me finish looking into this consoleauth thing first though | |
| 13:43:19 | sean-k-mooney | ok if you have time to add it to your review queue then its an easy win assumeing you decide how you feel about it | |
| 13:43:33 | adrianc | sean-k-mooney: ill open a bug in neutron, once the revert is in ill abandon https://review.opendev.org/#/c/676713 | |
| 13:44:31 | sean-k-mooney | adrianc: why abandon that? it would be good to open the bug first and update the comment to reference the new bug | |
| 13:44:43 | sean-k-mooney | oh because it still depens on the mac | |
| 13:44:56 | sean-k-mooney | jsut looks at a different source | |
| 13:45:07 | adrianc | yah, we talked that changes will be required from server side | |
| 13:45:16 | adrianc | i.e the mechanism driver | |
| 13:46:19 | stephenfin | belmoreira: Have you tracebook to look at? There are a couple of InvalidToken exceptions that could be raised in that code | |
| 13:46:23 | stephenfin | *trackback | |
| 13:46:25 | stephenfin | *traceback | |
| 13:46:28 | stephenfin | third time lucky | |
| 13:48:01 | openstackgerrit | Alexandre arents proposed openstack/nova master: Abort live-migration during instance_init https://review.opendev.org/678016 | |
| 13:48:51 | stephenfin | I can't see anything obvious there, though I was wrong with my statement about it being a fallback. If that's toggled, we check the consoleauth service first, not after | |
| 13:51:14 | belmoreira | stephenfin: from consoleauth: Checking Token: ***, False | |
| 13:52:22 | shilpasd | gibi: Hi, i have pushed revised patches (waiting for zuul) but i have lost your +2s, requesting you to review/vote further, thanks | |
| 13:53:40 | shilpasd | Addressed your review comments and uploaded patches for isolated aggregates patches. | |
| 13:54:02 | belmoreira | stephenfin: from nova-novncproxy: https://www.codepile.net/pile/O1P8ee1q | |
| 13:54:55 | stephenfin | belmoreira: Should I see something there? | |
| 13:55:55 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Update docstring of 'revert_resize' function https://review.opendev.org/665976 | |
| 13:56:32 | belmoreira | stephenfin: the way that is deployed is global. nova-novncproxy and consoleauth are not deployed per cell | |
| 13:57:54 | stephenfin | Oh, that could be problematic | |
| 13:58:04 | belmoreira | stephenfin: that is the trace that I get. the "code 404, message File not found" is new to me | |
| 14:00:03 | efried | nova meeting now | |
| 14:00:08 | Sundar | dansmith, sean-k-mooney, mriedem, gibi: Can you please review https://review.opendev.org/#/q/status:open+project:openstack/nova+bp/nova-cyborg-interaction ? I have added the notification and addressed the main comments. Will add more UT, tempest CI framework is making progress. | |
| 14:00:43 | Sundar | Well, all are welcome to review. | |
| 14:00:45 | stephenfin | belmoreira: I think you're going to need to open a bug for this. I don't know if this has been discussed as an issue before (I don't recall it having been so) | |
| 14:01:10 | efried | sean-k-mooney: We were going to wait until the name was official to start creating the artifacts in lp and nova-specs. If you have a spec you want to open right now, you can write it against backlog/ and then move it. | |
| 14:01:26 | sean-k-mooney | Sundar what os are you deveoping on? i can try and deploy the series in a vm | |
| 14:01:49 | efried | alex_xu, sean-k-mooney, aspiers: request filter stuff after the meeting? | |
| 14:01:59 | alex_xu | efried: yea | |
| 14:02:03 | sean-k-mooney | it will be next week before i can spend a lot of time on ith however | |
| 14:02:05 | belmoreira | stephenfin ok thanks | |
| 14:02:18 | sean-k-mooney | efried: ya i can do that. its going to be really short anyway | |
| 14:03:21 | sean-k-mooney | efried: stephenfin and i have an internal team meeting after the nova meeting but we will be still on irc | |
| 14:03:25 | Sundar | sean-k-mooney: It is Centos 7.6, kernel 3.10.0-957 | |
| 14:03:34 | Sundar | Thanks | |
| 14:03:54 | sean-k-mooney | Sundar: im assuming you testing with python 2 still? or python 3 | |
| 14:04:04 | Sundar | Yes, python 2 | |
| 14:04:35 | sean-k-mooney | ok i have been having issue with centos and python2 lately but ill spin up a vm and try and deploy it | |
| 14:04:50 | belmoreira | stephenfin is there any recommendation how to setup nonvc with multiple cells? | |
| 14:04:55 | aspiers | efried: sure | |
| 14:05:07 | dansmith | belmoreira: I think you really want to talk to melwitt | |