| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-20 | |||
| 14:23:12 | mriedem | in our docs | |
| 14:23:22 | mnaser | but we dont have psycopg in requirements, only in test-requirements i think | |
| 14:23:28 | mnaser | no db driver exists in requirements afaik | |
| 14:23:28 | mriedem | if we're building an api doc, it's a waste of time | |
| 14:24:03 | mriedem | mnaser: correct. -1 on the lower-constraints thing, otherwise i'd be +2. | |
| 14:24:10 | mriedem | might as well address efried's comments as well | |
| 14:24:47 | stephenfin | mriedem: We do. See doc/source/reference/services.rst and doc/source/reference/services.rst | |
| 14:25:04 | stephenfin | doc/source/reference/notifications.rst | |
| 14:25:04 | stephenfin | 145:.. automodule:: nova.notifications.objects.base | |
| 14:25:04 | stephenfin | doc/source/reference/services.rst | |
| 14:25:04 | stephenfin | 31:.. automodule:: nova.service | |
| 14:25:04 | stephenfin | 41:.. automodule:: nova.manage | |
| 14:25:26 | mriedem | oh god, we could just remove that | |
| 14:25:43 | stephenfin | no argument from me (y) | |
| 14:25:56 | mriedem | that's probably a relic from when you could extend that stuff via config out of tree | |
| 14:26:00 | mriedem | we removed that eons ago | |
| 14:26:13 | stephenfin | even the notifications stuff? | |
| 14:26:45 | mriedem | ew this https://docs.openstack.org/nova/latest/reference/notifications.html#the-nova-notifications-objects-base-module | |
| 14:27:12 | mriedem | that's actually useful for contributors adding new versioned notifications | |
| 14:27:23 | mriedem | is there a way to only build part of the api doc and not all of it? | |
| 14:28:04 | stephenfin | not that I'm aware of, but that autodoc package is really tough to grok | |
| 14:29:55 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Move DB, virt driver deps to 'extras' https://review.opendev.org/677475 | |
| 14:29:59 | stephenfin | mnaser, mriedem, aspiers: WIP but I think that would do the trick ^ | |
| 14:30:41 | prometheanfire | if I had to do it again... | |
| 14:31:38 | efried | alex_xu, sean-k-mooney: I think we now need to write a crisp discussion-free version of the design points as refined. I recommend either creating a new etherpad or shunting the current content down and doing it above. | |
| 14:31:42 | aspiers | stephenfin: cool! how do you use extras? | |
| 14:31:51 | stephenfin | prometheanfire: I'd do it with you? 🎶 | |
| 14:32:10 | stephenfin | aspiers: 'cd nova; pip install .[mysql]' | |
| 14:32:25 | sean-k-mooney | efried: yes we do. | |
| 14:32:36 | aspiers | stephenfin: what is that voodoo syntax! :) | |
| 14:32:37 | stephenfin | or 'pip install .[mysql,postgres,foo]' | |
| 14:32:43 | sean-k-mooney | efried: over all do you think this is a workable direction | |
| 14:32:44 | aspiers | never seen that before | |
| 14:32:55 | alex_xu | efried: got it | |
| 14:33:21 | stephenfin | now you know :) | |
| 14:33:29 | sean-k-mooney | stephenfin: that is install the python module in the current folder with the [] extras packages listed in the brackets right | |
| 14:33:35 | stephenfin | fwiw, that's what pbr is doing for 'doc/requirements.txt' under the hood | |
| 14:33:40 | stephenfin | it just generates a docs extra | |
| 14:33:50 | stephenfin | sean-k-mooney: correctamundo | |
| 14:34:37 | stephenfin | it also works with packages for PyPI, e.g. 'pip install oslo.db[mysql]' | |
| 14:34:43 | stephenfin | *from | |
| 14:35:26 | sean-k-mooney | alex_xu: i think it would be useful if you used both pmem and vgpus as example of how this could be used | |
| 14:35:41 | alex_xu | sean-k-mooney: good idea | |
| 14:37:15 | efried | sean-k-mooney: Workable, yes. Whether it's going to get by mriedem and dansmith is another question. But let's have that crisp writeup for them to look at so they don't have to try to follow our chicken-scratch stream of consciousness | |
| 14:38:20 | openstackgerrit | Mohammed Naser proposed openstack/nova master: requirements: move to using psycopg2-binary https://review.opendev.org/676684 | |
| 14:38:33 | mnaser | mriedem: ^ good call on lower-constraints | |
| 14:42:02 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Libvirt: add support for vPMU configuration. https://review.opendev.org/671338 | |
| 14:43:09 | mriedem | sean-k-mooney: i fixed up some nits in the libvirt driver tests https://review.opendev.org/#/c/671338/13 | |
| 14:43:10 | mriedem | +2 | |
| 14:43:17 | mriedem | stephenfin: i'm +2 on the vpmu change now https://review.opendev.org/#/c/671338/13 | |
| 14:43:28 | stephenfin | (y) | |
| 14:43:29 | mriedem | sean-k-mooney: you still need to update this v | |
| 14:43:30 | mriedem | https://review.opendev.org/#/c/675182/2 | |
| 14:43:34 | sean-k-mooney | mriedem: thanks :) | |
| 14:43:44 | sean-k-mooney | is that the glance change | |
| 14:43:47 | mriedem | yes | |
| 14:43:56 | sean-k-mooney | its on the todo list for today | |
| 14:44:32 | sean-k-mooney | im just finishing up myu prefilter change based on stephenfin commenst | |
| 14:44:39 | sean-k-mooney | then ill update both glance patches | |
| 14:46:37 | sean-k-mooney | stephenfin: ill address your comments on the deprecation patch after all of that is done ^ | |
| 14:48:22 | mriedem | melwitt: so abandon https://review.opendev.org/#/c/675218/ at this point yeah? | |
| 14:49:18 | aspiers | alex_xu: does https://review.opendev.org/#/c/638680/46/nova/tests/functional/libvirt/test_report_cpu_traits.py@92 make sense now? | |
| 14:50:57 | mriedem | melwitt: actually https://review.opendev.org/#/c/507486/67/nova/db/sqlalchemy/api.py@5572 | |
| 14:52:07 | sean-k-mooney | aspiers im changeing how some of that works by the way. | |
| 14:52:08 | mriedem | heh yeah in PS65 you had this: | |
| 14:52:08 | mriedem | meta = MetaData(get_engine(context=context, use_slave=True)) | |
| 14:52:28 | aspiers | sean-k-mooney: some of which? | |
| 14:52:40 | sean-k-mooney | how the libvirt driver reports traits | |
| 14:52:52 | aspiers | sean-k-mooney: I'm just reviewing your patch now | |
| 14:53:38 | aspiers | sean-k-mooney: you mean https://review.opendev.org/#/c/666915/8/nova/virt/libvirt/driver.py ? | |
| 14:54:19 | sean-k-mooney | that and the general helper function i have intoduced to remove most of the bolier plate | |
| 14:57:34 | sean-k-mooney | aspiers: hopefully the chagne wont conflict or wont confict too badly just wanted you to be aware | |
| 14:57:50 | aspiers | sean-k-mooney: I don't think it will conflict because the SEV trait is provided via a capability | |
| 14:58:27 | sean-k-mooney | ok | |
| 14:58:38 | aspiers | fingers crossed anyway, because you are just ahead of me on the runway X-D | |
| 15:01:17 | sean-k-mooney | sure i am vauguly aware that the new version of lxml broke things | |
| 15:02:36 | sean-k-mooney | i had thought that there was a larger patch that capped 4 or 5 libs floating around somewhere | |
| 15:05:01 | sean-k-mooney | efried: this is the ml thread http://lists.openstack.org/pipermail/openstack-discuss/2019-August/008562.html | |
| 15:05:55 | efried | yes | |
| 15:06:25 | sean-k-mooney | i think the bug present in how we compare xmls as equal or somthing like that | |
| 15:06:45 | sean-k-mooney | so i dont think it breaks the libvirt dirver but does break our unit tests | |
| 15:06:56 | efried | sean-k-mooney: in short, we either need to see if we can fix this in nova, or blacklist the lxml version(s) and open bugs against them and eventually uncap if/when they fix etc etc. | |
| 15:07:39 | sean-k-mooney | we likely shoudl be able to fix it in nova. ill see if i can repoduce this later today. | |
| 15:08:06 | efried | thanks sean-k-mooney. It just looks like attr ordering. We could probably resolve it in XMLMatcher, I would think. | |
| 15:08:16 | efried | I'm actually kind of surprised that that's not already taken into account there. | |
| 15:08:27 | sean-k-mooney | current upper-constratis is set to 4.3.4? so we dont hit this | |
| 15:08:27 | efried | or maybe those tests aren't using XMLMatcher. | |
| 15:08:48 | efried | sean-k-mooney: that's the point, prometheanfire is trying to get u-c to the latest published versions and running into this. | |
| 15:09:19 | sean-k-mooney | yep i know but we simply would not uncapp them in Train if that was not fixed by m3 | |
| 15:09:32 | sean-k-mooney | we should be able to fix it if its not too pervasive before then | |
| 15:10:20 | sean-k-mooney | it could be that it broke the XMLMatcher i just vaguly recall talking to prometheanfire about this so need to look at the actull error first to load context | |
| 15:12:42 | prometheanfire | ya, think we talked about it, wasn't it an ordering thing? | |
| 15:12:49 | sean-k-mooney | yep | |
| 15:12:54 | sean-k-mooney | i think so | |
| 15:13:19 | sean-k-mooney | once i reporduce it it will likely be a simple fix | |
| 15:13:33 | sean-k-mooney | either use the matcher if its using it already or fix the matcher | |
| 15:13:53 | sean-k-mooney | we created the xmlmatcher to ignore order | |
| 15:14:17 | sean-k-mooney | unlike other markup formate whitespace in xml and order is technically signifcant | |
| 15:14:22 | prometheanfire | just made https://review.opendev.org/677480 for you to submit reviews against to test (if you want) | |
| 15:15:01 | sean-k-mooney | ya i saw i can just add a depens on to make sure it passes | |