Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-08-19
16:37:19 openstackgerrit Adam Spiers proposed openstack/nova master: Add and to config.py https://review.opendev.org/636318
16:37:19 openstackgerrit Adam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565
16:37:20 openstackgerrit Eric Fried proposed openstack/nova-specs master: tox -e fast-specs https://review.opendev.org/673356
16:41:20 openstackgerrit Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420
16:42:04 openstackgerrit Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334
16:42:05 openstackgerrit Adam Spiers proposed openstack/nova master: Add and to config.py https://review.opendev.org/636318
16:42:05 openstackgerrit Adam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565
16:48:54 openstackgerrit Adam Spiers proposed openstack/nova master: Make it easier to run a selection of tests relevant to ongoing work https://review.opendev.org/677180
16:54:52 openstackgerrit sean mooney proposed openstack/nova master: Libvirt: add support for vPMU configuration. https://review.opendev.org/671338
16:55:14 sean-k-mooney mriedem: ^ should address your vpmu nits. im going to grab something to eat quickly but if you see anything else leave a comment and ill fix it in an hour or so
16:55:22 openstackgerrit Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616
17:01:44 efried mriedem: are you in favor of gating requirements on py37 using cross-nova? https://review.opendev.org/#/c/677071/5
17:01:44 efried Basically (IMO) we need *some* reasonable py37 coverage in there, and nova seemed as good as any.
17:06:15 mriedem gmann: comments in your novaclient 2.75 change https://review.opendev.org/#/c/676275/
17:07:43 mriedem is openstack-py37 voting on nova changes?
17:07:53 mriedem looks like yes
17:08:16 mriedem https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/zuul.d/jobs.yaml#L166
17:09:13 mriedem so yeah +1
17:09:37 efried thanks mriedem
17:13:39 openstackgerrit Matt Riedemann proposed openstack/nova master: doc: cleanup 2.75 REST API microversion history doc https://review.opendev.org/677259
17:29:46 openstackgerrit Akihiro Motoki proposed openstack/nova master: PDF documentation build https://review.opendev.org/676730
17:38:13 openstackgerrit Adam Spiers proposed openstack/nova-specs master: Allow deep-linking to memory reservation section of AMD SEV spec https://review.opendev.org/677264
18:01:12 aspiers err, why is there no direct link from https://docs.openstack.org/nova/latest/ to https://docs.openstack.org/nova/latest/user/ ?
18:04:03 efried aspiers: fix it!
18:07:39 aspiers efried: I was wondering if it was deliberate
18:08:14 aspiers "Todo
18:08:17 aspiers The rest of this document should probably move to the admin guide."
18:08:51 aspiers The top-level page directly links to some of the stuff under doc/source/user/
18:09:21 efried I can't imagine why the nova doc landing page wouldn't have a link to the user landing page anyway.
18:09:45 aspiers It does seem odd
18:09:53 aspiers but I find the whole doc organisation pretty confusing
18:10:12 efried agree
18:10:43 efried At some point donnyd was on a mission to reorganize, perhaps y'all could meet minds
18:11:16 aspiers when I've got this damn SEV series done
18:11:33 aspiers I'm pretty close now, just addressing your feedback on the tip of the series and then my backlog is clear I think
18:11:47 aspiers that is, until the next flood of -1s come in ;-)
18:14:53 aspiers efried: now I'm longing for tox -e fast-docs ...
18:15:36 openstackgerrit Matt Riedemann proposed openstack/nova master: api-ref: add config_drive to 2.75 rebuild response parameters https://review.opendev.org/677267
18:17:30 efried mriedem: Does this https://review.opendev.org/675908 smell like a stat mining / ATC grab exercise to you?
18:18:33 mriedem you mean just b/c it's nova-specs?
18:21:00 efried and because it's pointless, and because they put a co-author without any evidence of that person having co-authored anything, and because there's really nothing to co-author
18:21:21 efried basically this patch now has three contributors
18:21:50 efried Tempting to say, "you want a free summit ticket, go get it from somebody else's project"
18:21:51 donnyd efried: Still on that mission, but its hard to even get a start
18:22:09 efried I hear ya.
18:23:07 donnyd I am starting in docs with cyborg atm
18:49:51 mriedem efried: yeah... https://review.opendev.org/#/c/675908/3..4//COMMIT_MSG
18:50:49 mriedem i know "Add Python 3 Train unit tests" is a Train cycle goal - i don't really know what it is, but i know it's a goal
18:51:07 mriedem https://review.opendev.org/#/q/owner:%22Filippo+Inzaghi%22+status:open
18:51:27 efried yeah, I was okay with it at that point
18:52:03 efried But when Vieri, a notorious silent +1er, uploaded a new PS that added not him/her, but 98k, another notorious silent +1er, as co-author, my spidey sense went nuts.
19:00:59 efried dustinc: Are you busily debugging the ironic CI failure in patch #3 at this point?
19:01:52 openstackgerrit Matt Riedemann proposed openstack/nova master: doc: cleanup 2.75 REST API microversion history doc https://review.opendev.org/677259
19:01:53 openstackgerrit Matt Riedemann proposed openstack/nova master: api-ref: add config_drive to 2.75 rebuild response parameters https://review.opendev.org/677267
19:01:55 sean-k-mooney efried: well give we dont run the in repo test in the nova-specs gate i dont think https://review.opendev.org/#/c/675908/4 is relly useful
19:02:39 efried agree, it would be just for consistency with other projects, but I really don't think it's worthwhile.
19:02:48 mriedem efried: welcome to my world of being annoyed with random changes like this that just look like stat padding
19:03:06 mriedem and then my annoyance with people that are like, "what's the harm?! let them have their fun."
19:03:29 efried I don't mind stat padding if the change has *some* utility. But this one... doesn't.
19:05:55 efried mriedem: btw, I made this for you https://review.opendev.org/#/c/674678/
19:06:05 efried cmon man, I need to pad my stats
19:06:24 sean-k-mooney also nova-specs does not actully have any python deliverables. so personally i would rather remvoe the setup.cfg ectra that came form teh template to make it claer this is just a repo of text files and the tools needed to manage it. but i also dont really feel like writing a patch to do that or wasing your time reviewing it
19:07:26 sean-k-mooney i.e. rather then saying i support py37 and such. but thats just me
19:08:21 efried cmon sean-k-mooney, you need the stats
19:08:33 efried okay, enough of that joke
19:09:49 sean-k-mooney i -1'd it that will bump them enough
19:13:14 dustinc efried: actually was working on the providers stuff
19:13:19 dustinc providers.yaml
19:13:49 efried okay. Not trying to pressure you one way or another. Just lmk if you want help on that.
19:16:33 dustinc thanks, I probably need help on everything but just focusing on one thing at a time :)
19:33:37 openstackgerrit melanie witt proposed openstack/nova master: Re-use DB MetaData during archive_deleted_rows https://review.opendev.org/675218
19:33:38 openstackgerrit melanie witt proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.opendev.org/507486
19:33:38 openstackgerrit melanie witt proposed openstack/nova master: Verify archive_deleted_rows --all-cells in post test hook https://review.opendev.org/672840
19:35:36 openstackgerrit melanie witt proposed openstack/nova master: Verify archive_deleted_rows --all-cells in post test hook https://review.opendev.org/672840
20:03:51 openstackgerrit Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680
20:03:51 openstackgerrit Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420
20:03:52 openstackgerrit Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334
20:03:52 openstackgerrit Adam Spiers proposed openstack/nova master: Add and to config.py https://review.opendev.org/636318
20:03:53 openstackgerrit Adam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565
20:03:54 openstackgerrit Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616
20:08:58 openstackgerrit Adam Spiers proposed openstack/nova master: Switch some GitHub URLs to point to opendev.org https://review.opendev.org/677185
20:18:48 aspiers efried: all outstanding feedback on the SEV series has now been addressed, or at least replied to with a "not sure what to do next" kind of comment
20:19:15 efried aspiers: ack. I think at this point I need to let the other reviewers get satisfied before I jump back in, right?
20:19:22 efried cause I was mostly +2?
20:19:27 efried on the ones I could grok
20:19:44 aspiers efried: mostly, but I just addressed a whole bunch of your feedback on the final patch
20:20:26 aspiers efried: and actually there's a request for info from you on that: https://review.opendev.org/#/c/666616/23/nova/tests/unit/virt/libvirt/test_driver.py@23555
20:20:55 aspiers I guess I must have missed some magic when implementing my decorators in order to make them work on classes
20:21:52 efried mm
20:22:13 aspiers actually, now I think about it, it's kind of obvious that my patch_* code would not successfully patch classes
20:22:25 efried okay, well, it's going to take a significant context switch to get back in there, but I'll get there eventually.
20:22:43 aspiers well, unless Python has some magic which automatically applies decorators on a class to the methods within that class
20:23:01 aspiers but I suspect it doesn't
20:32:53 efried no, I suspect that's magic in mock's decorators
20:33:18 sean-k-mooney aspiers: well that depends on the decorator
20:34:21 aspiers efried: yes I suspect so too
20:50:23 openstackgerrit Merged openstack/nova master: Fix 'has_calls' method calls in unit tests https://review.opendev.org/676536
20:50:30 openstackgerrit Merged openstack/nova master: Fix wrong assertions in unit tests https://review.opendev.org/677102
21:07:24 openstackgerrit Merged openstack/nova-specs master: Allow deep-linking to memory reservation section of AMD SEV spec https://review.opendev.org/677264
21:44:53 openstackgerrit Merged openstack/nova master: Tests: autospecs all the mock.patch usages https://review.opendev.org/470775

Earlier   Later